)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"01bfc6f11a4694521c55dc466b39905ad207326c","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I60fb4921f08286d90469cd420261c7e600f5bc7c"},{"line_number":23,"context_line":"Partially-Implements: blueprint neutron-trunk-ui"},{"line_number":24,"context_line":"Related-Bug: #1667778"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a1ced50_8d145b4d","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":12},"updated":"2017-03-22 17:09:48.000000000","message":"You say this can fix bug 1667778. Why don\u0027t you use \u0027Closes-Bug\u0027?","commit_id":"4d0ec69e162afeed7aec0b65922656f8dd4222b2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2c981bdce8ecb326ef10cde9a6340e770c83bf20","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I60fb4921f08286d90469cd420261c7e600f5bc7c"},{"line_number":23,"context_line":"Partially-Implements: blueprint neutron-trunk-ui"},{"line_number":24,"context_line":"Related-Bug: #1667778"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a1ced50_e9e031fd","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":12},"in_reply_to":"1a1ced50_04df393a","updated":"2017-03-23 15:57:49.000000000","message":"I think the first way is to provide a way to know mappings between IP and MAC addresses. (1) addresses this much. I know it is not perfect but we can easily address the remaining part (mapping from instance to neutron ports), so I suggested to use Closes-Bug. If you prefer to Partial-Bug, I am fine with it.","commit_id":"4d0ec69e162afeed7aec0b65922656f8dd4222b2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"2b2dfee530682d25e6478c1ec4afa6b174ecad91","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I60fb4921f08286d90469cd420261c7e600f5bc7c"},{"line_number":23,"context_line":"Partially-Implements: blueprint neutron-trunk-ui"},{"line_number":24,"context_line":"Related-Bug: #1667778"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a1ced50_04df393a","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":12},"in_reply_to":"1a1ced50_8d145b4d","updated":"2017-03-23 15:12:22.000000000","message":"I was somewhat unsure, because the bug report suggested another fix. But I think this fix is just as good, so let\u0027s make it \u0027Closes-Bug\u0027.","commit_id":"4d0ec69e162afeed7aec0b65922656f8dd4222b2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"5e49d3ca8c97f26789ffaefd260ab19f3beddadd","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I60fb4921f08286d90469cd420261c7e600f5bc7c"},{"line_number":23,"context_line":"Partially-Implements: blueprint neutron-trunk-ui"},{"line_number":24,"context_line":"Related-Bug: #1667778"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ffe62b97_b0562f06","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":12},"in_reply_to":"1a1ced50_e9e031fd","updated":"2017-03-24 10:40:04.000000000","message":"I had the same concern. That is the table modified in this change lists the ports per network, while the rfe asked for port addresses by instance. I think we can go for Closes-Bug and leave the followup to the person who opened the rfe. He can always leave us feedback if he thinks this is not enough.","commit_id":"4d0ec69e162afeed7aec0b65922656f8dd4222b2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b889ef31d68bf921bd1e5b6cc3da29be09042367","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I60fb4921f08286d90469cd420261c7e600f5bc7c"},{"line_number":23,"context_line":"Partially-Implements: blueprint neutron-trunk-ui"},{"line_number":24,"context_line":"Related-Bug: #1667778"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ffe62b97_2f3bc7eb","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":12},"in_reply_to":"ffe62b97_b0562f06","updated":"2017-03-24 18:57:28.000000000","message":"Fair enough. Related-Bug looks good to me now.","commit_id":"4d0ec69e162afeed7aec0b65922656f8dd4222b2"}],"horizon/forms/fields.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"10de2222fb3fb5f1e5a10635b79812b7928387d2","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        return str(\u0027,\u0027.join(getattr(self, \"addresses\", [])))"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"class MACAddressField(fields.Field):"},{"line_number":133,"context_line":"    \"\"\"Form field for entering a MAC address with validation."},{"line_number":134,"context_line":"    Supports all formats known by netaddr.EUI(), for example:"},{"line_number":135,"context_line":"    .. xx:xx:xx:xx:xx:xx"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_13c4d690","line":132,"updated":"2017-03-14 15:58:34.000000000","message":"There\u0027s another place with an input field for a MAC address:\n\n openstack_dashboard/dashboards/project/networks/ports/extensions/allowed_address_pairs/forms.py\n\nIt\u0027d better to have only one kind of MAC input field and validation.","commit_id":"b2337d80f26494e6e4c5dab0c7620d692a21edb0"}],"openstack_dashboard/dashboards/admin/networks/ports/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"01bfc6f11a4694521c55dc466b39905ad207326c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                extension_kwargs[\u0027port_security_enabled\u0027] \u003d \\"},{"line_number":175,"context_line":"                    data[\u0027port_security_enabled\u0027]"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            if data.get(\u0027mac_address\u0027):"},{"line_number":178,"context_line":"                extension_kwargs[\u0027mac_address\u0027] \u003d data[\u0027mac_address\u0027]"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"            port \u003d api.neutron.port_update(request,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a1ced50_cdf6538e","line":177,"range":{"start_line":177,"start_character":12,"end_line":177,"end_character":39},"updated":"2017-03-22 17:09:48.000000000","message":"mac_address field always exists so this if-clause is unnecessary.","commit_id":"4d0ec69e162afeed7aec0b65922656f8dd4222b2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2c981bdce8ecb326ef10cde9a6340e770c83bf20","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                extension_kwargs[\u0027port_security_enabled\u0027] \u003d \\"},{"line_number":175,"context_line":"                    data[\u0027port_security_enabled\u0027]"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            if data.get(\u0027mac_address\u0027):"},{"line_number":178,"context_line":"                extension_kwargs[\u0027mac_address\u0027] \u003d data[\u0027mac_address\u0027]"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"            port \u003d api.neutron.port_update(request,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a1ced50_a985595a","line":177,"range":{"start_line":177,"start_character":12,"end_line":177,"end_character":39},"in_reply_to":"1a1ced50_5fdad817","updated":"2017-03-23 15:57:49.000000000","message":"I think we need to set \u0027mac_address\u0027 to the current value in openstack_dashboard.dashboards.project.networks.ports.views.UpdateView.get_initial(). This sets the current value as the default value of UpdateForm.","commit_id":"4d0ec69e162afeed7aec0b65922656f8dd4222b2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"5e49d3ca8c97f26789ffaefd260ab19f3beddadd","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                extension_kwargs[\u0027port_security_enabled\u0027] \u003d \\"},{"line_number":175,"context_line":"                    data[\u0027port_security_enabled\u0027]"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            if data.get(\u0027mac_address\u0027):"},{"line_number":178,"context_line":"                extension_kwargs[\u0027mac_address\u0027] \u003d data[\u0027mac_address\u0027]"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"            port \u003d api.neutron.port_update(request,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_d08e532d","line":177,"range":{"start_line":177,"start_character":12,"end_line":177,"end_character":39},"in_reply_to":"1a1ced50_a985595a","updated":"2017-03-24 10:40:04.000000000","message":"I\u0027m not sure if that\u0027s a good idea. IMHO there are semantic nuances in the neutron API, that can make a difference here.\n\n1) If we put the current mac address into the update, then we ask neutron to update the mac address to the value we have a seen a bit ago.\n\n2) If we put the mac_address key into the update with the empty string value, that\u0027s an error for neutron.\n\n3) If we do not even put the mac_address key into update, then we tell neutron to update some other attribute(s) of the port, but leave the mac_address as is.\n\nPlease notice that the get-then-set-again-to-the-same cycle in (1) is not atomic, therefore we could introduce a race condition in concurrent port updates. By that we\u0027d have the rare chance of overwriting a real mac_address update.\n\nThat\u0027s why I suggest going for (3).","commit_id":"4d0ec69e162afeed7aec0b65922656f8dd4222b2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"2b2dfee530682d25e6478c1ec4afa6b174ecad91","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                extension_kwargs[\u0027port_security_enabled\u0027] \u003d \\"},{"line_number":175,"context_line":"                    data[\u0027port_security_enabled\u0027]"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            if data.get(\u0027mac_address\u0027):"},{"line_number":178,"context_line":"                extension_kwargs[\u0027mac_address\u0027] \u003d data[\u0027mac_address\u0027]"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"            port \u003d api.neutron.port_update(request,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a1ced50_5fdad817","line":177,"range":{"start_line":177,"start_character":12,"end_line":177,"end_character":39},"in_reply_to":"1a1ced50_cdf6538e","updated":"2017-03-23 15:12:22.000000000","message":"Horizon forms and Neutron use different conventions here. When the mac address need not be changed during a port update, this field will have the emptry string value in Horizon. But for Neutron that\u0027s an error. Neutron expects the field to be missing.\n\nIf I remove the condition and update a port leaving the mac address field empty, then neutron throws an invalid mac error and the port update fails.","commit_id":"4d0ec69e162afeed7aec0b65922656f8dd4222b2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"85c68761a2ac25fc9ededd9c9b2622dda4719b49","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                extension_kwargs[\u0027port_security_enabled\u0027] \u003d \\"},{"line_number":175,"context_line":"                    data[\u0027port_security_enabled\u0027]"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            if data.get(\u0027mac_address\u0027):"},{"line_number":178,"context_line":"                extension_kwargs[\u0027mac_address\u0027] \u003d data[\u0027mac_address\u0027]"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"            port \u003d api.neutron.port_update(request,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_b6cd6e32","line":177,"range":{"start_line":177,"start_character":12,"end_line":177,"end_character":39},"in_reply_to":"ffe62b97_27960ef2","updated":"2017-03-28 19:34:27.000000000","message":"I agree with your idea. This sounds reasonable improvement.","commit_id":"4d0ec69e162afeed7aec0b65922656f8dd4222b2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a09b72f9291c7af124fc0fe2cbd3a43433c587e7","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                extension_kwargs[\u0027port_security_enabled\u0027] \u003d \\"},{"line_number":175,"context_line":"                    data[\u0027port_security_enabled\u0027]"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            if data.get(\u0027mac_address\u0027):"},{"line_number":178,"context_line":"                extension_kwargs[\u0027mac_address\u0027] \u003d data[\u0027mac_address\u0027]"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"            port \u003d api.neutron.port_update(request,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_27960ef2","line":177,"range":{"start_line":177,"start_character":12,"end_line":177,"end_character":39},"in_reply_to":"ffe62b97_527eb2e4","updated":"2017-03-27 15:17:54.000000000","message":"I think in an ideal world the input fields would be pre-filled with the current values only as a placeholder (you know, when the field shows the input, but as soon as you click on the field and start typing the pre-filled value disappears) and the browser would send back only the fields the user actually entered something into.\n\nBut this is definitely beyond the scope of this patchset. So I changed the port initialization to fill the mac_address with the current value.","commit_id":"4d0ec69e162afeed7aec0b65922656f8dd4222b2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b889ef31d68bf921bd1e5b6cc3da29be09042367","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                extension_kwargs[\u0027port_security_enabled\u0027] \u003d \\"},{"line_number":175,"context_line":"                    data[\u0027port_security_enabled\u0027]"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            if data.get(\u0027mac_address\u0027):"},{"line_number":178,"context_line":"                extension_kwargs[\u0027mac_address\u0027] \u003d data[\u0027mac_address\u0027]"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"            port \u003d api.neutron.port_update(request,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_527eb2e4","line":177,"range":{"start_line":177,"start_character":12,"end_line":177,"end_character":39},"in_reply_to":"ffe62b97_d08e532d","updated":"2017-03-24 18:57:28.000000000","message":"Yes, that\u0027s a valid concern, but so you suggest all fields in the update form are initialized as blank. It is not limited to MAC address field. This applies to all fields. I personally would like to be consistent for all fields without a special reason.\n\nAt now all other fields of all openstack_dashboard in update forms are filled with current values. If only MAC address field behaves different, users will be confused.\n\nIs there any reason we must handle only MAC address field differently?\n\nThought?","commit_id":"4d0ec69e162afeed7aec0b65922656f8dd4222b2"}],"openstack_dashboard/dashboards/project/networks/ports/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"01bfc6f11a4694521c55dc466b39905ad207326c","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            if \u0027port_security_enabled\u0027 in data:"},{"line_number":148,"context_line":"                params[\u0027port_security_enabled\u0027] \u003d data[\u0027port_security_enabled\u0027]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            if data.get(\u0027mac_address\u0027):"},{"line_number":151,"context_line":"                params[\u0027mac_address\u0027] \u003d data[\u0027mac_address\u0027]"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"            port \u003d api.neutron.port_create(request, **params)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a1ced50_2dbfe761","line":150,"range":{"start_line":150,"start_character":12,"end_line":150,"end_character":39},"updated":"2017-03-22 17:09:48.000000000","message":"This if-clause is unnecessary since mac_address is not optional.\nYou can simply move this to L.130.","commit_id":"4d0ec69e162afeed7aec0b65922656f8dd4222b2"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"2b2dfee530682d25e6478c1ec4afa6b174ecad91","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            if \u0027port_security_enabled\u0027 in data:"},{"line_number":148,"context_line":"                params[\u0027port_security_enabled\u0027] \u003d data[\u0027port_security_enabled\u0027]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            if data.get(\u0027mac_address\u0027):"},{"line_number":151,"context_line":"                params[\u0027mac_address\u0027] \u003d data[\u0027mac_address\u0027]"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"            port \u003d api.neutron.port_create(request, **params)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a1ced50_7fdf94d5","line":150,"range":{"start_line":150,"start_character":12,"end_line":150,"end_character":39},"in_reply_to":"1a1ced50_2dbfe761","updated":"2017-03-23 15:12:22.000000000","message":"Please see my answer in openstack_dashboard/dashboards/admin/networks/ports/forms.py, L177.","commit_id":"4d0ec69e162afeed7aec0b65922656f8dd4222b2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"dd9fbae8f555191cead871da463e69246f0e5ac1","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                params[\u0027port_security_enabled\u0027] \u003d data[\u0027port_security_enabled\u0027]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            if data.get(\u0027mac_address\u0027):"},{"line_number":151,"context_line":"                params[\u0027mac_address\u0027] \u003d data[\u0027mac_address\u0027]"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"            port \u003d api.neutron.port_create(request, **params)"},{"line_number":154,"context_line":"            if port[\u0027name\u0027]:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ffe62b97_769b6665","line":151,"updated":"2017-03-28 19:35:02.000000000","message":"This can be moved to L.130 as we discussed before.","commit_id":"820dccd50d00de7aee0f0eb05185c919b30d1bc8"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"5341e4e17112ae474f69cad35ea502a3d640fd07","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                params[\u0027port_security_enabled\u0027] \u003d data[\u0027port_security_enabled\u0027]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            if data.get(\u0027mac_address\u0027):"},{"line_number":151,"context_line":"                params[\u0027mac_address\u0027] \u003d data[\u0027mac_address\u0027]"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"            port \u003d api.neutron.port_create(request, **params)"},{"line_number":154,"context_line":"            if port[\u0027name\u0027]:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ffe62b97_c0224fb9","line":151,"in_reply_to":"ffe62b97_769b6665","updated":"2017-03-29 09:18:25.000000000","message":"Unlike the update I cannot make the create unconditional. We must support neutron\u0027s autogeneration of unique random mac addresses. For that we need to allow the mac_address field to be left empty in the create form.","commit_id":"820dccd50d00de7aee0f0eb05185c919b30d1bc8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"af2c06052e11a4c875241ec03b06f82db16e78c2","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                params[\u0027port_security_enabled\u0027] \u003d data[\u0027port_security_enabled\u0027]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            if data.get(\u0027mac_address\u0027):"},{"line_number":151,"context_line":"                params[\u0027mac_address\u0027] \u003d data[\u0027mac_address\u0027]"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"            port \u003d api.neutron.port_create(request, **params)"},{"line_number":154,"context_line":"            if port[\u0027name\u0027]:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ffe62b97_85db0420","line":151,"in_reply_to":"ffe62b97_c0224fb9","updated":"2017-03-30 08:53:33.000000000","message":"Good point. You are right. Let me add some comment here.","commit_id":"820dccd50d00de7aee0f0eb05185c919b30d1bc8"}]}
