)]}'
{"openstack_dashboard/api/cinder.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"388ea8c2b9f0d44c30a48e0e7e69e4f982ec3d3d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"try:"},{"line_number":61,"context_line":"    from cinderclient.v2 import client as cinder_client_v2"},{"line_number":62,"context_line":"    VERSIONS.load_supported_version(\u00272\u0027, {\"client\": cinder_client_v2,"},{"line_number":63,"context_line":"                                          \"version\": \u00272\u0027})"},{"line_number":64,"context_line":"except ImportError:"},{"line_number":65,"context_line":"    pass"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f044301_5c8efd2e","line":63,"updated":"2017-05-03 19:10:24.000000000","message":"I am confused by switching a version from number to a string.\nWe use a number (int or float) in OPENSTACK_API_VERSIONS in local/local_settings.py. Don\u0027t we use it consistently?","commit_id":"b04a187656d4a2b9b70800ea6a74310fc3cf12ac"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"1eb72388ce420ab6ce60b862072e3f85eb4b5cb6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"try:"},{"line_number":61,"context_line":"    from cinderclient.v2 import client as cinder_client_v2"},{"line_number":62,"context_line":"    VERSIONS.load_supported_version(\u00272\u0027, {\"client\": cinder_client_v2,"},{"line_number":63,"context_line":"                                          \"version\": \u00272\u0027})"},{"line_number":64,"context_line":"except ImportError:"},{"line_number":65,"context_line":"    pass"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f044301_ffdb7b7a","line":63,"in_reply_to":"3f044301_5c8efd2e","updated":"2017-05-03 19:32:07.000000000","message":"Unfortunately, floats can\u0027t express the difference between version 2.1 and version 2.10, so we have to switch to strings sooner or later. The patch that makes this possible is merged already, and I expect we will change it all gradually as needed.","commit_id":"b04a187656d4a2b9b70800ea6a74310fc3cf12ac"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"21946df7923830cbbf882280172016dfef4ce87e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"try:"},{"line_number":61,"context_line":"    from cinderclient.v2 import client as cinder_client_v2"},{"line_number":62,"context_line":"    VERSIONS.load_supported_version(\u00272\u0027, {\"client\": cinder_client_v2,"},{"line_number":63,"context_line":"                                          \"version\": \u00272\u0027})"},{"line_number":64,"context_line":"except ImportError:"},{"line_number":65,"context_line":"    pass"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f044301_9fa7d750","line":63,"in_reply_to":"3f044301_ffdb7b7a","updated":"2017-05-03 19:59:12.000000000","message":"Thanks for clarification. Sounds reasonable.","commit_id":"b04a187656d4a2b9b70800ea6a74310fc3cf12ac"},{"author":{"_account_id":15209,"name":"Lucas Xu","email":"hanxu@redhat.com","username":"xuh"},"change_message_id":"0a89c6fe5007c908bfc5cbedb4ae35528c87ff0f","unresolved":false,"context_lines":[{"line_number":172,"context_line":"def get_auth_params_from_request(request):"},{"line_number":173,"context_line":"    auth_url \u003d base.url_for(request, \u0027identity\u0027)"},{"line_number":174,"context_line":"    cinder_urls \u003d []"},{"line_number":175,"context_line":"    for service_name in (\u0027volume\u0027, \u0027volumev2\u0027, \u0027volumev3\u0027):"},{"line_number":176,"context_line":"        try:"},{"line_number":177,"context_line":"            cinder_url \u003d base.url_for(request, service_name)"},{"line_number":178,"context_line":"            cinder_urls.append((service_name, cinder_url))"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f013ff3_01dc8e72","line":175,"updated":"2017-05-12 15:46:11.000000000","message":"do we need to check `volume` here?","commit_id":"d78b56fc52ca5e99b7cf019590296339925b3619"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"2746039ea4f63d0f4d5f6416b2b176c92be0ada6","unresolved":false,"context_lines":[{"line_number":172,"context_line":"def get_auth_params_from_request(request):"},{"line_number":173,"context_line":"    auth_url \u003d base.url_for(request, \u0027identity\u0027)"},{"line_number":174,"context_line":"    cinder_urls \u003d []"},{"line_number":175,"context_line":"    for service_name in (\u0027volume\u0027, \u0027volumev2\u0027, \u0027volumev3\u0027):"},{"line_number":176,"context_line":"        try:"},{"line_number":177,"context_line":"            cinder_url \u003d base.url_for(request, service_name)"},{"line_number":178,"context_line":"            cinder_urls.append((service_name, cinder_url))"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f013ff3_b5c19031","line":175,"in_reply_to":"1f013ff3_01dc8e72","updated":"2017-05-12 19:59:12.000000000","message":"If we want to retain compatibility with the old code, yes.","commit_id":"d78b56fc52ca5e99b7cf019590296339925b3619"},{"author":{"_account_id":15209,"name":"Lucas Xu","email":"hanxu@redhat.com","username":"xuh"},"change_message_id":"0a89c6fe5007c908bfc5cbedb4ae35528c87ff0f","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    elif version \u003d\u003d 3:"},{"line_number":207,"context_line":"        service_name \u003d \u0027volumev3\u0027"},{"line_number":208,"context_line":"    else:"},{"line_number":209,"context_line":"        service_name \u003d \u0027volume\u0027"},{"line_number":210,"context_line":"    for name, cinder_url in cinder_urls:"},{"line_number":211,"context_line":"        if name \u003d\u003d service_name:"},{"line_number":212,"context_line":"            break"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f013ff3_e1c1a282","line":209,"updated":"2017-05-12 15:46:11.000000000","message":"here also. I think we don\u0027t have to check `volume` since you cover `volumev3`","commit_id":"d78b56fc52ca5e99b7cf019590296339925b3619"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"aac44dd62fd595e8f40101a7a2e2ee9ef4128f54","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    elif version \u003d\u003d 3:"},{"line_number":207,"context_line":"        service_name \u003d \u0027volumev3\u0027"},{"line_number":208,"context_line":"    else:"},{"line_number":209,"context_line":"        service_name \u003d \u0027volume\u0027"},{"line_number":210,"context_line":"    for name, cinder_url in cinder_urls:"},{"line_number":211,"context_line":"        if name \u003d\u003d service_name:"},{"line_number":212,"context_line":"            break"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f013ff3_19198c78","line":209,"in_reply_to":"1f013ff3_33b11391","updated":"2017-05-15 09:09:36.000000000","message":"This code tries to preserve the previous behavior. If we decide to change it, I think it warrants a separate patch then.","commit_id":"d78b56fc52ca5e99b7cf019590296339925b3619"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0e4ba4ebc29eeae7b30667c90d83fd8e13de1a39","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    elif version \u003d\u003d 3:"},{"line_number":207,"context_line":"        service_name \u003d \u0027volumev3\u0027"},{"line_number":208,"context_line":"    else:"},{"line_number":209,"context_line":"        service_name \u003d \u0027volume\u0027"},{"line_number":210,"context_line":"    for name, cinder_url in cinder_urls:"},{"line_number":211,"context_line":"        if name \u003d\u003d service_name:"},{"line_number":212,"context_line":"            break"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f013ff3_33b11391","line":209,"in_reply_to":"1f013ff3_95dc5419","updated":"2017-05-14 13:42:27.000000000","message":"There is no consensus on this. If an operator would like to provide Volume API v2 only, he can choose \u0027volume\u0027 as endpoint type for the volume service. Can you check \u0027volume\u0027 as a fallback?\n\nThere is an ongoing discussion on standardizing endpoint name. See \nhttp://lists.openstack.org/pipermail/openstack-dev/2017-April/116102.html and mails in that thread for more detail.\n\nOnce we have a consensus in the related reviews (in service-type-authority and API-WG), we can follow the direction. I am joining the discussion as a neutron liaison for API-WG and I can make a feedback to horizon.","commit_id":"d78b56fc52ca5e99b7cf019590296339925b3619"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"2746039ea4f63d0f4d5f6416b2b176c92be0ada6","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    elif version \u003d\u003d 3:"},{"line_number":207,"context_line":"        service_name \u003d \u0027volumev3\u0027"},{"line_number":208,"context_line":"    else:"},{"line_number":209,"context_line":"        service_name \u003d \u0027volume\u0027"},{"line_number":210,"context_line":"    for name, cinder_url in cinder_urls:"},{"line_number":211,"context_line":"        if name \u003d\u003d service_name:"},{"line_number":212,"context_line":"            break"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f013ff3_95dc5419","line":209,"in_reply_to":"1f013ff3_e1c1a282","updated":"2017-05-12 19:59:12.000000000","message":"\"volume\" is for version 1, volumev2 for version 2, and volumev3 for version 3.\n\nAt least that\u0027s how the original code seems to have done it.","commit_id":"d78b56fc52ca5e99b7cf019590296339925b3619"}],"openstack_dashboard/dashboards/project/volumes/templates/volumes/_detail_overview.html":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"388ea8c2b9f0d44c30a48e0e7e69e4f982ec3d3d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"      {% elif m.message_level \u003d\u003d \u0027WARNING\u0027 %}alert-warning"},{"line_number":109,"context_line":"      {% elif m.message_level \u003d\u003d \u0027INFO\u0027 %}alert-info"},{"line_number":110,"context_line":"      {% else %}alert-success"},{"line_number":111,"context_line":"      {% endif %}"},{"line_number":112,"context_line":"    \"\u003e"},{"line_number":113,"context_line":"      {{ m.user_message }}"},{"line_number":114,"context_line":"    \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":11,"id":"3f044301_5c0a7d8a","line":111,"updated":"2017-05-03 19:10:24.000000000","message":"I am okay with the current version, but another option is to prepare message classes in the view.","commit_id":"b04a187656d4a2b9b70800ea6a74310fc3cf12ac"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"1eb72388ce420ab6ce60b862072e3f85eb4b5cb6","unresolved":false,"context_lines":[{"line_number":108,"context_line":"      {% elif m.message_level \u003d\u003d \u0027WARNING\u0027 %}alert-warning"},{"line_number":109,"context_line":"      {% elif m.message_level \u003d\u003d \u0027INFO\u0027 %}alert-info"},{"line_number":110,"context_line":"      {% else %}alert-success"},{"line_number":111,"context_line":"      {% endif %}"},{"line_number":112,"context_line":"    \"\u003e"},{"line_number":113,"context_line":"      {{ m.user_message }}"},{"line_number":114,"context_line":"    \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":11,"id":"3f044301_5f882f70","line":111,"in_reply_to":"3f044301_5c0a7d8a","updated":"2017-05-03 19:32:07.000000000","message":"I decided to do it here, because those are bootstrap-specific class names, and I didn\u0027t want to couple the python code with them.","commit_id":"b04a187656d4a2b9b70800ea6a74310fc3cf12ac"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"21946df7923830cbbf882280172016dfef4ce87e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"      {% elif m.message_level \u003d\u003d \u0027WARNING\u0027 %}alert-warning"},{"line_number":109,"context_line":"      {% elif m.message_level \u003d\u003d \u0027INFO\u0027 %}alert-info"},{"line_number":110,"context_line":"      {% else %}alert-success"},{"line_number":111,"context_line":"      {% endif %}"},{"line_number":112,"context_line":"    \"\u003e"},{"line_number":113,"context_line":"      {{ m.user_message }}"},{"line_number":114,"context_line":"    \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":11,"id":"3f044301_df79df2f","line":111,"in_reply_to":"3f044301_5f882f70","updated":"2017-05-03 19:59:12.000000000","message":"Sounds good.","commit_id":"b04a187656d4a2b9b70800ea6a74310fc3cf12ac"}],"openstack_dashboard/dashboards/project/volumes/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"388ea8c2b9f0d44c30a48e0e7e69e4f982ec3d3d","unresolved":false,"context_lines":[{"line_number":1409,"context_line":"        api.nova.server_get(IsA(http.HttpRequest), server.id).AndReturn(server)"},{"line_number":1410,"context_line":"        cinder.tenant_absolute_limits(IsA(http.HttpRequest))\\"},{"line_number":1411,"context_line":"            .AndReturn(self.cinder_limits[\u0027absolute\u0027])"},{"line_number":1412,"context_line":"        cinder.message_list(IsA(http.HttpRequest), {"},{"line_number":1413,"context_line":"            \u0027resource_uuid\u0027: \u002711023e92-8008-4c8b-8059-7f2293ff3887\u0027,"},{"line_number":1414,"context_line":"            \u0027resource_type\u0027: \u0027volume\u0027,"},{"line_number":1415,"context_line":"        }).AndReturn([])"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f044301_7c5f79e5","line":1412,"range":{"start_line":1412,"start_character":51,"end_line":1412,"end_character":52},"updated":"2017-05-03 19:10:24.000000000","message":"This looks like odd indent. The dict elements have the same indent as for the argument of message_list. How about the following?\n\n  cinder.message.list(\n    IsA(http.HttpRequest,\n    {\u0027resource_uuid\u0027: ....,\n     \u0027resource_type\u0027: \u0027volume\u0027}).AndReturn([])","commit_id":"b04a187656d4a2b9b70800ea6a74310fc3cf12ac"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"1eb72388ce420ab6ce60b862072e3f85eb4b5cb6","unresolved":false,"context_lines":[{"line_number":1409,"context_line":"        api.nova.server_get(IsA(http.HttpRequest), server.id).AndReturn(server)"},{"line_number":1410,"context_line":"        cinder.tenant_absolute_limits(IsA(http.HttpRequest))\\"},{"line_number":1411,"context_line":"            .AndReturn(self.cinder_limits[\u0027absolute\u0027])"},{"line_number":1412,"context_line":"        cinder.message_list(IsA(http.HttpRequest), {"},{"line_number":1413,"context_line":"            \u0027resource_uuid\u0027: \u002711023e92-8008-4c8b-8059-7f2293ff3887\u0027,"},{"line_number":1414,"context_line":"            \u0027resource_type\u0027: \u0027volume\u0027,"},{"line_number":1415,"context_line":"        }).AndReturn([])"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f044301_5f7a6f88","line":1412,"range":{"start_line":1412,"start_character":51,"end_line":1412,"end_character":52},"in_reply_to":"3f044301_7c5f79e5","updated":"2017-05-03 19:32:07.000000000","message":"Done","commit_id":"b04a187656d4a2b9b70800ea6a74310fc3cf12ac"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"cee5bea88682eb732c2a8e006e4b20c49a5612a1","unresolved":false,"context_lines":[{"line_number":1428,"context_line":"        self.assertNoMessages()"},{"line_number":1429,"context_line":""},{"line_number":1430,"context_line":"    @test.create_stubs({cinder: (\u0027volume_get\u0027,"},{"line_number":1431,"context_line":"                                 \u0027volume_get_encryption_metadata\u0027)})"},{"line_number":1432,"context_line":"    def test_encryption_detail_view_encrypted(self):"},{"line_number":1433,"context_line":"        enc_meta \u003d self.cinder_volume_encryption.first()"},{"line_number":1434,"context_line":"        volume \u003d self.cinder_volumes.get(name\u003d\u0027my_volume2\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f044301_5dab70d5","line":1431,"updated":"2017-05-04 20:33:17.000000000","message":"nit: it\u0027s not related to this change","commit_id":"d78b56fc52ca5e99b7cf019590296339925b3619"}],"openstack_dashboard/dashboards/project/volumes/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"388ea8c2b9f0d44c30a48e0e7e69e4f982ec3d3d","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        try:"},{"line_number":177,"context_line":"            volume.messages \u003d cinder.message_list("},{"line_number":178,"context_line":"                self.request,"},{"line_number":179,"context_line":"                dict(resource_type\u003d\u0027volume\u0027, resource_uuid\u003dvolume.id)"},{"line_number":180,"context_line":"            )"},{"line_number":181,"context_line":"        except Exception:"},{"line_number":182,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f044301_bcc4e141","line":179,"range":{"start_line":179,"start_character":16,"end_line":179,"end_character":21},"updated":"2017-05-03 19:10:24.000000000","message":"nit: I prefer to\n\n  {\u0027resource_type\u0027: \u0027volumn\u0027, \u0027resource_uuid\u0027: volume.id}\n\nWe use { } without any specific reason in general.","commit_id":"b04a187656d4a2b9b70800ea6a74310fc3cf12ac"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"1eb72388ce420ab6ce60b862072e3f85eb4b5cb6","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        try:"},{"line_number":177,"context_line":"            volume.messages \u003d cinder.message_list("},{"line_number":178,"context_line":"                self.request,"},{"line_number":179,"context_line":"                dict(resource_type\u003d\u0027volume\u0027, resource_uuid\u003dvolume.id)"},{"line_number":180,"context_line":"            )"},{"line_number":181,"context_line":"        except Exception:"},{"line_number":182,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f044301_bf1bb371","line":179,"range":{"start_line":179,"start_character":16,"end_line":179,"end_character":21},"in_reply_to":"3f044301_bcc4e141","updated":"2017-05-03 19:32:07.000000000","message":"Done","commit_id":"b04a187656d4a2b9b70800ea6a74310fc3cf12ac"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"388ea8c2b9f0d44c30a48e0e7e69e4f982ec3d3d","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                dict(resource_type\u003d\u0027volume\u0027, resource_uuid\u003dvolume.id)"},{"line_number":180,"context_line":"            )"},{"line_number":181,"context_line":"        except Exception:"},{"line_number":182,"context_line":"            raise"},{"line_number":183,"context_line":"            volume.messages \u003d []"},{"line_number":184,"context_line":"            exceptions.handle("},{"line_number":185,"context_line":"                self.request,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f044301_9ce2452f","line":182,"range":{"start_line":182,"start_character":12,"end_line":182,"end_character":17},"updated":"2017-05-03 19:10:24.000000000","message":"Reraising an exception here means the logic below is not processed. Looking at the code below, this \u0027raise\u0027 looks unnecessary and you just want to show the error message.","commit_id":"b04a187656d4a2b9b70800ea6a74310fc3cf12ac"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"1eb72388ce420ab6ce60b862072e3f85eb4b5cb6","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                dict(resource_type\u003d\u0027volume\u0027, resource_uuid\u003dvolume.id)"},{"line_number":180,"context_line":"            )"},{"line_number":181,"context_line":"        except Exception:"},{"line_number":182,"context_line":"            raise"},{"line_number":183,"context_line":"            volume.messages \u003d []"},{"line_number":184,"context_line":"            exceptions.handle("},{"line_number":185,"context_line":"                self.request,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f044301_1f0d0737","line":182,"range":{"start_line":182,"start_character":12,"end_line":182,"end_character":17},"in_reply_to":"3f044301_9ce2452f","updated":"2017-05-03 19:32:07.000000000","message":"Argh, that was for debugging, thanks for catching.","commit_id":"b04a187656d4a2b9b70800ea6a74310fc3cf12ac"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"cee5bea88682eb732c2a8e006e4b20c49a5612a1","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                              _(\u0027Unable to retrieve volume details.\u0027),"},{"line_number":175,"context_line":"                              redirect\u003dredirect)"},{"line_number":176,"context_line":"        try:"},{"line_number":177,"context_line":"            volume.messages \u003d cinder.message_list("},{"line_number":178,"context_line":"                self.request,"},{"line_number":179,"context_line":"                {\u0027resource_type\u0027: \u0027volume\u0027, \u0027resource_uuid\u0027: volume.id},"},{"line_number":180,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f044301_7d698cbc","line":177,"updated":"2017-05-04 20:33:17.000000000","message":"should we use setattr here or add messages attr to the Volume class?","commit_id":"d78b56fc52ca5e99b7cf019590296339925b3619"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"9039c9bc6eb336fe5945cf66a670899c66bcf250","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                              _(\u0027Unable to retrieve volume details.\u0027),"},{"line_number":175,"context_line":"                              redirect\u003dredirect)"},{"line_number":176,"context_line":"        try:"},{"line_number":177,"context_line":"            volume.messages \u003d cinder.message_list("},{"line_number":178,"context_line":"                self.request,"},{"line_number":179,"context_line":"                {\u0027resource_type\u0027: \u0027volume\u0027, \u0027resource_uuid\u0027: volume.id},"},{"line_number":180,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f044301_ac923df5","line":177,"in_reply_to":"3f044301_7d698cbc","updated":"2017-05-05 08:23:42.000000000","message":"I don\u0027t understand what it would buy us. It\u0027s not like this can fail.","commit_id":"d78b56fc52ca5e99b7cf019590296339925b3619"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0e4ba4ebc29eeae7b30667c90d83fd8e13de1a39","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                              _(\u0027Unable to retrieve volume details.\u0027),"},{"line_number":175,"context_line":"                              redirect\u003dredirect)"},{"line_number":176,"context_line":"        try:"},{"line_number":177,"context_line":"            volume.messages \u003d cinder.message_list("},{"line_number":178,"context_line":"                self.request,"},{"line_number":179,"context_line":"                {\u0027resource_type\u0027: \u0027volume\u0027, \u0027resource_uuid\u0027: volume.id},"},{"line_number":180,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f013ff3_b34be385","line":177,"in_reply_to":"3f044301_ac923df5","updated":"2017-05-14 13:42:27.000000000","message":"L.167 uses setattr but we usually use the style like \u0027volume.messages\u0027.\nThey do mostly same thing and I am okay with the current version.","commit_id":"d78b56fc52ca5e99b7cf019590296339925b3619"}]}
