)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"d0e1c8b52f1faf520c03222dc4a67a3ba5fe99a3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Also, in the image panel, instead of checking v1 endpoint,"},{"line_number":17,"context_line":"it should check v2 and v3 as well."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Not sure whether I need to rewrite the unit test for this."},{"line_number":20,"context_line":"If having cinder v1 endpoint deleted, 15 jasmine tests would"},{"line_number":21,"context_line":"fail since these tests are cinder v1 related."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Any review would be much appreciated and free feel to"},{"line_number":24,"context_line":"ping me(lucasxu) in the IRC."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Thanks for the review and help!"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I642b2f62bb9502f958593c9fcad76e21ee1c80ad"},{"line_number":29,"context_line":"Closes-Bug: #1670789"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ffe62b97_469ed754","line":26,"range":{"start_line":19,"start_character":0,"end_line":26,"end_character":31},"updated":"2017-03-26 18:09:11.000000000","message":"This section should be removed","commit_id":"90cf27b3693345ec69986168ff3c3143d6a98408"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.js":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"95ee1b05226aa5cc3fb16eb6ed9af7d6b9e664ec","unresolved":false,"context_lines":[{"line_number":547,"context_line":"      serviceCatalog"},{"line_number":548,"context_line":"        .ifTypeEnabled(\u0027volume\u0027)"},{"line_number":549,"context_line":"        .then(onVolumeServiceEnabled, onCheckVolumeV2);"},{"line_number":550,"context_line":"      function onCheckVolumeV2() {"},{"line_number":551,"context_line":"        serviceCatalog"},{"line_number":552,"context_line":"          .ifTypeEnabled(\u0027volumev2\u0027)"},{"line_number":553,"context_line":"          .then(onVolumeServiceEnabled, resolvePromises);"}],"source_content_type":"text/javascript","patch_set":2,"id":"ffe62b97_1ae70a43","line":550,"updated":"2017-03-26 08:56:24.000000000","message":"here is also do we need to care for volumev3?","commit_id":"2da2b763dbd3d03959f747710947376fbe34c84b"},{"author":{"_account_id":15209,"name":"Lucas Xu","email":"hanxu@redhat.com","username":"xuh"},"change_message_id":"62d3a5588fe0ad1624770513cb382b557174c722","unresolved":false,"context_lines":[{"line_number":547,"context_line":"      serviceCatalog"},{"line_number":548,"context_line":"        .ifTypeEnabled(\u0027volume\u0027)"},{"line_number":549,"context_line":"        .then(onVolumeServiceEnabled, onCheckVolumeV2);"},{"line_number":550,"context_line":"      function onCheckVolumeV2() {"},{"line_number":551,"context_line":"        serviceCatalog"},{"line_number":552,"context_line":"          .ifTypeEnabled(\u0027volumev2\u0027)"},{"line_number":553,"context_line":"          .then(onVolumeServiceEnabled, resolvePromises);"}],"source_content_type":"text/javascript","patch_set":2,"id":"ffe62b97_c6878761","line":550,"in_reply_to":"ffe62b97_1ae70a43","updated":"2017-03-26 17:14:01.000000000","message":"Yes, I am planning to add another function \"onCheckVolumeV3\". Not sure if this is the best approach to solve this problem. Any idea would be much appreciated.","commit_id":"2da2b763dbd3d03959f747710947376fbe34c84b"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.spec.js":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"94f7a310a3ae5f200544abaa540567f17c19c692","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"            if (theType \u003d\u003d\u003d \u0027network\u0027 \u0026\u0026 neutronEnabled) {"},{"line_number":244,"context_line":"              deferred.resolve();"},{"line_number":245,"context_line":"            } else if (theType \u003d\u003d\u003d \u0027volumev2\u0027 \u0026\u0026 cinderEnabled) {"},{"line_number":246,"context_line":"              deferred.resolve();"},{"line_number":247,"context_line":"            } else {"},{"line_number":248,"context_line":"              deferred.reject();"}],"source_content_type":"text/javascript","patch_set":6,"id":"ffe62b97_92862c13","line":245,"updated":"2017-03-27 19:41:56.000000000","message":"Shoudn\u0027t we also check for v3 here?","commit_id":"33ca99f2769881fc9da6ab948276f19c1c80f5e3"},{"author":{"_account_id":15209,"name":"Lucas Xu","email":"hanxu@redhat.com","username":"xuh"},"change_message_id":"a4ab264838040d2d5f8827457aaaeaaf79e2eef3","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"            if (theType \u003d\u003d\u003d \u0027network\u0027 \u0026\u0026 neutronEnabled) {"},{"line_number":244,"context_line":"              deferred.resolve();"},{"line_number":245,"context_line":"            } else if (theType \u003d\u003d\u003d \u0027volumev2\u0027 \u0026\u0026 cinderEnabled) {"},{"line_number":246,"context_line":"              deferred.resolve();"},{"line_number":247,"context_line":"            } else {"},{"line_number":248,"context_line":"              deferred.reject();"}],"source_content_type":"text/javascript","patch_set":6,"id":"ffe62b97_7875c963","line":245,"in_reply_to":"ffe62b97_92862c13","updated":"2017-03-27 20:29:52.000000000","message":"You are right. Done! Thanks","commit_id":"33ca99f2769881fc9da6ab948276f19c1c80f5e3"}]}