)]}'
{"openstack_dashboard/api/nova.py":[{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"cec269e145e13a93ae41654f8d5cfd0764fe6240","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                return image.name"},{"line_number":137,"context_line":"            except (glance_exceptions.ClientException,"},{"line_number":138,"context_line":"                    horizon_exceptions.ServiceCatalogException):"},{"line_number":139,"context_line":"                self.image[\u0027name\u0027] \u003d None"},{"line_number":140,"context_line":"                return None"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_f53b28e8","line":139,"updated":"2017-05-21 22:22:03.000000000","message":"I don\u0027t think this line should be added. If the api call failed, we want to make the api call again next time trying to get the image name. With this line added, None will be returned in line 131 instead.","commit_id":"1faf8c2dd9554b9bd2d2c0b483bc1b7d697ef394"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"5006bd83846e5ec9d1675a1f94db67998a8a01fe","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                return image.name"},{"line_number":137,"context_line":"            except (glance_exceptions.ClientException,"},{"line_number":138,"context_line":"                    horizon_exceptions.ServiceCatalogException):"},{"line_number":139,"context_line":"                self.image[\u0027name\u0027] \u003d None"},{"line_number":140,"context_line":"                return None"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_94495d32","line":139,"in_reply_to":"5f201791_4717ac46","updated":"2017-08-03 03:00:12.000000000","message":"Thanks for the clarification.","commit_id":"1faf8c2dd9554b9bd2d2c0b483bc1b7d697ef394"},{"author":{"_account_id":23757,"name":"Mateusz Kowalski","email":"mko@redhat.com","username":"makowals"},"change_message_id":"0ebfdc74faf3d99a9a109e450ca6944b40e93c28","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                return image.name"},{"line_number":137,"context_line":"            except (glance_exceptions.ClientException,"},{"line_number":138,"context_line":"                    horizon_exceptions.ServiceCatalogException):"},{"line_number":139,"context_line":"                self.image[\u0027name\u0027] \u003d None"},{"line_number":140,"context_line":"                return None"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f201791_4717ac46","line":139,"in_reply_to":"ff0f0b1f_f53b28e8","updated":"2017-06-26 08:45:12.000000000","message":"Isn\u0027t it exactly the part of optimization? In most cases (API calls okay) we will get cached answer and improved speed; from time to time (no one expects a lot of cases) API will fail for whatever reason, but that\u0027s the tradeoff so we don\u0027t repeat this call.\n\nOne very simple example may be API timeout. If we do None here, we timeout once; without, we will be waiting for the timeout timers few times for the same server and performance of the whole request will be very bad.","commit_id":"1faf8c2dd9554b9bd2d2c0b483bc1b7d697ef394"}]}
