)]}'
{"openstack_dashboard/dashboards/identity/projects/workflows.py":[{"author":{"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},"change_message_id":"ad9231220bca94e1ae2bfef1f7ff9413026bccf8","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            cinder_data \u003d {key: data[key] for key in"},{"line_number":421,"context_line":"                           quotas.CINDER_QUOTA_FIELDS"},{"line_number":422,"context_line":"                           if key not in disabled_quotas and"},{"line_number":423,"context_line":"                           data[key] is not None}"},{"line_number":424,"context_line":"            if cinder_data:"},{"line_number":425,"context_line":"                cinder.tenant_quota_update(request, project_id, **cinder_data)"},{"line_number":426,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_040af31f","line":423,"updated":"2017-04-18 22:21:29.000000000","message":"Why is this check (for data[key] not None) only in the cinder quota check?  Shouldn\u0027t it be present in the nova and neutron quota checks, too?","commit_id":"3055a987632c29175c06d73e77fbad9062fcc2c4"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"a848b3cd2ea86d6f3792066352c67989f2d3b0a9","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            cinder_data \u003d {key: data[key] for key in"},{"line_number":421,"context_line":"                           quotas.CINDER_QUOTA_FIELDS"},{"line_number":422,"context_line":"                           if key not in disabled_quotas and"},{"line_number":423,"context_line":"                           data[key] is not None}"},{"line_number":424,"context_line":"            if cinder_data:"},{"line_number":425,"context_line":"                cinder.tenant_quota_update(request, project_id, **cinder_data)"},{"line_number":426,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_3ce05f96","line":423,"in_reply_to":"7ffa3b31_040af31f","updated":"2017-04-19 08:44:37.000000000","message":"It is there, because the Cinder API specifically has a problem with None values passed to it. I didn\u0027t want to change the behavior for other services, because I don\u0027t know if they use None as a special value for something.","commit_id":"3055a987632c29175c06d73e77fbad9062fcc2c4"},{"author":{"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},"change_message_id":"bcd2242085aa5df1ba2297ad0e3a9b1ebe95f26c","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            cinder_data \u003d {key: data[key] for key in"},{"line_number":421,"context_line":"                           quotas.CINDER_QUOTA_FIELDS"},{"line_number":422,"context_line":"                           if key not in disabled_quotas and"},{"line_number":423,"context_line":"                           data[key] is not None}"},{"line_number":424,"context_line":"            if cinder_data:"},{"line_number":425,"context_line":"                cinder.tenant_quota_update(request, project_id, **cinder_data)"},{"line_number":426,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_347e28af","line":423,"in_reply_to":"7ffa3b31_3ce05f96","updated":"2017-04-19 15:18:01.000000000","message":"Sounds reasonable.  If you have reason to update this change again, you may want to note that in a comment.","commit_id":"3055a987632c29175c06d73e77fbad9062fcc2c4"}]}
