)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"189b1142dde3a0f856664e37b8ce3fe8c8547db9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ferenc Cserepkei \u003cferenc.cserepkei@ericsson.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-03 13:43:48 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"TrunkPort, Horizon workflow: launch instance, django version"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ethernet trunks (network interfaces having a vlan tag) cannot be used"},{"line_number":10,"context_line":"as a boot interface. This is a DHCP/PXE limitation. So instead the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfeb2761_c6541d24","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":60},"updated":"2017-04-03 14:21:24.000000000","message":"Question to folks more familiar with Horizon: Now that there are two implementations of the launch instance workflow (in pure django and with angular), changes should be implemented in both, right?","commit_id":"06334db141ebbc2c8b1dee1c9da7f10facd35590"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"189b1142dde3a0f856664e37b8ce3fe8c8547db9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"TrunkPort, Horizon workflow: launch instance, django version"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ethernet trunks (network interfaces having a vlan tag) cannot be used"},{"line_number":10,"context_line":"as a boot interface. This is a DHCP/PXE limitation. So instead the"},{"line_number":11,"context_line":"interface without the vlan tag can be used. In neutron\u0027s nomenclature"},{"line_number":12,"context_line":"they are the trunk parents."},{"line_number":13,"context_line":"The given patch filters out trunk children ports from the list provided"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfeb2761_a9056ac4","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":51},"updated":"2017-04-03 14:21:24.000000000","message":"It is also an OpenStack limitation. Subports should not be passed to \u0027openstack server create --nic ...\u0027. But if you do, there\u0027s no clear error message about it. Please see Armando\u0027s analysis here why:\n\nhttps://bugs.launchpad.net/neutron/+bug/1636485/comments/9\n\nMay be worth to reference it.","commit_id":"06334db141ebbc2c8b1dee1c9da7f10facd35590"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"f1283a568f6f52184dd6856fd7b9052464e87c83","unresolved":false,"context_lines":[{"line_number":7,"context_line":"TrunkPort, Horizon workflow: launch instance, django version"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ethernet trunks (network interfaces having a vlan tag) cannot be used"},{"line_number":10,"context_line":"as a boot interface. This is a DHCP/PXE limitation. So instead the"},{"line_number":11,"context_line":"interface without the vlan tag can be used. In neutron\u0027s nomenclature"},{"line_number":12,"context_line":"they are the trunk parents."},{"line_number":13,"context_line":"The given patch filters out trunk children ports from the list provided"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfeb2761_d209602c","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":51},"in_reply_to":"dfeb2761_a9056ac4","updated":"2017-04-04 06:13:50.000000000","message":"Done.","commit_id":"06334db141ebbc2c8b1dee1c9da7f10facd35590"}],"openstack_dashboard/api/neutron.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c951cd3b17c79244efee0c6462616e5aa84380d2","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    \"\"\""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def __init__(self, apidict):"},{"line_number":151,"context_line":"        assert \u0027trunk_details\u0027 in apidict"},{"line_number":152,"context_line":"        super(PortTrunkParent, self).__init__(apidict)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_f300ca03","line":151,"range":{"start_line":151,"start_character":8,"end_line":151,"end_character":41},"updated":"2017-07-04 12:46:25.000000000","message":"Unhandled exception, I mean what happens if the assertion fails?","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"672953408e6683353c2c9c244575cc06ca65eafb","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    \"\"\""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def __init__(self, apidict):"},{"line_number":151,"context_line":"        assert \u0027trunk_details\u0027 in apidict"},{"line_number":152,"context_line":"        super(PortTrunkParent, self).__init__(apidict)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_067d066d","line":151,"range":{"start_line":151,"start_character":8,"end_line":151,"end_character":41},"in_reply_to":"3f1d235d_f300ca03","updated":"2017-07-06 07:14:44.000000000","message":"This is a guard. If the code wants to instantiate a PortTrunkParent from a port apidict belongs not to a parent port, then there was an error in the logic at all, so its fine to fail with HTTP/500 rather than allow and cause trouble later.","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c951cd3b17c79244efee0c6462616e5aa84380d2","unresolved":false,"context_lines":[{"line_number":155,"context_line":"class PortTrunkSubport(Port):"},{"line_number":156,"context_line":"    \"\"\"Neutron ports that are trunk subports."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    The Neutron API exresses port subtyping information in a surprisingly"},{"line_number":159,"context_line":"    complex way. When you see a port with attribute \u0027trunk_details\u0027 you know"},{"line_number":160,"context_line":"    it\u0027s a trunk parent. But when you see a port without the \u0027trunk_details\u0027"},{"line_number":161,"context_line":"    attribute you can\u0027t tell if it\u0027s a trunk subport or a regular without"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_f329ea89","line":158,"range":{"start_line":158,"start_character":20,"end_line":158,"end_character":28},"updated":"2017-07-04 12:46:25.000000000","message":"expresses","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"672953408e6683353c2c9c244575cc06ca65eafb","unresolved":false,"context_lines":[{"line_number":155,"context_line":"class PortTrunkSubport(Port):"},{"line_number":156,"context_line":"    \"\"\"Neutron ports that are trunk subports."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    The Neutron API exresses port subtyping information in a surprisingly"},{"line_number":159,"context_line":"    complex way. When you see a port with attribute \u0027trunk_details\u0027 you know"},{"line_number":160,"context_line":"    it\u0027s a trunk parent. But when you see a port without the \u0027trunk_details\u0027"},{"line_number":161,"context_line":"    attribute you can\u0027t tell if it\u0027s a trunk subport or a regular without"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_861a3614","line":158,"range":{"start_line":158,"start_character":20,"end_line":158,"end_character":28},"in_reply_to":"3f1d235d_f329ea89","updated":"2017-07-06 07:14:44.000000000","message":"Done","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c951cd3b17c79244efee0c6462616e5aa84380d2","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    The Neutron API exresses port subtyping information in a surprisingly"},{"line_number":159,"context_line":"    complex way. When you see a port with attribute \u0027trunk_details\u0027 you know"},{"line_number":160,"context_line":"    it\u0027s a trunk parent. But when you see a port without the \u0027trunk_details\u0027"},{"line_number":161,"context_line":"    attribute you can\u0027t tell if it\u0027s a trunk subport or a regular without"},{"line_number":162,"context_line":"    looking beyond the port\u0027s attributes. You must go and check if trunks"},{"line_number":163,"context_line":"    (and/or trunk_details of trunk parent ports) refer to this port."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_b31ff259","line":161,"range":{"start_line":161,"start_character":65,"end_line":161,"end_character":66},"updated":"2017-07-04 12:46:25.000000000","message":"port","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"672953408e6683353c2c9c244575cc06ca65eafb","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    The Neutron API exresses port subtyping information in a surprisingly"},{"line_number":159,"context_line":"    complex way. When you see a port with attribute \u0027trunk_details\u0027 you know"},{"line_number":160,"context_line":"    it\u0027s a trunk parent. But when you see a port without the \u0027trunk_details\u0027"},{"line_number":161,"context_line":"    attribute you can\u0027t tell if it\u0027s a trunk subport or a regular without"},{"line_number":162,"context_line":"    looking beyond the port\u0027s attributes. You must go and check if trunks"},{"line_number":163,"context_line":"    (and/or trunk_details of trunk parent ports) refer to this port."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_6615dae4","line":161,"range":{"start_line":161,"start_character":65,"end_line":161,"end_character":66},"in_reply_to":"3f1d235d_b31ff259","updated":"2017-07-06 07:14:44.000000000","message":"Done","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c951cd3b17c79244efee0c6462616e5aa84380d2","unresolved":false,"context_lines":[{"line_number":1086,"context_line":"             handle the inconsistencies caused by non-atomic API requests"},{"line_number":1087,"context_line":"             gracefully."},{"line_number":1088,"context_line":"    \"\"\""},{"line_number":1089,"context_line":"    def is_parent(p):"},{"line_number":1090,"context_line":"        if type(trunks) is list:"},{"line_number":1091,"context_line":"            return any(t[\u0027port_id\u0027] \u003d\u003d p[\u0027id\u0027] for t in trunks)"},{"line_number":1092,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_d30b8ed3","line":1089,"range":{"start_line":1089,"start_character":18,"end_line":1089,"end_character":19},"updated":"2017-07-04 12:46:25.000000000","message":"port","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"672953408e6683353c2c9c244575cc06ca65eafb","unresolved":false,"context_lines":[{"line_number":1086,"context_line":"             handle the inconsistencies caused by non-atomic API requests"},{"line_number":1087,"context_line":"             gracefully."},{"line_number":1088,"context_line":"    \"\"\""},{"line_number":1089,"context_line":"    def is_parent(p):"},{"line_number":1090,"context_line":"        if type(trunks) is list:"},{"line_number":1091,"context_line":"            return any(t[\u0027port_id\u0027] \u003d\u003d p[\u0027id\u0027] for t in trunks)"},{"line_number":1092,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_c6d26e28","line":1089,"range":{"start_line":1089,"start_character":18,"end_line":1089,"end_character":19},"in_reply_to":"3f1d235d_d30b8ed3","updated":"2017-07-06 07:14:44.000000000","message":"Done","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c951cd3b17c79244efee0c6462616e5aa84380d2","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"             gracefully."},{"line_number":1088,"context_line":"    \"\"\""},{"line_number":1089,"context_line":"    def is_parent(p):"},{"line_number":1090,"context_line":"        if type(trunks) is list:"},{"line_number":1091,"context_line":"            return any(t[\u0027port_id\u0027] \u003d\u003d p[\u0027id\u0027] for t in trunks)"},{"line_number":1092,"context_line":"        return False"},{"line_number":1093,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_13fd86b0","line":1090,"range":{"start_line":1090,"start_character":16,"end_line":1090,"end_character":22},"updated":"2017-07-04 12:46:25.000000000","message":"trunks should be the parameter of is_parent","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"672953408e6683353c2c9c244575cc06ca65eafb","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"             gracefully."},{"line_number":1088,"context_line":"    \"\"\""},{"line_number":1089,"context_line":"    def is_parent(p):"},{"line_number":1090,"context_line":"        if type(trunks) is list:"},{"line_number":1091,"context_line":"            return any(t[\u0027port_id\u0027] \u003d\u003d p[\u0027id\u0027] for t in trunks)"},{"line_number":1092,"context_line":"        return False"},{"line_number":1093,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_26a7e2bf","line":1090,"range":{"start_line":1090,"start_character":16,"end_line":1090,"end_character":22},"in_reply_to":"3f1d235d_13fd86b0","updated":"2017-07-06 07:14:44.000000000","message":"Done","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c951cd3b17c79244efee0c6462616e5aa84380d2","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"            return any(t[\u0027port_id\u0027] \u003d\u003d p[\u0027id\u0027] for t in trunks)"},{"line_number":1092,"context_line":"        return False"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"    def is_child(p, ret):"},{"line_number":1095,"context_line":"        if (type(trunks) is list) and (type(ret) is dict):"},{"line_number":1096,"context_line":"            for t in trunks:"},{"line_number":1097,"context_line":"                ret.update({\u0027trunk_id\u0027: t[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_f3bd6ad8","line":1094,"range":{"start_line":1094,"start_character":17,"end_line":1094,"end_character":18},"updated":"2017-07-04 12:46:25.000000000","message":"Please write the full name to make it easier to understand, so:\nport","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"672953408e6683353c2c9c244575cc06ca65eafb","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"            return any(t[\u0027port_id\u0027] \u003d\u003d p[\u0027id\u0027] for t in trunks)"},{"line_number":1092,"context_line":"        return False"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"    def is_child(p, ret):"},{"line_number":1095,"context_line":"        if (type(trunks) is list) and (type(ret) is dict):"},{"line_number":1096,"context_line":"            for t in trunks:"},{"line_number":1097,"context_line":"                ret.update({\u0027trunk_id\u0027: t[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_06d066c8","line":1094,"range":{"start_line":1094,"start_character":17,"end_line":1094,"end_character":18},"in_reply_to":"3f1d235d_f3bd6ad8","updated":"2017-07-06 07:14:44.000000000","message":"Done","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c951cd3b17c79244efee0c6462616e5aa84380d2","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"        return False"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"    def is_child(p, ret):"},{"line_number":1095,"context_line":"        if (type(trunks) is list) and (type(ret) is dict):"},{"line_number":1096,"context_line":"            for t in trunks:"},{"line_number":1097,"context_line":"                ret.update({\u0027trunk_id\u0027: t[\u0027id\u0027]})"},{"line_number":1098,"context_line":"                for s in t[\u0027sub_ports\u0027]:"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_93b876e5","line":1095,"range":{"start_line":1095,"start_character":17,"end_line":1095,"end_character":23},"updated":"2017-07-04 12:46:25.000000000","message":"trunks should be the parameter of is_parent","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"672953408e6683353c2c9c244575cc06ca65eafb","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"        return False"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"    def is_child(p, ret):"},{"line_number":1095,"context_line":"        if (type(trunks) is list) and (type(ret) is dict):"},{"line_number":1096,"context_line":"            for t in trunks:"},{"line_number":1097,"context_line":"                ret.update({\u0027trunk_id\u0027: t[\u0027id\u0027]})"},{"line_number":1098,"context_line":"                for s in t[\u0027sub_ports\u0027]:"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_06e9867e","line":1095,"range":{"start_line":1095,"start_character":17,"end_line":1095,"end_character":23},"in_reply_to":"3f1d235d_93b876e5","updated":"2017-07-06 07:14:44.000000000","message":"Done","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c951cd3b17c79244efee0c6462616e5aa84380d2","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"                ret.update({\u0027trunk_id\u0027: t[\u0027id\u0027]})"},{"line_number":1098,"context_line":"                for s in t[\u0027sub_ports\u0027]:"},{"line_number":1099,"context_line":"                    if s[\u0027port_id\u0027] \u003d\u003d p[\u0027id\u0027]:"},{"line_number":1100,"context_line":"                        ret.update({\u0027seg_id\u0027: s[\u0027segmentation_id\u0027]})"},{"line_number":1101,"context_line":"                        ret.update({\u0027seg_type\u0027: s[\u0027segmentation_type\u0027]})"},{"line_number":1102,"context_line":"                        return True"},{"line_number":1103,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_5ead45e7","line":1100,"range":{"start_line":1100,"start_character":37,"end_line":1100,"end_character":43},"updated":"2017-07-04 12:46:25.000000000","message":"segmentation_id","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"672953408e6683353c2c9c244575cc06ca65eafb","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"                ret.update({\u0027trunk_id\u0027: t[\u0027id\u0027]})"},{"line_number":1098,"context_line":"                for s in t[\u0027sub_ports\u0027]:"},{"line_number":1099,"context_line":"                    if s[\u0027port_id\u0027] \u003d\u003d p[\u0027id\u0027]:"},{"line_number":1100,"context_line":"                        ret.update({\u0027seg_id\u0027: s[\u0027segmentation_id\u0027]})"},{"line_number":1101,"context_line":"                        ret.update({\u0027seg_type\u0027: s[\u0027segmentation_type\u0027]})"},{"line_number":1102,"context_line":"                        return True"},{"line_number":1103,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_a601b23a","line":1100,"range":{"start_line":1100,"start_character":37,"end_line":1100,"end_character":43},"in_reply_to":"3f1d235d_5ead45e7","updated":"2017-07-06 07:14:44.000000000","message":"Done","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c951cd3b17c79244efee0c6462616e5aa84380d2","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"                for s in t[\u0027sub_ports\u0027]:"},{"line_number":1099,"context_line":"                    if s[\u0027port_id\u0027] \u003d\u003d p[\u0027id\u0027]:"},{"line_number":1100,"context_line":"                        ret.update({\u0027seg_id\u0027: s[\u0027segmentation_id\u0027]})"},{"line_number":1101,"context_line":"                        ret.update({\u0027seg_type\u0027: s[\u0027segmentation_type\u0027]})"},{"line_number":1102,"context_line":"                        return True"},{"line_number":1103,"context_line":"        return False"},{"line_number":1104,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_3eb60940","line":1101,"range":{"start_line":1101,"start_character":37,"end_line":1101,"end_character":45},"updated":"2017-07-04 12:46:25.000000000","message":"segmentation_type","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"672953408e6683353c2c9c244575cc06ca65eafb","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"                for s in t[\u0027sub_ports\u0027]:"},{"line_number":1099,"context_line":"                    if s[\u0027port_id\u0027] \u003d\u003d p[\u0027id\u0027]:"},{"line_number":1100,"context_line":"                        ret.update({\u0027seg_id\u0027: s[\u0027segmentation_id\u0027]})"},{"line_number":1101,"context_line":"                        ret.update({\u0027seg_type\u0027: s[\u0027segmentation_type\u0027]})"},{"line_number":1102,"context_line":"                        return True"},{"line_number":1103,"context_line":"        return False"},{"line_number":1104,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_66f71a5b","line":1101,"range":{"start_line":1101,"start_character":37,"end_line":1101,"end_character":45},"in_reply_to":"3f1d235d_3eb60940","updated":"2017-07-06 07:14:44.000000000","message":"Done","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c951cd3b17c79244efee0c6462616e5aa84380d2","unresolved":false,"context_lines":[{"line_number":1104,"context_line":""},{"line_number":1105,"context_line":"    LOG.debug(\"port_list_with_trunk_types(): params\u003d%s\", params)"},{"line_number":1106,"context_line":"    port_list \u003d []"},{"line_number":1107,"context_line":"    ports \u003d neutronclient(request).list_ports(**params).get(\u0027ports\u0027)"},{"line_number":1108,"context_line":"    if \u0027tenant_id\u0027 in params:"},{"line_number":1109,"context_line":"        arg \u003d dict(tenant_id\u003dparams.get(\u0027tenant_id\u0027))"},{"line_number":1110,"context_line":"        trunks \u003d neutronclient(request).list_trunks(arg).get(\u0027trunks\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_f338caa0","line":1107,"range":{"start_line":1107,"start_character":4,"end_line":1107,"end_character":68},"updated":"2017-07-04 12:46:25.000000000","message":"it should also fetched only for the given tenant, or am I wrong?","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"672953408e6683353c2c9c244575cc06ca65eafb","unresolved":false,"context_lines":[{"line_number":1104,"context_line":""},{"line_number":1105,"context_line":"    LOG.debug(\"port_list_with_trunk_types(): params\u003d%s\", params)"},{"line_number":1106,"context_line":"    port_list \u003d []"},{"line_number":1107,"context_line":"    ports \u003d neutronclient(request).list_ports(**params).get(\u0027ports\u0027)"},{"line_number":1108,"context_line":"    if \u0027tenant_id\u0027 in params:"},{"line_number":1109,"context_line":"        arg \u003d dict(tenant_id\u003dparams.get(\u0027tenant_id\u0027))"},{"line_number":1110,"context_line":"        trunks \u003d neutronclient(request).list_trunks(arg).get(\u0027trunks\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_21058c11","line":1107,"range":{"start_line":1107,"start_character":4,"end_line":1107,"end_character":68},"in_reply_to":"3f1d235d_f338caa0","updated":"2017-07-06 07:14:44.000000000","message":"Yes, the request has the tenant_id field in question.","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c951cd3b17c79244efee0c6462616e5aa84380d2","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        ret \u003d dict()"},{"line_number":1115,"context_line":"        if is_parent(port):"},{"line_number":1116,"context_line":"            port_list.append(PortTrunkParent(port))"},{"line_number":1117,"context_line":"        elif is_child(port, ret):"},{"line_number":1118,"context_line":"            port_list.append(PortTrunkSubport(port,"},{"line_number":1119,"context_line":"                                              ret[\u0027trunk_id\u0027],"},{"line_number":1120,"context_line":"                                              ret[\u0027seg_type\u0027],"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_bec9f9ac","line":1117,"range":{"start_line":1117,"start_character":8,"end_line":1117,"end_character":33},"updated":"2017-07-04 12:46:25.000000000","message":"if is_child returns with w dict or None, than you should do something like:\nsubport_details \u003d is_child()\nelif subport_details:\n  port_list.append..........","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"672953408e6683353c2c9c244575cc06ca65eafb","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        ret \u003d dict()"},{"line_number":1115,"context_line":"        if is_parent(port):"},{"line_number":1116,"context_line":"            port_list.append(PortTrunkParent(port))"},{"line_number":1117,"context_line":"        elif is_child(port, ret):"},{"line_number":1118,"context_line":"            port_list.append(PortTrunkSubport(port,"},{"line_number":1119,"context_line":"                                              ret[\u0027trunk_id\u0027],"},{"line_number":1120,"context_line":"                                              ret[\u0027seg_type\u0027],"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f1d235d_c1a5b8a3","line":1117,"range":{"start_line":1117,"start_character":8,"end_line":1117,"end_character":33},"in_reply_to":"3f1d235d_bec9f9ac","updated":"2017-07-06 07:14:44.000000000","message":"I understand, but this case the function should be run 2 times, this is not optimal. As a result of calculating the decision, You get those these field as side effect, however the function is called from an if so i should return mainly a logical value. Python doesn\u0027t support if (a \u003d myfun()) \u003d\u003d true then ... as c++ does\nDict in python is passed by reference, so the is_child() will update the caller\u0027s variable, what is valid only the function returns true","commit_id":"f717e9f07ed4c39c528e9b7d81379e74c72661a8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d73279903831936ed882ac88ffe060e2f2f5ddb4","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    \"\"\""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def __init__(self, apidict):"},{"line_number":151,"context_line":"        assert \u0027trunk_details\u0027 in apidict"},{"line_number":152,"context_line":"        super(PortTrunkParent, self).__init__(apidict)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_d01f94b4","line":151,"range":{"start_line":151,"start_character":7,"end_line":151,"end_character":41},"updated":"2017-07-19 19:27:53.000000000","message":"Could you avoid using \u0027assert\u0027? In general, assert should be used in the test code. In OpenStack python code, we do not have \u0027assert\u0027 in normal code.","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"314340672381452d2fa7261e2d316f5ede53ef2b","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    \"\"\""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def __init__(self, apidict):"},{"line_number":151,"context_line":"        assert \u0027trunk_details\u0027 in apidict"},{"line_number":152,"context_line":"        super(PortTrunkParent, self).__init__(apidict)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_f58f0b2c","line":151,"range":{"start_line":151,"start_character":7,"end_line":151,"end_character":41},"in_reply_to":"1f1a1f67_d01f94b4","updated":"2017-07-24 13:40:41.000000000","message":"It purpose was safe guard, i.e.: creating PorttrunkParent from an unsuitable apidict. But ok. I remove it.","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d73279903831936ed882ac88ffe060e2f2f5ddb4","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def __init__(self, apidict):"},{"line_number":151,"context_line":"        assert \u0027trunk_details\u0027 in apidict"},{"line_number":152,"context_line":"        super(PortTrunkParent, self).__init__(apidict)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"class PortTrunkSubport(Port):"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_50cf0428","line":152,"updated":"2017-07-19 19:27:53.000000000","message":"I think it is better to add some information like \u0027type\u0027 to all classes.\nFor example, \u0027normal\u0027, \u0027trunk-parent\u0027, \u0027trunk-subport\u0027.\n\nLooking at the JS code, you check \u0027trunk_id\u0027 to determine a port is a subport or not. It is too fragile to neutron API changes.\n\nI think we should define some solid interface between horizon API wrapper and JS side.","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"314340672381452d2fa7261e2d316f5ede53ef2b","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def __init__(self, apidict):"},{"line_number":151,"context_line":"        assert \u0027trunk_details\u0027 in apidict"},{"line_number":152,"context_line":"        super(PortTrunkParent, self).__init__(apidict)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"class PortTrunkSubport(Port):"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_55b6bf8c","line":152,"in_reply_to":"1f1a1f67_50cf0428","updated":"2017-07-24 13:40:41.000000000","message":"Yes, at the API wrapper RTTI is lost, every object became an \u0027item\u0027. I\u0027m ok with Your idea adding the port-type to the apidict","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d73279903831936ed882ac88ffe060e2f2f5ddb4","unresolved":false,"context_lines":[{"line_number":1086,"context_line":"             handle the inconsistencies caused by non-atomic API requests"},{"line_number":1087,"context_line":"             gracefully."},{"line_number":1088,"context_line":"    \"\"\""},{"line_number":1089,"context_line":"    def is_parent(port, trunks):"},{"line_number":1090,"context_line":"        if type(trunks) is list:"},{"line_number":1091,"context_line":"            return any(t[\u0027port_id\u0027] \u003d\u003d port[\u0027id\u0027] for t in trunks)"},{"line_number":1092,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_507ca470","line":1089,"range":{"start_line":1089,"start_character":4,"end_line":1089,"end_character":32},"updated":"2017-07-19 19:27:53.000000000","message":"I don\u0027t think we need to define is_parent and is_child functions inside the function. There is no variables inside the function are used in these functions. Could you move these to the outside of the port_list_with_trunk_types()? (for example, _is_parent_port and _is_child_port would be good names I think).","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"314340672381452d2fa7261e2d316f5ede53ef2b","unresolved":false,"context_lines":[{"line_number":1086,"context_line":"             handle the inconsistencies caused by non-atomic API requests"},{"line_number":1087,"context_line":"             gracefully."},{"line_number":1088,"context_line":"    \"\"\""},{"line_number":1089,"context_line":"    def is_parent(port, trunks):"},{"line_number":1090,"context_line":"        if type(trunks) is list:"},{"line_number":1091,"context_line":"            return any(t[\u0027port_id\u0027] \u003d\u003d port[\u0027id\u0027] for t in trunks)"},{"line_number":1092,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_d0309deb","line":1089,"range":{"start_line":1089,"start_character":4,"end_line":1089,"end_character":32},"in_reply_to":"1f1a1f67_507ca470","updated":"2017-07-24 13:40:41.000000000","message":"These 2 predicates are useful only inside this function, so this is the reason they were put inside.","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d73279903831936ed882ac88ffe060e2f2f5ddb4","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"             gracefully."},{"line_number":1088,"context_line":"    \"\"\""},{"line_number":1089,"context_line":"    def is_parent(port, trunks):"},{"line_number":1090,"context_line":"        if type(trunks) is list:"},{"line_number":1091,"context_line":"            return any(t[\u0027port_id\u0027] \u003d\u003d port[\u0027id\u0027] for t in trunks)"},{"line_number":1092,"context_line":"        return False"},{"line_number":1093,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_f0d97082","line":1090,"range":{"start_line":1090,"start_character":8,"end_line":1090,"end_character":32},"updated":"2017-07-19 19:27:53.000000000","message":"Is there a case where \u0027trunks\u0027 is not a list?\n\nIf there is such case, consider using isinstance() instead.\n\n  if isinstance(trunks, list):","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"314340672381452d2fa7261e2d316f5ede53ef2b","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"             gracefully."},{"line_number":1088,"context_line":"    \"\"\""},{"line_number":1089,"context_line":"    def is_parent(port, trunks):"},{"line_number":1090,"context_line":"        if type(trunks) is list:"},{"line_number":1091,"context_line":"            return any(t[\u0027port_id\u0027] \u003d\u003d port[\u0027id\u0027] for t in trunks)"},{"line_number":1092,"context_line":"        return False"},{"line_number":1093,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_754f7b92","line":1090,"range":{"start_line":1090,"start_character":8,"end_line":1090,"end_character":32},"in_reply_to":"1f1a1f67_f0d97082","updated":"2017-07-24 13:40:41.000000000","message":"ok","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d73279903831936ed882ac88ffe060e2f2f5ddb4","unresolved":false,"context_lines":[{"line_number":1088,"context_line":"    \"\"\""},{"line_number":1089,"context_line":"    def is_parent(port, trunks):"},{"line_number":1090,"context_line":"        if type(trunks) is list:"},{"line_number":1091,"context_line":"            return any(t[\u0027port_id\u0027] \u003d\u003d port[\u0027id\u0027] for t in trunks)"},{"line_number":1092,"context_line":"        return False"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"    def is_child(port, trunks, ret):"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_90391ca5","line":1091,"range":{"start_line":1091,"start_character":19,"end_line":1091,"end_character":66},"updated":"2017-07-19 19:27:53.000000000","message":"This can be:\n\n   return port[\u0027id\u0027] in [t[\u0027port_id\u0027] for t in trunks]","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"314340672381452d2fa7261e2d316f5ede53ef2b","unresolved":false,"context_lines":[{"line_number":1088,"context_line":"    \"\"\""},{"line_number":1089,"context_line":"    def is_parent(port, trunks):"},{"line_number":1090,"context_line":"        if type(trunks) is list:"},{"line_number":1091,"context_line":"            return any(t[\u0027port_id\u0027] \u003d\u003d port[\u0027id\u0027] for t in trunks)"},{"line_number":1092,"context_line":"        return False"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"    def is_child(port, trunks, ret):"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_30111155","line":1091,"range":{"start_line":1091,"start_character":19,"end_line":1091,"end_character":66},"in_reply_to":"1f1a1f67_90391ca5","updated":"2017-07-24 13:40:41.000000000","message":"OK You prefer list comprehension over any()","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d73279903831936ed882ac88ffe060e2f2f5ddb4","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"            return any(t[\u0027port_id\u0027] \u003d\u003d port[\u0027id\u0027] for t in trunks)"},{"line_number":1092,"context_line":"        return False"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"    def is_child(port, trunks, ret):"},{"line_number":1095,"context_line":"        if (type(trunks) is list) and (type(ret) is dict):"},{"line_number":1096,"context_line":"            for t in trunks:"},{"line_number":1097,"context_line":"                ret.update({\u0027trunk_id\u0027: t[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_f047301c","line":1094,"range":{"start_line":1094,"start_character":31,"end_line":1094,"end_character":34},"updated":"2017-07-19 19:27:53.000000000","message":"Could you use more meaningful name as argument?","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"314340672381452d2fa7261e2d316f5ede53ef2b","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"            return any(t[\u0027port_id\u0027] \u003d\u003d port[\u0027id\u0027] for t in trunks)"},{"line_number":1092,"context_line":"        return False"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"    def is_child(port, trunks, ret):"},{"line_number":1095,"context_line":"        if (type(trunks) is list) and (type(ret) is dict):"},{"line_number":1096,"context_line":"            for t in trunks:"},{"line_number":1097,"context_line":"                ret.update({\u0027trunk_id\u0027: t[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_5087ed10","line":1094,"range":{"start_line":1094,"start_character":31,"end_line":1094,"end_character":34},"in_reply_to":"1f1a1f67_f047301c","updated":"2017-07-24 13:40:41.000000000","message":"see my answer below","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d73279903831936ed882ac88ffe060e2f2f5ddb4","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"                ret.update({\u0027trunk_id\u0027: t[\u0027id\u0027]})"},{"line_number":1098,"context_line":"                for s in t[\u0027sub_ports\u0027]:"},{"line_number":1099,"context_line":"                    if s[\u0027port_id\u0027] \u003d\u003d port[\u0027id\u0027]:"},{"line_number":1100,"context_line":"                        ret.update("},{"line_number":1101,"context_line":"                            {\u0027segmentation_id\u0027: s[\u0027segmentation_id\u0027]})"},{"line_number":1102,"context_line":"                        ret.update("},{"line_number":1103,"context_line":"                            {\u0027segmentation_type\u0027: s[\u0027segmentation_type\u0027]})"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_f01e100a","line":1100,"range":{"start_line":1100,"start_character":24,"end_line":1100,"end_character":35},"updated":"2017-07-19 19:27:53.000000000","message":"It is not a good idea to change a dict in a function named is_xxxx.\nUsual python developers never imagine is_xxxx function changes arguments.","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"314340672381452d2fa7261e2d316f5ede53ef2b","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"                ret.update({\u0027trunk_id\u0027: t[\u0027id\u0027]})"},{"line_number":1098,"context_line":"                for s in t[\u0027sub_ports\u0027]:"},{"line_number":1099,"context_line":"                    if s[\u0027port_id\u0027] \u003d\u003d port[\u0027id\u0027]:"},{"line_number":1100,"context_line":"                        ret.update("},{"line_number":1101,"context_line":"                            {\u0027segmentation_id\u0027: s[\u0027segmentation_id\u0027]})"},{"line_number":1102,"context_line":"                        ret.update("},{"line_number":1103,"context_line":"                            {\u0027segmentation_type\u0027: s[\u0027segmentation_type\u0027]})"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_90a465bb","line":1100,"range":{"start_line":1100,"start_character":24,"end_line":1100,"end_character":35},"in_reply_to":"1f1a1f67_f01e100a","updated":"2017-07-24 13:40:41.000000000","message":"I Intended to return a truth value, but when the port is a trunk child I return additional trunk information as well. The function should work in a logical expression (if) and in case of true I would like to have the trunk details. Is it okay to rename ret, to trunkinfo and writing a sort description on the variable\u0027s role? Python can\u0027t do what c/c++ can:\nif (val\u003dfunction()) \u003d\u003d true {...}","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d73279903831936ed882ac88ffe060e2f2f5ddb4","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"    LOG.debug(\"port_list_with_trunk_types(): params\u003d%s\", params)"},{"line_number":1108,"context_line":"    port_list \u003d []"},{"line_number":1109,"context_line":"    ports \u003d neutronclient(request).list_ports(**params).get(\u0027ports\u0027)"},{"line_number":1110,"context_line":"    if \u0027tenant_id\u0027 in params:"},{"line_number":1111,"context_line":"        arg \u003d dict(tenant_id\u003dparams.get(\u0027tenant_id\u0027))"},{"line_number":1112,"context_line":"        trunks \u003d neutronclient(request).list_trunks(arg).get(\u0027trunks\u0027)"},{"line_number":1113,"context_line":"    else:"},{"line_number":1114,"context_line":"        trunks \u003d neutronclient(request).list_trunks().get(\u0027trunks\u0027)"},{"line_number":1115,"context_line":"    for port in ports:"},{"line_number":1116,"context_line":"        ret \u003d dict()"},{"line_number":1117,"context_line":"        if is_parent(port, trunks):"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_d000b4ad","line":1114,"range":{"start_line":1110,"start_character":4,"end_line":1114,"end_character":67},"updated":"2017-07-19 19:27:53.000000000","message":"Consider:\n\n  filters \u003d {}\n  if \u0027tenant_id\u0027 in params:\n      filters[\u0027tenant_id\u0027] \u003d params[\u0027tenant_id\u0027]\n  trunks \u003d neutronclient(request).list_trunks(**filters)[\u0027trunks\u0027]","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e5b4c422e8475d1a7af7bb1cba3de4b3ad93e87a","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"    LOG.debug(\"port_list_with_trunk_types(): params\u003d%s\", params)"},{"line_number":1108,"context_line":"    port_list \u003d []"},{"line_number":1109,"context_line":"    ports \u003d neutronclient(request).list_ports(**params).get(\u0027ports\u0027)"},{"line_number":1110,"context_line":"    if \u0027tenant_id\u0027 in params:"},{"line_number":1111,"context_line":"        arg \u003d dict(tenant_id\u003dparams.get(\u0027tenant_id\u0027))"},{"line_number":1112,"context_line":"        trunks \u003d neutronclient(request).list_trunks(arg).get(\u0027trunks\u0027)"},{"line_number":1113,"context_line":"    else:"},{"line_number":1114,"context_line":"        trunks \u003d neutronclient(request).list_trunks().get(\u0027trunks\u0027)"},{"line_number":1115,"context_line":"    for port in ports:"},{"line_number":1116,"context_line":"        ret \u003d dict()"},{"line_number":1117,"context_line":"        if is_parent(port, trunks):"}],"source_content_type":"text/x-python","patch_set":32,"id":"ff346bd7_1a47364e","line":1114,"range":{"start_line":1110,"start_character":4,"end_line":1114,"end_character":67},"in_reply_to":"1f1a1f67_6b443c75","updated":"2017-07-24 14:49:11.000000000","message":"hmm...  looks strange.\nThe above code is just a refactored version of the original one.\nIt works for me http://paste.openstack.org/show/616311/","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"314340672381452d2fa7261e2d316f5ede53ef2b","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"    LOG.debug(\"port_list_with_trunk_types(): params\u003d%s\", params)"},{"line_number":1108,"context_line":"    port_list \u003d []"},{"line_number":1109,"context_line":"    ports \u003d neutronclient(request).list_ports(**params).get(\u0027ports\u0027)"},{"line_number":1110,"context_line":"    if \u0027tenant_id\u0027 in params:"},{"line_number":1111,"context_line":"        arg \u003d dict(tenant_id\u003dparams.get(\u0027tenant_id\u0027))"},{"line_number":1112,"context_line":"        trunks \u003d neutronclient(request).list_trunks(arg).get(\u0027trunks\u0027)"},{"line_number":1113,"context_line":"    else:"},{"line_number":1114,"context_line":"        trunks \u003d neutronclient(request).list_trunks().get(\u0027trunks\u0027)"},{"line_number":1115,"context_line":"    for port in ports:"},{"line_number":1116,"context_line":"        ret \u003d dict()"},{"line_number":1117,"context_line":"        if is_parent(port, trunks):"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_6b443c75","line":1114,"range":{"start_line":1110,"start_character":4,"end_line":1114,"end_character":67},"in_reply_to":"1f1a1f67_d000b4ad","updated":"2017-07-24 13:40:41.000000000","message":"causes HTTP/500 (exception in python-neutronclient)\nBadRequest: Invalid input for operation: \u0027tenant_id\u0027 is not supported for filtering.","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e01e07c2f408f0bf8ce9fa4e2cfcfe53eba663fe","unresolved":false,"context_lines":[{"line_number":1093,"context_line":"        :param port: the port in question"},{"line_number":1094,"context_line":"        :param trunks: the trunks to investigate"},{"line_number":1095,"context_line":"        \"\"\""},{"line_number":1096,"context_line":"        if isinstance(trunks, list):"},{"line_number":1097,"context_line":"            return port[\u0027id\u0027] in [t[\u0027port_id\u0027] for t in trunks]"},{"line_number":1098,"context_line":"        return False"},{"line_number":1099,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"ff346bd7_7a276214","line":1096,"range":{"start_line":1096,"start_character":8,"end_line":1096,"end_character":36},"updated":"2017-07-24 15:57:14.000000000","message":"we can expect trunks is always a list because neutronclient(req).list_trunks always a dict of {\u0027trunks\u0027: \u003csome list\u003e}.\nIt will never be None. As a result, this check just loses the readability.","commit_id":"53ceb202b71523b6b211a0b0ee006d5d337a0afd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e01e07c2f408f0bf8ce9fa4e2cfcfe53eba663fe","unresolved":false,"context_lines":[{"line_number":1104,"context_line":"        :param trunks: the trunks to investigate"},{"line_number":1105,"context_line":"        :param trunkinfo: trunk info returned when the result is true"},{"line_number":1106,"context_line":"        \"\"\""},{"line_number":1107,"context_line":"        if (isinstance(trunks, list) and isinstance(trunkinfo, dict)):"},{"line_number":1108,"context_line":"            for t in trunks:"},{"line_number":1109,"context_line":"                trunkinfo.update({\u0027trunk_id\u0027: t[\u0027id\u0027]})"},{"line_number":1110,"context_line":"                for s in t[\u0027sub_ports\u0027]:"}],"source_content_type":"text/x-python","patch_set":33,"id":"ff346bd7_da664e52","line":1107,"range":{"start_line":1107,"start_character":8,"end_line":1107,"end_character":70},"updated":"2017-07-24 15:57:14.000000000","message":"Same as the above. We usually do not do this in python code.\nPassing a dict is the responsibility of callers, and if a different type is passed, it is enough to raise an exception.","commit_id":"53ceb202b71523b6b211a0b0ee006d5d337a0afd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e01e07c2f408f0bf8ce9fa4e2cfcfe53eba663fe","unresolved":false,"context_lines":[{"line_number":1105,"context_line":"        :param trunkinfo: trunk info returned when the result is true"},{"line_number":1106,"context_line":"        \"\"\""},{"line_number":1107,"context_line":"        if (isinstance(trunks, list) and isinstance(trunkinfo, dict)):"},{"line_number":1108,"context_line":"            for t in trunks:"},{"line_number":1109,"context_line":"                trunkinfo.update({\u0027trunk_id\u0027: t[\u0027id\u0027]})"},{"line_number":1110,"context_line":"                for s in t[\u0027sub_ports\u0027]:"},{"line_number":1111,"context_line":"                    if s[\u0027port_id\u0027] \u003d\u003d port[\u0027id\u0027]:"}],"source_content_type":"text/x-python","patch_set":33,"id":"ff346bd7_1a2bb694","line":1108,"updated":"2017-07-24 15:57:14.000000000","message":"This logic is not effective at all. We should avoid this even though it works as a logic. It will be called (\u003cnum_port\u003e * sum \u003ctotal num of trunk subports\u003e) times potentially. Even though the logic exist first when a port is found, it is not a good idea. Consider creating a dict for trunks.","commit_id":"53ceb202b71523b6b211a0b0ee006d5d337a0afd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fc47d7f2dd872125fc9eb785b1266d9b9580fdbd","unresolved":false,"context_lines":[{"line_number":1119,"context_line":"    LOG.debug(\"port_list_with_trunk_types(): params\u003d%s\", params)"},{"line_number":1120,"context_line":"    port_list \u003d []"},{"line_number":1121,"context_line":"    ports \u003d neutronclient(request).list_ports(**params).get(\u0027ports\u0027)"},{"line_number":1122,"context_line":"    trunks \u003d neutronclient(request).list_trunks().get(\u0027trunks\u0027)"},{"line_number":1123,"context_line":"    for port in ports:"},{"line_number":1124,"context_line":"        trunkinfo \u003d dict()"},{"line_number":1125,"context_line":"        if is_parent(port, trunks):"}],"source_content_type":"text/x-python","patch_set":33,"id":"ff346bd7_e2972490","line":1122,"range":{"start_line":1122,"start_character":47,"end_line":1122,"end_character":49},"updated":"2017-07-24 16:38:36.000000000","message":"tenant_id filter needs to be passed here because if a user has admin role this leads to retrieve all trunks from all projects. This is a pattern should be avoided.","commit_id":"53ceb202b71523b6b211a0b0ee006d5d337a0afd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f44b06b756ad3121d23a4f0e51ac53fcc606f207","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"                         {\u0027trunk_id\u0027: t[\u0027id\u0027],"},{"line_number":1093,"context_line":"                          \u0027segmentation_type\u0027: s[\u0027segmentation_type\u0027],"},{"line_number":1094,"context_line":"                          \u0027segmentation_id\u0027: s[\u0027segmentation_id\u0027]})"},{"line_number":1095,"context_line":"                        for s in t[\u0027sub_ports\u0027]"},{"line_number":1096,"context_line":"                        for t in trunks])"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"    def _get_port_info(port):"},{"line_number":1099,"context_line":"        if port[\u0027id\u0027] in parent_ports:"}],"source_content_type":"text/x-python","patch_set":34,"id":"ff346bd7_8bc99379","line":1096,"range":{"start_line":1095,"start_character":24,"end_line":1096,"end_character":39},"updated":"2017-07-24 17:48:28.000000000","message":"woops. the order of inner and outer loops was wrong. it should be:\n\n [....\n  for t in trunks\n  for s in t[\u0027sub_ports\u0027]]","commit_id":"5486cf35b5ff74c06bbe11afe226f80789ef695b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a75875ba5b5858672a9ad49c9c7b1032dc1865f0","unresolved":false,"context_lines":[{"line_number":1068,"context_line":""},{"line_number":1069,"context_line":""},{"line_number":1070,"context_line":"@profiler.trace"},{"line_number":1071,"context_line":"@memoized"},{"line_number":1072,"context_line":"def port_list_with_trunk_types(request, **params):"},{"line_number":1073,"context_line":"    \"\"\"List neutron Ports for this tenant with possible TrunkPort indicated"},{"line_number":1074,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"ff346bd7_abae972b","line":1071,"range":{"start_line":1071,"start_character":0,"end_line":1071,"end_character":9},"updated":"2017-07-24 18:01:54.000000000","message":"I see the following warnings. It needs to be fixed before the merge.\n\n UnhashableKeyWarning: The key ((\u003cweakref at 0x7f2c9ff56418; to \n\u0027WSGIRequest\u0027 at 0x7f2cbfe87750\u003e,), ((u\u0027network_id\u0027, [u\u0027027c55cd-62c7-4f98-b7d2-6ebdf5495d9e\u0027]),)) is not hashable and cannot be memoized.\n WARNING:py.warnings:UnhashableKeyWarning: The key ((\u003cweakref at 0x7f2c9ff56418; to \u0027WSGIRequest\u0027 at 0x7f2cbfe87750\u003e,), ((u\u0027network_id\u0027, [u\u0027027c55cd-62c7-4f98-b7d2-6ebdf5495d9e\u0027]),)) is not hashable and cannot be memoized.","commit_id":"166b133e4e89c7bb4557cbb2a943346351429a86"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7c1c661026f2f2a0d23d2a8f2f2c781ae37c524e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    \"\"\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def __init__(self, apidict):"},{"line_number":150,"context_line":"        super(PortTrunkParent, self).__init__(apidict)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"class PortTrunkSubport(Port):"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_729be2c8","line":150,"updated":"2017-07-25 13:52:01.000000000","message":"Is there any reason you need this? If you need nothing specific to the class, the python convention is not to have it.","commit_id":"34ca0226ce8a739db84987016659176494d596ef"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"2379a4d7f27bef022a2490042b84b312e0bf7bbd","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    \"\"\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def __init__(self, apidict):"},{"line_number":150,"context_line":"        super(PortTrunkParent, self).__init__(apidict)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"class PortTrunkSubport(Port):"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_57779403","line":150,"in_reply_to":"ff346bd7_1f0ede3a","updated":"2017-07-26 05:34:52.000000000","message":"Akihiro  this link is available:\nhttps://docs.python.org/2/reference/datamodel.html#new-style-and-classic-classes","commit_id":"34ca0226ce8a739db84987016659176494d596ef"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ac5022bc68de2230425f852cd700d9bb20ebdeb8","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    \"\"\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def __init__(self, apidict):"},{"line_number":150,"context_line":"        super(PortTrunkParent, self).__init__(apidict)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"class PortTrunkSubport(Port):"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_52ce50b4","line":150,"in_reply_to":"ff346bd7_57779403","updated":"2017-07-27 08:41:27.000000000","message":"Thanks. IIRC, __init__ is not affected by the new class style in python, so I was confused.","commit_id":"34ca0226ce8a739db84987016659176494d596ef"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f60d2a6dc99b1cb9ca9c3074cf788c8e14edaedc","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    \"\"\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def __init__(self, apidict):"},{"line_number":150,"context_line":"        super(PortTrunkParent, self).__init__(apidict)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"class PortTrunkSubport(Port):"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_1f0ede3a","line":150,"in_reply_to":"ff346bd7_6ddd4313","updated":"2017-07-25 14:35:28.000000000","message":"Our python3.5 job does not complain any though...\n\nDo you have any pointer on the new class format in python 3?\nI would like to check this is actually needed.\nAFAIK, this is the first case I heard __init__ is required in python 3 as part of python 3 official support effort.","commit_id":"34ca0226ce8a739db84987016659176494d596ef"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"87cb642e6647af91bf2eedcd0bfb8d5dd3cb65c2","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    \"\"\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def __init__(self, apidict):"},{"line_number":150,"context_line":"        super(PortTrunkParent, self).__init__(apidict)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"class PortTrunkSubport(Port):"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_6ddd4313","line":150,"in_reply_to":"ff346bd7_729be2c8","updated":"2017-07-25 14:11:03.000000000","message":"I recall my memory that python 3 new class format need this and the base has __init__()","commit_id":"34ca0226ce8a739db84987016659176494d596ef"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"87cb642e6647af91bf2eedcd0bfb8d5dd3cb65c2","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    \"\"\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def __init__(self, apidict):"},{"line_number":150,"context_line":"        super(PortTrunkParent, self).__init__(apidict)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"class PortTrunkSubport(Port):"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_2dd17bce","line":150,"in_reply_to":"ff346bd7_729be2c8","updated":"2017-07-25 14:11:03.000000000","message":"Python 3 new class format may need this afaik, but unsure.","commit_id":"34ca0226ce8a739db84987016659176494d596ef"}],"openstack_dashboard/api/rest/neutron.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d73279903831936ed882ac88ffe060e2f2f5ddb4","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        # see"},{"line_number":135,"context_line":"        # https://github.com/openstack/neutron/blob/master/neutron/api/v2/attributes.py"},{"line_number":136,"context_line":"        result \u003d api.neutron.port_list_with_trunk_types(request, **request.GET)"},{"line_number":137,"context_line":"        return{\u0027items\u0027: [n.to_dict() for n in result]}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_10418ca9","line":136,"range":{"start_line":136,"start_character":65,"end_line":136,"end_character":78},"updated":"2017-07-19 19:27:53.000000000","message":"Can\u0027t you pass some filtering parameter like \u0027bootable\u003dTrue\u0027 from JS side? If so, we can filter sub-ports out from the returned data.","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1e58812cf4f44e1940b359cb5dba63bee619bfaa","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        # see"},{"line_number":135,"context_line":"        # https://github.com/openstack/neutron/blob/master/neutron/api/v2/attributes.py"},{"line_number":136,"context_line":"        result \u003d api.neutron.port_list_with_trunk_types(request, **request.GET)"},{"line_number":137,"context_line":"        return {\u0027items\u0027: [n.to_dict() for n in result]}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"ff346bd7_766096cf","line":136,"range":{"start_line":136,"start_character":65,"end_line":136,"end_character":78},"updated":"2017-07-24 18:06:11.000000000","message":"If you change this to:\n\n  **request.GET.dict()\n\nUnhashableKeyWarning from @memoized decorator will disappear [1].\n\n[1] https://docs.djangoproject.com/en/1.11/ref/request-response/#django.http.QueryDict.dict","commit_id":"166b133e4e89c7bb4557cbb2a943346351429a86"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"443232581d47084deacabd8e6a35021f5792779d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        # see"},{"line_number":135,"context_line":"        # https://github.com/openstack/neutron/blob/master/neutron/api/v2/attributes.py"},{"line_number":136,"context_line":"        result \u003d api.neutron.port_list_with_trunk_types(request, **request.GET)"},{"line_number":137,"context_line":"        return {\u0027items\u0027: [n.to_dict() for n in result]}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"ff346bd7_e755d251","line":136,"range":{"start_line":136,"start_character":65,"end_line":136,"end_character":78},"in_reply_to":"ff346bd7_766096cf","updated":"2017-07-25 13:19:18.000000000","message":"Akihiro I can\u0027t see such warning.","commit_id":"166b133e4e89c7bb4557cbb2a943346351429a86"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c7f79fb96567bee7a43ce5d02c4a28fe00897825","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        # see"},{"line_number":135,"context_line":"        # https://github.com/openstack/neutron/blob/master/neutron/api/v2/attributes.py"},{"line_number":136,"context_line":"        result \u003d api.neutron.port_list_with_trunk_types(request, **request.GET)"},{"line_number":137,"context_line":"        return {\u0027items\u0027: [n.to_dict() for n in result]}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"ff346bd7_52e0decc","line":136,"range":{"start_line":136,"start_character":65,"end_line":136,"end_character":78},"in_reply_to":"ff346bd7_e755d251","updated":"2017-07-25 13:38:27.000000000","message":"At least when I ran \u0027tox -e runserver\u0027 to test this patch and if I have at least one network, I always see this warning. I am not sure what configuration you use, but it actually happens.","commit_id":"166b133e4e89c7bb4557cbb2a943346351429a86"}],"openstack_dashboard/dashboards/project/instances/utils.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"189b1142dde3a0f856664e37b8ce3fe8c8547db9","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                                \",\".join([ip[\u0027ip_address\u0027]"},{"line_number":184,"context_line":"                                          for ip in port[\u0027fixed_ips\u0027]]))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def tp_filter(portlist):"},{"line_number":187,"context_line":"        # filter out trunk children"},{"line_number":188,"context_line":"        tp_children \u003d []"},{"line_number":189,"context_line":"        for a_port in portlist:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_e9ac928d","line":186,"range":{"start_line":186,"start_character":8,"end_line":186,"end_character":17},"updated":"2017-04-03 14:21:24.000000000","message":"A casual maintainer would probably not know what \u0027tp\u0027 stands for. What about \u0027filter_trunk_child_ports\u0027 or \u0027exclude_trunk_child_ports\u0027?","commit_id":"06334db141ebbc2c8b1dee1c9da7f10facd35590"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"f1283a568f6f52184dd6856fd7b9052464e87c83","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                                \",\".join([ip[\u0027ip_address\u0027]"},{"line_number":184,"context_line":"                                          for ip in port[\u0027fixed_ips\u0027]]))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def tp_filter(portlist):"},{"line_number":187,"context_line":"        # filter out trunk children"},{"line_number":188,"context_line":"        tp_children \u003d []"},{"line_number":189,"context_line":"        for a_port in portlist:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_d70ef28b","line":186,"range":{"start_line":186,"start_character":8,"end_line":186,"end_character":17},"in_reply_to":"dfeb2761_e9ac928d","updated":"2017-04-04 06:13:50.000000000","message":"Done.","commit_id":"06334db141ebbc2c8b1dee1c9da7f10facd35590"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"189b1142dde3a0f856664e37b8ce3fe8c8547db9","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        # filter out trunk children"},{"line_number":188,"context_line":"        tp_children \u003d []"},{"line_number":189,"context_line":"        for a_port in portlist:"},{"line_number":190,"context_line":"            property \u003d getattr(a_port, \"trunk_details\", None)"},{"line_number":191,"context_line":"            if property is not None:"},{"line_number":192,"context_line":"                for item in a_port.trunk_details[\"sub_ports\"]:"},{"line_number":193,"context_line":"                    tp_children.append(item[\"port_id\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_6983e2cd","line":190,"range":{"start_line":190,"start_character":12,"end_line":190,"end_character":61},"updated":"2017-04-03 14:21:24.000000000","message":"Theoretically the \u0027trunk_details\u0027 attribute is only ever present when the \u0027trunk-details\u0027 extension is available. But this way we save an extra call to neutron and that sounds wise for performance.","commit_id":"06334db141ebbc2c8b1dee1c9da7f10facd35590"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"f1283a568f6f52184dd6856fd7b9052464e87c83","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        # filter out trunk children"},{"line_number":188,"context_line":"        tp_children \u003d []"},{"line_number":189,"context_line":"        for a_port in portlist:"},{"line_number":190,"context_line":"            property \u003d getattr(a_port, \"trunk_details\", None)"},{"line_number":191,"context_line":"            if property is not None:"},{"line_number":192,"context_line":"                for item in a_port.trunk_details[\"sub_ports\"]:"},{"line_number":193,"context_line":"                    tp_children.append(item[\"port_id\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_b786ceda","line":190,"range":{"start_line":190,"start_character":12,"end_line":190,"end_character":61},"in_reply_to":"dfeb2761_6983e2cd","updated":"2017-04-04 06:13:50.000000000","message":"Yes. The other reason is given in the next comment.","commit_id":"06334db141ebbc2c8b1dee1c9da7f10facd35590"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"189b1142dde3a0f856664e37b8ce3fe8c8547db9","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        tp_children \u003d []"},{"line_number":189,"context_line":"        for a_port in portlist:"},{"line_number":190,"context_line":"            property \u003d getattr(a_port, \"trunk_details\", None)"},{"line_number":191,"context_line":"            if property is not None:"},{"line_number":192,"context_line":"                for item in a_port.trunk_details[\"sub_ports\"]:"},{"line_number":193,"context_line":"                    tp_children.append(item[\"port_id\"])"},{"line_number":194,"context_line":"        filtered \u003d [p for p in portlist if p[\"id\"] not in tp_children]"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_29db9aed","line":191,"range":{"start_line":191,"start_character":15,"end_line":191,"end_character":35},"updated":"2017-04-03 14:21:24.000000000","message":"This would be a bit more defensive:\n\n propertry is not None and \u0027sub_ports\u0027 in a_port.trunk_details","commit_id":"06334db141ebbc2c8b1dee1c9da7f10facd35590"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"f1283a568f6f52184dd6856fd7b9052464e87c83","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        tp_children \u003d []"},{"line_number":189,"context_line":"        for a_port in portlist:"},{"line_number":190,"context_line":"            property \u003d getattr(a_port, \"trunk_details\", None)"},{"line_number":191,"context_line":"            if property is not None:"},{"line_number":192,"context_line":"                for item in a_port.trunk_details[\"sub_ports\"]:"},{"line_number":193,"context_line":"                    tp_children.append(item[\"port_id\"])"},{"line_number":194,"context_line":"        filtered \u003d [p for p in portlist if p[\"id\"] not in tp_children]"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_b7492e8c","line":191,"range":{"start_line":191,"start_character":15,"end_line":191,"end_character":35},"in_reply_to":"dfeb2761_29db9aed","updated":"2017-04-04 06:13:50.000000000","message":"My experience is that, if a trunk parent is in the list returned by the neutron REST call, it has trunk details. If there is no trunk child for this parent, the sub_ports property is an empty list, but present.","commit_id":"06334db141ebbc2c8b1dee1c9da7f10facd35590"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"189b1142dde3a0f856664e37b8ce3fe8c8547db9","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            if property is not None:"},{"line_number":192,"context_line":"                for item in a_port.trunk_details[\"sub_ports\"]:"},{"line_number":193,"context_line":"                    tp_children.append(item[\"port_id\"])"},{"line_number":194,"context_line":"        filtered \u003d [p for p in portlist if p[\"id\"] not in tp_children]"},{"line_number":195,"context_line":"        return filtered"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    ports \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_29603a01","line":194,"range":{"start_line":194,"start_character":19,"end_line":194,"end_character":70},"updated":"2017-04-03 14:21:24.000000000","message":"This is O(nm) for n ports and m tp_children. Can be practically quadratic. May or may not be ok depending on the scale we\u0027re targeting. Not sure about that though.","commit_id":"06334db141ebbc2c8b1dee1c9da7f10facd35590"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"f1283a568f6f52184dd6856fd7b9052464e87c83","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            if property is not None:"},{"line_number":192,"context_line":"                for item in a_port.trunk_details[\"sub_ports\"]:"},{"line_number":193,"context_line":"                    tp_children.append(item[\"port_id\"])"},{"line_number":194,"context_line":"        filtered \u003d [p for p in portlist if p[\"id\"] not in tp_children]"},{"line_number":195,"context_line":"        return filtered"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    ports \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_b717ee51","line":194,"range":{"start_line":194,"start_character":19,"end_line":194,"end_character":70},"in_reply_to":"dfeb2761_29603a01","updated":"2017-04-04 06:13:50.000000000","message":"Yes, i see Your computational complexity concerns, but i have found no better way to filter out the children: collect all parent\u0027s sub ports and filter with this collection the whole list.","commit_id":"06334db141ebbc2c8b1dee1c9da7f10facd35590"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"c5608b07d3bc6bed5b3d54168b10062a66894bc4","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    def add_children(port_list):"},{"line_number":187,"context_line":"        children \u003d []"},{"line_number":188,"context_line":"        for port in port_list:"},{"line_number":189,"context_line":"            property \u003d getattr(port, \"trunk_details\", None)"},{"line_number":190,"context_line":"            if property is not None:"},{"line_number":191,"context_line":"                for item in port.trunk_details[\"sub_ports\"]:"},{"line_number":192,"context_line":"                    children.append(item[\"port_id\"])"},{"line_number":193,"context_line":"        return children"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff0f0b1f_cdcd0686","line":190,"range":{"start_line":189,"start_character":12,"end_line":190,"end_character":36},"updated":"2017-05-23 11:02:25.000000000","message":"if hasattr(port, \"trunk_details\"): \nwould be the same, would it not?","commit_id":"c9a02a4a5cadb1130feefd99a9076f78d27e4bd8"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"8220a25bf3bcf43372b9bfab0152f72b103341cd","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    def add_children(port_list):"},{"line_number":187,"context_line":"        children \u003d []"},{"line_number":188,"context_line":"        for port in port_list:"},{"line_number":189,"context_line":"            property \u003d getattr(port, \"trunk_details\", None)"},{"line_number":190,"context_line":"            if property is not None:"},{"line_number":191,"context_line":"                for item in port.trunk_details[\"sub_ports\"]:"},{"line_number":192,"context_line":"                    children.append(item[\"port_id\"])"},{"line_number":193,"context_line":"        return children"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff0f0b1f_79f7c05a","line":190,"range":{"start_line":189,"start_character":12,"end_line":190,"end_character":36},"in_reply_to":"ff0f0b1f_cdcd0686","updated":"2017-05-24 06:48:15.000000000","message":"Yes it would. From the python 2.x manual: \"This is implemented by calling getattr(object, name) and seeing whether it raises an exception or not.)\" I used getattr() beacuse, handling an exception is a cost (even if it is handled internally) and I know that only a few element will have the \u0027trunk_details\u0027 normally. I agree with You that the use of hasattr() is more readable","commit_id":"c9a02a4a5cadb1130feefd99a9076f78d27e4bd8"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"c5608b07d3bc6bed5b3d54168b10062a66894bc4","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        return children"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    ports \u003d []"},{"line_number":196,"context_line":"    tp_children \u003d []"},{"line_number":197,"context_line":"    if api.base.is_service_enabled(request, \u0027network\u0027):"},{"line_number":198,"context_line":"        network_list \u003d api.neutron.network_list_for_tenant("},{"line_number":199,"context_line":"            request, request.user.tenant_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff0f0b1f_0db41ed0","line":196,"range":{"start_line":196,"start_character":4,"end_line":196,"end_character":6},"updated":"2017-05-23 11:02:25.000000000","message":"make this more verbose please; \"tp\" means nothing to people unfamiliar with trunks.","commit_id":"c9a02a4a5cadb1130feefd99a9076f78d27e4bd8"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"8220a25bf3bcf43372b9bfab0152f72b103341cd","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        return children"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    ports \u003d []"},{"line_number":196,"context_line":"    tp_children \u003d []"},{"line_number":197,"context_line":"    if api.base.is_service_enabled(request, \u0027network\u0027):"},{"line_number":198,"context_line":"        network_list \u003d api.neutron.network_list_for_tenant("},{"line_number":199,"context_line":"            request, request.user.tenant_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff0f0b1f_f9b99078","line":196,"range":{"start_line":196,"start_character":4,"end_line":196,"end_character":6},"in_reply_to":"ff0f0b1f_0db41ed0","updated":"2017-05-24 06:48:15.000000000","message":"Okay I will use \u0027trunk_children\u0027. I used tp_children because of fear from pep8 jenkins trigger error \u0027too long line\u0027","commit_id":"c9a02a4a5cadb1130feefd99a9076f78d27e4bd8"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"c5608b07d3bc6bed5b3d54168b10062a66894bc4","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            request, request.user.tenant_id)"},{"line_number":200,"context_line":"        for network in network_list:"},{"line_number":201,"context_line":"            net_port_list \u003d api.neutron.port_list(request,"},{"line_number":202,"context_line":"                                                  network_id\u003dnetwork.id)"},{"line_number":203,"context_line":"            tp_children +\u003d add_children(net_port_list)"},{"line_number":204,"context_line":"            ports.extend("},{"line_number":205,"context_line":"                [(port.id, add_more_info_port_name(port))"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff0f0b1f_8dbf0ea9","line":202,"updated":"2017-05-23 11:02:25.000000000","message":"This is an expensive API call. You\u0027re making a port list call for every single network in serial. I would like a cleaner solution.","commit_id":"c9a02a4a5cadb1130feefd99a9076f78d27e4bd8"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"8220a25bf3bcf43372b9bfab0152f72b103341cd","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            request, request.user.tenant_id)"},{"line_number":200,"context_line":"        for network in network_list:"},{"line_number":201,"context_line":"            net_port_list \u003d api.neutron.port_list(request,"},{"line_number":202,"context_line":"                                                  network_id\u003dnetwork.id)"},{"line_number":203,"context_line":"            tp_children +\u003d add_children(net_port_list)"},{"line_number":204,"context_line":"            ports.extend("},{"line_number":205,"context_line":"                [(port.id, add_more_info_port_name(port))"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff0f0b1f_fc297e36","line":202,"in_reply_to":"ff0f0b1f_8dbf0ea9","updated":"2017-05-24 06:48:15.000000000","message":"Rob this is the same \u0027generator\u0027 used in the list comprehension of the original code. The original goal was to map port_id to port_name+IPV4 address. The widget should collect, hence display each defined ports available for this tenant. I have just reused the generator output to feed the new function add_children() as well.","commit_id":"c9a02a4a5cadb1130feefd99a9076f78d27e4bd8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d73279903831936ed882ac88ffe060e2f2f5ddb4","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            request, request.user.tenant_id)"},{"line_number":191,"context_line":"        for network in network_list:"},{"line_number":192,"context_line":"            ports.extend("},{"line_number":193,"context_line":"                [(port.id, add_more_info_port_name(port))"},{"line_number":194,"context_line":"                 for port in api.neutron.port_list_with_trunk_types("},{"line_number":195,"context_line":"                    request,"},{"line_number":196,"context_line":"                    network_id\u003dnetwork.id,"},{"line_number":197,"context_line":"                    tenant_id\u003drequest.user.tenant_id)"},{"line_number":198,"context_line":"                 if ((type(port) is not PortTrunkSubport) and"},{"line_number":199,"context_line":"                     (port.device_owner \u003d\u003d \u0027\u0027))])"},{"line_number":200,"context_line":"    ports.sort(key\u003dlambda obj: obj[1])"},{"line_number":201,"context_line":"    return ports"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_f0005036","line":199,"range":{"start_line":193,"start_character":16,"end_line":199,"end_character":48},"updated":"2017-07-19 19:27:53.000000000","message":"I would suggest to move this logic to api/neutron and create a new function called get_bootable_ports().","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d73279903831936ed882ac88ffe060e2f2f5ddb4","unresolved":false,"context_lines":[{"line_number":511,"context_line":"      var ports \u003d [];"},{"line_number":512,"context_line":"      networkPorts.data.items.forEach(function(port) {"},{"line_number":513,"context_line":"        // no device_owner means that the port can be attached"},{"line_number":514,"context_line":"        if (port.device_owner \u003d\u003d\u003d \"\" \u0026\u0026 port.admin_state \u003d\u003d\u003d \"UP\") {"},{"line_number":515,"context_line":"          port.subnet_names \u003d getPortSubnets(port, network.subnets);"},{"line_number":516,"context_line":"          port.network_name \u003d network.name;"},{"line_number":517,"context_line":"          if (!port.hasOwnProperty(\"trunk_id\")) {"},{"line_number":518,"context_line":"            ports.push(port);"},{"line_number":519,"context_line":"          }"},{"line_number":520,"context_line":"        }"},{"line_number":521,"context_line":"      });"},{"line_number":522,"context_line":"      push.apply(model.ports, ports);"},{"line_number":523,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":32,"id":"1f1a1f67_f073b0e5","line":520,"range":{"start_line":514,"start_character":8,"end_line":520,"end_character":9},"updated":"2017-07-19 19:27:53.000000000","message":"Honestly I do not like the logic like this. In large deployments, we usually have a lot of ports, but most of them are used by servers and the number of bootable ports (ports which can be used for a new server) will be small. I don\u0027t think it is a good idea to return hundreds or more ports and choose a few number of bootable ports... it costs much, but most JavaScript developers like this? I believe this logic should be revisit later.","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d01c1bd9bfff22c9152ff29c1b02a79f210c3ba9","unresolved":false,"context_lines":[{"line_number":511,"context_line":"      var ports \u003d [];"},{"line_number":512,"context_line":"      networkPorts.data.items.forEach(function(port) {"},{"line_number":513,"context_line":"        // no device_owner means that the port can be attached"},{"line_number":514,"context_line":"        if (port.device_owner \u003d\u003d\u003d \"\" \u0026\u0026 port.admin_state \u003d\u003d\u003d \"UP\") {"},{"line_number":515,"context_line":"          port.subnet_names \u003d getPortSubnets(port, network.subnets);"},{"line_number":516,"context_line":"          port.network_name \u003d network.name;"},{"line_number":517,"context_line":"          if (!port.hasOwnProperty(\"trunk_id\")) {"},{"line_number":518,"context_line":"            ports.push(port);"},{"line_number":519,"context_line":"          }"},{"line_number":520,"context_line":"        }"},{"line_number":521,"context_line":"      });"},{"line_number":522,"context_line":"      push.apply(model.ports, ports);"},{"line_number":523,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":32,"id":"ff346bd7_1a8f36cd","line":520,"range":{"start_line":514,"start_character":8,"end_line":520,"end_character":9},"in_reply_to":"1f1a1f67_f073b0e5","updated":"2017-07-24 16:40:16.000000000","message":"I don\u0027t like the approach, but the trunk support changes the situation a bit, so I am okay with it in this patch.","commit_id":"dc146e41b95b14c29614cc0b9a27d81656ffa830"}],"openstack_dashboard/test/api_tests/neutron_tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c23b0a094984f66e917ba8aaa6793e78728c489e","unresolved":false,"context_lines":[{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        ret_val \u003d api.neutron.port_list_with_trunk_types(self.request)"},{"line_number":384,"context_line":"        for p in ret_val:"},{"line_number":385,"context_line":"            self.assertTrue(repr(p) in [repr(p) for p in self.tp_ports.list()])"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def test_port_get(self):"},{"line_number":388,"context_line":"        port \u003d {\u0027port\u0027: self.api_ports.first()}"}],"source_content_type":"text/x-python","patch_set":43,"id":"bf3e73b7_6d51120f","line":385,"updated":"2017-08-05 15:14:01.000000000","message":"This covers only the most typical case. I think we need to cover more complex cases checking the detail logic of test_port_list_with_trunk_types.\n\nListing detail cases needs effort to me at the same level of effort like writing tests, so if you need more information on what needs to be covered I can write more tests (but it will be after Queens cycle is open).","commit_id":"c2596cfae039fc55d40b3cf4352368087ecf36c2"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"0627eb058733f0fe2642dc85388c5a88b4836d14","unresolved":false,"context_lines":[{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        ret_val \u003d api.neutron.port_list_with_trunk_types(self.request)"},{"line_number":384,"context_line":"        for p in ret_val:"},{"line_number":385,"context_line":"            self.assertTrue(repr(p) in [repr(p) for p in self.tp_ports.list()])"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def test_port_get(self):"},{"line_number":388,"context_line":"        port \u003d {\u0027port\u0027: self.api_ports.first()}"}],"source_content_type":"text/x-python","patch_set":43,"id":"bf3e73b7_b761783c","line":385,"in_reply_to":"bf3e73b7_6d51120f","updated":"2017-08-07 06:17:12.000000000","message":"Akihiro - this is a complex test, function faces to a complex data structure, 4 ports, subport in other net than trunk parent. Output is checked against an expected result.","commit_id":"c2596cfae039fc55d40b3cf4352368087ecf36c2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cecfa1b37b09014c0aa1edd381a333483f6e5eae","unresolved":false,"context_lines":[{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        ret_val \u003d api.neutron.port_list_with_trunk_types(self.request)"},{"line_number":384,"context_line":"        for v in ret_val:"},{"line_number":385,"context_line":"            self.assertTrue(repr(v) in [repr(p) for p in self.tp_ports.list()])"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def test_port_get(self):"},{"line_number":388,"context_line":"        port \u003d {\u0027port\u0027: self.api_ports.first()}"}],"source_content_type":"text/x-python","patch_set":52,"id":"7f287b81_15ce1383","line":385,"updated":"2017-08-31 21:32:24.000000000","message":"It is better to check all expected ports are included. This version works but this depends on self.tp_ports. Generally, it is better to depend on self.api_tp_ports. I updated the tests in patch set 53 so that it tests what we expect more.","commit_id":"7cf775a780599e32088c379189bfbe82ece05d53"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"53607f7af9161a48a740d0aadcfbb3947e8b3180","unresolved":false,"context_lines":[{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        ret_val \u003d api.neutron.port_list_with_trunk_types(self.request)"},{"line_number":384,"context_line":"        for v in ret_val:"},{"line_number":385,"context_line":"            self.assertTrue(repr(v) in [repr(p) for p in self.tp_ports.list()])"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def test_port_get(self):"},{"line_number":388,"context_line":"        port \u003d {\u0027port\u0027: self.api_ports.first()}"}],"source_content_type":"text/x-python","patch_set":52,"id":"7f287b81_a0e5943a","line":385,"in_reply_to":"7f287b81_15ce1383","updated":"2017-09-03 12:41:10.000000000","message":"Akihiro, my approach was a black-box test, i.e. provide stimuli in ports and trunks and check system response against self.tp_ports - what holds the expected results (port kinds with attributes) I can accept the use of self.tp_ports may not fit well into the framework\u0027s concepts.","commit_id":"7cf775a780599e32088c379189bfbe82ece05d53"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3200c7bf55692f9a4da84ed8b90b4ecf4b4ac538","unresolved":false,"context_lines":[{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        ret_val \u003d api.neutron.port_list_with_trunk_types(self.request)"},{"line_number":384,"context_line":"        for v in ret_val:"},{"line_number":385,"context_line":"            self.assertTrue(repr(v) in [repr(p) for p in self.tp_ports.list()])"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def test_port_get(self):"},{"line_number":388,"context_line":"        port \u003d {\u0027port\u0027: self.api_ports.first()}"}],"source_content_type":"text/x-python","patch_set":52,"id":"7f287b81_263dd88e","line":385,"in_reply_to":"7f287b81_a0e5943a","updated":"2017-09-07 08:26:17.000000000","message":"Yes, your approach works well. Sorry for confusion. The approach is no problem, but it is just not what we don\u0027t usually do.\n\nThe only thing I thought should be improved is it did not check all items in self.tp_ports are contained in ret_val. I tried to follow the approach but when classifying port classes it turned out more logic is needed.","commit_id":"7cf775a780599e32088c379189bfbe82ece05d53"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"348d59816179739343ebe098b77f04dbf36f7bcf","unresolved":false,"context_lines":[{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        ret_val \u003d api.neutron.port_list_with_trunk_types(self.request)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        self.assertEqual(len(self.tp_ports.list()), len(ret_val))"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        parent_port_ids \u003d {p.id for p in ret_val"},{"line_number":416,"context_line":"                           if isinstance(p, api.neutron.PortTrunkParent)}"}],"source_content_type":"text/x-python","patch_set":53,"id":"7f287b81_75a437ba","line":413,"range":{"start_line":413,"start_character":29,"end_line":413,"end_character":42},"updated":"2017-08-31 21:33:15.000000000","message":"This should be self.api_ports to check the length of ret_val is same as that of self.api_tp_ports.","commit_id":"1efa60ca2440f4eb8ce71616f1c20a250ff78975"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"40e10a760f1494a70d369b39b6e04e0b77d54bc3","unresolved":false,"context_lines":[{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        ret_val \u003d api.neutron.port_list_with_trunk_types(self.request)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        self.assertEqual(len(self.tp_ports.list()), len(ret_val))"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        parent_port_ids \u003d {p.id for p in ret_val"},{"line_number":416,"context_line":"                           if isinstance(p, api.neutron.PortTrunkParent)}"}],"source_content_type":"text/x-python","patch_set":53,"id":"7f287b81_f578272c","line":413,"range":{"start_line":413,"start_character":29,"end_line":413,"end_character":42},"in_reply_to":"7f287b81_75a437ba","updated":"2017-08-31 21:34:27.000000000","message":"Done","commit_id":"1efa60ca2440f4eb8ce71616f1c20a250ff78975"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"82f26cf344d68aceae9a43eaa1a3f06d1ffaabb9","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        ret_val \u003d api.neutron.port_list_with_trunk_types(self.request)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        self.assertEqual(len(ports), len(ret_val))"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        parent_port_ids \u003d {p.id for p in ret_val"},{"line_number":416,"context_line":"                           if isinstance(p, api.neutron.PortTrunkParent)}"},{"line_number":417,"context_line":"        subport_ids \u003d {p.id for p in ret_val"}],"source_content_type":"text/x-python","patch_set":54,"id":"7f287b81_c0e2e001","line":414,"updated":"2017-09-03 12:38:49.000000000","message":"As I see Your code does the verification on a port kind basis. I\u0027m fine with Your approach, too","commit_id":"748d9860bb95f931f70479f831ceea3e240243d4"}]}
