)]}'
{"openstack_dashboard/dashboards/project/cgroups/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9d12ad90a86e58b758f5a3c0440783092f527aa6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        cleaned_data \u003d super(UpdateForm, self).clean()"},{"line_number":33,"context_line":"        new_desc \u003d cleaned_data.get(\u0027description\u0027)"},{"line_number":34,"context_line":"        old_desc \u003d self.initial[\u0027description\u0027]"},{"line_number":35,"context_line":"        if old_desc and len(old_desc):"},{"line_number":36,"context_line":"            if len(new_desc) \u003d\u003d 0:"},{"line_number":37,"context_line":"                error_msg \u003d _(\"Description is required.\")"},{"line_number":38,"context_line":"                self._errors[\u0027description\u0027] \u003d self.error_class([error_msg])"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_07b9f82c","line":35,"updated":"2017-04-06 20:29:46.000000000","message":"So can we change this to\n\n  if old_desc:","commit_id":"c177a4221760da3901aaf0df2d847861a7b8e1a4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9d12ad90a86e58b758f5a3c0440783092f527aa6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        new_desc \u003d cleaned_data.get(\u0027description\u0027)"},{"line_number":34,"context_line":"        old_desc \u003d self.initial[\u0027description\u0027]"},{"line_number":35,"context_line":"        if old_desc and len(old_desc):"},{"line_number":36,"context_line":"            if len(new_desc) \u003d\u003d 0:"},{"line_number":37,"context_line":"                error_msg \u003d _(\"Description is required.\")"},{"line_number":38,"context_line":"                self._errors[\u0027description\u0027] \u003d self.error_class([error_msg])"},{"line_number":39,"context_line":"                return cleaned_data"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_0792189f","line":36,"range":{"start_line":36,"start_character":11,"end_line":36,"end_character":34},"updated":"2017-04-06 20:29:46.000000000","message":"and we can merge L.35 and 36.\n\n  if old_desc and not new_desc:","commit_id":"c177a4221760da3901aaf0df2d847861a7b8e1a4"},{"author":{"_account_id":24056,"name":"wei.ying","email":"wei.ying@easystack.cn","username":"wei.ying"},"change_message_id":"a656226bbacb3318cca6ff108dbd92989418ea0c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        new_desc \u003d cleaned_data.get(\u0027description\u0027)"},{"line_number":34,"context_line":"        old_desc \u003d self.initial[\u0027description\u0027]"},{"line_number":35,"context_line":"        if old_desc and len(old_desc):"},{"line_number":36,"context_line":"            if len(new_desc) \u003d\u003d 0:"},{"line_number":37,"context_line":"                error_msg \u003d _(\"Description is required.\")"},{"line_number":38,"context_line":"                self._errors[\u0027description\u0027] \u003d self.error_class([error_msg])"},{"line_number":39,"context_line":"                return cleaned_data"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_e9c70212","line":36,"range":{"start_line":36,"start_character":11,"end_line":36,"end_character":34},"in_reply_to":"bff0334d_0792189f","updated":"2017-04-07 02:09:42.000000000","message":"That\u0027s good advice, thanks for your comment that make sense. Done in patch set 2.","commit_id":"c177a4221760da3901aaf0df2d847861a7b8e1a4"}]}
