)]}'
{"horizon/static/framework/widgets/form/modal-form.controller.js":[{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"79a2d1516fe901d3df520c0eb246cef5def7a18d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    ctrl.submitText \u003d context.submitText;"},{"line_number":51,"context_line":"    ctrl.submitIcon \u003d context.submitIcon;"},{"line_number":52,"context_line":"    ctrl.cancel \u003d cancel;"},{"line_number":53,"context_line":"    ctrl.checkSubmit \u003d function($event, schemaForm) {"},{"line_number":54,"context_line":"      $event.preventDefault();"},{"line_number":55,"context_line":"      $event.stopPropagation();"},{"line_number":56,"context_line":"      if (!schemaForm.$invalid) {"},{"line_number":57,"context_line":"        $uibModalInstance.close(context);"},{"line_number":58,"context_line":"      }"},{"line_number":59,"context_line":"    };"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    function submit() {"}],"source_content_type":"text/javascript","patch_set":12,"id":"3f4b6375_00769e07","line":58,"range":{"start_line":53,"start_character":31,"end_line":58,"end_character":7},"updated":"2017-10-31 08:54:57.000000000","message":"could you move these lines into existing submit() ?","commit_id":"7836ccc89e2632591559d4a8577bc505339f46e7"}],"horizon/static/framework/widgets/form/modal-form.html":[{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"9bcc480e78ca270c46ac40c0a8b97599615ac0d4","unresolved":false,"context_lines":[{"line_number":8,"context_line":"\u003c/div\u003e"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"\u003cdiv class\u003d\"modal-body\"\u003e"},{"line_number":11,"context_line":"  \u003cform name\u003d\"schemaForm\""},{"line_number":12,"context_line":"        sf-schema\u003d\"ctrl.schema\""},{"line_number":13,"context_line":"        sf-form\u003d\"ctrl.form\""},{"line_number":14,"context_line":"        sf-model\u003d\"ctrl.model\""}],"source_content_type":"text/html","patch_set":8,"id":"7f515b1d_e1e5fd39","line":11,"updated":"2017-09-22 03:15:48.000000000","message":"I think this issue can be fixed simply by using the div tag instead of the form tag on line 11 and 17.","commit_id":"3505f1e4e1f5e8fe837e78a4900c6ccf819d9968"},{"author":{"_account_id":12156,"name":"Jeremy Moffitt","email":"jmoffitt@suse.com","username":"jmoffitt"},"change_message_id":"9e5fd7d85e384de2e911b1405da3bc88236a17f5","unresolved":false,"context_lines":[{"line_number":8,"context_line":"\u003c/div\u003e"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"\u003cdiv class\u003d\"modal-body\"\u003e"},{"line_number":11,"context_line":"  \u003cform name\u003d\"schemaForm\""},{"line_number":12,"context_line":"        sf-schema\u003d\"ctrl.schema\""},{"line_number":13,"context_line":"        sf-form\u003d\"ctrl.form\""},{"line_number":14,"context_line":"        sf-model\u003d\"ctrl.model\""}],"source_content_type":"text/html","patch_set":8,"id":"7f515b1d_cabf9cce","line":11,"in_reply_to":"7f515b1d_e1e5fd39","updated":"2017-10-04 20:07:15.000000000","message":"I\u0027ll give it a try, thanks for the suggestion","commit_id":"3505f1e4e1f5e8fe837e78a4900c6ccf819d9968"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"79a2d1516fe901d3df520c0eb246cef5def7a18d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        sf-model\u003d\"ctrl.model\""},{"line_number":15,"context_line":"        sf-options\u003d\"{ validateOnRender: true,"},{"line_number":16,"context_line":"                      pristine: { errors: false, success: false } }\""},{"line_number":17,"context_line":"        ng-submit\u003d\"ctrl.checkSubmit($event, schemaForm, ctrl.model)\"\u003e"},{"line_number":18,"context_line":"  \u003c/form\u003e"},{"line_number":19,"context_line":"\u003c/div\u003e"},{"line_number":20,"context_line":""}],"source_content_type":"text/html","patch_set":12,"id":"3f4b6375_a0646a4a","line":17,"range":{"start_line":17,"start_character":24,"end_line":17,"end_character":35},"updated":"2017-10-31 08:54:57.000000000","message":"could you use existing submit() ?","commit_id":"7836ccc89e2632591559d4a8577bc505339f46e7"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"79a2d1516fe901d3df520c0eb246cef5def7a18d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        sf-model\u003d\"ctrl.model\""},{"line_number":15,"context_line":"        sf-options\u003d\"{ validateOnRender: true,"},{"line_number":16,"context_line":"                      pristine: { errors: false, success: false } }\""},{"line_number":17,"context_line":"        ng-submit\u003d\"ctrl.checkSubmit($event, schemaForm, ctrl.model)\"\u003e"},{"line_number":18,"context_line":"  \u003c/form\u003e"},{"line_number":19,"context_line":"\u003c/div\u003e"},{"line_number":20,"context_line":""}],"source_content_type":"text/html","patch_set":12,"id":"3f4b6375_805bae85","line":17,"range":{"start_line":17,"start_character":54,"end_line":17,"end_character":66},"updated":"2017-10-31 08:54:57.000000000","message":"unnecessary","commit_id":"7836ccc89e2632591559d4a8577bc505339f46e7"}],"releasenotes/notes/bug-1655487-406fd9c70104d333.yaml":[{"author":{"_account_id":11880,"name":"Gloria Gu","email":"gloriafanggu@gmail.com","username":"gugl"},"change_message_id":"bfbcdeb80b316adb9af266b2ce9f72ee8f354b2f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    will not call the submit function defined in the controller. To enable"},{"line_number":7,"context_line":"    this functionality, add a \"preventSubmitOnEnter\" context value set to"},{"line_number":8,"context_line":"    true in the form context object (see containers.controller.js as an"},{"line_number":9,"context_line":"    example). "},{"line_number":10,"context_line":"fixes:"},{"line_number":11,"context_line":"  - The root cause of this seems to be that forms created with the modal"},{"line_number":12,"context_line":"    service normally use a submit button outside of the \"form\" element"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f044301_56210dfb","line":9,"range":{"start_line":9,"start_character":13,"end_line":9,"end_character":14},"updated":"2017-05-04 23:23:23.000000000","message":"nit, please remove an extra space at the end.","commit_id":"d4457f290e2c868215f5f58d83fc24f4373fe6a2"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"8e6d1397ea46d1af658b2b96d736b62d9575a7bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Allows panels to programatically block premature submission for forms"},{"line_number":4,"context_line":"    created via the modal-form.service.js . Due to the way uibModals are"},{"line_number":5,"context_line":"    structured, pressing \"enter\" on a form field will submit the form, but"},{"line_number":6,"context_line":"    will not call the submit function defined in the controller. To enable"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f515b1d_32d69e51","line":3,"range":{"start_line":3,"start_character":3,"end_line":3,"end_character":5},"updated":"2017-10-05 03:42:16.000000000","message":"add a |","commit_id":"3505f1e4e1f5e8fe837e78a4900c6ccf819d9968"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"8e6d1397ea46d1af658b2b96d736b62d9575a7bb","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    true in the form context object (see containers.controller.js as an"},{"line_number":9,"context_line":"    example)."},{"line_number":10,"context_line":"fixes:"},{"line_number":11,"context_line":"  - The root cause of this seems to be that forms created with the modal"},{"line_number":12,"context_line":"    service normally use a submit button outside of the \"form\" element"},{"line_number":13,"context_line":"    in the DOM, but pressing enter on a form defaults to submitting the"},{"line_number":14,"context_line":"    actual \u003cform\u003e element, bypassing the modal service."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f515b1d_b2c16e83","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":4},"updated":"2017-10-05 03:42:16.000000000","message":"add a |","commit_id":"3505f1e4e1f5e8fe837e78a4900c6ccf819d9968"}]}