)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e9ece8fabccf48dd861b5e9595e9d6ecc8659dea","unresolved":false,"context_lines":[{"line_number":7,"context_line":"operation_log: Fix logout generating AttributeError"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When logging out request.user.is_authenticated() throws"},{"line_number":10,"context_line":"AttributeError as request.user is NoneType and does not"},{"line_number":11,"context_line":"contain required method. Solution is to wrap the code"},{"line_number":12,"context_line":"with try block and ignore AttributeError exception."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f1d235d_58cdb65b","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":41},"updated":"2017-06-30 07:25:54.000000000","message":"If so, why don\u0027t you check request.user is None rather than catching AttributeError?","commit_id":"c0638a936dc56ae9432b571fed7accf0e73dedc2"}],"horizon/middleware/operation_log.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e9ece8fabccf48dd861b5e9595e9d6ecc8659dea","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _get_log_format(self, request):"},{"line_number":108,"context_line":"        \"\"\"Return operation log format.\"\"\""},{"line_number":109,"context_line":"        try:"},{"line_number":110,"context_line":"            if not (hasattr(request, \u0027user\u0027) and"},{"line_number":111,"context_line":"                    request.user.is_authenticated()):"},{"line_number":112,"context_line":"                return"},{"line_number":113,"context_line":"        except AttributeError:"},{"line_number":114,"context_line":"            return"},{"line_number":115,"context_line":"        method \u003d request.method.upper()"},{"line_number":116,"context_line":"        if not (method in self.target_methods):"},{"line_number":117,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_f81362b7","line":114,"range":{"start_line":109,"start_character":8,"end_line":114,"end_character":18},"updated":"2017-06-30 07:25:54.000000000","message":"I think the following logic is cleaner.\n\n  user \u003d getattr(request, \u0027user\u0027, None)\n  if not user:\n      return\n  if not request.user.is_authenticated():\n      return","commit_id":"c0638a936dc56ae9432b571fed7accf0e73dedc2"}]}
