)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ff1855287d6b1f5e0abb423d607552d9b83dcaf0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     wei.ying \u003cwei.ying@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-08 23:28:09 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use subnet id to allocate floating IP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the admin allocate floating IP form, the pool select display"},{"line_number":10,"context_line":"the subnet cidr info, which should be used subnet id when creating a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff0f0b1f_51da48e9","line":7,"updated":"2017-05-17 20:28:48.000000000","message":"Could you add \"in Admin panel\" at the end of line?","commit_id":"94d782320b7949ab611275b4f8edf5348a5d28cc"},{"author":{"_account_id":24056,"name":"wei.ying","email":"wei.ying@easystack.cn","username":"wei.ying"},"change_message_id":"62375290fbde54dab998bf5c2f9e8cf9b7a123fd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     wei.ying \u003cwei.ying@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-08 23:28:09 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use subnet id to allocate floating IP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the admin allocate floating IP form, the pool select display"},{"line_number":10,"context_line":"the subnet cidr info, which should be used subnet id when creating a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff0f0b1f_45383bd2","line":7,"in_reply_to":"ff0f0b1f_51da48e9","updated":"2017-05-18 01:50:59.000000000","message":"Add it in next patch.","commit_id":"94d782320b7949ab611275b4f8edf5348a5d28cc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ff1855287d6b1f5e0abb423d607552d9b83dcaf0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"floating IP. This patch fix it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4f12027c90e580824d74b10010bf799515920702"},{"line_number":14,"context_line":"loses-Bug: #1689230"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff0f0b1f_d1bbf8e2","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":9},"updated":"2017-05-17 20:28:48.000000000","message":"-\u003e Closes-Bug\n\n\"C\" at the beginning is missing","commit_id":"94d782320b7949ab611275b4f8edf5348a5d28cc"},{"author":{"_account_id":24056,"name":"wei.ying","email":"wei.ying@easystack.cn","username":"wei.ying"},"change_message_id":"62375290fbde54dab998bf5c2f9e8cf9b7a123fd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"floating IP. This patch fix it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4f12027c90e580824d74b10010bf799515920702"},{"line_number":14,"context_line":"loses-Bug: #1689230"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff0f0b1f_852653b7","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":9},"in_reply_to":"ff0f0b1f_d1bbf8e2","updated":"2017-05-18 01:50:59.000000000","message":"How embarrassing. Thanks for the review Akihiro!","commit_id":"94d782320b7949ab611275b4f8edf5348a5d28cc"}],"openstack_dashboard/dashboards/admin/floating_ips/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ff1855287d6b1f5e0abb423d607552d9b83dcaf0","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        self.assertContains(res, \"Invalid version for IP address\")"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @test.create_stubs({api.network: (\u0027tenant_floating_ip_allocate\u0027,),"},{"line_number":158,"context_line":"                        api.neutron: (\u0027network_list\u0027, \u0027subnet_get\u0027,),"},{"line_number":159,"context_line":"                        api.keystone: (\u0027tenant_list\u0027,)})"},{"line_number":160,"context_line":"    def test_admin_allocate_post(self):"},{"line_number":161,"context_line":"        tenant \u003d self.tenants.first()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_71878cd9","line":158,"range":{"start_line":158,"start_character":66,"end_line":158,"end_character":67},"updated":"2017-05-17 20:28:48.000000000","message":"nit: A comma at the end is unnecessary.","commit_id":"94d782320b7949ab611275b4f8edf5348a5d28cc"}],"openstack_dashboard/dashboards/admin/floating_ips/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ff1855287d6b1f5e0abb423d607552d9b83dcaf0","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            for subnet in pool.subnets:"},{"line_number":177,"context_line":"                if netaddr.IPNetwork(subnet.cidr).version !\u003d 4:"},{"line_number":178,"context_line":"                    continue"},{"line_number":179,"context_line":"                pool_display_name \u003d (_(\"%(cidr)s %(pool_name)s\")"},{"line_number":180,"context_line":"                                     % {\u0027cidr\u0027: subnet.cidr,"},{"line_number":181,"context_line":"                                        \u0027pool_name\u0027: pool.name})"},{"line_number":182,"context_line":"                pool_list.append((subnet.id, pool_display_name))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_5155a84f","line":179,"range":{"start_line":179,"start_character":40,"end_line":179,"end_character":62},"updated":"2017-05-17 20:28:48.000000000","message":"IMHO \"%(pool_name)s (%(cidr)s)\" would be nicer. I think users first check the pool name and then check CIDR so I think it is better to place the pool name first. Thought?","commit_id":"94d782320b7949ab611275b4f8edf5348a5d28cc"},{"author":{"_account_id":24056,"name":"wei.ying","email":"wei.ying@easystack.cn","username":"wei.ying"},"change_message_id":"62375290fbde54dab998bf5c2f9e8cf9b7a123fd","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            for subnet in pool.subnets:"},{"line_number":177,"context_line":"                if netaddr.IPNetwork(subnet.cidr).version !\u003d 4:"},{"line_number":178,"context_line":"                    continue"},{"line_number":179,"context_line":"                pool_display_name \u003d (_(\"%(cidr)s %(pool_name)s\")"},{"line_number":180,"context_line":"                                     % {\u0027cidr\u0027: subnet.cidr,"},{"line_number":181,"context_line":"                                        \u0027pool_name\u0027: pool.name})"},{"line_number":182,"context_line":"                pool_list.append((subnet.id, pool_display_name))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_453ddbb9","line":179,"range":{"start_line":179,"start_character":40,"end_line":179,"end_character":62},"in_reply_to":"ff0f0b1f_5155a84f","updated":"2017-05-18 01:50:59.000000000","message":"I think so. Thanks, it makes sense for the user.","commit_id":"94d782320b7949ab611275b4f8edf5348a5d28cc"}]}
