)]}'
{"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.js":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"5f116d2eeeecc31bf925a2d8a1cb1035d64dea94","unresolved":false,"context_lines":[{"line_number":667,"context_line":""},{"line_number":668,"context_line":"    function addAllowedBootSource(rawTypes, type, label) {"},{"line_number":669,"context_line":"      if (rawTypes) {"},{"line_number":670,"context_line":"        var allowedBootSources \u003d model.allowedBootSources;"},{"line_number":671,"context_line":"        allowedBootSources.push({"},{"line_number":672,"context_line":"          type: type,"},{"line_number":673,"context_line":"          label: label"},{"line_number":674,"context_line":"        });"},{"line_number":675,"context_line":"        allowedBootSources.sort(function(a, b) {"},{"line_number":676,"context_line":"          return a.type \u003e b.type;"},{"line_number":677,"context_line":"        });"},{"line_number":678,"context_line":"        model.allowedBootSources \u003d allowedBootSources;"},{"line_number":679,"context_line":"      }"},{"line_number":680,"context_line":"    }"},{"line_number":681,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"1f013ff3_30367b05","line":678,"range":{"start_line":670,"start_character":8,"end_line":678,"end_character":54},"updated":"2017-05-16 09:42:02.000000000","message":"Why do we have to assign to new var?\nWhy not do this instead:\n    model.allowedBootSources.sort(...)","commit_id":"8a52ce2804fc66732ab469ae89b08077fa4bf885"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"917b9fe0c52f42f2903a80f4f0c1ae396836b72a","unresolved":false,"context_lines":[{"line_number":667,"context_line":""},{"line_number":668,"context_line":"    function addAllowedBootSource(rawTypes, type, label) {"},{"line_number":669,"context_line":"      if (rawTypes) {"},{"line_number":670,"context_line":"        var allowedBootSources \u003d model.allowedBootSources;"},{"line_number":671,"context_line":"        allowedBootSources.push({"},{"line_number":672,"context_line":"          type: type,"},{"line_number":673,"context_line":"          label: label"},{"line_number":674,"context_line":"        });"},{"line_number":675,"context_line":"        allowedBootSources.sort(function(a, b) {"},{"line_number":676,"context_line":"          return a.type \u003e b.type;"},{"line_number":677,"context_line":"        });"},{"line_number":678,"context_line":"        model.allowedBootSources \u003d allowedBootSources;"},{"line_number":679,"context_line":"      }"},{"line_number":680,"context_line":"    }"},{"line_number":681,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"ff0f0b1f_f3848760","line":678,"range":{"start_line":670,"start_character":8,"end_line":678,"end_character":54},"in_reply_to":"1f013ff3_30367b05","updated":"2017-05-19 11:09:00.000000000","message":"As in, .push() and then .sort()? Mainly just to avoid having the UI keep updating itself. If you push to allowedBootSources, the select will update, and then update again when sort is triggered.\n\nNow that I think about it, a nicer solution might be use $q.all() and then sort it...","commit_id":"8a52ce2804fc66732ab469ae89b08077fa4bf885"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"84eea47c665dc364363f850bf4a2f1a7910bd6e6","unresolved":false,"context_lines":[{"line_number":667,"context_line":""},{"line_number":668,"context_line":"    function addAllowedBootSource(rawTypes, type, label) {"},{"line_number":669,"context_line":"      if (rawTypes) {"},{"line_number":670,"context_line":"        var allowedBootSources \u003d model.allowedBootSources;"},{"line_number":671,"context_line":"        allowedBootSources.push({"},{"line_number":672,"context_line":"          type: type,"},{"line_number":673,"context_line":"          label: label"},{"line_number":674,"context_line":"        });"},{"line_number":675,"context_line":"        allowedBootSources.sort(function(a, b) {"},{"line_number":676,"context_line":"          return a.type \u003e b.type;"},{"line_number":677,"context_line":"        });"},{"line_number":678,"context_line":"        model.allowedBootSources \u003d allowedBootSources;"},{"line_number":679,"context_line":"      }"},{"line_number":680,"context_line":"    }"},{"line_number":681,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"ff0f0b1f_73c6379d","line":678,"range":{"start_line":670,"start_character":8,"end_line":678,"end_character":54},"in_reply_to":"ff0f0b1f_f3848760","updated":"2017-05-19 11:10:52.000000000","message":"/me needs coffee, I just realised my reply was dum.","commit_id":"8a52ce2804fc66732ab469ae89b08077fa4bf885"}]}