)]}'
{"openstack_dashboard/dashboards/project/instances/tests.py":[{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"8f77e27243309e3a6a227603d522bceed4bd27ac","unresolved":false,"context_lines":[{"line_number":2897,"context_line":"                                    \u0027tenant_limit_usages\u0027)})"},{"line_number":2898,"context_line":"    def _test_launch_form_instance_requirement_error(self, image, flavor,"},{"line_number":2899,"context_line":"                                                     keypair_require\u003dFalse,"},{"line_number":2900,"context_line":"                                                     no_error\u003dFalse):"},{"line_number":2901,"context_line":"        keypair \u003d self.keypairs.first()"},{"line_number":2902,"context_line":"        server \u003d self.servers.first()"},{"line_number":2903,"context_line":"        volume \u003d self.volumes.first()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_6ae9b518","line":2900,"updated":"2017-05-18 16:04:23.000000000","message":"It\u0027s weird to have a no_error option for this error test case. There should be separate tests cases for valid and error scenarios.","commit_id":"e061657178fdab7cea933f3fa0b44ceedb535482"},{"author":{"_account_id":16628,"name":"Beth Elwell","email":"e.r.elwell@gmail.com","username":"bethelwell"},"change_message_id":"364ad0c2373e847b548c7f6d080dace297a3c215","unresolved":false,"context_lines":[{"line_number":2897,"context_line":"                                    \u0027tenant_limit_usages\u0027)})"},{"line_number":2898,"context_line":"    def _test_launch_form_instance_requirement_error(self, image, flavor,"},{"line_number":2899,"context_line":"                                                     keypair_require\u003dFalse,"},{"line_number":2900,"context_line":"                                                     no_error\u003dFalse):"},{"line_number":2901,"context_line":"        keypair \u003d self.keypairs.first()"},{"line_number":2902,"context_line":"        server \u003d self.servers.first()"},{"line_number":2903,"context_line":"        volume \u003d self.volumes.first()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_13d138fc","line":2900,"in_reply_to":"ff0f0b1f_6ae9b518","updated":"2017-05-19 13:03:27.000000000","message":"Hi Ying, This is something that is built into this entire test file from the way it was structured when first created. To start changing this would be a massive effort and probably needs to be a different patch.","commit_id":"e061657178fdab7cea933f3fa0b44ceedb535482"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"133a67079b539b4a3b9ecf37f4c8e36510e94c48","unresolved":false,"context_lines":[{"line_number":2982,"context_line":"        msg \u003d \"The flavor \u0026#39;%s\u0026#39; is too small\" % flavor.name"},{"line_number":2983,"context_line":"        self.assertContains(res, msg)"},{"line_number":2984,"context_line":""},{"line_number":2985,"context_line":"    def test_launch_form_instance_requirement_error_flavor(self):"},{"line_number":2986,"context_line":"        flavor \u003d self.flavors.first()"},{"line_number":2987,"context_line":"        image \u003d self.versioned_images.first()"},{"line_number":2988,"context_line":"        image.min_ram \u003d flavor.ram"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_4274bf99","line":2985,"range":{"start_line":2985,"start_character":9,"end_line":2985,"end_character":58},"updated":"2017-06-10 12:12:27.000000000","message":"The test name looks confusing. I wonder this is not an error case.\nram requirement is satisfied and the disk size check is disabled as flavor.disk is 0. This is NOT an requirement error.","commit_id":"81102b43eef5ab35e24ef675d761a715f141317e"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"591b2ab12a156fd6fddd854e085df0f258c7ee7a","unresolved":false,"context_lines":[{"line_number":2982,"context_line":"        msg \u003d \"The flavor \u0026#39;%s\u0026#39; is too small\" % flavor.name"},{"line_number":2983,"context_line":"        self.assertContains(res, msg)"},{"line_number":2984,"context_line":""},{"line_number":2985,"context_line":"    def test_launch_form_instance_requirement_error_flavor(self):"},{"line_number":2986,"context_line":"        flavor \u003d self.flavors.first()"},{"line_number":2987,"context_line":"        image \u003d self.versioned_images.first()"},{"line_number":2988,"context_line":"        image.min_ram \u003d flavor.ram"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_5a9259f8","line":2985,"range":{"start_line":2985,"start_character":9,"end_line":2985,"end_character":58},"in_reply_to":"7f231b9d_4274bf99","updated":"2017-06-12 07:07:04.000000000","message":"What name would you propose instead?","commit_id":"81102b43eef5ab35e24ef675d761a715f141317e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4c16b5186133e2d642045ddb48628295f22bc1ce","unresolved":false,"context_lines":[{"line_number":2982,"context_line":"        msg \u003d \"The flavor \u0026#39;%s\u0026#39; is too small\" % flavor.name"},{"line_number":2983,"context_line":"        self.assertContains(res, msg)"},{"line_number":2984,"context_line":""},{"line_number":2985,"context_line":"    def test_launch_form_instance_requirement_error_flavor(self):"},{"line_number":2986,"context_line":"        flavor \u003d self.flavors.first()"},{"line_number":2987,"context_line":"        image \u003d self.versioned_images.first()"},{"line_number":2988,"context_line":"        image.min_ram \u003d flavor.ram"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_afd005f9","line":2985,"range":{"start_line":2985,"start_character":9,"end_line":2985,"end_character":58},"in_reply_to":"7f231b9d_5a9259f8","updated":"2017-06-12 10:04:25.000000000","message":"What about \"test_launch_form_instance_zero_value_flavor_with_min_req\" or something like this? It is not an \"error\".","commit_id":"81102b43eef5ab35e24ef675d761a715f141317e"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"ae6ca96cc70fbf7998f7aa77bcbcef8822908b89","unresolved":false,"context_lines":[{"line_number":2982,"context_line":"        msg \u003d \"The flavor \u0026#39;%s\u0026#39; is too small\" % flavor.name"},{"line_number":2983,"context_line":"        self.assertContains(res, msg)"},{"line_number":2984,"context_line":""},{"line_number":2985,"context_line":"    def test_launch_form_instance_requirement_error_flavor(self):"},{"line_number":2986,"context_line":"        flavor \u003d self.flavors.first()"},{"line_number":2987,"context_line":"        image \u003d self.versioned_images.first()"},{"line_number":2988,"context_line":"        image.min_ram \u003d flavor.ram"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_61cc4189","line":2985,"range":{"start_line":2985,"start_character":9,"end_line":2985,"end_character":58},"in_reply_to":"7f231b9d_afd005f9","updated":"2017-06-12 10:39:51.000000000","message":"Works for me.","commit_id":"81102b43eef5ab35e24ef675d761a715f141317e"}]}
