)]}'
{"openstack_dashboard/api/neutron.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"b4052b2dd84d5c6797ec174f2d07f4508dd3022e","unresolved":false,"context_lines":[{"line_number":812,"context_line":"def trunk_create(request, **params):"},{"line_number":813,"context_line":"    LOG.debug(\"trunk_create(): params\u003d%s\", params)"},{"line_number":814,"context_line":"    if \u0027project_id\u0027 not in params:"},{"line_number":815,"context_line":"        params[\u0027project_id\u0027] \u003d request.user.project_id"},{"line_number":816,"context_line":"    body \u003d {\u0027trunk\u0027: params}"},{"line_number":817,"context_line":"    trunk \u003d neutronclient(request).create_trunk(body\u003dbody).get(\u0027trunk\u0027)"},{"line_number":818,"context_line":"    return Trunk(trunk)"}],"source_content_type":"text/x-python","patch_set":24,"id":"9f436f4f_e0bdf968","line":815,"updated":"2017-08-08 19:44:43.000000000","message":"curiosity: Why do we have to add the project_id explicitly?","commit_id":"9bcb68bfb665b8e9c63ef1ddc3223fa99aa4a430"}],"openstack_dashboard/static/app/core/openstack-service-api/neutron.service.js":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"b4052b2dd84d5c6797ec174f2d07f4508dd3022e","unresolved":false,"context_lines":[{"line_number":428,"context_line":"     */"},{"line_number":429,"context_line":"    function createTrunk(newTrunk) {"},{"line_number":430,"context_line":"      return apiService.post(\u0027/api/neutron/trunks/\u0027, newTrunk)"},{"line_number":431,"context_line":"        .error(function () {"},{"line_number":432,"context_line":"          toastService.add(\u0027error\u0027, gettext(\u0027Unable to create the trunk.\u0027));"},{"line_number":433,"context_line":"        });"},{"line_number":434,"context_line":"    }"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    /**"}],"source_content_type":"text/javascript","patch_set":24,"id":"9f436f4f_007d9db0","line":433,"range":{"start_line":431,"start_character":0,"end_line":433,"end_character":11},"updated":"2017-08-08 19:44:43.000000000","message":"Why do we keep the error toast here, but the success toast in create.action.service?","commit_id":"9bcb68bfb665b8e9c63ef1ddc3223fa99aa4a430"}],"openstack_dashboard/static/app/core/trunks/actions/create.action.service.js":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"3aa96995faf73c33917dfe63a50dd4e60a9180df","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        deregisterSubPortsFormWatcher();"},{"line_number":90,"context_line":"      }"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"      neutron.getPorts().then("},{"line_number":93,"context_line":"        function(response) {"},{"line_number":94,"context_line":"          var ports \u003d response.data.items;"},{"line_number":95,"context_line":"          $scope.allPorts \u003d ports;"},{"line_number":96,"context_line":"        }"},{"line_number":97,"context_line":"      );"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    function onFormInput(e, formContents) {"},{"line_number":101,"context_line":"      angular.extend(model.trunk, formContents);"}],"source_content_type":"text/javascript","patch_set":6,"id":"3f1d235d_a4ab7c73","line":98,"range":{"start_line":92,"start_character":0,"end_line":98,"end_character":5},"updated":"2017-07-10 15:15:09.000000000","message":"We should get the port list later, when the create button is pressed. Otherwise we may see a quite old port listing.","commit_id":"18051753015000279e2b6769970b6bef11154e18"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"9c42f71798fe090b6ffb72c159b5d864d38be430","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"      $scope.allPorts \u003d [];"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"      // FIXME(bence romsics): Here we query the ports too early, when the panel"},{"line_number":105,"context_line":"      // is loaded. It\u0027d be better if we queried the ports when the create modal"},{"line_number":106,"context_line":"      // is opened, ie. in perform() below. But if I move this code to perform()"},{"line_number":107,"context_line":"      // then transformtable sees the available table too early and fails. We"},{"line_number":108,"context_line":"      // should find a way to synchronize."},{"line_number":109,"context_line":"      neutron.getNetworks().then(getPorts, noop);"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"      function getPorts(networks) {"}],"source_content_type":"text/javascript","patch_set":15,"id":"1f1a1f67_0fd98120","line":108,"range":{"start_line":104,"start_character":0,"end_line":108,"end_character":42},"updated":"2017-07-19 09:39:27.000000000","message":"We could experiment with introducing a module on the level of the modal (launch instance has something similar). And then calling all the getPorts related stuff from there.","commit_id":"4d8f9378be1491df1d5c69cf251c83bc7b82a68d"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"9c42f71798fe090b6ffb72c159b5d864d38be430","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      // is opened, ie. in perform() below. But if I move this code to perform()"},{"line_number":107,"context_line":"      // then transformtable sees the available table too early and fails. We"},{"line_number":108,"context_line":"      // should find a way to synchronize."},{"line_number":109,"context_line":"      neutron.getNetworks().then(getPorts, noop);"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"      function getPorts(networks) {"},{"line_number":112,"context_line":"        networks.data.items.forEach(function(network) {"},{"line_number":113,"context_line":"          return neutron.getPorts({network_id: network.id}).then(function(ports) {"},{"line_number":114,"context_line":"            onGetPorts(ports, network);"},{"line_number":115,"context_line":"          }, noop);"},{"line_number":116,"context_line":"        });"},{"line_number":117,"context_line":"      }"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"      function onGetPorts(networkPorts, network) {"},{"line_number":120,"context_line":"        var ports \u003d [];"},{"line_number":121,"context_line":"        networkPorts.data.items.forEach(function(port) {"},{"line_number":122,"context_line":"          // no device_owner means that the port can be attached"},{"line_number":123,"context_line":"          if (port.device_owner \u003d\u003d\u003d \"\" \u0026\u0026 port.admin_state \u003d\u003d\u003d \"UP\") {"},{"line_number":124,"context_line":"            port.subnet_names \u003d getSubnetsForPort(port, network.subnets);"},{"line_number":125,"context_line":"            port.network_name \u003d network.name;"},{"line_number":126,"context_line":"            ports.push(port);"},{"line_number":127,"context_line":"          }"},{"line_number":128,"context_line":"        });"},{"line_number":129,"context_line":"        push.apply($scope.allPorts, ports);"},{"line_number":130,"context_line":"      }"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"      function getSubnetsForPort(port, subnets) {"},{"line_number":133,"context_line":"        var subnetNames \u003d {};"},{"line_number":134,"context_line":"        port.fixed_ips.forEach(function (ip) {"},{"line_number":135,"context_line":"          subnets.forEach(function (subnet) {"},{"line_number":136,"context_line":"            if (ip.subnet_id \u003d\u003d\u003d subnet.id) {"},{"line_number":137,"context_line":"              subnetNames[ip.ip_address] \u003d subnet.name;"},{"line_number":138,"context_line":"            }"},{"line_number":139,"context_line":"          });"},{"line_number":140,"context_line":"        });"},{"line_number":141,"context_line":"        return subnetNames;"},{"line_number":142,"context_line":"      }"},{"line_number":143,"context_line":"    }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    function onFormInput(e, formContents) {"},{"line_number":146,"context_line":"      angular.extend(model.trunk, formContents);"}],"source_content_type":"text/javascript","patch_set":15,"id":"1f1a1f67_4fce5963","line":143,"range":{"start_line":109,"start_character":0,"end_line":143,"end_character":5},"updated":"2017-07-19 09:39:27.000000000","message":"To avoid duplication we could put this into its own service.","commit_id":"4d8f9378be1491df1d5c69cf251c83bc7b82a68d"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"b4052b2dd84d5c6797ec174f2d07f4508dd3022e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    function perform() {"},{"line_number":129,"context_line":"      trunk \u003d {};"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"      // NOTE(bence romsics): This seems to be good enough but it is still"},{"line_number":132,"context_line":"      // suboptimal from a UX perspective. We delay opening the modal until"},{"line_number":133,"context_line":"      // neutron objects are loaded. But ideally the steps independent of"},{"line_number":134,"context_line":"      // already existing neutron objects (ie. the trunk details step) could"},{"line_number":135,"context_line":"      // already work while loading neutron stuff in the background."}],"source_content_type":"text/javascript","patch_set":24,"id":"9f436f4f_602469c7","line":132,"range":{"start_line":131,"start_character":30,"end_line":132,"end_character":42},"updated":"2017-08-08 19:44:43.000000000","message":"Could just say: Suboptimal UX.","commit_id":"9bcb68bfb665b8e9c63ef1ddc3223fa99aa4a430"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"36ba7e2bddb7ba2637b6dfae696f7d38a8706ce3","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    function perform() {"},{"line_number":129,"context_line":"      trunk \u003d {};"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"      // NOTE(bence romsics): This seems to be good enough but it is still"},{"line_number":132,"context_line":"      // suboptimal from a UX perspective. We delay opening the modal until"},{"line_number":133,"context_line":"      // neutron objects are loaded. But ideally the steps independent of"},{"line_number":134,"context_line":"      // already existing neutron objects (ie. the trunk details step) could"},{"line_number":135,"context_line":"      // already work while loading neutron stuff in the background."}],"source_content_type":"text/javascript","patch_set":24,"id":"9f436f4f_a8afc692","line":132,"range":{"start_line":131,"start_character":30,"end_line":132,"end_character":42},"in_reply_to":"9f436f4f_602469c7","updated":"2017-08-09 14:49:49.000000000","message":"Done","commit_id":"9bcb68bfb665b8e9c63ef1ddc3223fa99aa4a430"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"b4052b2dd84d5c6797ec174f2d07f4508dd3022e","unresolved":false,"context_lines":[{"line_number":157,"context_line":"          submit: submit,"},{"line_number":158,"context_line":"          data: {"},{"line_number":159,"context_line":"            ports: {"},{"line_number":160,"context_line":"              // TODO sort candidate ports"},{"line_number":161,"context_line":"              parentPortCandidates: params.parentPortCandidates,"},{"line_number":162,"context_line":"              subportCandidates: params.subportCandidates,"},{"line_number":163,"context_line":"              subportsOfInitTrunk: []"}],"source_content_type":"text/javascript","patch_set":24,"id":"9f436f4f_400a8526","line":160,"updated":"2017-08-08 19:44:43.000000000","message":"by (port name, port id)","commit_id":"9bcb68bfb665b8e9c63ef1ddc3223fa99aa4a430"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"36ba7e2bddb7ba2637b6dfae696f7d38a8706ce3","unresolved":false,"context_lines":[{"line_number":157,"context_line":"          submit: submit,"},{"line_number":158,"context_line":"          data: {"},{"line_number":159,"context_line":"            ports: {"},{"line_number":160,"context_line":"              // TODO sort candidate ports"},{"line_number":161,"context_line":"              parentPortCandidates: params.parentPortCandidates,"},{"line_number":162,"context_line":"              subportCandidates: params.subportCandidates,"},{"line_number":163,"context_line":"              subportsOfInitTrunk: []"}],"source_content_type":"text/javascript","patch_set":24,"id":"9f436f4f_e303ac41","line":160,"in_reply_to":"9f436f4f_400a8526","updated":"2017-08-09 14:49:49.000000000","message":"Done","commit_id":"9bcb68bfb665b8e9c63ef1ddc3223fa99aa4a430"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"0abaeb5c6c315d5e7857bf69eb74fb3eb80cb972","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    ////////////"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    function initAction() {"},{"line_number":67,"context_line":"      createTrunkPromise \u003d policy.ifAllowed("},{"line_number":68,"context_line":"        {rules: ["},{"line_number":69,"context_line":"          [\u0027trunk\u0027, \u0027create_trunk\u0027]"},{"line_number":70,"context_line":"        ]}"}],"source_content_type":"text/javascript","patch_set":29,"id":"9f436f4f_6f3591a8","line":67,"range":{"start_line":67,"start_character":27,"end_line":67,"end_character":43},"updated":"2017-08-17 12:26:04.000000000","message":"I don\u0027t think we need to recheck the policy in every initAction(). The result can\u0027t change between initAction()s. It\u0027s enough to have this in allowed().","commit_id":"a314ae2e585d86373b33cf1c131b0c13c4d4f583"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"62c9094d2994965e4f87e606bd2c6c281054239a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    ////////////"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    function initAction() {"},{"line_number":67,"context_line":"      createTrunkPromise \u003d policy.ifAllowed("},{"line_number":68,"context_line":"        {rules: ["},{"line_number":69,"context_line":"          [\u0027trunk\u0027, \u0027create_trunk\u0027]"},{"line_number":70,"context_line":"        ]}"}],"source_content_type":"text/javascript","patch_set":29,"id":"9f436f4f_036b7e1f","line":67,"range":{"start_line":67,"start_character":27,"end_line":67,"end_character":43},"in_reply_to":"9f436f4f_6f3591a8","updated":"2017-08-17 14:57:12.000000000","message":"Done","commit_id":"a314ae2e585d86373b33cf1c131b0c13c4d4f583"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"0abaeb5c6c315d5e7857bf69eb74fb3eb80cb972","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    function initAction() {"},{"line_number":67,"context_line":"      createTrunkPromise \u003d policy.ifAllowed("},{"line_number":68,"context_line":"        {rules: ["},{"line_number":69,"context_line":"          [\u0027trunk\u0027, \u0027create_trunk\u0027]"},{"line_number":70,"context_line":"        ]}"},{"line_number":71,"context_line":"      );"},{"line_number":72,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":29,"id":"9f436f4f_af1a596c","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":17},"updated":"2017-08-17 12:26:04.000000000","message":"Should be \u0027network\u0027.","commit_id":"a314ae2e585d86373b33cf1c131b0c13c4d4f583"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"62c9094d2994965e4f87e606bd2c6c281054239a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    function initAction() {"},{"line_number":67,"context_line":"      createTrunkPromise \u003d policy.ifAllowed("},{"line_number":68,"context_line":"        {rules: ["},{"line_number":69,"context_line":"          [\u0027trunk\u0027, \u0027create_trunk\u0027]"},{"line_number":70,"context_line":"        ]}"},{"line_number":71,"context_line":"      );"},{"line_number":72,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":29,"id":"9f436f4f_e3675a51","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":17},"in_reply_to":"9f436f4f_af1a596c","updated":"2017-08-17 14:57:12.000000000","message":"Done","commit_id":"a314ae2e585d86373b33cf1c131b0c13c4d4f583"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"318f83218c8b8aad035a4ad9984a3e7031ab038c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"              name: \u0027\u0027,"},{"line_number":123,"context_line":"              port_id: undefined,"},{"line_number":124,"context_line":"              sub_ports: []"},{"line_number":125,"context_line":"            },"},{"line_number":126,"context_line":"            ports: {"},{"line_number":127,"context_line":"              parentPortCandidates: params.parentPortCandidates.sort("},{"line_number":128,"context_line":"                portsExtra.cmpPortsByNameAndId),"}],"source_content_type":"text/javascript","patch_set":41,"id":"ff82abbf_c817c3ed","line":125,"updated":"2017-11-20 05:21:22.000000000","message":"Looks like the only actual initial data should be set in this dict is admin_state_up. The rest of the fields should be handled as the default values.","commit_id":"c42f620d9829be4e96e0841f5fd981ff62c665e7"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"746f9210115afe9f577417bd85afe4e3e87488cd","unresolved":false,"context_lines":[{"line_number":122,"context_line":"              name: \u0027\u0027,"},{"line_number":123,"context_line":"              port_id: undefined,"},{"line_number":124,"context_line":"              sub_ports: []"},{"line_number":125,"context_line":"            },"},{"line_number":126,"context_line":"            ports: {"},{"line_number":127,"context_line":"              parentPortCandidates: params.parentPortCandidates.sort("},{"line_number":128,"context_line":"                portsExtra.cmpPortsByNameAndId),"}],"source_content_type":"text/javascript","patch_set":41,"id":"ff82abbf_5db433d1","line":125,"in_reply_to":"ff82abbf_c817c3ed","updated":"2017-11-27 13:11:03.000000000","message":"I\u0027m not sure. These fields have defaults in the API. But this is here to initialize the input form. Shall we have defaults in the input form too? That sounds strange.","commit_id":"c42f620d9829be4e96e0841f5fd981ff62c665e7"}],"openstack_dashboard/static/app/core/trunks/actions/create.action.service.spec.js":[{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"3cad4a58fc7386a6ad538b72d9c5af5d3df91eb3","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    it(\u0027open the modal with the correct parameters\u0027, function() {"},{"line_number":100,"context_line":"      spyOn(wizardModalService, \u0027modal\u0027).and.callThrough();"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"      service.initScope($scope);"},{"line_number":103,"context_line":"      service.perform();"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"      $scope.$digest();"}],"source_content_type":"text/javascript","patch_set":30,"id":"7f287b81_f9075981","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":32},"updated":"2017-08-29 08:41:55.000000000","message":"unnecessary","commit_id":"f1f31eab6240b13ce50ad72444fdbd06c8ff1e2d"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"c98cbfe76d74dbf89532de6c7c22b19a2c321e91","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    it(\u0027open the modal with the correct parameters\u0027, function() {"},{"line_number":100,"context_line":"      spyOn(wizardModalService, \u0027modal\u0027).and.callThrough();"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"      service.initScope($scope);"},{"line_number":103,"context_line":"      service.perform();"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"      $scope.$digest();"}],"source_content_type":"text/javascript","patch_set":30,"id":"7f287b81_01372301","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":32},"in_reply_to":"7f287b81_f9075981","updated":"2017-08-30 13:08:11.000000000","message":"Done","commit_id":"f1f31eab6240b13ce50ad72444fdbd06c8ff1e2d"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"3cad4a58fc7386a6ad538b72d9c5af5d3df91eb3","unresolved":false,"context_lines":[{"line_number":116,"context_line":"      spyOn(neutronAPI, \u0027createTrunk\u0027).and.callThrough();"},{"line_number":117,"context_line":"      spyOn(wizardModalService, \u0027modal\u0027).and.callThrough();"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"      service.initScope($scope);"},{"line_number":120,"context_line":"      service.perform();"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"      $scope.$digest();"}],"source_content_type":"text/javascript","patch_set":30,"id":"7f287b81_d90c9da6","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":32},"updated":"2017-08-29 08:41:55.000000000","message":"ditto","commit_id":"f1f31eab6240b13ce50ad72444fdbd06c8ff1e2d"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"c98cbfe76d74dbf89532de6c7c22b19a2c321e91","unresolved":false,"context_lines":[{"line_number":116,"context_line":"      spyOn(neutronAPI, \u0027createTrunk\u0027).and.callThrough();"},{"line_number":117,"context_line":"      spyOn(wizardModalService, \u0027modal\u0027).and.callThrough();"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"      service.initScope($scope);"},{"line_number":120,"context_line":"      service.perform();"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"      $scope.$digest();"}],"source_content_type":"text/javascript","patch_set":30,"id":"7f287b81_e139b7f1","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":32},"in_reply_to":"7f287b81_d90c9da6","updated":"2017-08-30 13:08:11.000000000","message":"Done","commit_id":"f1f31eab6240b13ce50ad72444fdbd06c8ff1e2d"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"3cad4a58fc7386a6ad538b72d9c5af5d3df91eb3","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    it(\u0027should turn the hide parent message around\u0027, function() {"},{"line_number":154,"context_line":"      spyOn($scope, \u0027$broadcast\u0027);"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"      service.initScope($scope);"},{"line_number":157,"context_line":"      service.perform();"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"      var payload \u003d {\u0027port-a\u0027: true};"}],"source_content_type":"text/javascript","patch_set":30,"id":"7f287b81_9902956e","line":156,"range":{"start_line":156,"start_character":0,"end_line":156,"end_character":32},"updated":"2017-08-29 08:41:55.000000000","message":"ditto","commit_id":"f1f31eab6240b13ce50ad72444fdbd06c8ff1e2d"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"c98cbfe76d74dbf89532de6c7c22b19a2c321e91","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    it(\u0027should turn the hide parent message around\u0027, function() {"},{"line_number":154,"context_line":"      spyOn($scope, \u0027$broadcast\u0027);"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"      service.initScope($scope);"},{"line_number":157,"context_line":"      service.perform();"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"      var payload \u003d {\u0027port-a\u0027: true};"}],"source_content_type":"text/javascript","patch_set":30,"id":"7f287b81_a1272fca","line":156,"range":{"start_line":156,"start_character":0,"end_line":156,"end_character":32},"in_reply_to":"7f287b81_9902956e","updated":"2017-08-30 13:08:11.000000000","message":"Done","commit_id":"f1f31eab6240b13ce50ad72444fdbd06c8ff1e2d"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"3cad4a58fc7386a6ad538b72d9c5af5d3df91eb3","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    it(\u0027should turn the hide subports message around\u0027, function() {"},{"line_number":172,"context_line":"      spyOn($scope, \u0027$broadcast\u0027);"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"      service.initScope($scope);"},{"line_number":175,"context_line":"      service.perform();"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"      var payload \u003d {\u0027port-a\u0027: true};"}],"source_content_type":"text/javascript","patch_set":30,"id":"7f287b81_79fb6978","line":174,"range":{"start_line":174,"start_character":0,"end_line":174,"end_character":32},"updated":"2017-08-29 08:41:55.000000000","message":"ditto","commit_id":"f1f31eab6240b13ce50ad72444fdbd06c8ff1e2d"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"c98cbfe76d74dbf89532de6c7c22b19a2c321e91","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    it(\u0027should turn the hide subports message around\u0027, function() {"},{"line_number":172,"context_line":"      spyOn($scope, \u0027$broadcast\u0027);"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"      service.initScope($scope);"},{"line_number":175,"context_line":"      service.perform();"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"      var payload \u003d {\u0027port-a\u0027: true};"}],"source_content_type":"text/javascript","patch_set":30,"id":"7f287b81_8122f3b7","line":174,"range":{"start_line":174,"start_character":0,"end_line":174,"end_character":32},"in_reply_to":"7f287b81_79fb6978","updated":"2017-08-30 13:08:11.000000000","message":"Done","commit_id":"f1f31eab6240b13ce50ad72444fdbd06c8ff1e2d"}],"openstack_dashboard/static/app/core/trunks/actions/get-available-ports.service.js":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"3afedb6f6bb2546d795cd52f3408a8397b5c8241","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  /**"},{"line_number":36,"context_line":"   * @ngdoc factory"},{"line_number":37,"context_line":"   * @name horizon.app.core.trunks.actions.load-ports.service"},{"line_number":38,"context_line":"   * @Description Load all neutron ports of the current project that are"},{"line_number":39,"context_line":"   * available for use (ie. they are not owned and their admin state is up)."},{"line_number":40,"context_line":"   * Also merge network and subnet info into the port list."}],"source_content_type":"text/javascript","patch_set":22,"id":"df3967d1_c3001b04","line":37,"range":{"start_line":37,"start_character":11,"end_line":37,"end_character":61},"updated":"2017-08-04 08:58:22.000000000","message":"Outdated, should be fixed.","commit_id":"e7fc5e0c7ee84f36f443d7fa1fc15ddc355ea503"}],"openstack_dashboard/static/app/core/trunks/actions/ports-extra.service.js":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"ca30dbb9b88bcf9c4959bae737e2019291758b6a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        // so here we cannot filter on device_owner being unset. However the ovs"},{"line_number":61,"context_line":"        // driver is going to throw errors if the user tries to trunk a port"},{"line_number":62,"context_line":"        // already booted."},{"line_number":63,"context_line":"        (port.device_owner \u003d\u003d\u003d \u0027\u0027 || port.device_owner \u003d\u003d\u003d \u0027compute:nova\u0027) \u0026\u0026"},{"line_number":64,"context_line":"        // port is not a trunk parent already"},{"line_number":65,"context_line":"        !port.hasOwnProperty(\u0027trunk_details\u0027) \u0026\u0026"},{"line_number":66,"context_line":"        // port is not a trunk subport already"}],"source_content_type":"text/javascript","patch_set":24,"id":"9f436f4f_0a7daab0","line":63,"range":{"start_line":63,"start_character":60,"end_line":63,"end_character":72},"updated":"2017-08-09 08:06:35.000000000","message":"This is too much. We should only check for device_owner starting with \u0027compute:\u0027 but not for the name of an availability zone following.","commit_id":"9bcb68bfb665b8e9c63ef1ddc3223fa99aa4a430"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"36ba7e2bddb7ba2637b6dfae696f7d38a8706ce3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        // so here we cannot filter on device_owner being unset. However the ovs"},{"line_number":61,"context_line":"        // driver is going to throw errors if the user tries to trunk a port"},{"line_number":62,"context_line":"        // already booted."},{"line_number":63,"context_line":"        (port.device_owner \u003d\u003d\u003d \u0027\u0027 || port.device_owner \u003d\u003d\u003d \u0027compute:nova\u0027) \u0026\u0026"},{"line_number":64,"context_line":"        // port is not a trunk parent already"},{"line_number":65,"context_line":"        !port.hasOwnProperty(\u0027trunk_details\u0027) \u0026\u0026"},{"line_number":66,"context_line":"        // port is not a trunk subport already"}],"source_content_type":"text/javascript","patch_set":24,"id":"9f436f4f_48c97a76","line":63,"range":{"start_line":63,"start_character":60,"end_line":63,"end_character":72},"in_reply_to":"9f436f4f_0a7daab0","updated":"2017-08-09 14:49:49.000000000","message":"Done","commit_id":"9bcb68bfb665b8e9c63ef1ddc3223fa99aa4a430"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"b4052b2dd84d5c6797ec174f2d07f4508dd3022e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        // ports in the device_owner filter and when the router iface port\u0027s"},{"line_number":104,"context_line":"        // network is owned by project demo"},{"line_number":105,"context_line":"        if (angular.isDefined(network)) {"},{"line_number":106,"context_line":"          port.network_name \u003d network.name;"},{"line_number":107,"context_line":"          port.subnet_names \u003d getSubnetsForPort(port, network.subnets);"},{"line_number":108,"context_line":"        }"},{"line_number":109,"context_line":"      });"},{"line_number":110,"context_line":""}],"source_content_type":"text/javascript","patch_set":24,"id":"9f436f4f_c32c3f9b","line":107,"range":{"start_line":106,"start_character":0,"end_line":107,"end_character":71},"updated":"2017-08-08 19:44:43.000000000","message":"better avoid modifying the ports passed in","commit_id":"9bcb68bfb665b8e9c63ef1ddc3223fa99aa4a430"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"36ba7e2bddb7ba2637b6dfae696f7d38a8706ce3","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        // ports in the device_owner filter and when the router iface port\u0027s"},{"line_number":104,"context_line":"        // network is owned by project demo"},{"line_number":105,"context_line":"        if (angular.isDefined(network)) {"},{"line_number":106,"context_line":"          port.network_name \u003d network.name;"},{"line_number":107,"context_line":"          port.subnet_names \u003d getSubnetsForPort(port, network.subnets);"},{"line_number":108,"context_line":"        }"},{"line_number":109,"context_line":"      });"},{"line_number":110,"context_line":""}],"source_content_type":"text/javascript","patch_set":24,"id":"9f436f4f_bd5ca14b","line":107,"range":{"start_line":106,"start_character":0,"end_line":107,"end_character":71},"in_reply_to":"9f436f4f_c32c3f9b","updated":"2017-08-09 14:49:49.000000000","message":"Done","commit_id":"9bcb68bfb665b8e9c63ef1ddc3223fa99aa4a430"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"822926b991a0cebce6f9456f1071ec63593a7f59","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    var service \u003d {"},{"line_number":34,"context_line":"      addNetworkAndSubnetInfo: addNetworkAndSubnetInfo,"},{"line_number":35,"context_line":"      cmpPortsByNameAndId: cmpPortsByNameAndId,"},{"line_number":36,"context_line":"      cmpSubportsBySegmentationTypeAndId: cmpSubportsBySegmentationTypeAndId,"},{"line_number":37,"context_line":"      isParentPortCandidate: isParentPortCandidate,"},{"line_number":38,"context_line":"      isSubportCandidate: isSubportCandidate,"},{"line_number":39,"context_line":"      isSubportOfTrunk: isSubportOfTrunk"}],"source_content_type":"text/javascript","patch_set":35,"id":"3f4b6375_3521da4e","line":36,"range":{"start_line":36,"start_character":42,"end_line":36,"end_character":76},"updated":"2017-10-31 07:53:01.000000000","message":"undefined. is this needed?","commit_id":"85dc11e394563ff2195c8965e7e918d74ba2bdf6"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"907ef1fdcd7c25012aa59e0e752b9e02c4523be5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    var service \u003d {"},{"line_number":34,"context_line":"      addNetworkAndSubnetInfo: addNetworkAndSubnetInfo,"},{"line_number":35,"context_line":"      cmpPortsByNameAndId: cmpPortsByNameAndId,"},{"line_number":36,"context_line":"      cmpSubportsBySegmentationTypeAndId: cmpSubportsBySegmentationTypeAndId,"},{"line_number":37,"context_line":"      isParentPortCandidate: isParentPortCandidate,"},{"line_number":38,"context_line":"      isSubportCandidate: isSubportCandidate,"},{"line_number":39,"context_line":"      isSubportOfTrunk: isSubportOfTrunk"}],"source_content_type":"text/javascript","patch_set":35,"id":"3f4b6375_467dce1a","line":36,"range":{"start_line":36,"start_character":42,"end_line":36,"end_character":76},"in_reply_to":"3f4b6375_3521da4e","updated":"2017-10-31 10:01:18.000000000","message":"I\u0027m going to move this line to the edit-button change in the next patch set. That\u0027s where this function is used and where its definition is. Thanks for catching this.","commit_id":"85dc11e394563ff2195c8965e7e918d74ba2bdf6"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"728be7b4bd458c33f10537d34896b68f5f0b64b1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    var service \u003d {"},{"line_number":34,"context_line":"      addNetworkAndSubnetInfo: addNetworkAndSubnetInfo,"},{"line_number":35,"context_line":"      cmpPortsByNameAndId: cmpPortsByNameAndId,"},{"line_number":36,"context_line":"      cmpSubportsBySegmentationTypeAndId: cmpSubportsBySegmentationTypeAndId,"},{"line_number":37,"context_line":"      isParentPortCandidate: isParentPortCandidate,"},{"line_number":38,"context_line":"      isSubportCandidate: isSubportCandidate,"},{"line_number":39,"context_line":"      isSubportOfTrunk: isSubportOfTrunk"}],"source_content_type":"text/javascript","patch_set":35,"id":"3f4b6375_87b4ddd2","line":36,"range":{"start_line":36,"start_character":42,"end_line":36,"end_character":76},"in_reply_to":"3f4b6375_467dce1a","updated":"2017-10-31 13:45:30.000000000","message":"Done","commit_id":"85dc11e394563ff2195c8965e7e918d74ba2bdf6"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"318f83218c8b8aad035a4ad9984a3e7031ab038c","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    function isParentPortCandidate(port) {"},{"line_number":46,"context_line":"      return ("},{"line_number":47,"context_line":"        port.admin_state \u003d\u003d\u003d \u0027UP\u0027 \u0026\u0026"},{"line_number":48,"context_line":"        // NOTE(bence romsics): A port already booted on may or may not be used"},{"line_number":49,"context_line":"        // as the parent port of a trunk depending on the neutron driver. But"},{"line_number":50,"context_line":"        // we do not (and should not) know anything about neutron driver config"}],"source_content_type":"text/javascript","patch_set":41,"id":"ff82abbf_c8a82379","line":47,"updated":"2017-11-20 05:21:22.000000000","message":"The field name should be admin_state_up according to the CLI.","commit_id":"c42f620d9829be4e96e0841f5fd981ff62c665e7"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"746f9210115afe9f577417bd85afe4e3e87488cd","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    function isParentPortCandidate(port) {"},{"line_number":46,"context_line":"      return ("},{"line_number":47,"context_line":"        port.admin_state \u003d\u003d\u003d \u0027UP\u0027 \u0026\u0026"},{"line_number":48,"context_line":"        // NOTE(bence romsics): A port already booted on may or may not be used"},{"line_number":49,"context_line":"        // as the parent port of a trunk depending on the neutron driver. But"},{"line_number":50,"context_line":"        // we do not (and should not) know anything about neutron driver config"}],"source_content_type":"text/javascript","patch_set":41,"id":"ff82abbf_97685a1d","line":47,"in_reply_to":"ff82abbf_b0ef3a86","updated":"2017-11-27 13:11:03.000000000","message":"Done","commit_id":"c42f620d9829be4e96e0841f5fd981ff62c665e7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b7206e9f7d19aa3e26ced4615eb02fcfbc8b84c","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    function isParentPortCandidate(port) {"},{"line_number":46,"context_line":"      return ("},{"line_number":47,"context_line":"        port.admin_state \u003d\u003d\u003d \u0027UP\u0027 \u0026\u0026"},{"line_number":48,"context_line":"        // NOTE(bence romsics): A port already booted on may or may not be used"},{"line_number":49,"context_line":"        // as the parent port of a trunk depending on the neutron driver. But"},{"line_number":50,"context_line":"        // we do not (and should not) know anything about neutron driver config"}],"source_content_type":"text/javascript","patch_set":41,"id":"ff82abbf_b0ef3a86","line":47,"in_reply_to":"ff82abbf_c8a82379","updated":"2017-11-20 15:41:34.000000000","message":"+1 to use admin_state_up as data source.\n\nadmin_state field is defined in openstack_dashboard/api/neutron.py, but it is mainly to prepare visible data (UP/DOWN) (which I think is a bad convention to be clean up)","commit_id":"c42f620d9829be4e96e0841f5fd981ff62c665e7"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"318f83218c8b8aad035a4ad9984a3e7031ab038c","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    function isSubportCandidate(port) {"},{"line_number":64,"context_line":"      return ("},{"line_number":65,"context_line":"        port.admin_state \u003d\u003d\u003d \u0027UP\u0027 \u0026\u0026"},{"line_number":66,"context_line":"        // port already booted on must never be a subport"},{"line_number":67,"context_line":"        port.device_owner \u003d\u003d\u003d \u0027\u0027 \u0026\u0026"},{"line_number":68,"context_line":"        // port is not a trunk parent already"}],"source_content_type":"text/javascript","patch_set":41,"id":"ff82abbf_68b797da","line":65,"updated":"2017-11-20 05:21:22.000000000","message":"The field name should be admin_state_up according to the CLI.","commit_id":"c42f620d9829be4e96e0841f5fd981ff62c665e7"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"746f9210115afe9f577417bd85afe4e3e87488cd","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    function isSubportCandidate(port) {"},{"line_number":64,"context_line":"      return ("},{"line_number":65,"context_line":"        port.admin_state \u003d\u003d\u003d \u0027UP\u0027 \u0026\u0026"},{"line_number":66,"context_line":"        // port already booted on must never be a subport"},{"line_number":67,"context_line":"        port.device_owner \u003d\u003d\u003d \u0027\u0027 \u0026\u0026"},{"line_number":68,"context_line":"        // port is not a trunk parent already"}],"source_content_type":"text/javascript","patch_set":41,"id":"ff82abbf_37594e8d","line":65,"in_reply_to":"ff82abbf_68b797da","updated":"2017-11-27 13:11:03.000000000","message":"Done","commit_id":"c42f620d9829be4e96e0841f5fd981ff62c665e7"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"318f83218c8b8aad035a4ad9984a3e7031ab038c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        // port is not a trunk parent already"},{"line_number":69,"context_line":"        !port.hasOwnProperty(\u0027trunk_details\u0027) \u0026\u0026"},{"line_number":70,"context_line":"        // port is not a trunk subport already"},{"line_number":71,"context_line":"        !port.hasOwnProperty(\u0027trunk_id\u0027)"},{"line_number":72,"context_line":"      );"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""}],"source_content_type":"text/javascript","patch_set":41,"id":"ff82abbf_28ff4f68","line":71,"updated":"2017-11-20 05:21:22.000000000","message":"I think you just need \"!port.trunk_details \u0026\u0026 !port.trunk_id\" for line 57, 59, 69, and 71.","commit_id":"c42f620d9829be4e96e0841f5fd981ff62c665e7"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"746f9210115afe9f577417bd85afe4e3e87488cd","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        // port is not a trunk parent already"},{"line_number":69,"context_line":"        !port.hasOwnProperty(\u0027trunk_details\u0027) \u0026\u0026"},{"line_number":70,"context_line":"        // port is not a trunk subport already"},{"line_number":71,"context_line":"        !port.hasOwnProperty(\u0027trunk_id\u0027)"},{"line_number":72,"context_line":"      );"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""}],"source_content_type":"text/javascript","patch_set":41,"id":"ff82abbf_17d9aaf1","line":71,"in_reply_to":"ff82abbf_28ff4f68","updated":"2017-11-27 13:11:03.000000000","message":"Done","commit_id":"c42f620d9829be4e96e0841f5fd981ff62c665e7"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"318f83218c8b8aad035a4ad9984a3e7031ab038c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    function isSubportOfTrunk(trunkId, port) {"},{"line_number":76,"context_line":"      return ("},{"line_number":77,"context_line":"        // port is a trunk subport..."},{"line_number":78,"context_line":"        port.hasOwnProperty(\u0027trunk_id\u0027) \u0026\u0026"},{"line_number":79,"context_line":"        // ...of this trunk"},{"line_number":80,"context_line":"        port.trunk_id \u003d\u003d\u003d trunkId"},{"line_number":81,"context_line":"      );"}],"source_content_type":"text/javascript","patch_set":41,"id":"ff82abbf_a8d91f23","line":78,"updated":"2017-11-20 05:21:22.000000000","message":"port.trunk_id","commit_id":"c42f620d9829be4e96e0841f5fd981ff62c665e7"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"746f9210115afe9f577417bd85afe4e3e87488cd","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    function isSubportOfTrunk(trunkId, port) {"},{"line_number":76,"context_line":"      return ("},{"line_number":77,"context_line":"        // port is a trunk subport..."},{"line_number":78,"context_line":"        port.hasOwnProperty(\u0027trunk_id\u0027) \u0026\u0026"},{"line_number":79,"context_line":"        // ...of this trunk"},{"line_number":80,"context_line":"        port.trunk_id \u003d\u003d\u003d trunkId"},{"line_number":81,"context_line":"      );"}],"source_content_type":"text/javascript","patch_set":41,"id":"ff82abbf_b7e1de9d","line":78,"in_reply_to":"ff82abbf_a8d91f23","updated":"2017-11-27 13:11:03.000000000","message":"Done","commit_id":"c42f620d9829be4e96e0841f5fd981ff62c665e7"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"318f83218c8b8aad035a4ad9984a3e7031ab038c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    function cmpPortsByNameAndId(a, b) {"},{"line_number":85,"context_line":"      return ("},{"line_number":86,"context_line":"        // primary key: ports with a name sort earlier than ports without"},{"line_number":87,"context_line":"        (a.name \u003d\u003d\u003d \u0027\u0027) - (b.name \u003d\u003d\u003d \u0027\u0027) ||"},{"line_number":88,"context_line":"        // secondary key: name"},{"line_number":89,"context_line":"        a.name.localeCompare(b.name) ||"},{"line_number":90,"context_line":"        // tertiary key: id"}],"source_content_type":"text/javascript","patch_set":41,"id":"ff82abbf_e8cf2755","line":87,"updated":"2017-11-20 05:21:22.000000000","message":"what does this do?","commit_id":"c42f620d9829be4e96e0841f5fd981ff62c665e7"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"746f9210115afe9f577417bd85afe4e3e87488cd","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    function cmpPortsByNameAndId(a, b) {"},{"line_number":85,"context_line":"      return ("},{"line_number":86,"context_line":"        // primary key: ports with a name sort earlier than ports without"},{"line_number":87,"context_line":"        (a.name \u003d\u003d\u003d \u0027\u0027) - (b.name \u003d\u003d\u003d \u0027\u0027) ||"},{"line_number":88,"context_line":"        // secondary key: name"},{"line_number":89,"context_line":"        a.name.localeCompare(b.name) ||"},{"line_number":90,"context_line":"        // tertiary key: id"}],"source_content_type":"text/javascript","patch_set":41,"id":"ff82abbf_379cee0c","line":87,"in_reply_to":"ff82abbf_e8cf2755","updated":"2017-11-27 13:11:03.000000000","message":"It sorts a port with a name earlier than a port with no name. The idea was that the user likely named the ports to be used here, so named ports should be up front.","commit_id":"c42f620d9829be4e96e0841f5fd981ff62c665e7"}],"openstack_dashboard/static/app/core/trunks/steps/trunk-details.help.html":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a40d84c7a6e56cbc5023ae140b80961e8651fab6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdl\u003e"},{"line_number":2,"context_line":"  \u003cdt translate\u003eName\u003c/dt\u003e"},{"line_number":3,"context_line":"  \u003cdd translate\u003e"},{"line_number":4,"context_line":"  \u003cp\u003eAn arbitrary name for the trunk. May not be unique.\u003c/p\u003e"},{"line_number":5,"context_line":"  \u003cp\u003eDefault: Empty string\u003c/p\u003e"},{"line_number":6,"context_line":"  \u003c/dd\u003e"},{"line_number":7,"context_line":"  \u003cdt translate\u003eDescription\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":16,"id":"1f1a1f67_aa7b89f2","line":4,"range":{"start_line":4,"start_character":2,"end_line":4,"end_character":60},"updated":"2017-07-19 18:48:40.000000000","message":"Could you specify \"translate\" for \u003cp\u003e? It allows translators not to handle HTML tags.","commit_id":"fd7d396ac9142a05f7647aed9153d141d5dde54c"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"0980bc04b4cc4ff49bc438c70af6760027bf4731","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdl\u003e"},{"line_number":2,"context_line":"  \u003cdt translate\u003eName\u003c/dt\u003e"},{"line_number":3,"context_line":"  \u003cdd translate\u003e"},{"line_number":4,"context_line":"  \u003cp\u003eAn arbitrary name for the trunk. May not be unique.\u003c/p\u003e"},{"line_number":5,"context_line":"  \u003cp\u003eDefault: Empty string\u003c/p\u003e"},{"line_number":6,"context_line":"  \u003c/dd\u003e"},{"line_number":7,"context_line":"  \u003cdt translate\u003eDescription\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":16,"id":"1f1a1f67_dc579c26","line":4,"range":{"start_line":4,"start_character":2,"end_line":4,"end_character":60},"in_reply_to":"1f1a1f67_aa7b89f2","updated":"2017-07-20 10:27:23.000000000","message":"Done","commit_id":"fd7d396ac9142a05f7647aed9153d141d5dde54c"}],"openstack_dashboard/static/app/core/trunks/steps/trunk-parent-port.controller.js":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"da92c946be5dbceede2d776233a8afcf253b29ac","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  TrunkParentPortController.$inject \u003d ["},{"line_number":34,"context_line":"    \u0027$scope\u0027,"},{"line_number":35,"context_line":"    \u0027horizon.app.core.openstack-service-api.neutron\u0027,"},{"line_number":36,"context_line":"    \u0027horizon.framework.widgets.action-list.button-tooltip.row-warning.service\u0027,"},{"line_number":37,"context_line":"    \u0027horizon.framework.widgets.transfer-table.events\u0027"},{"line_number":38,"context_line":"  ];"}],"source_content_type":"text/javascript","patch_set":26,"id":"9f436f4f_25df2ad7","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":52},"updated":"2017-08-11 18:41:15.000000000","message":"unused","commit_id":"1a84c0b5ef6966c4a44e03113b59bbd9ec3c2ed7"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"da92c946be5dbceede2d776233a8afcf253b29ac","unresolved":false,"context_lines":[{"line_number":115,"context_line":"      });"},{"line_number":116,"context_line":"    }"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    function hideAllocated(newValue, oldValue) {"},{"line_number":119,"context_line":"      if (newValue !\u003d\u003d oldValue) {"},{"line_number":120,"context_line":"        var allocatedThere \u003d {};"},{"line_number":121,"context_line":"        var availableHere;"},{"line_number":122,"context_line":""}],"source_content_type":"text/javascript","patch_set":26,"id":"9f436f4f_6523f2be","line":119,"range":{"start_line":118,"start_character":37,"end_line":119,"end_character":34},"updated":"2017-08-11 18:41:15.000000000","message":"Doesn\u0027t watchCollection guarantee to only call this function when the condition is true? If we left off the oldValue parameter that would also improve performance somewhat.","commit_id":"1a84c0b5ef6966c4a44e03113b59bbd9ec3c2ed7"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"318f83218c8b8aad035a4ad9984a3e7031ab038c","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    function hideAllocated(allocatedThereList) {"},{"line_number":104,"context_line":"      var allocatedThereDict \u003d {};"},{"line_number":105,"context_line":"      var availableHereList;"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"      allocatedThereList.forEach(function(port) {"},{"line_number":108,"context_line":"        allocatedThereDict[port.id] \u003d true;"}],"source_content_type":"text/javascript","patch_set":41,"id":"ff82abbf_083b6b38","line":105,"updated":"2017-11-20 05:21:22.000000000","message":"Can you remove the \"here\" and \"there\" from the names?","commit_id":"c42f620d9829be4e96e0841f5fd981ff62c665e7"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"746f9210115afe9f577417bd85afe4e3e87488cd","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    function hideAllocated(allocatedThereList) {"},{"line_number":104,"context_line":"      var allocatedThereDict \u003d {};"},{"line_number":105,"context_line":"      var availableHereList;"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"      allocatedThereList.forEach(function(port) {"},{"line_number":108,"context_line":"        allocatedThereDict[port.id] \u003d true;"}],"source_content_type":"text/javascript","patch_set":41,"id":"ff82abbf_376aaeec","line":105,"in_reply_to":"ff82abbf_083b6b38","updated":"2017-11-27 13:11:03.000000000","message":"Done","commit_id":"c42f620d9829be4e96e0841f5fd981ff62c665e7"}],"openstack_dashboard/static/app/core/trunks/steps/trunk-parent-port.help.html":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a40d84c7a6e56cbc5023ae140b80961e8651fab6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  \u003cdt translate\u003eParent Port\u003c/dt\u003e"},{"line_number":3,"context_line":"  \u003cdd translate\u003e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  \u003cp\u003eExactly one regular Neutron port. Has to be provided when the trunk"},{"line_number":6,"context_line":"  is created. Cannot be changed during the trunk\u0027s life.\u003c/p\u003e"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  \u003cp\u003eThe parent port is the port you have to add to the instance at"}],"source_content_type":"text/html","patch_set":16,"id":"1f1a1f67_8acc4d35","line":5,"range":{"start_line":5,"start_character":2,"end_line":5,"end_character":5},"updated":"2017-07-19 18:48:40.000000000","message":"Same comments for other files.\n\n \u003cp translate\u003e\n\nrather than \u003cdd translate\u003e","commit_id":"fd7d396ac9142a05f7647aed9153d141d5dde54c"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"0980bc04b4cc4ff49bc438c70af6760027bf4731","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  \u003cdt translate\u003eParent Port\u003c/dt\u003e"},{"line_number":3,"context_line":"  \u003cdd translate\u003e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  \u003cp\u003eExactly one regular Neutron port. Has to be provided when the trunk"},{"line_number":6,"context_line":"  is created. Cannot be changed during the trunk\u0027s life.\u003c/p\u003e"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  \u003cp\u003eThe parent port is the port you have to add to the instance at"}],"source_content_type":"text/html","patch_set":16,"id":"1f1a1f67_9c180485","line":5,"range":{"start_line":5,"start_character":2,"end_line":5,"end_character":5},"in_reply_to":"1f1a1f67_8acc4d35","updated":"2017-07-20 10:27:23.000000000","message":"Done","commit_id":"fd7d396ac9142a05f7647aed9153d141d5dde54c"}],"openstack_dashboard/static/app/core/trunks/steps/trunk-subports.controller.js":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"b4052b2dd84d5c6797ec174f2d07f4508dd3022e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  ) {"},{"line_number":43,"context_line":"    var ctrl \u003d this;"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    ctrl.portStatuses \u003d {"},{"line_number":46,"context_line":"      \u0027ACTIVE\u0027: gettext(\u0027Active\u0027),"},{"line_number":47,"context_line":"      \u0027DOWN\u0027: gettext(\u0027Down\u0027)"},{"line_number":48,"context_line":"    };"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    ctrl.portAdminStates \u003d {"},{"line_number":51,"context_line":"      \u0027UP\u0027: gettext(\u0027Up\u0027),"},{"line_number":52,"context_line":"      \u0027DOWN\u0027: gettext(\u0027Down\u0027)"},{"line_number":53,"context_line":"    };"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    ctrl.vnicTypes \u003d {"},{"line_number":56,"context_line":"      \u0027normal\u0027: gettext(\u0027Normal\u0027),"},{"line_number":57,"context_line":"      \u0027direct\u0027: gettext(\u0027Direct\u0027),"},{"line_number":58,"context_line":"      \u0027direct-physical\u0027: gettext(\u0027Direct Physical\u0027),"},{"line_number":59,"context_line":"      \u0027macvtap\u0027: gettext(\u0027MacVTap\u0027),"},{"line_number":60,"context_line":"      \u0027baremetal\u0027: gettext(\u0027Bare Metal\u0027)"},{"line_number":61,"context_line":"    };"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    ctrl.tableHelpText \u003d {"},{"line_number":64,"context_line":"      allocHelpText: gettext(\u0027Select from the list of available ports below.\u0027),"},{"line_number":65,"context_line":"      availHelpText: gettext(\u0027Select many\u0027)"},{"line_number":66,"context_line":"    };"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    ctrl.tooltipModel \u003d tooltipService;"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    ctrl.nameOrID \u003d function nameOrId(data) {"},{"line_number":71,"context_line":"      return angular.isDefined(data.name) \u0026\u0026 data.name !\u003d\u003d \u0027\u0027 ? data.name : data.id;"},{"line_number":72,"context_line":"    };"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    ctrl.tableLimits \u003d {"},{"line_number":75,"context_line":"      maxAllocation: -1"}],"source_content_type":"text/javascript","patch_set":24,"id":"9f436f4f_a05b7185","line":72,"range":{"start_line":45,"start_character":0,"end_line":72,"end_character":6},"updated":"2017-08-08 19:44:43.000000000","message":"Almost all of this is duplicated in the parent and the subports controllers.","commit_id":"9bcb68bfb665b8e9c63ef1ddc3223fa99aa4a430"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"b4052b2dd84d5c6797ec174f2d07f4508dd3022e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        // of transfertable. Therefore we have two watchers calling this"},{"line_number":138,"context_line":"        // function. We may and will be called when the two data structures"},{"line_number":139,"context_line":"        // are not consistent. We skip these cases by the following condition."},{"line_number":140,"context_line":"        if (newDetails[element.id] !\u003d\u003d undefined) {"},{"line_number":141,"context_line":"          trunk.sub_ports.push({"},{"line_number":142,"context_line":"            port_id: element.id,"},{"line_number":143,"context_line":"            segmentation_id: newDetails[element.id].segmentation_id,"}],"source_content_type":"text/javascript","patch_set":24,"id":"9f436f4f_6027c914","line":140,"range":{"start_line":140,"start_character":12,"end_line":140,"end_character":48},"updated":"2017-08-08 19:44:43.000000000","message":"angular.isDefined","commit_id":"9bcb68bfb665b8e9c63ef1ddc3223fa99aa4a430"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"36ba7e2bddb7ba2637b6dfae696f7d38a8706ce3","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        // of transfertable. Therefore we have two watchers calling this"},{"line_number":138,"context_line":"        // function. We may and will be called when the two data structures"},{"line_number":139,"context_line":"        // are not consistent. We skip these cases by the following condition."},{"line_number":140,"context_line":"        if (newDetails[element.id] !\u003d\u003d undefined) {"},{"line_number":141,"context_line":"          trunk.sub_ports.push({"},{"line_number":142,"context_line":"            port_id: element.id,"},{"line_number":143,"context_line":"            segmentation_id: newDetails[element.id].segmentation_id,"}],"source_content_type":"text/javascript","patch_set":24,"id":"9f436f4f_c694368e","line":140,"range":{"start_line":140,"start_character":12,"end_line":140,"end_character":48},"in_reply_to":"9f436f4f_6027c914","updated":"2017-08-09 14:49:49.000000000","message":"even better: element.id in newDetails","commit_id":"9bcb68bfb665b8e9c63ef1ddc3223fa99aa4a430"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"da92c946be5dbceede2d776233a8afcf253b29ac","unresolved":false,"context_lines":[{"line_number":143,"context_line":"      });"},{"line_number":144,"context_line":"    }"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    function hideAllocated(newValue, oldValue) {"},{"line_number":147,"context_line":"      if (newValue !\u003d\u003d oldValue) {"},{"line_number":148,"context_line":"        var allocatedThere \u003d {};"},{"line_number":149,"context_line":"        var availableHere;"},{"line_number":150,"context_line":""}],"source_content_type":"text/javascript","patch_set":26,"id":"9f436f4f_051c2676","line":147,"range":{"start_line":146,"start_character":37,"end_line":147,"end_character":34},"updated":"2017-08-11 18:41:15.000000000","message":"superfluous parameter and if","commit_id":"1a84c0b5ef6966c4a44e03113b59bbd9ec3c2ed7"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"318f83218c8b8aad035a4ad9984a3e7031ab038c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    ctrl.segmentationTypesDict \u003d {"},{"line_number":67,"context_line":"      // The first item will be the default type."},{"line_number":68,"context_line":"      \u0027vlan\u0027: [1, 4094],"},{"line_number":69,"context_line":"      \u0027inherit\u0027: undefined"},{"line_number":70,"context_line":"    };"},{"line_number":71,"context_line":"    ctrl.segmentationTypes \u003d Object.keys(ctrl.segmentationTypesDict);"},{"line_number":72,"context_line":"    ctrl.subportsDetails \u003d {};"}],"source_content_type":"text/javascript","patch_set":41,"id":"ff82abbf_050a7425","line":69,"updated":"2017-11-20 05:21:22.000000000","message":"I think null is more appropriate here.","commit_id":"c42f620d9829be4e96e0841f5fd981ff62c665e7"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"746f9210115afe9f577417bd85afe4e3e87488cd","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    ctrl.segmentationTypesDict \u003d {"},{"line_number":67,"context_line":"      // The first item will be the default type."},{"line_number":68,"context_line":"      \u0027vlan\u0027: [1, 4094],"},{"line_number":69,"context_line":"      \u0027inherit\u0027: undefined"},{"line_number":70,"context_line":"    };"},{"line_number":71,"context_line":"    ctrl.segmentationTypes \u003d Object.keys(ctrl.segmentationTypesDict);"},{"line_number":72,"context_line":"    ctrl.subportsDetails \u003d {};"}],"source_content_type":"text/javascript","patch_set":41,"id":"ff82abbf_f77766d3","line":69,"in_reply_to":"ff82abbf_050a7425","updated":"2017-11-27 13:11:03.000000000","message":"Done","commit_id":"c42f620d9829be4e96e0841f5fd981ff62c665e7"}],"openstack_dashboard/static/app/core/trunks/steps/trunk-subports.help.html":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a40d84c7a6e56cbc5023ae140b80961e8651fab6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdl\u003e"},{"line_number":2,"context_line":"  \u003cdt translate\u003eSubports\u003c/dt\u003e"},{"line_number":3,"context_line":"  \u003cdd translate\u003e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  \u003cp\u003eAn arbitrary amount (0, 1, 2, ...) of regular Neutron ports with"},{"line_number":6,"context_line":"  segmentation details (ie. type and ID). May be provided when the trunk"}],"source_content_type":"text/html","patch_set":16,"id":"1f1a1f67_0a5ddd45","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":16},"updated":"2017-07-19 18:48:40.000000000","message":"Same comments for other files.\nCould you use \u003cp translate\u003e rather than \u003cdd translate\u003e?\n\nThe current version (\u003cdd translate\u003e) generates a super big single translation string and it is hard for translators to translate it in our translation platform.\n\nBy using \u003cp translate\u003e, we can split strings into reasonable pieces.","commit_id":"fd7d396ac9142a05f7647aed9153d141d5dde54c"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"0980bc04b4cc4ff49bc438c70af6760027bf4731","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdl\u003e"},{"line_number":2,"context_line":"  \u003cdt translate\u003eSubports\u003c/dt\u003e"},{"line_number":3,"context_line":"  \u003cdd translate\u003e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  \u003cp\u003eAn arbitrary amount (0, 1, 2, ...) of regular Neutron ports with"},{"line_number":6,"context_line":"  segmentation details (ie. type and ID). May be provided when the trunk"}],"source_content_type":"text/html","patch_set":16,"id":"1f1a1f67_7f507a0b","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":16},"in_reply_to":"1f1a1f67_0a5ddd45","updated":"2017-07-20 10:27:23.000000000","message":"Done","commit_id":"fd7d396ac9142a05f7647aed9153d141d5dde54c"}],"openstack_dashboard/static/app/core/trunks/steps/trunk-subports.html":[{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"3cad4a58fc7386a6ad538b72d9c5af5d3df91eb3","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            \u003c/td\u003e"},{"line_number":135,"context_line":"            \u003ctd class\u003d\"rsp-p1 word-break\"\u003e{$ ctrl.nameOrID(item) $}\u003c/td\u003e"},{"line_number":136,"context_line":"            \u003ctd class\u003d\"rsp-p2\"\u003e"},{"line_number":137,"context_line":"                \u003cdiv ng-repeat\u003d\"ip in item.fixed_ips\"\u003e"},{"line_number":138,"context_line":"                  {$ ip.ip_address $} on subnet: {$ item.subnet_names[ip.ip_address] $}"},{"line_number":139,"context_line":"                \u003c/div\u003e"},{"line_number":140,"context_line":"            \u003c/td\u003e"}],"source_content_type":"text/html","patch_set":30,"id":"7f287b81_996f35fb","line":137,"range":{"start_line":137,"start_character":53,"end_line":137,"end_character":54},"updated":"2017-08-29 08:41:55.000000000","message":"`translate` seems to be needed.","commit_id":"f1f31eab6240b13ce50ad72444fdbd06c8ff1e2d"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"c98cbfe76d74dbf89532de6c7c22b19a2c321e91","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            \u003c/td\u003e"},{"line_number":135,"context_line":"            \u003ctd class\u003d\"rsp-p1 word-break\"\u003e{$ ctrl.nameOrID(item) $}\u003c/td\u003e"},{"line_number":136,"context_line":"            \u003ctd class\u003d\"rsp-p2\"\u003e"},{"line_number":137,"context_line":"                \u003cdiv ng-repeat\u003d\"ip in item.fixed_ips\"\u003e"},{"line_number":138,"context_line":"                  {$ ip.ip_address $} on subnet: {$ item.subnet_names[ip.ip_address] $}"},{"line_number":139,"context_line":"                \u003c/div\u003e"},{"line_number":140,"context_line":"            \u003c/td\u003e"}],"source_content_type":"text/html","patch_set":30,"id":"7f287b81_211d7f73","line":137,"range":{"start_line":137,"start_character":53,"end_line":137,"end_character":54},"in_reply_to":"7f287b81_996f35fb","updated":"2017-08-30 13:08:11.000000000","message":"Done","commit_id":"f1f31eab6240b13ce50ad72444fdbd06c8ff1e2d"}]}
