)]}'
{"openstack_dashboard/static/app/core/images/steps/create-image/create-image.controller.js":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"7287ce739ef14f9f6f7ed5a207f6f0375d60273e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"      min_ram: 0,"},{"line_number":66,"context_line":"      container_format: \u0027\u0027,"},{"line_number":67,"context_line":"      disk_format: \u0027\u0027,"},{"line_number":68,"context_line":"      visibility: \u0027private\u0027"},{"line_number":69,"context_line":"    };"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    ctrl.uploadProgress \u003d -1;"}],"source_content_type":"text/javascript","patch_set":1,"id":"7f231b9d_9e4fcf91","line":68,"updated":"2017-06-20 09:38:33.000000000","message":"I would prefer we make this configurable rather than change the default; people have requested this type of configuration before :)","commit_id":"ffba0938a4cb3fa30b454809694ea462bd457856"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"ce2999eb95a46cfe9832c7950af3ca411dd279fb","unresolved":false,"context_lines":[{"line_number":65,"context_line":"      min_ram: 0,"},{"line_number":66,"context_line":"      container_format: \u0027\u0027,"},{"line_number":67,"context_line":"      disk_format: \u0027\u0027,"},{"line_number":68,"context_line":"      visibility: \u0027private\u0027"},{"line_number":69,"context_line":"    };"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    ctrl.uploadProgress \u003d -1;"}],"source_content_type":"text/javascript","patch_set":1,"id":"5f201791_7c7dfbaf","line":68,"in_reply_to":"7f231b9d_9e4fcf91","updated":"2017-06-22 00:49:47.000000000","message":"I added a new ticket for making it configurable. https://bugs.launchpad.net/horizon/+bug/1699144. To fix this issue, I need to set it as private first then set it back to public if the user is allowed to create public images.","commit_id":"ffba0938a4cb3fa30b454809694ea462bd457856"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"7287ce739ef14f9f6f7ed5a207f6f0375d60273e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    function init() {"},{"line_number":153,"context_line":"      glance.getImages({paginate: false}).success(onGetImages);"},{"line_number":154,"context_line":"      userSession.get().then(function(user) {"},{"line_number":155,"context_line":"        ctrl.isAdmin \u003d !!(user \u0026\u0026 user.is_superuser);"},{"line_number":156,"context_line":"      });"},{"line_number":157,"context_line":"    }"},{"line_number":158,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"7f231b9d_7e6bd3f0","line":155,"updated":"2017-06-20 09:38:33.000000000","message":"This should use policy, rather explicitly checking for an admin role. https://github.com/openstack/glance/blob/master/etc/policy.json#L10 Otherwise you could block users from doing this even though policy allows it.","commit_id":"ffba0938a4cb3fa30b454809694ea462bd457856"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"ce2999eb95a46cfe9832c7950af3ca411dd279fb","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    function init() {"},{"line_number":153,"context_line":"      glance.getImages({paginate: false}).success(onGetImages);"},{"line_number":154,"context_line":"      userSession.get().then(function(user) {"},{"line_number":155,"context_line":"        ctrl.isAdmin \u003d !!(user \u0026\u0026 user.is_superuser);"},{"line_number":156,"context_line":"      });"},{"line_number":157,"context_line":"    }"},{"line_number":158,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"5f201791_bc5cb34b","line":155,"in_reply_to":"7f231b9d_7e6bd3f0","updated":"2017-06-22 00:49:47.000000000","message":"Changed to use policy in the new patch. Thanks!","commit_id":"ffba0938a4cb3fa30b454809694ea462bd457856"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"673b456317e1ccd0eacefd1b7f2349ea76b6f79d","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        function () {"},{"line_number":160,"context_line":"          ctrl.allowPublicizeImage \u003d false;"},{"line_number":161,"context_line":"        }"},{"line_number":162,"context_line":"      );"},{"line_number":163,"context_line":"    }"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    function onGetImages(response) {"}],"source_content_type":"text/javascript","patch_set":2,"id":"3f1d235d_e41b31c7","line":162,"updated":"2017-07-05 20:27:47.000000000","message":"This is an improvement, but I\u0027d prefer if we made the logic default cleanly to the current behaviour; that would make it safer to backport. So, please set allowPublicizeImage to true by default (probably around L57) and leave visibility as public. Then run the policy check, and if it fails, set publicize to false and image visibility to private. You can use angular.noop to ignore the positive condition.","commit_id":"b858d89e34080d268626ec7f5cf5c0f863afab47"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"670ba018a348947e21fe568fadf0f673778f86fc","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        function () {"},{"line_number":160,"context_line":"          ctrl.allowPublicizeImage \u003d false;"},{"line_number":161,"context_line":"        }"},{"line_number":162,"context_line":"      );"},{"line_number":163,"context_line":"    }"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    function onGetImages(response) {"}],"source_content_type":"text/javascript","patch_set":2,"id":"3f1d235d_4fbf99a9","line":162,"in_reply_to":"3f1d235d_e41b31c7","updated":"2017-07-06 03:01:07.000000000","message":"Done","commit_id":"b858d89e34080d268626ec7f5cf5c0f863afab47"}]}
