)]}'
{"horizon/test/tests/middleware.py":[{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"84e9bedefc957494785ab4d0e110f5e01b2468b7","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        return request, response"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def _test_ready_for_get(self,"},{"line_number":111,"context_line":"                            url\u003d\u0027/dashboard/project/?start\u003d2016-03-01\u0026end\u0027 +"},{"line_number":112,"context_line":"                                \u0027\u003d2016-03-11\u0027):"},{"line_number":113,"context_line":"        request \u003d self.factory.get(url)"},{"line_number":114,"context_line":"        request.META[\u0027HTTP_HOST\u0027] \u003d self.http_host"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f201791_cf984a76","line":111,"updated":"2017-06-27 10:22:53.000000000","message":"This looks a bit ugly, would it be possible to do:\n\ndef _test_ready_for_get(self, url\u003dNone)\n\nif url is None:\n    url \u003d \u0027/dashboard/project/?start\u003d2016-03-01\u0026end\u003d2016-03-11\u0027","commit_id":"83fab2154eafefd6bcba139e22b535c9b3018506"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a60762aa9d156bb67c6144a0b76551cfad35f2b8","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        olm \u003d middleware.OperationLogMiddleware()"},{"line_number":203,"context_line":"        request, _ \u003d self._test_ready_for_get()"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        self.assertTrue(olm._get_log_format(request), olm._default_format)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    @override_settings(OPERATION_LOG_ENABLED\u003dTrue)"},{"line_number":208,"context_line":"    @patch((\u0027horizon.middleware.operation_log.OperationLogMiddleware.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_7c7fadaa","line":205,"range":{"start_line":205,"start_character":8,"end_line":205,"end_character":74},"updated":"2017-06-27 13:37:10.000000000","message":"assertTrue checks the first argument is True after applying bool(xxx).\nIn this case, you need to compare two arguments.\n\n  self.assertEqual(olm._default_format, olm._get_log_format(request))\n\nNote that the usual convention places the expected value as the first argument and the actual value as the second parameter.","commit_id":"ffde33c13b3c44949a2c8d4a21fe1011d40d6f19"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a60762aa9d156bb67c6144a0b76551cfad35f2b8","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        request, _ \u003d self._test_ready_for_get()"},{"line_number":213,"context_line":"        request.delattr(\"user\")"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        self.assertTrue(olm._get_log_format(request), None)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    @override_settings(OPERATION_LOG_ENABLED\u003dTrue)"},{"line_number":218,"context_line":"    @patch((\u0027horizon.middleware.operation_log.OperationLogMiddleware.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_bc10a558","line":215,"range":{"start_line":215,"start_character":8,"end_line":215,"end_character":59},"updated":"2017-06-27 13:37:10.000000000","message":"in this case, do you want to check old._get_log_format() is None?\n\nif so,\n\n  self.assertIsNone(olm._get_log_format(request))","commit_id":"ffde33c13b3c44949a2c8d4a21fe1011d40d6f19"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a60762aa9d156bb67c6144a0b76551cfad35f2b8","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        request, _ \u003d self._test_ready_for_get()"},{"line_number":223,"context_line":"        request.method \u003d \"FAKE\""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        self.assertTrue(olm._get_log_format(request), None)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @override_settings(OPERATION_LOG_ENABLED\u003dTrue)"},{"line_number":228,"context_line":"    @patch((\u0027horizon.middleware.operation_log.OperationLogMiddleware.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_873472df","line":225,"updated":"2017-06-27 13:37:10.000000000","message":"ditto","commit_id":"ffde33c13b3c44949a2c8d4a21fe1011d40d6f19"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a60762aa9d156bb67c6144a0b76551cfad35f2b8","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        olm \u003d middleware.OperationLogMiddleware()"},{"line_number":232,"context_line":"        request, _ \u003d self._test_ready_for_get(\"/api/policy\")"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        self.assertTrue(olm._get_log_format(request), None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f201791_672f1688","line":234,"updated":"2017-06-27 13:37:10.000000000","message":"ditto","commit_id":"ffde33c13b3c44949a2c8d4a21fe1011d40d6f19"}]}