)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9c8741c1f6c3dbb6b9822fec98f8bf683963ac4d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The structure of DetailView was changed, so the network topology"},{"line_number":10,"context_line":"code needs to be updated so that subnets can be deleted properly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Added a required method in DetailView."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-bug: #1643414"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df3967d1_05bff4fb","line":12,"updated":"2017-07-29 11:23:56.000000000","message":"nit: it would be good to mention method name or remove this sentence from the commit message.","commit_id":"cce59a9922431a9df731358e86506c2b33e567cc"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"2c233fccdf5e671aca7dca96f057adf4e8cea32b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The structure of DetailView was changed, so the network topology"},{"line_number":10,"context_line":"code needs to be updated so that subnets can be deleted properly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Added a required method in DetailView."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-bug: #1643414"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df3967d1_b55ea873","line":12,"in_reply_to":"df3967d1_05bff4fb","updated":"2017-08-02 20:04:31.000000000","message":"Done","commit_id":"cce59a9922431a9df731358e86506c2b33e567cc"}],"openstack_dashboard/static/js/horizon.networktopology.js":[{"author":{"_account_id":14151,"name":"ziyu032","email":"chen.qiaomin@99cloud.net","username":"ziyu032"},"change_message_id":"77ce043b843fa5c4e9d29d9a6148b38f5f63b3f6","unresolved":false,"context_lines":[{"line_number":856,"context_line":"    self.delete_balloon();"},{"line_number":857,"context_line":"  },"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"  removePort: function(portId, deviceData) {"},{"line_number":860,"context_line":"    var self \u003d this;"},{"line_number":861,"context_line":"    var routerId \u003d deviceData.router_id;"},{"line_number":862,"context_line":"    var networkId \u003d deviceData.network_id;"}],"source_content_type":"text/javascript","patch_set":2,"id":"3f1d235d_5f00ca67","line":859,"range":{"start_line":859,"start_character":2,"end_line":859,"end_character":12},"updated":"2017-07-03 09:39:47.000000000","message":"function name:removePort, but the function contains remove subnet. Maybe should rename this function","commit_id":"6cf926caf75003f88788fae39f361e206bd74674"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"7a951223ba7951e22a4d4e72e8aeca24fb7e16c0","unresolved":false,"context_lines":[{"line_number":856,"context_line":"    self.delete_balloon();"},{"line_number":857,"context_line":"  },"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"  removePort: function(portId, deviceData) {"},{"line_number":860,"context_line":"    var self \u003d this;"},{"line_number":861,"context_line":"    var routerId \u003d deviceData.router_id;"},{"line_number":862,"context_line":"    var networkId \u003d deviceData.network_id;"}],"source_content_type":"text/javascript","patch_set":2,"id":"3f1d235d_06c2f8e9","line":859,"range":{"start_line":859,"start_character":2,"end_line":859,"end_character":12},"in_reply_to":"3f1d235d_5f00ca67","updated":"2017-07-03 23:46:17.000000000","message":"Done","commit_id":"6cf926caf75003f88788fae39f361e206bd74674"},{"author":{"_account_id":23037,"name":"Huachao Mao","email":"mao.huachao@99cloud.net","username":"huachaomao"},"change_message_id":"dc1c2253a6671f7eb9af08202b66de9019cac3f5","unresolved":false,"context_lines":[{"line_number":886,"context_line":"      var subnets \u003d networkData.subnets;"},{"line_number":887,"context_line":"      for (var subnet in subnets) {"},{"line_number":888,"context_line":"        if (subnets[subnet].id \u003d\u003d\u003d portId) {"},{"line_number":889,"context_line":"          if (subnets.length \u003d\u003d 1) {"},{"line_number":890,"context_line":"            delete(networkData.subnets);"},{"line_number":891,"context_line":"          } else {"},{"line_number":892,"context_line":"            subnets.splice(subnet, 1);"}],"source_content_type":"text/javascript","patch_set":2,"id":"3f1d235d_84e059ce","line":889,"range":{"start_line":889,"start_character":28,"end_line":889,"end_character":31},"updated":"2017-07-03 09:24:52.000000000","message":"\u003d\u003d\u003d","commit_id":"6cf926caf75003f88788fae39f361e206bd74674"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"2bd58305bbe0618336f44da912bb83353da4d9ca","unresolved":false,"context_lines":[{"line_number":886,"context_line":"      var subnets \u003d networkData.subnets;"},{"line_number":887,"context_line":"      for (var subnet in subnets) {"},{"line_number":888,"context_line":"        if (subnets[subnet].id \u003d\u003d\u003d portId) {"},{"line_number":889,"context_line":"          if (subnets.length \u003d\u003d 1) {"},{"line_number":890,"context_line":"            delete(networkData.subnets);"},{"line_number":891,"context_line":"          } else {"},{"line_number":892,"context_line":"            subnets.splice(subnet, 1);"}],"source_content_type":"text/javascript","patch_set":2,"id":"3f1d235d_c6a2c04b","line":889,"range":{"start_line":889,"start_character":28,"end_line":889,"end_character":31},"in_reply_to":"3f1d235d_84e059ce","updated":"2017-07-03 23:44:18.000000000","message":"length returns an integer always so it doesn\u0027t need to check the type here","commit_id":"6cf926caf75003f88788fae39f361e206bd74674"}]}
