)]}'
{"horizon/static/framework/widgets/load-edit/load-edit.directive.js":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"ef36accd6c63012cd9ff114b4635b486a4dccd91","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    var directive \u003d {"},{"line_number":46,"context_line":"      restrict: \u0027E\u0027,"},{"line_number":47,"context_line":"      scope: {"},{"line_number":48,"context_line":"        title: \u0027\u003d\u0027,"},{"line_number":49,"context_line":"        model: \u0027\u003d\u0027,"},{"line_number":50,"context_line":"        maxBytes: \u0027\u003d\u0027,"},{"line_number":51,"context_line":"        key: \u0027@\u0027"}],"source_content_type":"text/javascript","patch_set":2,"id":"ff346bd7_be4b9eae","line":48,"updated":"2017-07-22 15:35:58.000000000","message":"This doesn\u0027t need to be a two-way binding, I think; could just make it one-way bind.","commit_id":"fdb2de7ddac56fd281cdd4a9c412224fbade1f31"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"ad521423a26b04cb7e0dd1d3654cd107ce7258ce","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    var directive \u003d {"},{"line_number":46,"context_line":"      restrict: \u0027E\u0027,"},{"line_number":47,"context_line":"      scope: {"},{"line_number":48,"context_line":"        title: \u0027\u003d\u0027,"},{"line_number":49,"context_line":"        model: \u0027\u003d\u0027,"},{"line_number":50,"context_line":"        maxBytes: \u0027\u003d\u0027,"},{"line_number":51,"context_line":"        key: \u0027@\u0027"}],"source_content_type":"text/javascript","patch_set":2,"id":"ff346bd7_e061753b","line":48,"in_reply_to":"ff346bd7_be4b9eae","updated":"2017-07-24 03:49:55.000000000","message":"Done","commit_id":"fdb2de7ddac56fd281cdd4a9c412224fbade1f31"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"ef36accd6c63012cd9ff114b4635b486a4dccd91","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      scope: {"},{"line_number":48,"context_line":"        title: \u0027\u003d\u0027,"},{"line_number":49,"context_line":"        model: \u0027\u003d\u0027,"},{"line_number":50,"context_line":"        maxBytes: \u0027\u003d\u0027,"},{"line_number":51,"context_line":"        key: \u0027@\u0027"},{"line_number":52,"context_line":"      },"},{"line_number":53,"context_line":"      link: link,"}],"source_content_type":"text/javascript","patch_set":2,"id":"ff346bd7_7ecbf61d","line":50,"updated":"2017-07-22 15:35:58.000000000","message":"ditto","commit_id":"fdb2de7ddac56fd281cdd4a9c412224fbade1f31"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"ad521423a26b04cb7e0dd1d3654cd107ce7258ce","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      scope: {"},{"line_number":48,"context_line":"        title: \u0027\u003d\u0027,"},{"line_number":49,"context_line":"        model: \u0027\u003d\u0027,"},{"line_number":50,"context_line":"        maxBytes: \u0027\u003d\u0027,"},{"line_number":51,"context_line":"        key: \u0027@\u0027"},{"line_number":52,"context_line":"      },"},{"line_number":53,"context_line":"      link: link,"}],"source_content_type":"text/javascript","patch_set":2,"id":"ff346bd7_c0667152","line":50,"in_reply_to":"ff346bd7_7ecbf61d","updated":"2017-07-24 03:49:55.000000000","message":"Done","commit_id":"fdb2de7ddac56fd281cdd4a9c412224fbade1f31"}],"horizon/static/framework/widgets/load-edit/load-edit.html":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"ef36accd6c63012cd9ff114b4635b486a4dccd91","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            rows\u003d\"8\""},{"line_number":20,"context_line":"            id\u003d\"{$ key $}\""},{"line_number":21,"context_line":"            name\u003d\"{$ key $}\""},{"line_number":22,"context_line":"            ng-maxlength\u003d\"maxBytes\""},{"line_number":23,"context_line":"            ng-model\u003d\"textContent\"\u003e"},{"line_number":24,"context_line":"  \u003c/textarea\u003e"},{"line_number":25,"context_line":"  \u003cspan class\u003d\"help-block\""}],"source_content_type":"text/html","patch_set":2,"id":"ff346bd7_5ed032ca","line":22,"updated":"2017-07-22 15:35:58.000000000","message":"Most of the values in this file could be one time binds with :: instead of having all these watchers :) Things like title, id, max bytes, shouldnt change during the life cycle of the component. The model obviously will need to be a two way bind.","commit_id":"fdb2de7ddac56fd281cdd4a9c412224fbade1f31"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"ad521423a26b04cb7e0dd1d3654cd107ce7258ce","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            rows\u003d\"8\""},{"line_number":20,"context_line":"            id\u003d\"{$ key $}\""},{"line_number":21,"context_line":"            name\u003d\"{$ key $}\""},{"line_number":22,"context_line":"            ng-maxlength\u003d\"maxBytes\""},{"line_number":23,"context_line":"            ng-model\u003d\"textContent\"\u003e"},{"line_number":24,"context_line":"  \u003c/textarea\u003e"},{"line_number":25,"context_line":"  \u003cspan class\u003d\"help-block\""}],"source_content_type":"text/html","patch_set":2,"id":"ff346bd7_a0d00dcb","line":22,"in_reply_to":"ff346bd7_5ed032ca","updated":"2017-07-24 03:49:55.000000000","message":"Done","commit_id":"fdb2de7ddac56fd281cdd4a9c412224fbade1f31"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/configuration/configuration.controller.js":[{"author":{"_account_id":26341,"name":"Chiew Yee Xin","email":"yeexinc@gmail.com","username":"yeexinc"},"change_message_id":"c92faba0111634999ecfbb07d4ec2b373b25ee38","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  function LaunchInstanceConfigurationController() {"},{"line_number":37,"context_line":"    var ctrl \u003d this;"},{"line_number":38,"context_line":"    ctrl.title \u003d gettext(\"Customization Script\");"},{"line_number":39,"context_line":"    ctrl.MAX_SCRIPT_SIZE \u003d MAX_SCRIPT_SIZE;"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    ctrl.diskConfigOptions \u003d ["},{"line_number":42,"context_line":"      { value: \u0027AUTO\u0027, text: gettext(\u0027Automatic\u0027) },"}],"source_content_type":"text/javascript","patch_set":2,"id":"1f1a1f67_d68302a9","line":39,"range":{"start_line":39,"start_character":9,"end_line":39,"end_character":42},"updated":"2017-07-20 05:16:30.000000000","message":"Since we are renaming \u0027script\u0027 to \u0027text\u0027, should these be renamed to MAX_TEXT_SIZE? Same goes to the one in configuration.html","commit_id":"fdb2de7ddac56fd281cdd4a9c412224fbade1f31"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"d63f96cbab4b18221cc8d155d80176d0bf3eff94","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  function LaunchInstanceConfigurationController() {"},{"line_number":37,"context_line":"    var ctrl \u003d this;"},{"line_number":38,"context_line":"    ctrl.title \u003d gettext(\"Customization Script\");"},{"line_number":39,"context_line":"    ctrl.MAX_SCRIPT_SIZE \u003d MAX_SCRIPT_SIZE;"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    ctrl.diskConfigOptions \u003d ["},{"line_number":42,"context_line":"      { value: \u0027AUTO\u0027, text: gettext(\u0027Automatic\u0027) },"}],"source_content_type":"text/javascript","patch_set":2,"id":"1f1a1f67_f9c94f5a","line":39,"range":{"start_line":39,"start_character":9,"end_line":39,"end_character":42},"in_reply_to":"1f1a1f67_d68302a9","updated":"2017-07-20 05:50:16.000000000","message":"To commonize, renaming \u0027script\u0027 to \u0027text\u0027 is done in only controller and template for load-edit directive. It\u0027s better to name each variables as suit for each use case in each panel, such as template or controller for configuration. So we should not rename them, I think.","commit_id":"fdb2de7ddac56fd281cdd4a9c412224fbade1f31"}]}
