)]}'
{"openstack_dashboard/api/neutron.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d75489db353356787ada141916b58da1dceb4e1d","unresolved":false,"context_lines":[{"line_number":906,"context_line":"        if old_trunk[k] !\u003d new_trunk[k]}"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"    subports_old \u003d {dict2frozenset(d): d"},{"line_number":909,"context_line":"                    for d in old_trunk.get(\u0027sub_ports\u0027, []) or []}"},{"line_number":910,"context_line":"    subports_new \u003d {dict2frozenset(d): d"},{"line_number":911,"context_line":"                    for d in new_trunk.get(\u0027sub_ports\u0027, []) or []}"},{"line_number":912,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3f4b6375_04a9f2dd","line":909,"range":{"start_line":909,"start_character":59,"end_line":909,"end_character":65},"updated":"2017-10-22 14:22:32.000000000","message":"\"or []\" looks unnecessary. Is there a case where \u0027sub_ports\u0027 exists but the value is not a list?\n\nI think old_trunk.get(\u0027sub_ports\u0027, []) or old_trunk.get(\u0027sub_ports\u0027) or [] is enough. These two are a bit different though.","commit_id":"4743aacc3ca804e66b6fada9a4b490969f8b5854"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"e2fd01fa6212720c3916ab7a2486a6c67bc33884","unresolved":false,"context_lines":[{"line_number":906,"context_line":"        if old_trunk[k] !\u003d new_trunk[k]}"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"    subports_old \u003d {dict2frozenset(d): d"},{"line_number":909,"context_line":"                    for d in old_trunk.get(\u0027sub_ports\u0027, []) or []}"},{"line_number":910,"context_line":"    subports_new \u003d {dict2frozenset(d): d"},{"line_number":911,"context_line":"                    for d in new_trunk.get(\u0027sub_ports\u0027, []) or []}"},{"line_number":912,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3f4b6375_9edfd464","line":909,"range":{"start_line":909,"start_character":59,"end_line":909,"end_character":65},"in_reply_to":"3f4b6375_04a9f2dd","updated":"2017-10-27 14:37:06.000000000","message":"\u003e Is there a case where \u0027sub_ports\u0027 exists\n \u003e but the value is not a list?\n\nNot that I know of. It was just habitual defensive coding.","commit_id":"4743aacc3ca804e66b6fada9a4b490969f8b5854"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d75489db353356787ada141916b58da1dceb4e1d","unresolved":false,"context_lines":[{"line_number":908,"context_line":"    subports_old \u003d {dict2frozenset(d): d"},{"line_number":909,"context_line":"                    for d in old_trunk.get(\u0027sub_ports\u0027, []) or []}"},{"line_number":910,"context_line":"    subports_new \u003d {dict2frozenset(d): d"},{"line_number":911,"context_line":"                    for d in new_trunk.get(\u0027sub_ports\u0027, []) or []}"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"    old_set \u003d set(subports_old.keys())"},{"line_number":914,"context_line":"    new_set \u003d set(subports_new.keys())"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f4b6375_e4aff6e0","line":911,"range":{"start_line":911,"start_character":59,"end_line":911,"end_character":65},"updated":"2017-10-22 14:22:32.000000000","message":"ditto","commit_id":"4743aacc3ca804e66b6fada9a4b490969f8b5854"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"e2fd01fa6212720c3916ab7a2486a6c67bc33884","unresolved":false,"context_lines":[{"line_number":908,"context_line":"    subports_old \u003d {dict2frozenset(d): d"},{"line_number":909,"context_line":"                    for d in old_trunk.get(\u0027sub_ports\u0027, []) or []}"},{"line_number":910,"context_line":"    subports_new \u003d {dict2frozenset(d): d"},{"line_number":911,"context_line":"                    for d in new_trunk.get(\u0027sub_ports\u0027, []) or []}"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"    old_set \u003d set(subports_old.keys())"},{"line_number":914,"context_line":"    new_set \u003d set(subports_new.keys())"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f4b6375_7ed41848","line":911,"range":{"start_line":911,"start_character":59,"end_line":911,"end_character":65},"in_reply_to":"3f4b6375_e4aff6e0","updated":"2017-10-27 14:37:06.000000000","message":"Done","commit_id":"4743aacc3ca804e66b6fada9a4b490969f8b5854"}],"openstack_dashboard/static/app/core/openstack-service-api/neutron.service.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d75489db353356787ada141916b58da1dceb4e1d","unresolved":false,"context_lines":[{"line_number":464,"context_line":"     * Update an existing trunk."},{"line_number":465,"context_line":"     */"},{"line_number":466,"context_line":"    function updateTrunk(oldTrunk, newTrunk) {"},{"line_number":467,"context_line":"      return apiService.patch(\u0027/api/neutron/trunks/\u0027 + newTrunk.id + \u0027/\u0027, [oldTrunk, newTrunk])"},{"line_number":468,"context_line":"      .error(function() {"},{"line_number":469,"context_line":"        toastService.add(\u0027error\u0027, gettext(\u0027Unable to update the trunk.\u0027));"},{"line_number":470,"context_line":"      });"}],"source_content_type":"text/javascript","patch_set":19,"id":"3f4b6375_045b322e","line":467,"range":{"start_line":467,"start_character":55,"end_line":467,"end_character":66},"updated":"2017-10-22 14:22:32.000000000","message":"While we cannot change ID of trunk, I think oldTrunk.id is better as we are updating an existing trunk.","commit_id":"4743aacc3ca804e66b6fada9a4b490969f8b5854"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"e2fd01fa6212720c3916ab7a2486a6c67bc33884","unresolved":false,"context_lines":[{"line_number":464,"context_line":"     * Update an existing trunk."},{"line_number":465,"context_line":"     */"},{"line_number":466,"context_line":"    function updateTrunk(oldTrunk, newTrunk) {"},{"line_number":467,"context_line":"      return apiService.patch(\u0027/api/neutron/trunks/\u0027 + newTrunk.id + \u0027/\u0027, [oldTrunk, newTrunk])"},{"line_number":468,"context_line":"      .error(function() {"},{"line_number":469,"context_line":"        toastService.add(\u0027error\u0027, gettext(\u0027Unable to update the trunk.\u0027));"},{"line_number":470,"context_line":"      });"}],"source_content_type":"text/javascript","patch_set":19,"id":"3f4b6375_3eca20a0","line":467,"range":{"start_line":467,"start_character":55,"end_line":467,"end_character":66},"in_reply_to":"3f4b6375_045b322e","updated":"2017-10-27 14:37:06.000000000","message":"Done","commit_id":"4743aacc3ca804e66b6fada9a4b490969f8b5854"}],"openstack_dashboard/static/app/core/trunks/actions/edit.action.service.js":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"eff7a9e0631487c07523210bc8c456a470b086b9","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        scope.model.oldTrunk \u003d angular.copy(trunk.data);"},{"line_number":128,"context_line":"      });"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"      getAvailablePorts(ports).then(performModalOpen);"},{"line_number":131,"context_line":"    }"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    function submit() {"}],"source_content_type":"text/javascript","patch_set":8,"id":"df3967d1_236b671e","line":130,"updated":"2017-08-04 09:28:35.000000000","message":"We should return this:\n\n return getAvailablePorts(ports).then(performModalOpen);\n\nOtherwise the result of the update is lost and the table will not be refreshed.","commit_id":"5e738a6e34869561ff0f8299f1f21e258def8b47"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"21c0d8c3f998bb17b9ed4b8523562fbe7a84548d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        .then(onUpdateTrunkSuccess);"},{"line_number":136,"context_line":"    }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    function onUpdateTrunkSuccess(trunk) {"},{"line_number":139,"context_line":"      toast.add(\u0027success\u0027, interpolate("},{"line_number":140,"context_line":"        gettext(\u0027Trunk %s was successfully edited.\u0027), [trunk.name]));"},{"line_number":141,"context_line":"      return actionResultService.getActionResult()"}],"source_content_type":"text/javascript","patch_set":8,"id":"df3967d1_3e993ec3","line":138,"range":{"start_line":138,"start_character":34,"end_line":138,"end_character":39},"updated":"2017-08-04 09:44:11.000000000","message":"We get back a response object here. So we can either:\n\n function onUpdateTrunkSuccess(response) {\n   toast.add(\u0027success\u0027, interpolate(\n     gettext(\u0027Trunk %s was successfully edited.\u0027),\n [response.data.name]));\n return actionResultService.getActionResult()\n   .updated(resourceType, response.data.id)\n   .result;\n }\n\nBut everything we need here was already present in scope.model.trunk, so this would be simpler IMHO:\n\n function onUpdateTrunkSuccess() {\n   toast.add(\u0027success\u0027, interpolate(\n     gettext(\u0027Trunk %s was successfully edited.\u0027), \n [scope.model.trunk.name]));\n return actionResultService.getActionResult()\n .updated(resourceType, scope.model.trunk.id)\n .result;\n }","commit_id":"5e738a6e34869561ff0f8299f1f21e258def8b47"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"b92f0aae17cc99acc046f441accddb8cdb539dfe","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        var ports \u003d responses[1].data.items;"},{"line_number":103,"context_line":"        var trunk \u003d responses[2].data;"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        function isSubportOfSelectedTrunk(port) {"},{"line_number":106,"context_line":"          return portsExtra.isSubportOfTrunk(selected.id, port);"},{"line_number":107,"context_line":"        }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        return {"},{"line_number":110,"context_line":"          subportCandidates: portsExtra.addExtraInfo("}],"source_content_type":"text/javascript","patch_set":11,"id":"9f436f4f_63dc7374","line":107,"range":{"start_line":105,"start_character":0,"end_line":107,"end_character":9},"updated":"2017-08-08 19:52:27.000000000","message":"could do with bind()","commit_id":"7762161034f6e5ac8d590d6440ab9f8132736064"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"c3b7c0f327b27d31ab08b9f2af1cb3590fbe8c70","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        var ports \u003d responses[1].data.items;"},{"line_number":103,"context_line":"        var trunk \u003d responses[2].data;"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        function isSubportOfSelectedTrunk(port) {"},{"line_number":106,"context_line":"          return portsExtra.isSubportOfTrunk(selected.id, port);"},{"line_number":107,"context_line":"        }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        return {"},{"line_number":110,"context_line":"          subportCandidates: portsExtra.addExtraInfo("}],"source_content_type":"text/javascript","patch_set":11,"id":"9f436f4f_a66372dc","line":107,"range":{"start_line":105,"start_character":0,"end_line":107,"end_character":9},"in_reply_to":"9f436f4f_63dc7374","updated":"2017-08-09 14:49:58.000000000","message":"Done","commit_id":"7762161034f6e5ac8d590d6440ab9f8132736064"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"b92f0aae17cc99acc046f441accddb8cdb539dfe","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            ports: {"},{"line_number":130,"context_line":"              parentPortCandidates: [],"},{"line_number":131,"context_line":"              // TODO sort the subports"},{"line_number":132,"context_line":"              subportCandidates: params.subportCandidates,"},{"line_number":133,"context_line":"              subportsOfInitTrunk: params.subportsOfInitTrunk"},{"line_number":134,"context_line":"            },"},{"line_number":135,"context_line":"            initTrunk: oldTrunk"}],"source_content_type":"text/javascript","patch_set":11,"id":"9f436f4f_e3d18359","line":132,"updated":"2017-08-08 19:52:27.000000000","message":"by (port name, port id)","commit_id":"7762161034f6e5ac8d590d6440ab9f8132736064"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"c3b7c0f327b27d31ab08b9f2af1cb3590fbe8c70","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            ports: {"},{"line_number":130,"context_line":"              parentPortCandidates: [],"},{"line_number":131,"context_line":"              // TODO sort the subports"},{"line_number":132,"context_line":"              subportCandidates: params.subportCandidates,"},{"line_number":133,"context_line":"              subportsOfInitTrunk: params.subportsOfInitTrunk"},{"line_number":134,"context_line":"            },"},{"line_number":135,"context_line":"            initTrunk: oldTrunk"}],"source_content_type":"text/javascript","patch_set":11,"id":"9f436f4f_83faa03f","line":132,"in_reply_to":"9f436f4f_e3d18359","updated":"2017-08-09 14:49:58.000000000","message":"Done","commit_id":"7762161034f6e5ac8d590d6440ab9f8132736064"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"b92f0aae17cc99acc046f441accddb8cdb539dfe","unresolved":false,"context_lines":[{"line_number":130,"context_line":"              parentPortCandidates: [],"},{"line_number":131,"context_line":"              // TODO sort the subports"},{"line_number":132,"context_line":"              subportCandidates: params.subportCandidates,"},{"line_number":133,"context_line":"              subportsOfInitTrunk: params.subportsOfInitTrunk"},{"line_number":134,"context_line":"            },"},{"line_number":135,"context_line":"            initTrunk: oldTrunk"},{"line_number":136,"context_line":"          }"}],"source_content_type":"text/javascript","patch_set":11,"id":"9f436f4f_8345171a","line":133,"updated":"2017-08-08 19:52:27.000000000","message":"by (segmentation type, segmentation id)","commit_id":"7762161034f6e5ac8d590d6440ab9f8132736064"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"c3b7c0f327b27d31ab08b9f2af1cb3590fbe8c70","unresolved":false,"context_lines":[{"line_number":130,"context_line":"              parentPortCandidates: [],"},{"line_number":131,"context_line":"              // TODO sort the subports"},{"line_number":132,"context_line":"              subportCandidates: params.subportCandidates,"},{"line_number":133,"context_line":"              subportsOfInitTrunk: params.subportsOfInitTrunk"},{"line_number":134,"context_line":"            },"},{"line_number":135,"context_line":"            initTrunk: oldTrunk"},{"line_number":136,"context_line":"          }"}],"source_content_type":"text/javascript","patch_set":11,"id":"9f436f4f_63957ce4","line":133,"in_reply_to":"9f436f4f_8345171a","updated":"2017-08-09 14:49:58.000000000","message":"Done","commit_id":"7762161034f6e5ac8d590d6440ab9f8132736064"}],"openstack_dashboard/static/app/core/trunks/panel.html":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"a8223fb41df143e2a73876d5acd74b6a7dde1fa7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003chz-resource-panel resource-type-name\u003d\"OS::Neutron::Trunk\"\u003e"},{"line_number":2,"context_line":"  \u003chz-resource-table resource-type-name\u003d\"OS::Neutron::Trunk\""},{"line_number":3,"context_line":"                     track-by\u003d\"track_by\"\u003e\u003c/hz-resource-table\u003e"},{"line_number":4,"context_line":"\u003c/hz-resource-panel\u003e"}],"source_content_type":"text/html","patch_set":6,"id":"df3967d1_82e7f612","line":3,"updated":"2017-08-02 12:59:04.000000000","message":"If you deployed the previous patch sets into you dev environment then you may get an older template version from $templateCache. You can drop that cache by eg. fully cleaning your horizon git repo:\n\n git clean -fdx","commit_id":"992739869aacf069adea64ac5bc6c36389ef621b"}],"openstack_dashboard/static/app/core/trunks/steps/trunk-subports.controller.js":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"b92f0aae17cc99acc046f441accddb8cdb539dfe","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    ctrl.subportsTables \u003d {"},{"line_number":99,"context_line":"      available: [].concat("},{"line_number":100,"context_line":"        $scope.ports.subportCandidates,"},{"line_number":101,"context_line":"        $scope.ports.subportsOfInitTrunk),"},{"line_number":102,"context_line":"      allocated: $scope.ports.subportsOfInitTrunk,"},{"line_number":103,"context_line":"      displayedAvailable: [],"},{"line_number":104,"context_line":"      displayedAllocated: []"}],"source_content_type":"text/javascript","patch_set":11,"id":"9f436f4f_23542bca","line":101,"range":{"start_line":100,"start_character":0,"end_line":101,"end_character":42},"updated":"2017-08-08 19:52:27.000000000","message":"reverse order?","commit_id":"7762161034f6e5ac8d590d6440ab9f8132736064"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"c3b7c0f327b27d31ab08b9f2af1cb3590fbe8c70","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    ctrl.subportsTables \u003d {"},{"line_number":99,"context_line":"      available: [].concat("},{"line_number":100,"context_line":"        $scope.ports.subportCandidates,"},{"line_number":101,"context_line":"        $scope.ports.subportsOfInitTrunk),"},{"line_number":102,"context_line":"      allocated: $scope.ports.subportsOfInitTrunk,"},{"line_number":103,"context_line":"      displayedAvailable: [],"},{"line_number":104,"context_line":"      displayedAllocated: []"}],"source_content_type":"text/javascript","patch_set":11,"id":"9f436f4f_233bf4eb","line":101,"range":{"start_line":100,"start_character":0,"end_line":101,"end_character":42},"in_reply_to":"9f436f4f_23542bca","updated":"2017-08-09 14:49:58.000000000","message":"Done","commit_id":"7762161034f6e5ac8d590d6440ab9f8132736064"}],"openstack_dashboard/static/app/core/trunks/trunks.service.js":[{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"256ed267ea9ad41508d1bdf52aded93f5322830a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            // It is weird but there are trunk updates when the revision number"},{"line_number":86,"context_line":"            // does not increase. Eg. if you only update the description of a"},{"line_number":87,"context_line":"            // trunk. So we also add \u0027updated_at\u0027 to the composite."},{"line_number":88,"context_line":"            trunk.updated_at.toISOString()"},{"line_number":89,"context_line":"          ].join(\u0027/\u0027);"},{"line_number":90,"context_line":"          return trunk;"},{"line_number":91,"context_line":"        })}};"}],"source_content_type":"text/javascript","patch_set":27,"id":"1f485f77_387df67e","line":88,"range":{"start_line":88,"start_character":18,"end_line":88,"end_character":28},"updated":"2017-11-16 09:24:08.000000000","message":"\u0027updated_at\u0027 may be string. so toISOString() causes error on test.","commit_id":"c29b22ee5c69abeffdf94f0262f65512387b7a7c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2bb3565c13f17dcf7c68fe5c17650758a68fa206","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            // It is weird but there are trunk updates when the revision number"},{"line_number":86,"context_line":"            // does not increase. Eg. if you only update the description of a"},{"line_number":87,"context_line":"            // trunk. So we also add \u0027updated_at\u0027 to the composite."},{"line_number":88,"context_line":"            trunk.updated_at.toISOString()"},{"line_number":89,"context_line":"          ].join(\u0027/\u0027);"},{"line_number":90,"context_line":"          return trunk;"},{"line_number":91,"context_line":"        })}};"}],"source_content_type":"text/javascript","patch_set":27,"id":"1f485f77_8bf6d162","line":88,"range":{"start_line":88,"start_character":18,"end_line":88,"end_character":28},"in_reply_to":"1f485f77_387df67e","updated":"2017-11-16 12:35:33.000000000","message":"actually by returning with an object that has a Date() for updated_at it can be tested.\nThanks for the feedback","commit_id":"c29b22ee5c69abeffdf94f0262f65512387b7a7c"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"4fdcdf9501c1e598058a08ac83908fbb92f52197","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            // It is weird but there are trunk updates when the revision number"},{"line_number":86,"context_line":"            // does not increase. Eg. if you only update the description of a"},{"line_number":87,"context_line":"            // trunk. So we also add \u0027updated_at\u0027 to the composite."},{"line_number":88,"context_line":"            trunk.updated_at.toISOString()"},{"line_number":89,"context_line":"          ].join(\u0027/\u0027);"},{"line_number":90,"context_line":"          return trunk;"},{"line_number":91,"context_line":"        })}};"}],"source_content_type":"text/javascript","patch_set":27,"id":"1f485f77_ab3df68f","line":88,"range":{"start_line":88,"start_character":18,"end_line":88,"end_character":28},"in_reply_to":"1f485f77_8bf6d162","updated":"2017-11-17 03:46:25.000000000","message":"I\u0027m sorry I don\u0027t have environment for trunks panel, so I can\u0027t confirm this with running. Could you check following again?\nAFAIK, the date included in the response from Angular\u0027s $http isn\u0027t parsed, also isn\u0027t converted to Date object. So \u0027update_at\u0027 should be simply concateneted as string.","commit_id":"c29b22ee5c69abeffdf94f0262f65512387b7a7c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4a69c1b060947896b8f3f9ad8edd74ae09b798fc","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            // It is weird but there are trunk updates when the revision number"},{"line_number":86,"context_line":"            // does not increase. Eg. if you only update the description of a"},{"line_number":87,"context_line":"            // trunk. So we also add \u0027updated_at\u0027 to the composite."},{"line_number":88,"context_line":"            trunk.updated_at.toISOString()"},{"line_number":89,"context_line":"          ].join(\u0027/\u0027);"},{"line_number":90,"context_line":"          return trunk;"},{"line_number":91,"context_line":"        })}};"}],"source_content_type":"text/javascript","patch_set":27,"id":"1f485f77_76efc7e8","line":88,"range":{"start_line":88,"start_character":18,"end_line":88,"end_character":28},"in_reply_to":"1f485f77_ab3df68f","updated":"2017-11-18 11:20:11.000000000","message":"It seems to work well. \nhttp://paste.openstack.org/show/626684/","commit_id":"c29b22ee5c69abeffdf94f0262f65512387b7a7c"}]}
