)]}'
{"horizon/static/framework/widgets/details/routed-details-view.controller.js":[{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"ec3b0aaae3e231f66b87bc50f063ea24f1efff10","unresolved":false,"context_lines":[{"line_number":87,"context_line":"      ctrl.itemName \u003d ctrl.resourceType.itemName(response.data);"},{"line_number":88,"context_line":"    }"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    function loadDataError() {"},{"line_number":91,"context_line":"      spinnerService.hideModalSpinner();"},{"line_number":92,"context_line":"      ctrl.showDetails \u003d false;"},{"line_number":93,"context_line":"      var url \u003d navigationsService.getActivePanelUrl();"}],"source_content_type":"text/javascript","patch_set":9,"id":"7f515b1d_b3dbad7b","line":90,"range":{"start_line":90,"start_character":13,"end_line":90,"end_character":26},"updated":"2017-10-05 08:15:54.000000000","message":"This should be renamed to \u0027loadIndexView\u0027. Please see also next comment.","commit_id":"468f05a24f95869c2859ab7f4503f006120268fc"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d2af1d6377ccd50fed167b281d903d8c3dc1f2d4","unresolved":false,"context_lines":[{"line_number":87,"context_line":"      ctrl.itemName \u003d ctrl.resourceType.itemName(response.data);"},{"line_number":88,"context_line":"    }"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    function loadDataError() {"},{"line_number":91,"context_line":"      spinnerService.hideModalSpinner();"},{"line_number":92,"context_line":"      ctrl.showDetails \u003d false;"},{"line_number":93,"context_line":"      var url \u003d navigationsService.getActivePanelUrl();"}],"source_content_type":"text/javascript","patch_set":9,"id":"7f515b1d_73195c78","line":90,"range":{"start_line":90,"start_character":13,"end_line":90,"end_character":26},"in_reply_to":"7f515b1d_b3dbad7b","updated":"2017-10-09 07:43:55.000000000","message":"Valid comment, sounds better","commit_id":"468f05a24f95869c2859ab7f4503f006120268fc"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"ec3b0aaae3e231f66b87bc50f063ea24f1efff10","unresolved":false,"context_lines":[{"line_number":100,"context_line":"      // particular action because the actions return data in a standard form."},{"line_number":101,"context_line":"      // That return includes the id and type of each created, updated, deleted"},{"line_number":102,"context_line":"      // and failed item."},{"line_number":103,"context_line":"      // Currently just refreshes the display each time."},{"line_number":104,"context_line":"      if (result) {"},{"line_number":105,"context_line":"        spinnerService.showModalSpinner(gettext(\u0027Please Wait\u0027));"},{"line_number":106,"context_line":"        ctrl.showDetails \u003d false;"},{"line_number":107,"context_line":"        ctrl.context.loadPromise \u003d ctrl.resourceType.load(ctrl.context.identifier);"}],"source_content_type":"text/javascript","patch_set":9,"id":"7f515b1d_33a0dda5","line":104,"range":{"start_line":103,"start_character":6,"end_line":104,"end_character":19},"updated":"2017-10-05 08:15:54.000000000","message":"if (result.failed.length \u003d\u003d\u003d 0 \u0026\u0026 result.deleted.length \u003e 0) {\n  // If delete action successed, details view will fail to load the resource itself.\n  // So return to index view.\n  loadIndexView();\n} else if (result) {\n  // Otherwise, just refreshes the display each time.","commit_id":"468f05a24f95869c2859ab7f4503f006120268fc"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d2af1d6377ccd50fed167b281d903d8c3dc1f2d4","unresolved":false,"context_lines":[{"line_number":100,"context_line":"      // particular action because the actions return data in a standard form."},{"line_number":101,"context_line":"      // That return includes the id and type of each created, updated, deleted"},{"line_number":102,"context_line":"      // and failed item."},{"line_number":103,"context_line":"      // Currently just refreshes the display each time."},{"line_number":104,"context_line":"      if (result) {"},{"line_number":105,"context_line":"        spinnerService.showModalSpinner(gettext(\u0027Please Wait\u0027));"},{"line_number":106,"context_line":"        ctrl.showDetails \u003d false;"},{"line_number":107,"context_line":"        ctrl.context.loadPromise \u003d ctrl.resourceType.load(ctrl.context.identifier);"}],"source_content_type":"text/javascript","patch_set":9,"id":"7f515b1d_f3054c11","line":104,"range":{"start_line":103,"start_character":6,"end_line":104,"end_character":19},"in_reply_to":"7f515b1d_33a0dda5","updated":"2017-10-09 07:43:55.000000000","message":"you are a magician....\nI had to add some extra validation to make the unit tests pass, but perhaps even those tests can be changed, as:\n\nresult always contains a dict like: {created :[], updated: [], ....}","commit_id":"468f05a24f95869c2859ab7f4503f006120268fc"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"ec3b0aaae3e231f66b87bc50f063ea24f1efff10","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        spinnerService.showModalSpinner(gettext(\u0027Please Wait\u0027));"},{"line_number":106,"context_line":"        ctrl.showDetails \u003d false;"},{"line_number":107,"context_line":"        ctrl.context.loadPromise \u003d ctrl.resourceType.load(ctrl.context.identifier);"},{"line_number":108,"context_line":"        return ctrl.context.loadPromise.then(loadData, loadDataError);"},{"line_number":109,"context_line":"      }"},{"line_number":110,"context_line":"    }"},{"line_number":111,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":9,"id":"7f515b1d_33369db6","line":108,"range":{"start_line":108,"start_character":55,"end_line":108,"end_character":68},"updated":"2017-10-05 08:15:54.000000000","message":"I can not estimate the nessecity for this, this should be renamed also to \u0027loadIndexView\u0027.","commit_id":"468f05a24f95869c2859ab7f4503f006120268fc"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d2af1d6377ccd50fed167b281d903d8c3dc1f2d4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        spinnerService.showModalSpinner(gettext(\u0027Please Wait\u0027));"},{"line_number":106,"context_line":"        ctrl.showDetails \u003d false;"},{"line_number":107,"context_line":"        ctrl.context.loadPromise \u003d ctrl.resourceType.load(ctrl.context.identifier);"},{"line_number":108,"context_line":"        return ctrl.context.loadPromise.then(loadData, loadDataError);"},{"line_number":109,"context_line":"      }"},{"line_number":110,"context_line":"    }"},{"line_number":111,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":9,"id":"7f515b1d_93105850","line":108,"range":{"start_line":108,"start_character":55,"end_line":108,"end_character":68},"in_reply_to":"7f515b1d_33369db6","updated":"2017-10-09 07:43:55.000000000","message":"It seems that it is not necessary, so I removed.","commit_id":"468f05a24f95869c2859ab7f4503f006120268fc"}],"openstack_dashboard/static/app/core/images/details/overview.controller.js":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"295ede844c85eece195bf6696abbb1dee1e4b4b3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    $scope.context.loadPromise.then(onGetImage);"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    function onGetImage(image) {"},{"line_number":43,"context_line":"      if (image.status !\u003d\u003d 404) {"},{"line_number":44,"context_line":"        ctrl.image \u003d image.data;"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        ctrl.image.properties \u003d Object.keys(ctrl.image.properties).map(function mapProps(prop) {"}],"source_content_type":"text/javascript","patch_set":1,"id":"df3967d1_7117eba5","line":43,"range":{"start_line":43,"start_character":23,"end_line":43,"end_character":30},"updated":"2017-08-04 18:27:52.000000000","message":"We should not single out the error code 404. Every 2xx code is success, anything else is failure.","commit_id":"007e8d4f5af7384dae3b2b9f5054714d6dcb0436"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4d8e0a5575f40be1b74d2e429a687dcf31aa280d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    $scope.context.loadPromise.then(onGetImage);"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    function onGetImage(image) {"},{"line_number":43,"context_line":"      if (image.status !\u003d\u003d 404) {"},{"line_number":44,"context_line":"        ctrl.image \u003d image.data;"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        ctrl.image.properties \u003d Object.keys(ctrl.image.properties).map(function mapProps(prop) {"}],"source_content_type":"text/javascript","patch_set":1,"id":"bf3e73b7_92c55891","line":43,"range":{"start_line":43,"start_character":23,"end_line":43,"end_character":30},"in_reply_to":"df3967d1_7117eba5","updated":"2017-08-09 12:36:33.000000000","message":"Done","commit_id":"007e8d4f5af7384dae3b2b9f5054714d6dcb0436"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"295ede844c85eece195bf6696abbb1dee1e4b4b3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        ctrl.projectId \u003d session.project_id;"},{"line_number":59,"context_line":"      }"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":1,"id":"df3967d1_310de38f","line":61,"updated":"2017-08-04 18:27:52.000000000","message":"I guess this empty line wasn\u0027t intentional.","commit_id":"007e8d4f5af7384dae3b2b9f5054714d6dcb0436"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4d8e0a5575f40be1b74d2e429a687dcf31aa280d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        ctrl.projectId \u003d session.project_id;"},{"line_number":59,"context_line":"      }"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":1,"id":"bf3e73b7_72c2f487","line":61,"in_reply_to":"df3967d1_310de38f","updated":"2017-08-09 12:36:33.000000000","message":"Done","commit_id":"007e8d4f5af7384dae3b2b9f5054714d6dcb0436"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"5fe4f383133422bb14f292a1a866d87c683d20ec","unresolved":false,"context_lines":[{"line_number":50,"context_line":"          return {name: prop, value: propValue};"},{"line_number":51,"context_line":"        });"},{"line_number":52,"context_line":"      } else {"},{"line_number":53,"context_line":"        ctrl.image \u003d image;"},{"line_number":54,"context_line":"      }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"      userSession.get().then(setProject);"}],"source_content_type":"text/javascript","patch_set":3,"id":"9f436f4f_72ed40ee","line":53,"updated":"2017-08-09 15:48:33.000000000","message":"What\u0027s the point of storing the non-2xx response in the controller? There\u0027s also some type confusion in ctrl.image. In the if case it will be an image. In the else case it will be a response.","commit_id":"b24c33d616608474d5334a94decc54793483385a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"103b6841210cc2e1227f4bc52ad29ecd0dbec80c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"          return {name: prop, value: propValue};"},{"line_number":51,"context_line":"        });"},{"line_number":52,"context_line":"      } else {"},{"line_number":53,"context_line":"        ctrl.image \u003d image;"},{"line_number":54,"context_line":"      }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"      userSession.get().then(setProject);"}],"source_content_type":"text/javascript","patch_set":3,"id":"9f436f4f_19e041fa","line":53,"in_reply_to":"9f436f4f_72ed40ee","updated":"2017-08-10 11:04:53.000000000","message":"True, I changed it to response, as it is really a response.\nThe panel actually uses these information (overview.html, hz-resource-property-list) and throws tons of errors of searching undefined things. By this there is no extra errors on the console, only the 404 from the API.","commit_id":"b24c33d616608474d5334a94decc54793483385a"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"5fe4f383133422bb14f292a1a866d87c683d20ec","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        ctrl.image \u003d image;"},{"line_number":54,"context_line":"      }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"      userSession.get().then(setProject);"},{"line_number":57,"context_line":"      function setProject(session) {"},{"line_number":58,"context_line":"        ctrl.projectId \u003d session.project_id;"},{"line_number":59,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":3,"id":"9f436f4f_b2ccc889","line":56,"updated":"2017-08-09 15:48:33.000000000","message":"Let\u0027s not make needless whitespace changes.","commit_id":"b24c33d616608474d5334a94decc54793483385a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"103b6841210cc2e1227f4bc52ad29ecd0dbec80c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        ctrl.image \u003d image;"},{"line_number":54,"context_line":"      }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"      userSession.get().then(setProject);"},{"line_number":57,"context_line":"      function setProject(session) {"},{"line_number":58,"context_line":"        ctrl.projectId \u003d session.project_id;"},{"line_number":59,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":3,"id":"9f436f4f_d9e199fe","line":56,"in_reply_to":"9f436f4f_b2ccc889","updated":"2017-08-10 11:04:53.000000000","message":"Done","commit_id":"b24c33d616608474d5334a94decc54793483385a"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"01b6558a768d1568c66e967271fc5f5b4bb02a57","unresolved":false,"context_lines":[{"line_number":49,"context_line":"          }"},{"line_number":50,"context_line":"          return {name: prop, value: propValue};"},{"line_number":51,"context_line":"        });"},{"line_number":52,"context_line":"      } else {"},{"line_number":53,"context_line":"        // Note (lajos katona): if the http status from the API is out of the 2xx"},{"line_number":54,"context_line":"        // range redirect back to the previous page (the images panel from the"},{"line_number":55,"context_line":"        // project or the admin dashboard)."},{"line_number":56,"context_line":"        ctrl.image \u003d response;"},{"line_number":57,"context_line":"        history.back();"},{"line_number":58,"context_line":"      }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"      userSession.get().then(setProject);"}],"source_content_type":"text/javascript","patch_set":7,"id":"9f436f4f_5eb0228c","line":57,"range":{"start_line":52,"start_character":7,"end_line":57,"end_character":23},"updated":"2017-08-18 09:23:09.000000000","message":"It is weird that this arrives in the then() handler instead of the catch() handler.","commit_id":"4b6836b08e46a726345d9e9e9238e2f74b65ad62"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4cc26f104734adc8e8ef07cc1c5951fabed97582","unresolved":false,"context_lines":[{"line_number":49,"context_line":"          }"},{"line_number":50,"context_line":"          return {name: prop, value: propValue};"},{"line_number":51,"context_line":"        });"},{"line_number":52,"context_line":"      } else {"},{"line_number":53,"context_line":"        // Note (lajos katona): if the http status from the API is out of the 2xx"},{"line_number":54,"context_line":"        // range redirect back to the previous page (the images panel from the"},{"line_number":55,"context_line":"        // project or the admin dashboard)."},{"line_number":56,"context_line":"        ctrl.image \u003d response;"},{"line_number":57,"context_line":"        history.back();"},{"line_number":58,"context_line":"      }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"      userSession.get().then(setProject);"}],"source_content_type":"text/javascript","patch_set":7,"id":"9f436f4f_5cdfd70b","line":57,"range":{"start_line":52,"start_character":7,"end_line":57,"end_character":23},"in_reply_to":"9f436f4f_5eb0228c","updated":"2017-08-21 13:11:39.000000000","message":"I made a trial both with \n* just letting angular to chain the bad result through the promises\n* using $q.reject\nBut neither of them helped to get rid of this ugly if.","commit_id":"4b6836b08e46a726345d9e9e9238e2f74b65ad62"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"944b3bc0de00f2a48810c2a8e8900932a532d985","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    $scope.context.loadPromise.then(onGetImage);"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    function onGetImage(response) {"},{"line_number":43,"context_line":"      ctrl.image \u003d response.data;"},{"line_number":44,"context_line":"      ctrl.image.properties \u003d Object.keys(ctrl.image.properties).map(function mapProps(prop) {"},{"line_number":45,"context_line":"        var propValue \u003d ctrl.image.properties[prop];"}],"source_content_type":"text/javascript","patch_set":8,"id":"7f515b1d_d730aa58","line":42,"range":{"start_line":42,"start_character":24,"end_line":42,"end_character":32},"updated":"2017-10-02 09:40:44.000000000","message":"not agree with this too","commit_id":"d8f65e7418095f775c08326763a51c4f3c47fafc"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"eea17a335952974966b05f2af30f39bf2d1c7e63","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    $scope.context.loadPromise.then(onGetImage);"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    function onGetImage(response) {"},{"line_number":43,"context_line":"      ctrl.image \u003d response.data;"},{"line_number":44,"context_line":"      ctrl.image.properties \u003d Object.keys(ctrl.image.properties).map(function mapProps(prop) {"},{"line_number":45,"context_line":"        var propValue \u003d ctrl.image.properties[prop];"}],"source_content_type":"text/javascript","patch_set":8,"id":"7f515b1d_62cdafb5","line":42,"range":{"start_line":42,"start_character":24,"end_line":42,"end_character":32},"in_reply_to":"7f515b1d_d730aa58","updated":"2017-10-02 13:45:37.000000000","message":"Good catch, this was from an earlier phase of the patch.\nThanks.","commit_id":"d8f65e7418095f775c08326763a51c4f3c47fafc"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"2c190f4cda484357863729b9bdf28de70edb76d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5f4e5783_eeb0538e","updated":"2017-10-10 03:45:56.000000000","message":"nit: can you remove the change on this file so its git history is cleaner?","commit_id":"0a2c342c5807f2832524c68cf7fc3e058d01578e"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"9dfeb642f1598a8932de46fb45ee91f852715bb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5f4e5783_c544e81d","in_reply_to":"5f4e5783_cfc0a37f","updated":"2017-10-13 03:11:10.000000000","message":"Thanks","commit_id":"0a2c342c5807f2832524c68cf7fc3e058d01578e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8f35983daf68b1f81d6984947e3001502137bbdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5f4e5783_cfc0a37f","in_reply_to":"5f4e5783_eeb0538e","updated":"2017-10-12 06:48:14.000000000","message":"Sure, sorry my fault, I missed the delete line...","commit_id":"0a2c342c5807f2832524c68cf7fc3e058d01578e"}],"openstack_dashboard/static/app/core/images/details/overview.controller.spec.js":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"5fe4f383133422bb14f292a1a866d87c683d20ec","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      var session \u003d $injector.get(\u0027horizon.app.core.openstack-service-api.userSession\u0027);"},{"line_number":31,"context_line":"      var deferred \u003d $q.defer();"},{"line_number":32,"context_line":"      var sessionDeferred \u003d $q.defer();"},{"line_number":33,"context_line":"      //deferred.resolve({data: {properties: [{\u0027a\u0027: \u0027apple\u0027}, [], {}]}});"},{"line_number":34,"context_line":"      deferred.resolve({status: 200, data: {properties: [{\u0027a\u0027: \u0027apple\u0027}, [], {}]}});"},{"line_number":35,"context_line":"      sessionDeferred.resolve(sessionObj);"},{"line_number":36,"context_line":"      spyOn(glance, \u0027getNamespaces\u0027).and.returnValue(deferred.promise);"}],"source_content_type":"text/javascript","patch_set":3,"id":"9f436f4f_528a3c1b","line":33,"updated":"2017-08-09 15:48:33.000000000","message":"If we don\u0027t need this, then it should be deleted.","commit_id":"b24c33d616608474d5334a94decc54793483385a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"103b6841210cc2e1227f4bc52ad29ecd0dbec80c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      var session \u003d $injector.get(\u0027horizon.app.core.openstack-service-api.userSession\u0027);"},{"line_number":31,"context_line":"      var deferred \u003d $q.defer();"},{"line_number":32,"context_line":"      var sessionDeferred \u003d $q.defer();"},{"line_number":33,"context_line":"      //deferred.resolve({data: {properties: [{\u0027a\u0027: \u0027apple\u0027}, [], {}]}});"},{"line_number":34,"context_line":"      deferred.resolve({status: 200, data: {properties: [{\u0027a\u0027: \u0027apple\u0027}, [], {}]}});"},{"line_number":35,"context_line":"      sessionDeferred.resolve(sessionObj);"},{"line_number":36,"context_line":"      spyOn(glance, \u0027getNamespaces\u0027).and.returnValue(deferred.promise);"}],"source_content_type":"text/javascript","patch_set":3,"id":"9f436f4f_b9f015cb","line":33,"in_reply_to":"9f436f4f_528a3c1b","updated":"2017-08-10 11:04:53.000000000","message":"Done","commit_id":"b24c33d616608474d5334a94decc54793483385a"}],"openstack_dashboard/static/app/core/images/images.service.js":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"5fe4f383133422bb14f292a1a866d87c683d20ec","unresolved":false,"context_lines":[{"line_number":152,"context_line":"      }"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"      function getImageError(response) {"},{"line_number":155,"context_line":"        history.back();"},{"line_number":156,"context_line":"        return response;"},{"line_number":157,"context_line":"      }"},{"line_number":158,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":3,"id":"9f436f4f_329a1814","line":155,"range":{"start_line":155,"start_character":8,"end_line":155,"end_character":23},"updated":"2017-08-09 15:48:33.000000000","message":"This will send the user back even if the error was not a result of trying to delete an image from the image details view. In that case I don\u0027t think this desirable.","commit_id":"b24c33d616608474d5334a94decc54793483385a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"23912b1762f29d84ec5832a0e8b2c49bde50c4d8","unresolved":false,"context_lines":[{"line_number":152,"context_line":"      }"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"      function getImageError(response) {"},{"line_number":155,"context_line":"        history.back();"},{"line_number":156,"context_line":"        return response;"},{"line_number":157,"context_line":"      }"},{"line_number":158,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":3,"id":"9f436f4f_b90be38b","line":155,"range":{"start_line":155,"start_character":8,"end_line":155,"end_character":23},"in_reply_to":"9f436f4f_329a1814","updated":"2017-08-16 13:00:57.000000000","message":"True. I moved the history.back() operation to the overview.controller, with that I hope I will only redirect back to images panel in case the error happens during the loading of details panel.","commit_id":"b24c33d616608474d5334a94decc54793483385a"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"01b6558a768d1568c66e967271fc5f5b4bb02a57","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        return response;"},{"line_number":152,"context_line":"      }"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"      function getImageError(response) {"},{"line_number":155,"context_line":"        return response;"},{"line_number":156,"context_line":"      }"},{"line_number":157,"context_line":"    }"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    /*"}],"source_content_type":"text/javascript","patch_set":7,"id":"9f436f4f_be4f0e91","line":156,"range":{"start_line":154,"start_character":0,"end_line":156,"end_character":7},"updated":"2017-08-18 09:23:09.000000000","message":"Maybe this is the reason for the stange behavior I commented on in the other file. Don\u0027t we suppress an error here and push it back to the then() branch?","commit_id":"4b6836b08e46a726345d9e9e9238e2f74b65ad62"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4cc26f104734adc8e8ef07cc1c5951fabed97582","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        return response;"},{"line_number":152,"context_line":"      }"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"      function getImageError(response) {"},{"line_number":155,"context_line":"        return response;"},{"line_number":156,"context_line":"      }"},{"line_number":157,"context_line":"    }"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    /*"}],"source_content_type":"text/javascript","patch_set":7,"id":"9f436f4f_1c026f70","line":156,"range":{"start_line":154,"start_character":0,"end_line":156,"end_character":7},"in_reply_to":"9f436f4f_be4f0e91","updated":"2017-08-21 13:11:39.000000000","message":"I tried to just letting this out or instead using $q.reject,\n but neither of them resulted in the reject really chaining to overview controller....","commit_id":"4b6836b08e46a726345d9e9e9238e2f74b65ad62"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"944b3bc0de00f2a48810c2a8e8900932a532d985","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      function modifyResponse(response) {"},{"line_number":150,"context_line":"        response.data.apiVersion \u003d version;"},{"line_number":151,"context_line":"        return response;"},{"line_number":152,"context_line":"      }"},{"line_number":153,"context_line":"    }"},{"line_number":154,"context_line":""}],"source_content_type":"text/javascript","patch_set":8,"id":"7f515b1d_b7fe4e68","line":151,"range":{"start_line":151,"start_character":15,"end_line":151,"end_character":23},"updated":"2017-10-02 09:40:44.000000000","message":"this is a bad idea.\nif you want to change this, you should change the same thing in L127 too.","commit_id":"d8f65e7418095f775c08326763a51c4f3c47fafc"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"eea17a335952974966b05f2af30f39bf2d1c7e63","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      function modifyResponse(response) {"},{"line_number":150,"context_line":"        response.data.apiVersion \u003d version;"},{"line_number":151,"context_line":"        return response;"},{"line_number":152,"context_line":"      }"},{"line_number":153,"context_line":"    }"},{"line_number":154,"context_line":""}],"source_content_type":"text/javascript","patch_set":8,"id":"7f515b1d_02befbfd","line":151,"range":{"start_line":151,"start_character":15,"end_line":151,"end_character":23},"in_reply_to":"7f515b1d_b7fe4e68","updated":"2017-10-02 13:45:37.000000000","message":"Good catch. This was changed to response when in the patch I use some part of the http response, now that is unnecessary.\nThanks.","commit_id":"d8f65e7418095f775c08326763a51c4f3c47fafc"}]}
