)]}'
{"openstack_dashboard/dashboards/project/networks/subnets/tables.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c982758ac4c51f321030825af05be7f84ae40f85","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def get_policy_target(self, request, datum\u003dNone):"},{"line_number":37,"context_line":"        policy_target \u003d super(SubnetPolicyTargetMixin, self)\\"},{"line_number":38,"context_line":"            .get_policy_target(request, datum)"},{"line_number":39,"context_line":"        if \"tenant_id\" in datum:"},{"line_number":40,"context_line":"            network \u003d datum"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            network \u003d self.table._get_network()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_f0893526","line":39,"updated":"2017-09-11 19:19:43.000000000","message":"This code looks a bit hacky. Could you please add some comments here?","commit_id":"dc5edfe1e62a3347177ac6d48047ec880b7b1932"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"83e4c8f98db807170136bff2c49f78937a124ecd","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def get_policy_target(self, request, datum\u003dNone):"},{"line_number":37,"context_line":"        policy_target \u003d super(SubnetPolicyTargetMixin, self)\\"},{"line_number":38,"context_line":"            .get_policy_target(request, datum)"},{"line_number":39,"context_line":"        if \"tenant_id\" in datum:"},{"line_number":40,"context_line":"            network \u003d datum"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            network \u003d self.table._get_network()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_26268bb9","line":39,"in_reply_to":"5f2577a7_f0893526","updated":"2017-09-22 02:15:28.000000000","message":"Done","commit_id":"dc5edfe1e62a3347177ac6d48047ec880b7b1932"}],"openstack_dashboard/dashboards/project/networks/tables.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9dba5c272c178fb69deee41043f8844a9725a8db","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from horizon import tables"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from openstack_dashboard import api"},{"line_number":27,"context_line":"from openstack_dashboard.dashboards.project.networks.subnets.tables \\"},{"line_number":28,"context_line":"    import SubnetPolicyTargetMixin"},{"line_number":29,"context_line":"from openstack_dashboard import policy"},{"line_number":30,"context_line":"from openstack_dashboard.usage import quotas"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_3201a006","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":34},"updated":"2017-10-14 08:54:38.000000000","message":"This style of import is discouraged in the OpenStack coding guideline [1]. Could you honor it?\n\n  from openstack_dashboard.dashboards.project.networks.subnets import tables as subnet_tables\n\n[1] the first item of https://docs.openstack.org/hacking/latest/user/hacking.html#imports","commit_id":"579cf519537bc31919be374856f30107642bf687"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"85a597a3b59f35a041ce5b621211ba8ea921199f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from horizon import tables"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from openstack_dashboard import api"},{"line_number":27,"context_line":"from openstack_dashboard.dashboards.project.networks.subnets.tables \\"},{"line_number":28,"context_line":"    import SubnetPolicyTargetMixin"},{"line_number":29,"context_line":"from openstack_dashboard import policy"},{"line_number":30,"context_line":"from openstack_dashboard.usage import quotas"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_b28a30bc","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":34},"in_reply_to":"5f4e5783_3201a006","updated":"2017-10-14 10:37:28.000000000","message":"Done","commit_id":"579cf519537bc31919be374856f30107642bf687"}]}
