)]}'
{"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/source/source.controller.js":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"a948a318404734ea22114d21028870fd27c32fad","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    function updateBootSourceSelection(selectedSource) {"},{"line_number":431,"context_line":"      if (ctrl.currentBootSource !\u003d\u003d selectedSource) {"},{"line_number":432,"context_line":"        ctrl.selection.length \u003d 0;"},{"line_number":433,"context_line":"        ctrl.currentBootSource \u003d selectedSource;"},{"line_number":434,"context_line":"      }"},{"line_number":435,"context_line":"      if ((selectedSource \u003d\u003d\u003d bootSourceTypes.IMAGE ||"}],"source_content_type":"text/javascript","patch_set":5,"id":"7f287b81_5669b31e","line":432,"updated":"2017-08-28 12:39:13.000000000","message":"What is this line actually doing? I\u0027m finding it difficult to get my head around this without context.","commit_id":"48862eb9b7f5789dee3362d9103416628c5d3e76"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"7e392abbe3551b6988ddfb6d6f9ee7c2fd3c307f","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    function updateBootSourceSelection(selectedSource) {"},{"line_number":431,"context_line":"      if (ctrl.currentBootSource !\u003d\u003d selectedSource) {"},{"line_number":432,"context_line":"        ctrl.selection.length \u003d 0;"},{"line_number":433,"context_line":"        ctrl.currentBootSource \u003d selectedSource;"},{"line_number":434,"context_line":"      }"},{"line_number":435,"context_line":"      if ((selectedSource \u003d\u003d\u003d bootSourceTypes.IMAGE ||"}],"source_content_type":"text/javascript","patch_set":5,"id":"7f287b81_764eef97","line":432,"in_reply_to":"7f287b81_5669b31e","updated":"2017-08-28 12:47:31.000000000","message":"Not my patch but I\u0027d read this line as: \"clear the current selection\".","commit_id":"48862eb9b7f5789dee3362d9103416628c5d3e76"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"4c4dc4b3bedc45afe4c5d8748be961017bcfed2d","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    function updateBootSourceSelection(selectedSource) {"},{"line_number":431,"context_line":"      if (ctrl.currentBootSource !\u003d\u003d selectedSource) {"},{"line_number":432,"context_line":"        ctrl.selection.length \u003d 0;"},{"line_number":433,"context_line":"        ctrl.currentBootSource \u003d selectedSource;"},{"line_number":434,"context_line":"      }"},{"line_number":435,"context_line":"      if ((selectedSource \u003d\u003d\u003d bootSourceTypes.IMAGE ||"}],"source_content_type":"text/javascript","patch_set":5,"id":"7f287b81_e957a057","line":432,"in_reply_to":"7f287b81_764eef97","updated":"2017-08-28 13:08:29.000000000","message":"yep, this was my intention.","commit_id":"48862eb9b7f5789dee3362d9103416628c5d3e76"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/source/source.controller.spec.js":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"dbc30b4df6f26b5326cee7d67ad3f2dad282dfe8","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            expect(scope.$broadcast).toHaveBeenCalled();"},{"line_number":292,"context_line":"          });"},{"line_number":293,"context_line":"        });"},{"line_number":294,"context_line":"        describe(\u0027updateDataSource\u0027, function() {"},{"line_number":295,"context_line":"          it(\u0027should not update selection on undefined pre selection\u0027, function()){"},{"line_number":296,"context_line":"            ctrl.selection \u003d [\u0027image\u0027]"},{"line_number":297,"context_line":"            ctrl.updateDataSource(\u0027image\u0027, undefined)"},{"line_number":298,"context_line":"            scope.$apply();"},{"line_number":299,"context_line":"            except(ctrl.selection).toEqual([\u0027image\u0027])"},{"line_number":300,"context_line":"          }"},{"line_number":301,"context_line":"        }"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        describe(\u0027source allocation\u0027, function() {"},{"line_number":304,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"9f436f4f_311d8cbd","line":301,"range":{"start_line":294,"start_character":8,"end_line":301,"end_character":9},"updated":"2017-08-18 12:14:52.000000000","message":"it should be \nit(\u0027should not update selection on undefined pre selection\u0027,\n     function(){\n            ctrl.selection \u003d [\u0027image\u0027]\n            ctrl.updateDataSource(\u0027image\u0027, undefined)\n            scope.$apply();\n            except(ctrl.selection).toEqual([\u0027image\u0027])\n          }\n)","commit_id":"e86443f965d324191b94ffc261475e365e1528f8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c74f0d6136f477d22855eb2ef0bd2cc8cfb00edb","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            expect(scope.$broadcast).toHaveBeenCalled();"},{"line_number":292,"context_line":"          });"},{"line_number":293,"context_line":"          it(\u0027should not flush selection if boot source still the same\u0027, function(){"},{"line_number":294,"context_line":"            ctrl.currentBootSource \u003d\u0027image\u0027"},{"line_number":295,"context_line":"            ctrl.selection \u003d [\u0027test_selection\u0027]"},{"line_number":296,"context_line":"            ctrl.updateBootSourceSelection(\u0027image\u0027)"},{"line_number":297,"context_line":"            scope.$apply();"}],"source_content_type":"text/javascript","patch_set":2,"id":"9f436f4f_695f960e","line":294,"updated":"2017-08-19 08:27:20.000000000","message":"semicolon is needed at EOL","commit_id":"4ae0417dc857c44ce7d537aca319fe1e9f82473e"}]}