)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"28c573508d4752b3823230eee05af658d95be514","unresolved":false,"context_lines":[{"line_number":10,"context_line":"table. This patch resolves that issue by re-using the pagination"},{"line_number":11,"context_line":"code for flavors."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"It also supports Ying Zuo\u0027s scenario:"},{"line_number":14,"context_line":"After I set only 1 item per page and deleted the instance on the first page,"},{"line_number":15,"context_line":"the expected behavior is showing the next instance in the table after one is"},{"line_number":16,"context_line":"deleted."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1514678"},{"line_number":19,"context_line":"Closes-Bug: #1274427"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"5f2577a7_f3eed686","line":16,"range":{"start_line":13,"start_character":0,"end_line":16,"end_character":8},"updated":"2019-01-02 09:59:55.000000000","message":"I should delete this.","commit_id":"75d46127fd94cb0b0270c47cbe8bfc5ee91a89a9"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"219d59a6102b0bc531ca82f822979ba8ae3e7ca8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"the expected behavior is showing the next instance in the table after one is"},{"line_number":16,"context_line":"deleted."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1514678"},{"line_number":19,"context_line":"Closes-Bug: #1274427"},{"line_number":20,"context_line":"Co-Authored-By: Dmitry Ratushnyy \u003cdratushn@cisco.com\u003e"},{"line_number":21,"context_line":"Change-Id: Id8eaae6bf1b5d6f42291291655e14b8715c08bc8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"7f515b1d_1f8658ba","line":18,"updated":"2017-10-02 13:36:48.000000000","message":"This bug tagged as duplicate of #1274427","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"e0f91242032bcc2c9232b8805ffbb15f53f31913","unresolved":false,"context_lines":[{"line_number":15,"context_line":"the expected behavior is showing the next instance in the table after one is"},{"line_number":16,"context_line":"deleted."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1514678"},{"line_number":19,"context_line":"Closes-Bug: #1274427"},{"line_number":20,"context_line":"Co-Authored-By: Dmitry Ratushnyy \u003cdratushn@cisco.com\u003e"},{"line_number":21,"context_line":"Change-Id: Id8eaae6bf1b5d6f42291291655e14b8715c08bc8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"7f515b1d_5a44d073","line":18,"in_reply_to":"7f515b1d_1f8658ba","updated":"2017-10-03 06:49:29.000000000","message":"This was the original bug the patch is made for. Launchpad doesn\u0027t know about this duplicate relation.","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"78a6e235bccb51af2294b433bf7c54bb31d551ab","unresolved":false,"context_lines":[{"line_number":15,"context_line":"the expected behavior is showing the next instance in the table after one is"},{"line_number":16,"context_line":"deleted."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1514678"},{"line_number":19,"context_line":"Closes-Bug: #1274427"},{"line_number":20,"context_line":"Co-Authored-By: Dmitry Ratushnyy \u003cdratushn@cisco.com\u003e"},{"line_number":21,"context_line":"Change-Id: Id8eaae6bf1b5d6f42291291655e14b8715c08bc8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"7f515b1d_fcfb7475","line":18,"in_reply_to":"7f515b1d_5a44d073","updated":"2017-10-03 12:04:55.000000000","message":"You can see \"This bug report is a duplicate of:  Bug #1274427: Instance list pagination. \" in launchpad. Launchpad know about it.","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"dfcae02bd39ff09c677f100a42c9df95817c060c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"the expected behavior is showing the next instance in the table after one is"},{"line_number":16,"context_line":"deleted."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1514678"},{"line_number":19,"context_line":"Closes-Bug: #1274427"},{"line_number":20,"context_line":"Co-Authored-By: Dmitry Ratushnyy \u003cdratushn@cisco.com\u003e"},{"line_number":21,"context_line":"Change-Id: Id8eaae6bf1b5d6f42291291655e14b8715c08bc8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"7f515b1d_9462d4ac","line":18,"in_reply_to":"7f515b1d_fcfb7475","updated":"2017-10-05 11:46:22.000000000","message":"Done","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"}],"openstack_dashboard/api/nova.py":[{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"e28953b7c5a29f5d802aca239187e19a43469fc0","unresolved":false,"context_lines":[{"line_number":502,"context_line":"    # Tagging the deleted server with the token guarantees that"},{"line_number":503,"context_line":"    # only the view listing the servers will recognize it as own"},{"line_number":504,"context_line":"    # DeleteInstance action performed"},{"line_number":505,"context_line":"    if isinstance(SERVER_DELETED, dict):"},{"line_number":506,"context_line":"        SERVER_DELETED.update("},{"line_number":507,"context_line":"            {request.user.token.id: instance_id})"},{"line_number":508,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_b17602a4","line":505,"updated":"2017-09-25 13:45:53.000000000","message":"What if \u0027SERVER_DELETED \u003d None\u0027 as on 60 line?","commit_id":"32df137d1fc43748dc510695cf4e9b92884bd4b7"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"4b05667c3a11ae03d5dbc9ccdd685d48ca24d2d5","unresolved":false,"context_lines":[{"line_number":502,"context_line":"    # Tagging the deleted server with the token guarantees that"},{"line_number":503,"context_line":"    # only the view listing the servers will recognize it as own"},{"line_number":504,"context_line":"    # DeleteInstance action performed"},{"line_number":505,"context_line":"    if isinstance(SERVER_DELETED, dict):"},{"line_number":506,"context_line":"        SERVER_DELETED.update("},{"line_number":507,"context_line":"            {request.user.token.id: instance_id})"},{"line_number":508,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_d874e16a","line":505,"in_reply_to":"7f515b1d_b17602a4","updated":"2017-09-26 10:28:19.000000000","message":"server_list_paged() would like to receive notifications in a special case and We don\u0027t want to add the entry if it won\u0027t get processed/purged. So the notification semaphore is off by default.","commit_id":"32df137d1fc43748dc510695cf4e9b92884bd4b7"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"e28953b7c5a29f5d802aca239187e19a43469fc0","unresolved":false,"context_lines":[{"line_number":542,"context_line":"    else:"},{"line_number":543,"context_line":"        SERVER_DELETED \u003d None"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    if search_opts.get(\u0027all_tenants\u0027, False) is not True:"},{"line_number":546,"context_line":"        search_opts[\u0027project_id\u0027] \u003d request.user.tenant_id"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    if search_opts.pop(\u0027paginate\u0027, False):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_71b88a75","line":545,"updated":"2017-09-25 13:45:53.000000000","message":"Please, use `if not search_opts.get(\u0027all_tenants\u0027, False):`\nDo we need `search_opts[\u0027all_tenants\u0027] \u003d True` if the previous condition is not true as in original function?","commit_id":"32df137d1fc43748dc510695cf4e9b92884bd4b7"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"4b05667c3a11ae03d5dbc9ccdd685d48ca24d2d5","unresolved":false,"context_lines":[{"line_number":542,"context_line":"    else:"},{"line_number":543,"context_line":"        SERVER_DELETED \u003d None"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    if search_opts.get(\u0027all_tenants\u0027, False) is not True:"},{"line_number":546,"context_line":"        search_opts[\u0027project_id\u0027] \u003d request.user.tenant_id"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    if search_opts.pop(\u0027paginate\u0027, False):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_bb935fa3","line":545,"in_reply_to":"7f515b1d_71b88a75","updated":"2017-09-26 10:28:19.000000000","message":"No we don\u0027t I think. all_tenants just have extracted from the dict. If it not present in the dict We just stuff the project id. I was in the mood to refactor 521-525, thanks for this recommendation.","commit_id":"32df137d1fc43748dc510695cf4e9b92884bd4b7"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"e28953b7c5a29f5d802aca239187e19a43469fc0","unresolved":false,"context_lines":[{"line_number":593,"context_line":""},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"@profiler.trace"},{"line_number":596,"context_line":"def server_list(request, search_opts\u003dNone, detailed\u003dTrue):"},{"line_number":597,"context_line":"    (servers, has_more_data, _) \u003d server_list_paged(request,"},{"line_number":598,"context_line":"                                                    search_opts,"},{"line_number":599,"context_line":"                                                    detailed)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_7109aa2a","line":596,"updated":"2017-09-25 13:45:53.000000000","message":"Do we actually need this function? We can replace all occurrences on server_list_paged, but we should be so accurate with it.","commit_id":"32df137d1fc43748dc510695cf4e9b92884bd4b7"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"4b05667c3a11ae03d5dbc9ccdd685d48ca24d2d5","unresolved":false,"context_lines":[{"line_number":593,"context_line":""},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"@profiler.trace"},{"line_number":596,"context_line":"def server_list(request, search_opts\u003dNone, detailed\u003dTrue):"},{"line_number":597,"context_line":"    (servers, has_more_data, _) \u003d server_list_paged(request,"},{"line_number":598,"context_line":"                                                    search_opts,"},{"line_number":599,"context_line":"                                                    detailed)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_fbe0b7fc","line":596,"in_reply_to":"7f515b1d_7109aa2a","updated":"2017-09-26 10:28:19.000000000","message":"server_list() remained since the the function can be called from the cli as well not just from django. For django I have enhanced the pagination logic - _paged() version, I followed the concepts of flavor listing. Note that the test code base should be refactored heavily if we drop server_list().","commit_id":"32df137d1fc43748dc510695cf4e9b92884bd4b7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"30f195a3f7b6a1db81d9486b04f4bb7062c0e0a3","unresolved":false,"context_lines":[{"line_number":537,"context_line":""},{"line_number":538,"context_line":"    # Turn the semaphore on in this special case"},{"line_number":539,"context_line":"    if page_size \u003d\u003d 1:"},{"line_number":540,"context_line":"        if SERVER_DELETED is None:"},{"line_number":541,"context_line":"            SERVER_DELETED \u003d {}"},{"line_number":542,"context_line":"    else:"},{"line_number":543,"context_line":"        SERVER_DELETED \u003d None"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f515b1d_abb98215","line":540,"updated":"2017-09-28 09:59:00.000000000","message":"SERVER_DELETED will always contain only one key-value pair. Do we really need a dict?","commit_id":"1341da948ec674a0135012ef589de9fe0093fa3f"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"f1da926a44176b4117806743d6becdfb8c42cb8b","unresolved":false,"context_lines":[{"line_number":537,"context_line":""},{"line_number":538,"context_line":"    # Turn the semaphore on in this special case"},{"line_number":539,"context_line":"    if page_size \u003d\u003d 1:"},{"line_number":540,"context_line":"        if SERVER_DELETED is None:"},{"line_number":541,"context_line":"            SERVER_DELETED \u003d {}"},{"line_number":542,"context_line":"    else:"},{"line_number":543,"context_line":"        SERVER_DELETED \u003d None"}],"source_content_type":"text/x-python","patch_set":18,"id":"7f515b1d_91ba746b","line":540,"in_reply_to":"7f515b1d_abb98215","updated":"2017-09-28 13:44:04.000000000","message":"This is a global variable. consider more than one user executes the Delete action at the same time.","commit_id":"1341da948ec674a0135012ef589de9fe0093fa3f"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"391647041650dff943ee10b2fc3e737aabe77052","unresolved":false,"context_lines":[{"line_number":502,"context_line":"    # Tagging the deleted server with the token guarantees that"},{"line_number":503,"context_line":"    # only the view listing the servers will recognize it as own"},{"line_number":504,"context_line":"    # DeleteInstance action performed"},{"line_number":505,"context_line":"    SERVER_DELETED.update({request.user.token.id: instance_id})"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"def get_novaclient_with_locked_status(request):"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f515b1d_e9c9715a","line":505,"updated":"2017-10-03 13:44:19.000000000","message":"What happens when Horizon is running on several different servers that are load balanced, and each request can be handled by a different server?","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"dfcae02bd39ff09c677f100a42c9df95817c060c","unresolved":false,"context_lines":[{"line_number":502,"context_line":"    # Tagging the deleted server with the token guarantees that"},{"line_number":503,"context_line":"    # only the view listing the servers will recognize it as own"},{"line_number":504,"context_line":"    # DeleteInstance action performed"},{"line_number":505,"context_line":"    SERVER_DELETED.update({request.user.token.id: instance_id})"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"def get_novaclient_with_locked_status(request):"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f515b1d_146ee495","line":505,"in_reply_to":"7f515b1d_e9c9715a","updated":"2017-10-05 11:46:22.000000000","message":"Considered, done.","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"cc4c04a6f3b98971d0f53a07dc5abad8759922d0","unresolved":false,"context_lines":[{"line_number":520,"context_line":"def server_list_paged(request,"},{"line_number":521,"context_line":"                      search_opts\u003dNone,"},{"line_number":522,"context_line":"                      detailed\u003dTrue,"},{"line_number":523,"context_line":"                      marker\u003dNone,"},{"line_number":524,"context_line":"                      sort_dir\u003d\"desc\","},{"line_number":525,"context_line":"                      sort_key\u003d\"uuid\","},{"line_number":526,"context_line":"                      reversed_order\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f515b1d_e24d1f3b","line":523,"updated":"2017-10-02 13:48:53.000000000","message":"we","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"e0f91242032bcc2c9232b8805ffbb15f53f31913","unresolved":false,"context_lines":[{"line_number":520,"context_line":"def server_list_paged(request,"},{"line_number":521,"context_line":"                      search_opts\u003dNone,"},{"line_number":522,"context_line":"                      detailed\u003dTrue,"},{"line_number":523,"context_line":"                      marker\u003dNone,"},{"line_number":524,"context_line":"                      sort_dir\u003d\"desc\","},{"line_number":525,"context_line":"                      sort_key\u003d\"uuid\","},{"line_number":526,"context_line":"                      reversed_order\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f515b1d_facdbc5c","line":523,"in_reply_to":"7f515b1d_e24d1f3b","updated":"2017-10-03 06:49:29.000000000","message":"???","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"78a6e235bccb51af2294b433bf7c54bb31d551ab","unresolved":false,"context_lines":[{"line_number":520,"context_line":"def server_list_paged(request,"},{"line_number":521,"context_line":"                      search_opts\u003dNone,"},{"line_number":522,"context_line":"                      detailed\u003dTrue,"},{"line_number":523,"context_line":"                      marker\u003dNone,"},{"line_number":524,"context_line":"                      sort_dir\u003d\"desc\","},{"line_number":525,"context_line":"                      sort_key\u003d\"uuid\","},{"line_number":526,"context_line":"                      reversed_order\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f515b1d_7c2d44fc","line":523,"in_reply_to":"7f515b1d_e24d1f3b","updated":"2017-10-03 12:04:55.000000000","message":"Done","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"219d59a6102b0bc531ca82f822979ba8ae3e7ca8","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        search_opts[\u0027project_id\u0027] \u003d request.user.tenant_id"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"    if search_opts.pop(\u0027paginate\u0027, False):"},{"line_number":539,"context_line":"        if reversed_order:"},{"line_number":540,"context_line":"            sort_dir \u003d \u0027desc\u0027 if sort_dir \u003d\u003d \u0027asc\u0027 else \u0027asc\u0027"},{"line_number":541,"context_line":"        deleted \u003d SERVER_DELETED.pop(request.user.token.id,"},{"line_number":542,"context_line":"                                     None)"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f515b1d_e243df3d","line":539,"updated":"2017-10-02 13:36:48.000000000","message":"Do we actually need this variable when we have sort_dir variable?","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"e0f91242032bcc2c9232b8805ffbb15f53f31913","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        search_opts[\u0027project_id\u0027] \u003d request.user.tenant_id"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"    if search_opts.pop(\u0027paginate\u0027, False):"},{"line_number":539,"context_line":"        if reversed_order:"},{"line_number":540,"context_line":"            sort_dir \u003d \u0027desc\u0027 if sort_dir \u003d\u003d \u0027asc\u0027 else \u0027asc\u0027"},{"line_number":541,"context_line":"        deleted \u003d SERVER_DELETED.pop(request.user.token.id,"},{"line_number":542,"context_line":"                                     None)"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f515b1d_fa3b7c34","line":539,"in_reply_to":"7f515b1d_e243df3d","updated":"2017-10-03 06:49:29.000000000","message":"Yes we have. If we are called with PREV_MARKER we ask nova an ascending list, however the view list the instances in descending order.","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"219d59a6102b0bc531ca82f822979ba8ae3e7ca8","unresolved":false,"context_lines":[{"line_number":546,"context_line":"                search_opts[\u0027marker\u0027] \u003d deleted"},{"line_number":547,"context_line":"            else:"},{"line_number":548,"context_line":"                search_opts[\u0027marker\u0027] \u003d marker"},{"line_number":549,"context_line":"        elif deleted is not None:"},{"line_number":550,"context_line":"            search_opts[\u0027marker\u0027] \u003d deleted"},{"line_number":551,"context_line":"        search_opts[\u0027limit\u0027] \u003d page_size + 1"},{"line_number":552,"context_line":"        search_opts[\u0027sort_dir\u0027] \u003d sort_dir"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f515b1d_5f3cd0df","line":549,"updated":"2017-10-02 13:36:48.000000000","message":"It seems that this condition is met in both cases, when \"marker \u003d\u003d True\" and when \"marker \u003d\u003d False\"","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"e0f91242032bcc2c9232b8805ffbb15f53f31913","unresolved":false,"context_lines":[{"line_number":546,"context_line":"                search_opts[\u0027marker\u0027] \u003d deleted"},{"line_number":547,"context_line":"            else:"},{"line_number":548,"context_line":"                search_opts[\u0027marker\u0027] \u003d marker"},{"line_number":549,"context_line":"        elif deleted is not None:"},{"line_number":550,"context_line":"            search_opts[\u0027marker\u0027] \u003d deleted"},{"line_number":551,"context_line":"        search_opts[\u0027limit\u0027] \u003d page_size + 1"},{"line_number":552,"context_line":"        search_opts[\u0027sort_dir\u0027] \u003d sort_dir"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f515b1d_5a8170c2","line":549,"in_reply_to":"7f515b1d_5f3cd0df","updated":"2017-10-03 06:49:29.000000000","message":"Thanks to hit this bug. We should set the searching marker this case if the server list in nova longer than the page size.","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"},{"author":{"_account_id":25946,"name":"Wangliangyu","email":"wangly2097@chinaunicom.cn","username":"wangliangyu"},"change_message_id":"9225bb1f6e0c6868cf45c0d8efde0012a7d3f299","unresolved":false,"context_lines":[{"line_number":520,"context_line":"    # by reference in python. Quote from django\u0027s developer manual:"},{"line_number":521,"context_line":"    # \" You can read it and write to request.session at any point"},{"line_number":522,"context_line":"    #   in your view. You can edit it multiple times.\""},{"line_number":523,"context_line":"    request.session[\u0027server_deleted\u0027] \u003d instance_id"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"def get_novaclient_with_locked_status(request):"}],"source_content_type":"text/x-python","patch_set":25,"id":"df87a7cf_b64dfec5","line":523,"range":{"start_line":523,"start_character":4,"end_line":523,"end_character":51},"updated":"2017-12-13 02:50:32.000000000","message":"This is no needed,in my opinion.","commit_id":"494cea7a7ccd5d4c93bf04885b957fec0c396d74"},{"author":{"_account_id":25946,"name":"Wangliangyu","email":"wangly2097@chinaunicom.cn","username":"wangliangyu"},"change_message_id":"9225bb1f6e0c6868cf45c0d8efde0012a7d3f299","unresolved":false,"context_lines":[{"line_number":562,"context_line":"                  (\u0027server_deleted\u0027 in request.session))"},{"line_number":563,"context_line":"        deleted \u003d request.session.pop(\u0027server_deleted\u0027,"},{"line_number":564,"context_line":"                                      None)"},{"line_number":565,"context_line":"        view_marker \u003d \u0027possibly_deleted\u0027 if deleted and marker else \u0027ok\u0027"},{"line_number":566,"context_line":"        search_opts[\u0027marker\u0027] \u003d deleted if deleted else marker"},{"line_number":567,"context_line":"        search_opts[\u0027limit\u0027] \u003d page_size + 1"},{"line_number":568,"context_line":"        search_opts[\u0027sort_dir\u0027] \u003d sort_dir"},{"line_number":569,"context_line":"        servers \u003d [Server(s, request)"}],"source_content_type":"text/x-python","patch_set":25,"id":"df87a7cf_56d4b2bd","line":566,"range":{"start_line":565,"start_character":8,"end_line":566,"end_character":61},"updated":"2017-12-13 02:50:32.000000000","message":"ditto","commit_id":"494cea7a7ccd5d4c93bf04885b957fec0c396d74"},{"author":{"_account_id":25946,"name":"Wangliangyu","email":"wangly2097@chinaunicom.cn","username":"wangliangyu"},"change_message_id":"9225bb1f6e0c6868cf45c0d8efde0012a7d3f299","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        search_opts[\u0027sort_dir\u0027] \u003d sort_dir"},{"line_number":569,"context_line":"        servers \u003d [Server(s, request)"},{"line_number":570,"context_line":"                   for s in nova_client.servers.list(detailed, search_opts)]"},{"line_number":571,"context_line":"        if view_marker \u003d\u003d \u0027possibly_deleted\u0027:"},{"line_number":572,"context_line":"            if len(servers) \u003d\u003d 0:"},{"line_number":573,"context_line":"                view_marker \u003d \u0027head_deleted\u0027"},{"line_number":574,"context_line":"                search_opts[\u0027sort_dir\u0027] \u003d \u0027desc\u0027"},{"line_number":575,"context_line":"                reversed_order \u003d False"},{"line_number":576,"context_line":"                servers \u003d [Server(s, request)"},{"line_number":577,"context_line":"                           for s in nova_client.servers.list(detailed,"},{"line_number":578,"context_line":"                                                             search_opts)]"},{"line_number":579,"context_line":"            if len(servers) \u003d\u003d 0:"},{"line_number":580,"context_line":"                view_marker \u003d \u0027tail_deleted\u0027"},{"line_number":581,"context_line":"                search_opts[\u0027sort_dir\u0027] \u003d \u0027asc\u0027"},{"line_number":582,"context_line":"                reversed_order \u003d True"},{"line_number":583,"context_line":"                servers \u003d [Server(s, request)"},{"line_number":584,"context_line":"                           for s in nova_client.servers.list(detailed,"},{"line_number":585,"context_line":"                                                             search_opts)]"},{"line_number":586,"context_line":"        (servers, has_more_data, has_prev_data) \u003d update_pagination("},{"line_number":587,"context_line":"            servers, page_size, marker, reversed_order)"},{"line_number":588,"context_line":"        has_prev_data \u003d (False"}],"source_content_type":"text/x-python","patch_set":25,"id":"df87a7cf_2ac73e48","line":585,"range":{"start_line":571,"start_character":8,"end_line":585,"end_character":74},"updated":"2017-12-13 02:50:32.000000000","message":"There are two solutions when deleting instances.One is prev_page number is less than page_size,the other one is next_page number is zero.So,I more like the code such as:\n\nif len(servers) \u003c page_size and reversed_order:\n    del search_opts[\u0027marker\u0027]\n    search_opts[\u0027sort_dir\u0027] \u003d \u0027desc\u0027\n    reversed_order \u003d False\n    servers \u003d [Server(s, request) for s in nova_client.servers.list(detailed, search_opts)]\n\nelif len(servers) \u003d\u003d 0:\n    del search_opts[\u0027marker\u0027]\n    search_opts[\u0027sort_dir\u0027] \u003d \u0027asc\u0027\n    reversed_order \u003d True\n    servers \u003d [Server(s, request) for s in nova_client.servers.list(detailed, search_opts)]\n\n    if len(servers) \u003e page_size:\n        servers.pop()\n        servers.reverse()\n        has_prev_data \u003d True\n        has_more_data \u003d False\n        return ...","commit_id":"494cea7a7ccd5d4c93bf04885b957fec0c396d74"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"b94bdc30d545ed7ae36c4f93ec1c6ef5adc03945","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        search_opts[\u0027sort_dir\u0027] \u003d sort_dir"},{"line_number":569,"context_line":"        servers \u003d [Server(s, request)"},{"line_number":570,"context_line":"                   for s in nova_client.servers.list(detailed, search_opts)]"},{"line_number":571,"context_line":"        if view_marker \u003d\u003d \u0027possibly_deleted\u0027:"},{"line_number":572,"context_line":"            if len(servers) \u003d\u003d 0:"},{"line_number":573,"context_line":"                view_marker \u003d \u0027head_deleted\u0027"},{"line_number":574,"context_line":"                search_opts[\u0027sort_dir\u0027] \u003d \u0027desc\u0027"},{"line_number":575,"context_line":"                reversed_order \u003d False"},{"line_number":576,"context_line":"                servers \u003d [Server(s, request)"},{"line_number":577,"context_line":"                           for s in nova_client.servers.list(detailed,"},{"line_number":578,"context_line":"                                                             search_opts)]"},{"line_number":579,"context_line":"            if len(servers) \u003d\u003d 0:"},{"line_number":580,"context_line":"                view_marker \u003d \u0027tail_deleted\u0027"},{"line_number":581,"context_line":"                search_opts[\u0027sort_dir\u0027] \u003d \u0027asc\u0027"},{"line_number":582,"context_line":"                reversed_order \u003d True"},{"line_number":583,"context_line":"                servers \u003d [Server(s, request)"},{"line_number":584,"context_line":"                           for s in nova_client.servers.list(detailed,"},{"line_number":585,"context_line":"                                                             search_opts)]"},{"line_number":586,"context_line":"        (servers, has_more_data, has_prev_data) \u003d update_pagination("},{"line_number":587,"context_line":"            servers, page_size, marker, reversed_order)"},{"line_number":588,"context_line":"        has_prev_data \u003d (False"}],"source_content_type":"text/x-python","patch_set":25,"id":"3fa0c359_0dda96e8","line":585,"range":{"start_line":571,"start_character":8,"end_line":585,"end_character":74},"in_reply_to":"7f96bb07_1704b97a","updated":"2018-02-05 10:59:20.000000000","message":"Wangliangyu Your pagination code suffers more than mine:\nMarket for delete: https://imagebin.ca/v/3qePbzft4tYG\nAfter the delete: https://imagebin.ca/v/3qeQkYTRNtUX","commit_id":"494cea7a7ccd5d4c93bf04885b957fec0c396d74"},{"author":{"_account_id":25946,"name":"Wangliangyu","email":"wangly2097@chinaunicom.cn","username":"wangliangyu"},"change_message_id":"832747a33c36065bb11ee54cfe24c2f6ed6e634c","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        search_opts[\u0027sort_dir\u0027] \u003d sort_dir"},{"line_number":569,"context_line":"        servers \u003d [Server(s, request)"},{"line_number":570,"context_line":"                   for s in nova_client.servers.list(detailed, search_opts)]"},{"line_number":571,"context_line":"        if view_marker \u003d\u003d \u0027possibly_deleted\u0027:"},{"line_number":572,"context_line":"            if len(servers) \u003d\u003d 0:"},{"line_number":573,"context_line":"                view_marker \u003d \u0027head_deleted\u0027"},{"line_number":574,"context_line":"                search_opts[\u0027sort_dir\u0027] \u003d \u0027desc\u0027"},{"line_number":575,"context_line":"                reversed_order \u003d False"},{"line_number":576,"context_line":"                servers \u003d [Server(s, request)"},{"line_number":577,"context_line":"                           for s in nova_client.servers.list(detailed,"},{"line_number":578,"context_line":"                                                             search_opts)]"},{"line_number":579,"context_line":"            if len(servers) \u003d\u003d 0:"},{"line_number":580,"context_line":"                view_marker \u003d \u0027tail_deleted\u0027"},{"line_number":581,"context_line":"                search_opts[\u0027sort_dir\u0027] \u003d \u0027asc\u0027"},{"line_number":582,"context_line":"                reversed_order \u003d True"},{"line_number":583,"context_line":"                servers \u003d [Server(s, request)"},{"line_number":584,"context_line":"                           for s in nova_client.servers.list(detailed,"},{"line_number":585,"context_line":"                                                             search_opts)]"},{"line_number":586,"context_line":"        (servers, has_more_data, has_prev_data) \u003d update_pagination("},{"line_number":587,"context_line":"            servers, page_size, marker, reversed_order)"},{"line_number":588,"context_line":"        has_prev_data \u003d (False"}],"source_content_type":"text/x-python","patch_set":25,"id":"7f96bb07_1704b97a","line":585,"range":{"start_line":571,"start_character":8,"end_line":585,"end_character":74},"in_reply_to":"7f96bb07_39453118","updated":"2018-01-22 14:41:01.000000000","message":"If page_size\u003d2,the i3 instance will be in second page.Now, marker\u003di2,reversed_order\u003dFalse.i4 instance will be leaved in second page when we have deleted i3.The situation is just a normal one ,not contained in my comments.","commit_id":"494cea7a7ccd5d4c93bf04885b957fec0c396d74"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"3a9ebe086528be356bc56c46e438cdabc55f9d09","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        search_opts[\u0027sort_dir\u0027] \u003d sort_dir"},{"line_number":569,"context_line":"        servers \u003d [Server(s, request)"},{"line_number":570,"context_line":"                   for s in nova_client.servers.list(detailed, search_opts)]"},{"line_number":571,"context_line":"        if view_marker \u003d\u003d \u0027possibly_deleted\u0027:"},{"line_number":572,"context_line":"            if len(servers) \u003d\u003d 0:"},{"line_number":573,"context_line":"                view_marker \u003d \u0027head_deleted\u0027"},{"line_number":574,"context_line":"                search_opts[\u0027sort_dir\u0027] \u003d \u0027desc\u0027"},{"line_number":575,"context_line":"                reversed_order \u003d False"},{"line_number":576,"context_line":"                servers \u003d [Server(s, request)"},{"line_number":577,"context_line":"                           for s in nova_client.servers.list(detailed,"},{"line_number":578,"context_line":"                                                             search_opts)]"},{"line_number":579,"context_line":"            if len(servers) \u003d\u003d 0:"},{"line_number":580,"context_line":"                view_marker \u003d \u0027tail_deleted\u0027"},{"line_number":581,"context_line":"                search_opts[\u0027sort_dir\u0027] \u003d \u0027asc\u0027"},{"line_number":582,"context_line":"                reversed_order \u003d True"},{"line_number":583,"context_line":"                servers \u003d [Server(s, request)"},{"line_number":584,"context_line":"                           for s in nova_client.servers.list(detailed,"},{"line_number":585,"context_line":"                                                             search_opts)]"},{"line_number":586,"context_line":"        (servers, has_more_data, has_prev_data) \u003d update_pagination("},{"line_number":587,"context_line":"            servers, page_size, marker, reversed_order)"},{"line_number":588,"context_line":"        has_prev_data \u003d (False"}],"source_content_type":"text/x-python","patch_set":25,"id":"7f96bb07_39453118","line":585,"range":{"start_line":571,"start_character":8,"end_line":585,"end_character":74},"in_reply_to":"df87a7cf_2ac73e48","updated":"2018-01-22 10:24:43.000000000","message":"okay. You have page size  \u003d 2, 4 i1, i2, ,i3, i4) instances and you just have deleted i3. Okay your code reset pagination in case of problem, but will Your logic show the i4 in any page ever?","commit_id":"494cea7a7ccd5d4c93bf04885b957fec0c396d74"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1aa01c76c71f68e85b252fb42d1c239b6a535e64","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    @property"},{"line_number":130,"context_line":"    def display_name(self):"},{"line_number":131,"context_line":"        return self.name"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    # TODO(gabriel): deprecate making a call to Glance as a fallback."},{"line_number":134,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":28,"id":"df7087c5_63c1a980","line":131,"updated":"2018-03-09 16:10:17.000000000","message":"Looks unrelated. How is it related to the pagination prev link fix?","commit_id":"3ff497ec85b2a04e189c0da483916aecd5c0e8ba"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"143ccc889821212ffa2a3ff5ad0e5d3f493fc975","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    @property"},{"line_number":130,"context_line":"    def display_name(self):"},{"line_number":131,"context_line":"        return self.name"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    # TODO(gabriel): deprecate making a call to Glance as a fallback."},{"line_number":134,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":28,"id":"df7087c5_fdcb0450","line":131,"in_reply_to":"df7087c5_63c1a980","updated":"2018-03-11 09:57:53.000000000","message":"When I started this patch in august, update_pagination() needed a key. I have selected the nova one server_name to have the local list consistent with nova sorting. Later update_pagination() have changed, the key is no longer needed, so functionally this property is no longer used. Unfortunately I forgot removing.","commit_id":"3ff497ec85b2a04e189c0da483916aecd5c0e8ba"}],"openstack_dashboard/dashboards/admin/instances/views.py":[{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"e28953b7c5a29f5d802aca239187e19a43469fc0","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        return getattr(self, \"_prev\", False)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def has_more_data(self, table):"},{"line_number":82,"context_line":"        return getattr(self, \"_more\", False)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def needs_filter_first(self, table):"},{"line_number":85,"context_line":"        return self._needs_filter_first"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_d1ba9e08","line":82,"updated":"2017-09-25 13:45:53.000000000","message":"What reason to use it instead of self._more?","commit_id":"32df137d1fc43748dc510695cf4e9b92884bd4b7"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"4b05667c3a11ae03d5dbc9ccdd685d48ca24d2d5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        return getattr(self, \"_prev\", False)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def has_more_data(self, table):"},{"line_number":82,"context_line":"        return getattr(self, \"_more\", False)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def needs_filter_first(self, table):"},{"line_number":85,"context_line":"        return self._needs_filter_first"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f515b1d_26d2b2d3","line":82,"in_reply_to":"7f515b1d_d1ba9e08","updated":"2017-09-26 10:28:19.000000000","message":"Ok I will change it self._more  has_prev_data() fails in unittest if I don\u0027t getattr(). I just wanted similar look.","commit_id":"32df137d1fc43748dc510695cf4e9b92884bd4b7"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"219d59a6102b0bc531ca82f822979ba8ae3e7ca8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    page_title \u003d _(\"Instances\")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def has_prev_data(self, table):"},{"line_number":79,"context_line":"        return getattr(self, \"_prev\", False)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def has_more_data(self, table):"},{"line_number":82,"context_line":"        return self._more"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f515b1d_fffb7c43","line":79,"updated":"2017-10-02 13:36:48.000000000","message":"Why we can not use \"self._prev\" here?","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"78a6e235bccb51af2294b433bf7c54bb31d551ab","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    page_title \u003d _(\"Instances\")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def has_prev_data(self, table):"},{"line_number":79,"context_line":"        return getattr(self, \"_prev\", False)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def has_more_data(self, table):"},{"line_number":82,"context_line":"        return self._more"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f515b1d_dc7318e6","line":79,"in_reply_to":"7f515b1d_9af2486f","updated":"2017-10-03 12:04:55.000000000","message":"why self._more always present?","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"e0f91242032bcc2c9232b8805ffbb15f53f31913","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    page_title \u003d _(\"Instances\")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def has_prev_data(self, table):"},{"line_number":79,"context_line":"        return getattr(self, \"_prev\", False)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def has_more_data(self, table):"},{"line_number":82,"context_line":"        return self._more"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f515b1d_9af2486f","line":79,"in_reply_to":"7f515b1d_fffb7c43","updated":"2017-10-03 06:49:29.000000000","message":"self._prev not always present. We fail some unit test cases with attribute not present, while executing has_prev_data()","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"cc4c04a6f3b98971d0f53a07dc5abad8759922d0","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                 self._prev) \u003d api.nova.server_list_paged("},{"line_number":160,"context_line":"                    self.request,"},{"line_number":161,"context_line":"                    search_opts\u003dsearch_opts,"},{"line_number":162,"context_line":"                    marker\u003dmarker,"},{"line_number":163,"context_line":"                    reversed_order\u003dreversed_order)"},{"line_number":164,"context_line":"                instances.extend(tmp_instances)"},{"line_number":165,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f515b1d_2271f776","line":162,"updated":"2017-10-02 13:48:53.000000000","message":"We already have marker in search_opts. This is duplicate.","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"e0f91242032bcc2c9232b8805ffbb15f53f31913","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                 self._prev) \u003d api.nova.server_list_paged("},{"line_number":160,"context_line":"                    self.request,"},{"line_number":161,"context_line":"                    search_opts\u003dsearch_opts,"},{"line_number":162,"context_line":"                    marker\u003dmarker,"},{"line_number":163,"context_line":"                    reversed_order\u003dreversed_order)"},{"line_number":164,"context_line":"                instances.extend(tmp_instances)"},{"line_number":165,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f515b1d_7ac30cee","line":162,"in_reply_to":"7f515b1d_2271f776","updated":"2017-10-03 06:49:29.000000000","message":"I use 2 markers, one for nova and one for the view in update_pagination(). You are right I should hide this detail from the i/f.","commit_id":"1fd0dcd7e875e75c036ebb0d385fb7355ee75303"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1aa01c76c71f68e85b252fb42d1c239b6a535e64","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        image_map \u003d {}"},{"line_number":93,"context_line":"        flavors \u003d []"},{"line_number":94,"context_line":"        full_flavors \u003d {}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        prev_marker \u003d self.request.GET.get("},{"line_number":97,"context_line":"            project_tables.AdminInstancesTable._meta.prev_pagination_param,"},{"line_number":98,"context_line":"            None)"}],"source_content_type":"text/x-python","patch_set":28,"id":"df7087c5_231731f0","line":95,"updated":"2018-03-09 16:10:17.000000000","message":"Can\u0027t you use _get_marker() in horizon.tables.views.PagedTableMixin?","commit_id":"3ff497ec85b2a04e189c0da483916aecd5c0e8ba"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"143ccc889821212ffa2a3ff5ad0e5d3f493fc975","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        image_map \u003d {}"},{"line_number":93,"context_line":"        flavors \u003d []"},{"line_number":94,"context_line":"        full_flavors \u003d {}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        prev_marker \u003d self.request.GET.get("},{"line_number":97,"context_line":"            project_tables.AdminInstancesTable._meta.prev_pagination_param,"},{"line_number":98,"context_line":"            None)"}],"source_content_type":"text/x-python","patch_set":28,"id":"df7087c5_ddd5e0e6","line":95,"in_reply_to":"df7087c5_231731f0","updated":"2018-03-11 09:57:53.000000000","message":"I have just followed the the logic existed here for marker. On the other hand there is a convention in python that entities started with \u0027_\u0027 are similar to private in C++, so calling them outside of the class breaks the intent.","commit_id":"3ff497ec85b2a04e189c0da483916aecd5c0e8ba"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ebcdd65cf6ad94a23631685e2aa9d24ab76fb5fe","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        image_map \u003d {}"},{"line_number":93,"context_line":"        flavors \u003d []"},{"line_number":94,"context_line":"        full_flavors \u003d {}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        prev_marker \u003d self.request.GET.get("},{"line_number":97,"context_line":"            project_tables.AdminInstancesTable._meta.prev_pagination_param,"},{"line_number":98,"context_line":"            None)"}],"source_content_type":"text/x-python","patch_set":28,"id":"bf659307_fa37574c","line":95,"in_reply_to":"df7087c5_baa49b09","updated":"2018-03-29 08:41:04.000000000","message":"So, is the only reason that the method name of _get_marker() starts with underscore? If so, I would like to send a renaming patch before your patch land.","commit_id":"3ff497ec85b2a04e189c0da483916aecd5c0e8ba"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"311b0f2a14ddd6b837becf9b2e184cc95b0e90e7","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        image_map \u003d {}"},{"line_number":93,"context_line":"        flavors \u003d []"},{"line_number":94,"context_line":"        full_flavors \u003d {}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        prev_marker \u003d self.request.GET.get("},{"line_number":97,"context_line":"            project_tables.AdminInstancesTable._meta.prev_pagination_param,"},{"line_number":98,"context_line":"            None)"}],"source_content_type":"text/x-python","patch_set":28,"id":"df7087c5_baa49b09","line":95,"in_reply_to":"df7087c5_dcf2b806","updated":"2018-03-22 03:06:19.000000000","message":"Akihiro I was not intended  creating more","commit_id":"3ff497ec85b2a04e189c0da483916aecd5c0e8ba"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"09bc90d7b229c607265ec04661633a2a0973afa2","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        image_map \u003d {}"},{"line_number":93,"context_line":"        flavors \u003d []"},{"line_number":94,"context_line":"        full_flavors \u003d {}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        prev_marker \u003d self.request.GET.get("},{"line_number":97,"context_line":"            project_tables.AdminInstancesTable._meta.prev_pagination_param,"},{"line_number":98,"context_line":"            None)"}],"source_content_type":"text/x-python","patch_set":28,"id":"df7087c5_dcf2b806","line":95,"in_reply_to":"df7087c5_ddd5e0e6","updated":"2018-03-21 21:55:46.000000000","message":"Yeah, I agree with you on this point. Perhaps we should rename _get_marker().\n\nOn the other hand, do we want to create more variants on pagination handling logic?","commit_id":"3ff497ec85b2a04e189c0da483916aecd5c0e8ba"}],"openstack_dashboard/dashboards/project/instances/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1aa01c76c71f68e85b252fb42d1c239b6a535e64","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    def has_more_data(self, table):"},{"line_number":69,"context_line":"        return self._more"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def get_data(self):"},{"line_number":72,"context_line":"        prev_marker \u003d self.request.GET.get("},{"line_number":73,"context_line":"            project_tables.InstancesTable._meta.prev_pagination_param, None)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"df7087c5_a3e021fc","line":71,"updated":"2018-03-09 16:10:17.000000000","message":"Can\u0027t you use _get_marker in horizon.tables.views.PagedTableMixin to retrieve a previous marker?","commit_id":"3ff497ec85b2a04e189c0da483916aecd5c0e8ba"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"143ccc889821212ffa2a3ff5ad0e5d3f493fc975","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    def has_more_data(self, table):"},{"line_number":69,"context_line":"        return self._more"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def get_data(self):"},{"line_number":72,"context_line":"        prev_marker \u003d self.request.GET.get("},{"line_number":73,"context_line":"            project_tables.InstancesTable._meta.prev_pagination_param, None)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"df7087c5_7d061489","line":71,"in_reply_to":"df7087c5_a3e021fc","updated":"2018-03-11 09:57:53.000000000","message":"See my answer in the admin view one.","commit_id":"3ff497ec85b2a04e189c0da483916aecd5c0e8ba"}],"openstack_dashboard/test/unit/api/test_nova.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1aa01c76c71f68e85b252fb42d1c239b6a535e64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"df7087c5_2369718a","updated":"2018-03-09 16:10:17.000000000","message":"api/nova.py was changed a lot. We would like to see corresponding unit test coverage here.","commit_id":"3ff497ec85b2a04e189c0da483916aecd5c0e8ba"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"143ccc889821212ffa2a3ff5ad0e5d3f493fc975","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"df7087c5_fd278411","in_reply_to":"df7087c5_2369718a","updated":"2018-03-11 09:57:53.000000000","message":"Akihiro You can find the test code suspected missing here: https://review.openstack.org/#/c/498018/28/openstack_dashboard/dashboards/admin/instances/tests.py@440","commit_id":"3ff497ec85b2a04e189c0da483916aecd5c0e8ba"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"03b92708a29e077afcc098f514fa13b7de2edda8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"bf659307_948227c8","in_reply_to":"df7087c5_5aba1f0a","updated":"2018-03-25 16:00:26.000000000","message":"I personally cannot understand how openstack_dashboard.api.nova module test coverage is discussed with the interaction difference between django and angular. This is a common module called from django and angular even after angular implementation is supported. There is no angular implementation on instance tables.\n\nI don\u0027t want to block this patch based on this comment.\n\nif you have no plan to add test coverage here, please file a bug and add TODO comment.","commit_id":"3ff497ec85b2a04e189c0da483916aecd5c0e8ba"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"311b0f2a14ddd6b837becf9b2e184cc95b0e90e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"df7087c5_5aba1f0a","in_reply_to":"df7087c5_fc43fc11","updated":"2018-03-22 03:06:19.000000000","message":"The function is given as \u0027user story\u0027 - not exact specification. The bug is more than 2 years old. Test coverage is hard, since it is interaction between django and angular","commit_id":"3ff497ec85b2a04e189c0da483916aecd5c0e8ba"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"09bc90d7b229c607265ec04661633a2a0973afa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"df7087c5_fc43fc11","in_reply_to":"df7087c5_fd278411","updated":"2018-03-21 21:55:46.000000000","message":"The test you mentioned above mocks api.nova.server_list_paged.\nDon\u0027t we need test coverage on server_list_paged itself?","commit_id":"3ff497ec85b2a04e189c0da483916aecd5c0e8ba"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ebcdd65cf6ad94a23631685e2aa9d24ab76fb5fe","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        self._mock_current_version(novaclient, \u00272.40\u0027)"},{"line_number":170,"context_line":"        novaclient.servers.list.return_value \u003d servers"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        (ret_val, has_more) \u003d api.nova.server_list("},{"line_number":173,"context_line":"            self.request,"},{"line_number":174,"context_line":"            search_opts\u003d{\u0027all_tenants\u0027: True})"},{"line_number":175,"context_line":"        for server in ret_val:"}],"source_content_type":"text/x-python","patch_set":30,"id":"bf659307_fa02f76e","line":172,"updated":"2018-03-29 08:41:04.000000000","message":"Why do you need to add parentheses? it is unnecessary.","commit_id":"f297ed23d66793ba4eff4c23f56f4a30bf63f4d0"},{"author":{"_account_id":18889,"name":"Ferenc Cserepkei","email":"ferenc.cserepkei@ericsson.com","username":"csfera"},"change_message_id":"6f7bf6d6dea9c2cbb1ec1aaa7e18ba2b4963582e","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        self._mock_current_version(novaclient, \u00272.40\u0027)"},{"line_number":170,"context_line":"        novaclient.servers.list.return_value \u003d servers"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        (ret_val, has_more) \u003d api.nova.server_list("},{"line_number":173,"context_line":"            self.request,"},{"line_number":174,"context_line":"            search_opts\u003d{\u0027all_tenants\u0027: True})"},{"line_number":175,"context_line":"        for server in ret_val:"}],"source_content_type":"text/x-python","patch_set":30,"id":"bf659307_8ae0cdfc","line":172,"in_reply_to":"bf659307_fa02f76e","updated":"2018-04-05 07:07:02.000000000","message":"my preference to surround () if the return value is a tuple, but o.k. removed","commit_id":"f297ed23d66793ba4eff4c23f56f4a30bf63f4d0"}]}
