)]}'
{"openstack_dashboard/api/nova.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"3479713d2f0f6e7c2b8fb649f209bb6839109923","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    if get_extras:"},{"line_number":336,"context_line":"        for flavor in flavors:"},{"line_number":337,"context_line":"            flavor.extras \u003d flavor_get_extras(request, flavor.id, True, flavor)"},{"line_number":338,"context_line":"    flavors \u003d sorted(flavors, key\u003dlambda x: (x.vcpus, x.ram))"},{"line_number":339,"context_line":"    return flavors"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_b95431ff","line":338,"updated":"2017-08-29 08:13:34.000000000","message":"nit: In Python you can write this as:\n\n flavors.sort(key\u003d...)\n\nThen it sorts in-place.","commit_id":"706b301df9db6a0ac1458b7de32ddf7f6ecbd317"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"38e837af182a217ad27f501339f7117a900e74d6","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    if get_extras:"},{"line_number":336,"context_line":"        for flavor in flavors:"},{"line_number":337,"context_line":"            flavor.extras \u003d flavor_get_extras(request, flavor.id, True, flavor)"},{"line_number":338,"context_line":"    flavors \u003d sorted(flavors, key\u003dlambda x: (x.vcpus, x.ram))"},{"line_number":339,"context_line":"    return flavors"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_73712f44","line":338,"in_reply_to":"7f287b81_b95431ff","updated":"2017-08-29 22:59:45.000000000","message":"Good catch, I will fix it.","commit_id":"706b301df9db6a0ac1458b7de32ddf7f6ecbd317"}],"openstack_dashboard/api/rest/nova.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e439e9aa3aea49ebb03471c295c3f1f0b9398721","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                d[\u0027extras\u0027] \u003d flavor.extras"},{"line_number":490,"context_line":"            result[\u0027items\u0027].append(d)"},{"line_number":491,"context_line":"        return result"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def _sort_flavors(self, flavors):"},{"line_number":494,"context_line":"        \"\"\"Utility method to sort a list of flavors."},{"line_number":495,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_74a306b3","line":492,"updated":"2017-11-29 19:15:17.000000000","message":"Very similar function already exists in openstack_dashboard/dashboards/project/instances/utils.py (sort_flavor_list). Could you reuse (or share) the logic rather than copying the logic?","commit_id":"d5c85e7baa412794fd0ea4c084fb93eca6c7d50e"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"2afff539745f100596fba6a365edd15ee099d2a3","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                d[\u0027extras\u0027] \u003d flavor.extras"},{"line_number":490,"context_line":"            result[\u0027items\u0027].append(d)"},{"line_number":491,"context_line":"        return result"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def _sort_flavors(self, flavors):"},{"line_number":494,"context_line":"        \"\"\"Utility method to sort a list of flavors."},{"line_number":495,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_77564809","line":492,"in_reply_to":"ff82abbf_74a306b3","updated":"2018-05-21 04:40:01.000000000","message":"It\u0027s possible to reuse the existing function, though they\u0027re returning different format. I will check how to handle it.","commit_id":"d5c85e7baa412794fd0ea4c084fb93eca6c7d50e"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"30d33baf292349ec5a91c1c3fa9f6ff7d62e7e86","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            try:"},{"line_number":502,"context_line":"                return getattr(flavor, sort_key)"},{"line_number":503,"context_line":"            except AttributeError:"},{"line_number":504,"context_line":"                return getattr(flavor, lambda x: (x.vcpus, x.ram))"},{"line_number":505,"context_line":"        try:"},{"line_number":506,"context_line":"            flavor_sort \u003d getattr(settings, \u0027CREATE_INSTANCE_FLAVOR_SORT\u0027, {})"},{"line_number":507,"context_line":"            sort_key \u003d flavor_sort.get(\u0027key\u0027, lambda x: (x.vcpus, x.ram))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_9742c0aa","line":504,"range":{"start_line":504,"start_character":16,"end_line":504,"end_character":66},"updated":"2017-09-05 09:35:41.000000000","message":"I\u0027m not sure I totally get the intention here, but passing a lambda to getattr is not ok.","commit_id":"d5c85e7baa412794fd0ea4c084fb93eca6c7d50e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e439e9aa3aea49ebb03471c295c3f1f0b9398721","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            try:"},{"line_number":502,"context_line":"                return getattr(flavor, sort_key)"},{"line_number":503,"context_line":"            except AttributeError:"},{"line_number":504,"context_line":"                return getattr(flavor, lambda x: (x.vcpus, x.ram))"},{"line_number":505,"context_line":"        try:"},{"line_number":506,"context_line":"            flavor_sort \u003d getattr(settings, \u0027CREATE_INSTANCE_FLAVOR_SORT\u0027, {})"},{"line_number":507,"context_line":"            sort_key \u003d flavor_sort.get(\u0027key\u0027, lambda x: (x.vcpus, x.ram))"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_14539a6c","line":504,"range":{"start_line":504,"start_character":16,"end_line":504,"end_character":66},"in_reply_to":"7f287b81_9742c0aa","updated":"2017-11-29 19:15:17.000000000","message":"Note that the default sort key is \u0027ram\u0027 as described in CREATE_INSTANCE_FLAVOR_SORT description.\n\nThis needs to return a concrete value instead of a function.\nPerhaps we would like to return flavor.ram\n\n  return flavor.ram","commit_id":"d5c85e7baa412794fd0ea4c084fb93eca6c7d50e"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"2afff539745f100596fba6a365edd15ee099d2a3","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            try:"},{"line_number":502,"context_line":"                return getattr(flavor, sort_key)"},{"line_number":503,"context_line":"            except AttributeError:"},{"line_number":504,"context_line":"                return getattr(flavor, lambda x: (x.vcpus, x.ram))"},{"line_number":505,"context_line":"        try:"},{"line_number":506,"context_line":"            flavor_sort \u003d getattr(settings, \u0027CREATE_INSTANCE_FLAVOR_SORT\u0027, {})"},{"line_number":507,"context_line":"            sort_key \u003d flavor_sort.get(\u0027key\u0027, lambda x: (x.vcpus, x.ram))"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_3740d035","line":504,"range":{"start_line":504,"start_character":16,"end_line":504,"end_character":66},"in_reply_to":"ff82abbf_14539a6c","updated":"2018-05-21 04:40:01.000000000","message":"I totally understand the default value is \"ram\", but it\u0027s not the ideal value for any cloud provider. Because the ideal sort is sort vcpus first, then ram. Only sort with ram is still making the list mess.","commit_id":"d5c85e7baa412794fd0ea4c084fb93eca6c7d50e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e439e9aa3aea49ebb03471c295c3f1f0b9398721","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                return getattr(flavor, lambda x: (x.vcpus, x.ram))"},{"line_number":505,"context_line":"        try:"},{"line_number":506,"context_line":"            flavor_sort \u003d getattr(settings, \u0027CREATE_INSTANCE_FLAVOR_SORT\u0027, {})"},{"line_number":507,"context_line":"            sort_key \u003d flavor_sort.get(\u0027key\u0027, lambda x: (x.vcpus, x.ram))"},{"line_number":508,"context_line":"            rev \u003d flavor_sort.get(\u0027reverse\u0027, False)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"            if not callable(sort_key):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_94948a38","line":507,"range":{"start_line":507,"start_character":12,"end_line":507,"end_character":73},"updated":"2017-11-29 19:15:17.000000000","message":"If you read the description of CREATE_INSTANCE_FLAVOR_SORT, you will notice the default sort key is \u0027ram\u0027.\n\n  sort_key \u003d flavor_sort.get(\u0027key\u0027, \u0027ram\u0027)","commit_id":"d5c85e7baa412794fd0ea4c084fb93eca6c7d50e"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"2afff539745f100596fba6a365edd15ee099d2a3","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                return getattr(flavor, lambda x: (x.vcpus, x.ram))"},{"line_number":505,"context_line":"        try:"},{"line_number":506,"context_line":"            flavor_sort \u003d getattr(settings, \u0027CREATE_INSTANCE_FLAVOR_SORT\u0027, {})"},{"line_number":507,"context_line":"            sort_key \u003d flavor_sort.get(\u0027key\u0027, lambda x: (x.vcpus, x.ram))"},{"line_number":508,"context_line":"            rev \u003d flavor_sort.get(\u0027reverse\u0027, False)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"            if not callable(sort_key):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_573b0cc7","line":507,"range":{"start_line":507,"start_character":12,"end_line":507,"end_character":73},"in_reply_to":"ff82abbf_94948a38","updated":"2018-05-21 04:40:01.000000000","message":"See above comments.","commit_id":"d5c85e7baa412794fd0ea4c084fb93eca6c7d50e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e439e9aa3aea49ebb03471c295c3f1f0b9398721","unresolved":false,"context_lines":[{"line_number":508,"context_line":"            rev \u003d flavor_sort.get(\u0027reverse\u0027, False)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"            if not callable(sort_key):"},{"line_number":511,"context_line":"                key \u003d lambda flavor: get_key(flavor, sort_key)"},{"line_number":512,"context_line":"            else:"},{"line_number":513,"context_line":"                key \u003d sort_key"},{"line_number":514,"context_line":"            flavors.sort(key\u003dkey, reverse\u003drev)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_f4dcf6e4","line":511,"range":{"start_line":511,"start_character":22,"end_line":511,"end_character":62},"updated":"2017-11-29 19:15:17.000000000","message":"my personal preference is to use functools.partial.\n\n  key \u003d functools.partial(get_key, sort_key\u003dsort_key)","commit_id":"d5c85e7baa412794fd0ea4c084fb93eca6c7d50e"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"79efedae4a27991b4ad87dcd865c960e88e72ed9","unresolved":false,"context_lines":[{"line_number":513,"context_line":"                key \u003d sort_key"},{"line_number":514,"context_line":"            flavors.sort(key\u003dkey, reverse\u003drev)"},{"line_number":515,"context_line":"        finally:"},{"line_number":516,"context_line":"            return flavors"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    @rest_utils.ajax(data_required\u003dTrue)"},{"line_number":519,"context_line":"    def post(self, request):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_b286ed64","line":516,"updated":"2017-09-05 09:09:14.000000000","message":"I found this method quite complicated to read. While playing with it I came up with this version:\n\n def _sorted(self, flavors):\n     kwargs \u003d getattr(settings, \u0027CREATE_INSTANCE_FLAVOR_SORT\u0027, {}) \n \n     if \u0027key\u0027 not in kwargs:\n         kwargs[\u0027key\u0027] \u003d lambda x: (x.vcpus, x.ram)\n     else:\n         if not callable(kwargs[\u0027key\u0027]):\n             # Save scalar attribute name before we replace it with getattr\n             # because sort() expects a callable key argument.\n             sort_by \u003d kwargs[\u0027key\u0027]\n             kwargs[\u0027key\u0027] \u003d lambda x: getattr(x, sort_by, None)\n \n     return sorted(flavors, **kwargs)\n\nMaybe I find it easier to read just because I have written it. ;-) Anyway if you also find it simpler feel free to use it.","commit_id":"d5c85e7baa412794fd0ea4c084fb93eca6c7d50e"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"30d33baf292349ec5a91c1c3fa9f6ff7d62e7e86","unresolved":false,"context_lines":[{"line_number":513,"context_line":"                key \u003d sort_key"},{"line_number":514,"context_line":"            flavors.sort(key\u003dkey, reverse\u003drev)"},{"line_number":515,"context_line":"        finally:"},{"line_number":516,"context_line":"            return flavors"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    @rest_utils.ajax(data_required\u003dTrue)"},{"line_number":519,"context_line":"    def post(self, request):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_d7660856","line":516,"in_reply_to":"7f287b81_b286ed64","updated":"2017-09-05 09:35:41.000000000","message":"Also note that my version is not fully equivalent with the original, because it (intentionally) fails if somebody configures sorting by attributes not present in the flavors.","commit_id":"d5c85e7baa412794fd0ea4c084fb93eca6c7d50e"}],"openstack_dashboard/dashboards/project/instances/utils.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1f54732a505fa800c63d8566bbfdcd756e4b3211","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            key \u003d sort_key"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        if simple_format:"},{"line_number":62,"context_line":"            flavor_list \u003d [(flavor.id, \u0027%s\u0027 % flavor.name)"},{"line_number":63,"context_line":"                           for flavor in sorted(flavors, key\u003dkey, reverse\u003drev)]"},{"line_number":64,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_8ca6050f","line":61,"range":{"start_line":61,"start_character":11,"end_line":61,"end_character":24},"updated":"2018-05-30 02:58:22.000000000","message":"L.65 looks like a simpler format, so True/False of simple_format sounds confusing... How about \"with_menu_label\" instead of \"simple_format\"?","commit_id":"66e025fc06e9918cda439d0069286a81654fdc25"}],"openstack_dashboard/test/settings.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e439e9aa3aea49ebb03471c295c3f1f0b9398721","unresolved":false,"context_lines":[{"line_number":312,"context_line":"CREATE_INSTANCE_FLAVOR_SORT \u003d {"},{"line_number":313,"context_line":"    \"key\": \"ram\","},{"line_number":314,"context_line":"    \"reverse\": False"},{"line_number":315,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_949a4a11","line":315,"updated":"2017-11-29 19:15:17.000000000","message":"Why do we need to add this? The default value should be handled in the code, so I don\u0027t think we need this.","commit_id":"d5c85e7baa412794fd0ea4c084fb93eca6c7d50e"}]}
