)]}'
{"openstack_dashboard/static/app/core/network_qos/qos.module.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eb92569a0c69e367d733a6a570f82506321ce62f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"      \u0027name\u0027: {label: gettext(\u0027Policy Name\u0027), filters: [\u0027noName\u0027] },"},{"line_number":97,"context_line":"      \u0027id\u0027: {label: gettext(\u0027Policy ID\u0027), filters: [\u0027noValue\u0027] },"},{"line_number":98,"context_line":"      \u0027description\u0027: {label: gettext(\u0027Description\u0027), filters: [\u0027noName\u0027] },"},{"line_number":99,"context_line":"      \u0027shared\u0027: {label: gettext(\u0027Shared\u0027), filters: [\u0027noName\u0027] },"},{"line_number":100,"context_line":"      \u0027tenant_id\u0027: {label: gettext(\u0027Tenant ID\u0027), filters: [\u0027noValue\u0027] },"},{"line_number":101,"context_line":"      \u0027project_id\u0027: {label: gettext(\u0027Project ID\u0027), filters: [\u0027noValue\u0027] },"},{"line_number":102,"context_line":"      \u0027created_at\u0027: {label: gettext(\u0027Created At\u0027), filters: [\u0027simpleDate\u0027] },"}],"source_content_type":"text/javascript","patch_set":2,"id":"7f515b1d_59135e67","line":99,"range":{"start_line":99,"start_character":43,"end_line":99,"end_character":64},"updated":"2017-10-06 00:51:46.000000000","message":"shared is a boolean value. Is it correct? yesno looks no problem to me.","commit_id":"f00c6c22da15f3fe79d94188e80f8db7a14bb400"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eb92569a0c69e367d733a6a570f82506321ce62f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"      \u0027project_id\u0027: {label: gettext(\u0027Project ID\u0027), filters: [\u0027noValue\u0027] },"},{"line_number":102,"context_line":"      \u0027created_at\u0027: {label: gettext(\u0027Created At\u0027), filters: [\u0027simpleDate\u0027] },"},{"line_number":103,"context_line":"      \u0027updated_at\u0027: {label: gettext(\u0027Updated At\u0027), filters: [\u0027simpleDate\u0027] },"},{"line_number":104,"context_line":"      \u0027rules\u0027: {label: gettext(\u0027Rules\u0027), filters: [\u0027noName\u0027] },"},{"line_number":105,"context_line":"      \u0027revision_number\u0027: {label: gettext(\u0027Revision Number\u0027), filters: [\u0027noValue\u0027] }"},{"line_number":106,"context_line":"    };"},{"line_number":107,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":2,"id":"7f515b1d_7c2a887e","line":104,"range":{"start_line":104,"start_character":41,"end_line":104,"end_character":60},"updated":"2017-10-06 00:51:46.000000000","message":"I am not sure this is a right filter or not. My understanding is that noName filter is mainly for string field. I am not sure noName filter is a right filter for array filed. noValue or some others?","commit_id":"f00c6c22da15f3fe79d94188e80f8db7a14bb400"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b13560e98873bd5e64b417506c7c6282d0273324","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    return {"},{"line_number":96,"context_line":"      \u0027name\u0027: {label: gettext(\u0027Policy Name\u0027), filters: [\u0027noName\u0027] },"},{"line_number":97,"context_line":"      \u0027id\u0027: {label: gettext(\u0027Policy ID\u0027), filters: [\u0027noValue\u0027] },"},{"line_number":98,"context_line":"      \u0027description\u0027: {label: gettext(\u0027Description\u0027), filters: [\u0027noName\u0027] },"},{"line_number":99,"context_line":"      \u0027shared\u0027: {label: gettext(\u0027Shared\u0027), filters: [\u0027yesno\u0027] },"},{"line_number":100,"context_line":"      \u0027tenant_id\u0027: {label: gettext(\u0027Tenant ID\u0027), filters: [\u0027noValue\u0027] },"},{"line_number":101,"context_line":"      \u0027project_id\u0027: {label: gettext(\u0027Project ID\u0027), filters: [\u0027noValue\u0027] },"}],"source_content_type":"text/javascript","patch_set":3,"id":"3f4b6375_afc959ac","line":98,"range":{"start_line":98,"start_character":64,"end_line":98,"end_character":70},"updated":"2017-11-07 03:30:35.000000000","message":"The filter name \"noName\" sounds confusing. noName filter is used for non-name fields. Is it time to revisit the filter name?\nI am okay with this patch, but it looks confusing.\n\nnoName filter shows \u0027None\u0027 if a value is empty.\nnoValue filter shows \u0027-\u0027 if a value is empty.\nThis is the only difference. \u0027NoneIfEmpty\u0027 might be a better name.","commit_id":"80991325652229f0a5eed2d26a487f4653421024"}]}
