)]}'
{"openstack_dashboard/api/vpn.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"40ebfb361a37a2509616763d264e75fae71ee552","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            return self[attr]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        def __setattr__(self, attr, value):"},{"line_number":40,"context_line":"            self[attr] \u003d value"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def readable(self, request):"},{"line_number":43,"context_line":"        pFormatted \u003d {\u0027id\u0027: self.id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9CMA%3D","line":40,"updated":"2013-12-17 13:47:49.000000000","message":"Shouldn\u0027t this be defined somewhere where it can be reused, like in horizon.utils?\nWouldn\u0027t it be better to use collections.namedtuple instead?","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"f81b87376bb52efb81e27b9957b433f3af25e6a7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            return self[attr]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        def __setattr__(self, attr, value):"},{"line_number":40,"context_line":"            self[attr] \u003d value"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def readable(self, request):"},{"line_number":43,"context_line":"        pFormatted \u003d {\u0027id\u0027: self.id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2FoQI%3D","line":40,"in_reply_to":"AAAATn%2F8t80%3D","updated":"2014-01-10 10:28:20.000000000","message":"As our goal is to add arbitrary parameters to this object I don\u0027t think namedtuple is a good option. It is a tuple after all with added ability to return value by predefined name.\n\nI have reported a separate bug to move AttributeDict to horizon.utils:\nhttps://bugs.launchpad.net/horizon/+bug/1267779","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3e66bfddfab413dcbe14d16972c882a6a3ade36a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            return self[attr]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        def __setattr__(self, attr, value):"},{"line_number":40,"context_line":"            self[attr] \u003d value"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def readable(self, request):"},{"line_number":43,"context_line":"        pFormatted \u003d {\u0027id\u0027: self.id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F8t80%3D","line":40,"in_reply_to":"AAAATn%2F9CMA%3D","updated":"2013-12-21 10:42:40.000000000","message":"readable() method is only used in VPNaaS and LBaaS. Personally I don\u0027t think we need AttributeDict and it is no problem even if we update the original IKEPolicy object.","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3e66bfddfab413dcbe14d16972c882a6a3ade36a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                      \u0027pfs\u0027: self.pfs,"},{"line_number":49,"context_line":"                      }"},{"line_number":50,"context_line":"        try:"},{"line_number":51,"context_line":"            conns \u003d ipsecsiteconnections_get(request)"},{"line_number":52,"context_line":"            pFormatted[\u0027ipsecsiteconns\u0027] \u003d []"},{"line_number":53,"context_line":"            for c in conns:"},{"line_number":54,"context_line":"                if c.ikepolicy_id \u003d\u003d self.id:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F8t8w%3D","line":51,"updated":"2013-12-21 10:42:40.000000000","message":"ipsecsiteconnections_get is now renamed to ipsecsiteconnect_list. Could you rebase?","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"f81b87376bb52efb81e27b9957b433f3af25e6a7","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                      \u0027pfs\u0027: self.pfs,"},{"line_number":49,"context_line":"                      }"},{"line_number":50,"context_line":"        try:"},{"line_number":51,"context_line":"            conns \u003d ipsecsiteconnections_get(request)"},{"line_number":52,"context_line":"            pFormatted[\u0027ipsecsiteconns\u0027] \u003d []"},{"line_number":53,"context_line":"            for c in conns:"},{"line_number":54,"context_line":"                if c.ikepolicy_id \u003d\u003d self.id:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2FoP8%3D","line":51,"in_reply_to":"AAAATn%2F8t8w%3D","updated":"2014-01-10 10:28:20.000000000","message":"Done","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"}],"openstack_dashboard/dashboards/project/vpn/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class UpdateVPNService(forms.SelfHandlingForm):"},{"line_number":36,"context_line":"    name \u003d forms.CharField(max_length\u003d80, label\u003d_(\"Name\"))"},{"line_number":37,"context_line":"    vpnservice_id \u003d forms.CharField(label\u003d_(\"ID\"),"},{"line_number":38,"context_line":"                                    widget\u003dforms.TextInput("},{"line_number":39,"context_line":"                                        attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuXo%3D","line":36,"updated":"2013-10-10 17:20:25.000000000","message":"name is an optional field in Neutron API. If VPN service is created by calling neutron API directly, a name can be an empty string, so we need to consider an empty name here.\nIt applies to all other VPNaaS resources.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class UpdateVPNService(forms.SelfHandlingForm):"},{"line_number":36,"context_line":"    name \u003d forms.CharField(max_length\u003d80, label\u003d_(\"Name\"))"},{"line_number":37,"context_line":"    vpnservice_id \u003d forms.CharField(label\u003d_(\"ID\"),"},{"line_number":38,"context_line":"                                    widget\u003dforms.TextInput("},{"line_number":39,"context_line":"                                        attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FleY%3D","line":36,"in_reply_to":"AAAATH%2F%2FuXo%3D","updated":"2013-10-14 14:11:30.000000000","message":"Done","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    failure_url \u003d \u0027horizon:project:vpn:index\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":47,"context_line":"        super(UpdateVPNService, self).__init__(request, *args, **kwargs)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def handle(self, request, context):"},{"line_number":50,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuXg%3D","line":47,"updated":"2013-10-10 17:20:25.000000000","message":"Unnecessary.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    failure_url \u003d \u0027horizon:project:vpn:index\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":47,"context_line":"        super(UpdateVPNService, self).__init__(request, *args, **kwargs)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def handle(self, request, context):"},{"line_number":50,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FleI%3D","line":47,"in_reply_to":"AAAATH%2F%2FuXg%3D","updated":"2013-10-14 14:11:30.000000000","message":"Done","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                                        (\"aes-256\", \"aes-256\")]"},{"line_number":100,"context_line":"        self.fields["},{"line_number":101,"context_line":"            \u0027encryption_algorithm\u0027].choices \u003d encryption_algorithm_choices"},{"line_number":102,"context_line":"        self.fields[\u0027encryption_algorithm\u0027].initial \u003d \"aes-128\""},{"line_number":103,"context_line":"        # Currently this field has only one choice, so mark it as readonly."},{"line_number":104,"context_line":"        self.fields[\u0027encryption_algorithm\u0027].widget.attrs[\u0027readonly\u0027] \u003d True"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuWQ%3D","line":102,"updated":"2013-10-10 17:20:25.000000000","message":"This is an update form, so we need to use the current value as initial.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                                        (\"aes-256\", \"aes-256\")]"},{"line_number":100,"context_line":"        self.fields["},{"line_number":101,"context_line":"            \u0027encryption_algorithm\u0027].choices \u003d encryption_algorithm_choices"},{"line_number":102,"context_line":"        self.fields[\u0027encryption_algorithm\u0027].initial \u003d \"aes-128\""},{"line_number":103,"context_line":"        # Currently this field has only one choice, so mark it as readonly."},{"line_number":104,"context_line":"        self.fields[\u0027encryption_algorithm\u0027].widget.attrs[\u0027readonly\u0027] \u003d True"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Flc8%3D","line":102,"in_reply_to":"AAAATH%2F%2FuWQ%3D","updated":"2013-10-14 14:11:30.000000000","message":"Thanks! Done.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            \u0027encryption_algorithm\u0027].choices \u003d encryption_algorithm_choices"},{"line_number":102,"context_line":"        self.fields[\u0027encryption_algorithm\u0027].initial \u003d \"aes-128\""},{"line_number":103,"context_line":"        # Currently this field has only one choice, so mark it as readonly."},{"line_number":104,"context_line":"        self.fields[\u0027encryption_algorithm\u0027].widget.attrs[\u0027readonly\u0027] \u003d True"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        ike_version_choices \u003d [(\"v1\", \"v1\"),"},{"line_number":107,"context_line":"                               (\"v2\", \"v2\")]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuV8%3D","line":104,"updated":"2013-10-10 17:20:25.000000000","message":"Hmm... encryption algorithm choices above has four candidates. Is the comment wrong?\nAre you trying to make auth_algorithm read-only?","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            \u0027encryption_algorithm\u0027].choices \u003d encryption_algorithm_choices"},{"line_number":102,"context_line":"        self.fields[\u0027encryption_algorithm\u0027].initial \u003d \"aes-128\""},{"line_number":103,"context_line":"        # Currently this field has only one choice, so mark it as readonly."},{"line_number":104,"context_line":"        self.fields[\u0027encryption_algorithm\u0027].widget.attrs[\u0027readonly\u0027] \u003d True"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        ike_version_choices \u003d [(\"v1\", \"v1\"),"},{"line_number":107,"context_line":"                               (\"v2\", \"v2\")]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlZg%3D","line":104,"in_reply_to":"AAAATH%2F%2FuV8%3D","updated":"2013-10-14 14:11:30.000000000","message":"Oops.. Thank you! Since that was just an initial commit, I made a copy of attributes from workflows.py and didn\u0027t notice the wrong comment there. I\u0027ve changed it to auth_algotithm here and there too.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                       (\"group5\", \"group5\"),"},{"line_number":117,"context_line":"                       (\"group14\", \"group14\")]"},{"line_number":118,"context_line":"        self.fields[\u0027pfs\u0027].choices \u003d pfs_choices"},{"line_number":119,"context_line":"        self.fields[\u0027pfs\u0027].initial \u003d \"group5\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        phase1_neg_mode_choices \u003d [(\"main\", \"main\")]"},{"line_number":122,"context_line":"        self.fields["}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuV0%3D","line":119,"updated":"2013-10-10 17:20:25.000000000","message":"Same as L.102","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                       (\"group5\", \"group5\"),"},{"line_number":117,"context_line":"                       (\"group14\", \"group14\")]"},{"line_number":118,"context_line":"        self.fields[\u0027pfs\u0027].choices \u003d pfs_choices"},{"line_number":119,"context_line":"        self.fields[\u0027pfs\u0027].initial \u003d \"group5\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        phase1_neg_mode_choices \u003d [(\"main\", \"main\")]"},{"line_number":122,"context_line":"        self.fields["}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlYQ%3D","line":119,"in_reply_to":"AAAATH%2F%2FuV0%3D","updated":"2013-10-14 14:11:30.000000000","message":"Done","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    auth_algorithm \u003d forms.ChoiceField(label\u003d_(\"Authorization algorithm\"))"},{"line_number":167,"context_line":"    encapsulation_mode \u003d forms.ChoiceField(label\u003d_(\"Encapsulation mode\"))"},{"line_number":168,"context_line":"    encryption_algorithm \u003d forms.ChoiceField(label\u003d_(\"Encryption algorithm\"))"},{"line_number":169,"context_line":"    #We cannot update lifetime now because of some neutronclient bug."},{"line_number":170,"context_line":"#    lifetime_units \u003d forms.ChoiceField(label\u003d_(\"Lifetime units\"))"},{"line_number":171,"context_line":"#    lifetime_value \u003d forms.IntegerField("},{"line_number":172,"context_line":"#        min_value\u003d60,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuVU%3D","line":169,"updated":"2013-10-10 17:20:25.000000000","message":"It would be better to add bug number here to track the bug status.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"634d12347796fef8b957fca9601c394c3d81c7c9","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    auth_algorithm \u003d forms.ChoiceField(label\u003d_(\"Authorization algorithm\"))"},{"line_number":167,"context_line":"    encapsulation_mode \u003d forms.ChoiceField(label\u003d_(\"Encapsulation mode\"))"},{"line_number":168,"context_line":"    encryption_algorithm \u003d forms.ChoiceField(label\u003d_(\"Encryption algorithm\"))"},{"line_number":169,"context_line":"    #We cannot update lifetime now because of some neutronclient bug."},{"line_number":170,"context_line":"#    lifetime_units \u003d forms.ChoiceField(label\u003d_(\"Lifetime units\"))"},{"line_number":171,"context_line":"#    lifetime_value \u003d forms.IntegerField("},{"line_number":172,"context_line":"#        min_value\u003d60,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fghc%3D","line":169,"in_reply_to":"AAAATH%2F%2FjuM%3D","updated":"2013-10-15 12:00:41.000000000","message":"Thanks for your review! :)","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"667a8b686d7b7ea71905675e8c7f74b3396feeff","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    auth_algorithm \u003d forms.ChoiceField(label\u003d_(\"Authorization algorithm\"))"},{"line_number":167,"context_line":"    encapsulation_mode \u003d forms.ChoiceField(label\u003d_(\"Encapsulation mode\"))"},{"line_number":168,"context_line":"    encryption_algorithm \u003d forms.ChoiceField(label\u003d_(\"Encryption algorithm\"))"},{"line_number":169,"context_line":"    #We cannot update lifetime now because of some neutronclient bug."},{"line_number":170,"context_line":"#    lifetime_units \u003d forms.ChoiceField(label\u003d_(\"Lifetime units\"))"},{"line_number":171,"context_line":"#    lifetime_value \u003d forms.IntegerField("},{"line_number":172,"context_line":"#        min_value\u003d60,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FjuM%3D","line":169,"in_reply_to":"AAAATH%2F%2FlXI%3D","updated":"2013-10-14 15:23:05.000000000","message":"Fair enough. i believe the patch will be merged soon.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    auth_algorithm \u003d forms.ChoiceField(label\u003d_(\"Authorization algorithm\"))"},{"line_number":167,"context_line":"    encapsulation_mode \u003d forms.ChoiceField(label\u003d_(\"Encapsulation mode\"))"},{"line_number":168,"context_line":"    encryption_algorithm \u003d forms.ChoiceField(label\u003d_(\"Encryption algorithm\"))"},{"line_number":169,"context_line":"    #We cannot update lifetime now because of some neutronclient bug."},{"line_number":170,"context_line":"#    lifetime_units \u003d forms.ChoiceField(label\u003d_(\"Lifetime units\"))"},{"line_number":171,"context_line":"#    lifetime_value \u003d forms.IntegerField("},{"line_number":172,"context_line":"#        min_value\u003d60,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlXI%3D","line":169,"in_reply_to":"AAAATH%2F%2FuVU%3D","updated":"2013-10-14 14:11:30.000000000","message":"I\u0027ve already filed the bug and it seems that a commit will be merged soon. So I\u0027ll just uncomment the code.\n\nhttps://review.openstack.org/#/c/50895/","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                                        (\"aes-256\", \"aes-256\")]"},{"line_number":196,"context_line":"        self.fields["},{"line_number":197,"context_line":"            \u0027encryption_algorithm\u0027].choices \u003d encryption_algorithm_choices"},{"line_number":198,"context_line":"        self.fields[\u0027encryption_algorithm\u0027].initial \u003d \"aes-128\""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"#        lifetime_units_choices \u003d [(\"seconds\", \"seconds\")]"},{"line_number":201,"context_line":"#        self.fields[\u0027lifetime_units\u0027].choices \u003d lifetime_units_choices"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuUs%3D","line":198,"updated":"2013-10-10 17:20:25.000000000","message":"the current value should be used as the initial value.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                                        (\"aes-256\", \"aes-256\")]"},{"line_number":196,"context_line":"        self.fields["},{"line_number":197,"context_line":"            \u0027encryption_algorithm\u0027].choices \u003d encryption_algorithm_choices"},{"line_number":198,"context_line":"        self.fields[\u0027encryption_algorithm\u0027].initial \u003d \"aes-128\""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"#        lifetime_units_choices \u003d [(\"seconds\", \"seconds\")]"},{"line_number":201,"context_line":"#        self.fields[\u0027lifetime_units\u0027].choices \u003d lifetime_units_choices"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlWg%3D","line":198,"in_reply_to":"AAAATH%2F%2FuUs%3D","updated":"2013-10-14 14:11:30.000000000","message":"Done","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"class UpdateIPSecSiteConnection(forms.SelfHandlingForm):"},{"line_number":251,"context_line":"    name \u003d forms.CharField(max_length\u003d80, label\u003d_(\"Name\"))"},{"line_number":252,"context_line":"    ipsecsiteconnection_id \u003d forms.CharField(label\u003d_(\"ID\"),"},{"line_number":253,"context_line":"        widget\u003dforms.TextInput(attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuS0%3D","line":250,"updated":"2013-10-10 17:20:25.000000000","message":"Hmm...there are so many duplicated fileld definition. It is worth considering to move these to workflows.py. We can share the field definitions in the create and update forms.\n\nIt will increase the code and string maintainability.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"634d12347796fef8b957fca9601c394c3d81c7c9","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"class UpdateIPSecSiteConnection(forms.SelfHandlingForm):"},{"line_number":251,"context_line":"    name \u003d forms.CharField(max_length\u003d80, label\u003d_(\"Name\"))"},{"line_number":252,"context_line":"    ipsecsiteconnection_id \u003d forms.CharField(label\u003d_(\"ID\"),"},{"line_number":253,"context_line":"        widget\u003dforms.TextInput(attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fgaw%3D","line":250,"in_reply_to":"AAAATH%2F%2FjsU%3D","updated":"2013-10-15 12:00:41.000000000","message":"What do you think about discussing this with blueprint vpnaas-ui-redesign implementation? Our case suits a thorough redesign rather than just adding buttons.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"667a8b686d7b7ea71905675e8c7f74b3396feeff","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"class UpdateIPSecSiteConnection(forms.SelfHandlingForm):"},{"line_number":251,"context_line":"    name \u003d forms.CharField(max_length\u003d80, label\u003d_(\"Name\"))"},{"line_number":252,"context_line":"    ipsecsiteconnection_id \u003d forms.CharField(label\u003d_(\"ID\"),"},{"line_number":253,"context_line":"        widget\u003dforms.TextInput(attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FjsU%3D","line":250,"in_reply_to":"AAAATH%2F%2FlTM%3D","updated":"2013-10-14 15:23:05.000000000","message":"It is a difficult choice. It seems better to be discussed with a separate topic. Only my concern is  that we need to maintain the fields and their description in two places.\n\nI actually saw two different field names for one field in the form and detail page in Havana RC1 phase and i need to fix it (though it is not just a case we are discussing).","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"class UpdateIPSecSiteConnection(forms.SelfHandlingForm):"},{"line_number":251,"context_line":"    name \u003d forms.CharField(max_length\u003d80, label\u003d_(\"Name\"))"},{"line_number":252,"context_line":"    ipsecsiteconnection_id \u003d forms.CharField(label\u003d_(\"ID\"),"},{"line_number":253,"context_line":"        widget\u003dforms.TextInput(attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlTM%3D","line":250,"in_reply_to":"AAAATH%2F%2FuS0%3D","updated":"2013-10-14 14:11:30.000000000","message":"Seems reasonable. But in the other hand, there will be simple workflow with only one step, too simple to be implemented as workflow.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                                              \u0027initiator\u0027: context["},{"line_number":331,"context_line":"                                                  \u0027initiator\u0027],"},{"line_number":332,"context_line":"                                              \u0027admin_state_up\u0027: context["},{"line_number":333,"context_line":"                                                  \u0027admin_state_up\u0027],"},{"line_number":334,"context_line":"                                              }}"},{"line_number":335,"context_line":"            ipsecsiteconnection \u003d api.vpn.ipsecsiteconnection_update("},{"line_number":336,"context_line":"                request, context[\u0027ipsecsiteconnection_id\u0027], **data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuSA%3D","line":333,"updated":"2013-10-10 17:20:25.000000000","message":"Please consider the following:\n\n data \u003d {\u0027ipsec_site_connection\u0027:\n            {\u0027name\u0027: context[\u0027name\u0027],\n             \u0027description\u0027: context[\u0027description\u0027],\n  ....","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                                              \u0027initiator\u0027: context["},{"line_number":331,"context_line":"                                                  \u0027initiator\u0027],"},{"line_number":332,"context_line":"                                              \u0027admin_state_up\u0027: context["},{"line_number":333,"context_line":"                                                  \u0027admin_state_up\u0027],"},{"line_number":334,"context_line":"                                              }}"},{"line_number":335,"context_line":"            ipsecsiteconnection \u003d api.vpn.ipsecsiteconnection_update("},{"line_number":336,"context_line":"                request, context[\u0027ipsecsiteconnection_id\u0027], **data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlTI%3D","line":333,"in_reply_to":"AAAATH%2F%2FuSA%3D","updated":"2013-10-14 14:11:30.000000000","message":"Done","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"de0f14dd9cc296b10b4ccb43642b0435e7dff399","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            vpnservice \u003d api.vpn.vpnservice_update("},{"line_number":53,"context_line":"                request, context[\u0027vpnservice_id\u0027], **data)"},{"line_number":54,"context_line":"            msg \u003d _("},{"line_number":55,"context_line":"                \u0027VPN Service %s was successfully updated.\u0027) % context[\u0027name\u0027]"},{"line_number":56,"context_line":"            LOG.debug(msg)"},{"line_number":57,"context_line":"            messages.success(request, msg)"},{"line_number":58,"context_line":"            return vpnservice"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fhd0%3D","line":55,"updated":"2013-11-02 15:28:09.000000000","message":"I prefer to:\n\n  msg \u003d (_(\u0027VPN Service %s was successfully updated.\u0027)\n         % context[\u0027name\u0027])","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"49da2cc3845c75cdef2ccd01f7fef399c477bc3e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            vpnservice \u003d api.vpn.vpnservice_update("},{"line_number":53,"context_line":"                request, context[\u0027vpnservice_id\u0027], **data)"},{"line_number":54,"context_line":"            msg \u003d _("},{"line_number":55,"context_line":"                \u0027VPN Service %s was successfully updated.\u0027) % context[\u0027name\u0027]"},{"line_number":56,"context_line":"            LOG.debug(msg)"},{"line_number":57,"context_line":"            messages.success(request, msg)"},{"line_number":58,"context_line":"            return vpnservice"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FeMQ%3D","line":55,"in_reply_to":"AAAATn%2F%2Fhd0%3D","updated":"2013-11-05 13:04:43.000000000","message":"Done","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"de0f14dd9cc296b10b4ccb43642b0435e7dff399","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                request, context[\u0027vpnservice_id\u0027], **data)"},{"line_number":54,"context_line":"            msg \u003d _("},{"line_number":55,"context_line":"                \u0027VPN Service %s was successfully updated.\u0027) % context[\u0027name\u0027]"},{"line_number":56,"context_line":"            LOG.debug(msg)"},{"line_number":57,"context_line":"            messages.success(request, msg)"},{"line_number":58,"context_line":"            return vpnservice"},{"line_number":59,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fhd8%3D","line":56,"updated":"2013-11-02 15:28:09.000000000","message":"It is very usual operation. I am not sure it is needed.","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"57b38354e29cd17c8d79891ebfbe7c9c9e434d48","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                request, context[\u0027vpnservice_id\u0027], **data)"},{"line_number":54,"context_line":"            msg \u003d _("},{"line_number":55,"context_line":"                \u0027VPN Service %s was successfully updated.\u0027) % context[\u0027name\u0027]"},{"line_number":56,"context_line":"            LOG.debug(msg)"},{"line_number":57,"context_line":"            messages.success(request, msg)"},{"line_number":58,"context_line":"            return vpnservice"},{"line_number":59,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FTv8%3D","line":56,"in_reply_to":"AAAATn%2F%2FUwU%3D","updated":"2013-11-12 09:20:27.000000000","message":"I see. I like the idea of clean-up. Let\u0027s do that a bit later.","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"df24232a9d4d37790dd1f5cc7183e3eaddb3008c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                request, context[\u0027vpnservice_id\u0027], **data)"},{"line_number":54,"context_line":"            msg \u003d _("},{"line_number":55,"context_line":"                \u0027VPN Service %s was successfully updated.\u0027) % context[\u0027name\u0027]"},{"line_number":56,"context_line":"            LOG.debug(msg)"},{"line_number":57,"context_line":"            messages.success(request, msg)"},{"line_number":58,"context_line":"            return vpnservice"},{"line_number":59,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FUwU%3D","line":56,"in_reply_to":"AAAATn%2F%2Fd5U%3D","updated":"2013-11-10 21:46:26.000000000","message":"Ah, okay. If needed, let\u0027s clean up them later.\nActually we see such debug log message only in forms and workflows in neutron related panels. Perhaps I added them in the network panel first and others follow it.","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"49da2cc3845c75cdef2ccd01f7fef399c477bc3e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                request, context[\u0027vpnservice_id\u0027], **data)"},{"line_number":54,"context_line":"            msg \u003d _("},{"line_number":55,"context_line":"                \u0027VPN Service %s was successfully updated.\u0027) % context[\u0027name\u0027]"},{"line_number":56,"context_line":"            LOG.debug(msg)"},{"line_number":57,"context_line":"            messages.success(request, msg)"},{"line_number":58,"context_line":"            return vpnservice"},{"line_number":59,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fd5U%3D","line":56,"in_reply_to":"AAAATn%2F%2Fhd8%3D","updated":"2013-11-05 13:04:43.000000000","message":"Is it really redundant here? We have the same logging in loadbalancers, firewalls and networks \"forms.py\" modules.","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"de0f14dd9cc296b10b4ccb43642b0435e7dff399","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            return vpnservice"},{"line_number":59,"context_line":"        except Exception:"},{"line_number":60,"context_line":"            msg \u003d _(\u0027Failed to update VPN Service %s\u0027) % context[\u0027name\u0027]"},{"line_number":61,"context_line":"            LOG.info(msg)"},{"line_number":62,"context_line":"            redirect \u003d reverse(self.failure_url)"},{"line_number":63,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fhd4%3D","line":61,"updated":"2013-11-02 15:28:09.000000000","message":"It is better the log message have the detail reason of the error. In addition, is \"info\" an appropriate level?\n\nAll these comments apply to other update forms.","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"df24232a9d4d37790dd1f5cc7183e3eaddb3008c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            return vpnservice"},{"line_number":59,"context_line":"        except Exception:"},{"line_number":60,"context_line":"            msg \u003d _(\u0027Failed to update VPN Service %s\u0027) % context[\u0027name\u0027]"},{"line_number":61,"context_line":"            LOG.info(msg)"},{"line_number":62,"context_line":"            redirect \u003d reverse(self.failure_url)"},{"line_number":63,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FUws%3D","line":61,"in_reply_to":"AAAATn%2F%2Fdy4%3D","updated":"2013-11-10 21:46:26.000000000","message":"I checked horizon.exceptions.handle() and confirmed a detail reason of exception is logged with warning level when an exception is recoverrable. I think you\u0027re right.","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"49da2cc3845c75cdef2ccd01f7fef399c477bc3e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            return vpnservice"},{"line_number":59,"context_line":"        except Exception:"},{"line_number":60,"context_line":"            msg \u003d _(\u0027Failed to update VPN Service %s\u0027) % context[\u0027name\u0027]"},{"line_number":61,"context_line":"            LOG.info(msg)"},{"line_number":62,"context_line":"            redirect \u003d reverse(self.failure_url)"},{"line_number":63,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fdy4%3D","line":61,"in_reply_to":"AAAATn%2F%2Fhd4%3D","updated":"2013-11-05 13:04:43.000000000","message":"That\u0027s a standard implementation of error logging in horizon forms modules, but you are right, we could add more details. The most probable (and verbose) errors are already filtered though, such as updating VPN Services which are still in use. What exactly do you suggest?","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"a0a9f4091e4d04634261e325769f998e5e6acb26","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    failure_url \u003d \u0027horizon:project:vpn:index\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":88,"context_line":"        super(UpdateIKEPolicy, self).__init__(request, *args, **kwargs)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        auth_algorithm_choices \u003d [(\"sha1\", \"sha1\")]"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F8I8%3D","line":87,"updated":"2014-01-06 14:29:27.000000000","message":"I believe that the content of this init method can be written as attributes of field declarations, because they are static.\n\nFor example check e.g. https://github.com/openstack/horizon/blob/87af06a123de40b3786c0b7aed3716648b8a7503/openstack_dashboard/dashboards/project/access_and_security/security_groups/forms.py#L228\n\nYou should use this dynamic way only for dynamic choices, e.g. obtained from API.","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"f773b4d126b0a912d4fa3382e811ab238334a8d0","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    failure_url \u003d \u0027horizon:project:vpn:index\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":88,"context_line":"        super(UpdateIKEPolicy, self).__init__(request, *args, **kwargs)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        auth_algorithm_choices \u003d [(\"sha1\", \"sha1\")]"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2FoEI%3D","line":87,"in_reply_to":"AAAAUH%2F%2F3G4%3D","updated":"2014-01-21 09:01:36.000000000","message":"Yes, the attributes are static. I move them here just to improve a readability.","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"4e0e669a46b225efbdc9b7f7560ba618282d5104","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    failure_url \u003d \u0027horizon:project:vpn:index\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":88,"context_line":"        super(UpdateIKEPolicy, self).__init__(request, *args, **kwargs)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        auth_algorithm_choices \u003d [(\"sha1\", \"sha1\")]"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F3G4%3D","line":87,"in_reply_to":"AAAAUH%2F%2F8I8%3D","updated":"2014-01-07 15:27:34.000000000","message":"I agree with Ladislav","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"a0a9f4091e4d04634261e325769f998e5e6acb26","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":88,"context_line":"        super(UpdateIKEPolicy, self).__init__(request, *args, **kwargs)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        auth_algorithm_choices \u003d [(\"sha1\", \"sha1\")]"},{"line_number":91,"context_line":"        self.fields[\u0027auth_algorithm\u0027].choices \u003d auth_algorithm_choices"},{"line_number":92,"context_line":"        # Currently this field has only one choice, so mark it as readonly."},{"line_number":93,"context_line":"        self.fields[\u0027auth_algorithm\u0027].widget.attrs[\u0027readonly\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F8Iw%3D","line":90,"updated":"2014-01-06 14:29:27.000000000","message":"The label part should be always translated, check the example above.","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"cf20b34af092b839507e6bb55b6c8b095bb4e752","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":88,"context_line":"        super(UpdateIKEPolicy, self).__init__(request, *args, **kwargs)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        auth_algorithm_choices \u003d [(\"sha1\", \"sha1\")]"},{"line_number":91,"context_line":"        self.fields[\u0027auth_algorithm\u0027].choices \u003d auth_algorithm_choices"},{"line_number":92,"context_line":"        # Currently this field has only one choice, so mark it as readonly."},{"line_number":93,"context_line":"        self.fields[\u0027auth_algorithm\u0027].widget.attrs[\u0027readonly\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2BxUQ%3D","line":90,"in_reply_to":"AAAAUH%2F%2F8Iw%3D","updated":"2014-01-22 12:15:06.000000000","message":"Done","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"a0a9f4091e4d04634261e325769f998e5e6acb26","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        # Currently this field has only one choice, so mark it as readonly."},{"line_number":120,"context_line":"        self.fields[\u0027phase1_negotiation_mode\u0027].widget.attrs[\u0027readonly\u0027] \u003d True"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def handle(self, request, context):"},{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            context.update({\u0027lifetime\u0027: {\u0027units\u0027: context[\u0027lifetime_units\u0027],"},{"line_number":125,"context_line":"                                         \u0027value\u0027: context[\u0027lifetime_value\u0027]}})"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F8Ic%3D","line":122,"updated":"2014-01-06 14:29:27.000000000","message":"I think it\u0027s more obvious to use \u0027data\u0027 instead of \u0027context\u0027 here. Context is used on View level so it might be confusing here.","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"cf20b34af092b839507e6bb55b6c8b095bb4e752","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        # Currently this field has only one choice, so mark it as readonly."},{"line_number":120,"context_line":"        self.fields[\u0027phase1_negotiation_mode\u0027].widget.attrs[\u0027readonly\u0027] \u003d True"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def handle(self, request, context):"},{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            context.update({\u0027lifetime\u0027: {\u0027units\u0027: context[\u0027lifetime_units\u0027],"},{"line_number":125,"context_line":"                                         \u0027value\u0027: context[\u0027lifetime_value\u0027]}})"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2BxBo%3D","line":122,"in_reply_to":"AAAAUH%2F%2F8Ic%3D","updated":"2014-01-22 12:15:06.000000000","message":"That\u0027s a good idea. If we could get rid of \u0027data\u0027 here somehow, it would be nice to replace \u0027context\u0027 with \u0027data\u0027. However I\u0027m not sure which way is better.","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"a0a9f4091e4d04634261e325769f998e5e6acb26","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def handle(self, request, context):"},{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            context.update({\u0027lifetime\u0027: {\u0027units\u0027: context[\u0027lifetime_units\u0027],"},{"line_number":125,"context_line":"                                         \u0027value\u0027: context[\u0027lifetime_value\u0027]}})"},{"line_number":126,"context_line":"            context.pop(\u0027lifetime_units\u0027)"},{"line_number":127,"context_line":"            context.pop(\u0027lifetime_value\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F8IU%3D","line":124,"updated":"2014-01-06 14:29:27.000000000","message":"is it necessary to change context dict here? it should enough to build the new dictionary without changing this one","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"cf20b34af092b839507e6bb55b6c8b095bb4e752","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def handle(self, request, context):"},{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            context.update({\u0027lifetime\u0027: {\u0027units\u0027: context[\u0027lifetime_units\u0027],"},{"line_number":125,"context_line":"                                         \u0027value\u0027: context[\u0027lifetime_value\u0027]}})"},{"line_number":126,"context_line":"            context.pop(\u0027lifetime_units\u0027)"},{"line_number":127,"context_line":"            context.pop(\u0027lifetime_value\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2BxMU%3D","line":124,"in_reply_to":"AAAAUH%2F%2F8IU%3D","updated":"2014-01-22 12:15:06.000000000","message":"Indeed. Thanks! Done.","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"a0a9f4091e4d04634261e325769f998e5e6acb26","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            context.pop(\u0027lifetime_units\u0027)"},{"line_number":127,"context_line":"            context.pop(\u0027lifetime_value\u0027)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"            data \u003d {\u0027ikepolicy\u0027: {\u0027name\u0027: context[\u0027name\u0027],"},{"line_number":130,"context_line":"                                  \u0027description\u0027: context[\u0027description\u0027],"},{"line_number":131,"context_line":"                                  \u0027auth_algorithm\u0027: context[\u0027auth_algorithm\u0027],"},{"line_number":132,"context_line":"                                  \u0027encryption_algorithm\u0027: context["}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F8II%3D","line":129,"updated":"2014-01-06 14:29:27.000000000","message":"it would be nicer to pack this into method, e.g. build_data_dict(self, data)","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"cf20b34af092b839507e6bb55b6c8b095bb4e752","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            context.pop(\u0027lifetime_units\u0027)"},{"line_number":127,"context_line":"            context.pop(\u0027lifetime_value\u0027)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"            data \u003d {\u0027ikepolicy\u0027: {\u0027name\u0027: context[\u0027name\u0027],"},{"line_number":130,"context_line":"                                  \u0027description\u0027: context[\u0027description\u0027],"},{"line_number":131,"context_line":"                                  \u0027auth_algorithm\u0027: context[\u0027auth_algorithm\u0027],"},{"line_number":132,"context_line":"                                  \u0027encryption_algorithm\u0027: context["}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2BxEk%3D","line":129,"in_reply_to":"AAAAUH%2F%2F8II%3D","updated":"2014-01-22 12:15:06.000000000","message":"I\u0027m afraid it won\u0027t make the code more readable.","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"a0a9f4091e4d04634261e325769f998e5e6acb26","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                                      \u0027phase1_negotiation_mode\u0027],"},{"line_number":139,"context_line":"                                  }}"},{"line_number":140,"context_line":"            ikepolicy \u003d api.vpn.ikepolicy_update("},{"line_number":141,"context_line":"                request, context[\u0027ikepolicy_id\u0027], **data)"},{"line_number":142,"context_line":"            msg \u003d (_(\u0027IKE Policy %s was successfully updated.\u0027)"},{"line_number":143,"context_line":"                   % context[\u0027name\u0027])"},{"line_number":144,"context_line":"            LOG.debug(msg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F8IE%3D","line":141,"updated":"2014-01-06 14:29:27.000000000","message":"Seems like this place is only occurrence of calling api.vpn.ikepolicy_update. Could we change it to accept dictionary \u0027data\u0027 instead of **kwargs ? Then you could just pass  the dictionary without need of unpacking and packing it again, which seems very ugly to me.","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"cf20b34af092b839507e6bb55b6c8b095bb4e752","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                                      \u0027phase1_negotiation_mode\u0027],"},{"line_number":139,"context_line":"                                  }}"},{"line_number":140,"context_line":"            ikepolicy \u003d api.vpn.ikepolicy_update("},{"line_number":141,"context_line":"                request, context[\u0027ikepolicy_id\u0027], **data)"},{"line_number":142,"context_line":"            msg \u003d (_(\u0027IKE Policy %s was successfully updated.\u0027)"},{"line_number":143,"context_line":"                   % context[\u0027name\u0027])"},{"line_number":144,"context_line":"            LOG.debug(msg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2BxDE%3D","line":141,"in_reply_to":"AAAAUH%2F%2F8IE%3D","updated":"2014-01-22 12:15:06.000000000","message":"Good idea, thank you. However I\u0027m afraid that it works fine for rather small dictionaries. I have fixed the dictionary itself a bit and IMO it looks better now.","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"4e0e669a46b225efbdc9b7f7560ba618282d5104","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            return ikepolicy"},{"line_number":147,"context_line":"        except Exception:"},{"line_number":148,"context_line":"            msg \u003d _(\u0027Failed to update IKE Policy %s\u0027) % context[\u0027name\u0027]"},{"line_number":149,"context_line":"            LOG.info(msg)"},{"line_number":150,"context_line":"            redirect \u003d reverse(self.failure_url)"},{"line_number":151,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F3HE%3D","line":149,"updated":"2014-01-07 15:27:34.000000000","message":"I love logging the exceptions, but I find it useful to log the actual exception.  E.g.,\n\nexcept Exception as e:\n    LOG.info(\u0027%s: %s\u0027 % (msg, e))","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"cf20b34af092b839507e6bb55b6c8b095bb4e752","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            return ikepolicy"},{"line_number":147,"context_line":"        except Exception:"},{"line_number":148,"context_line":"            msg \u003d _(\u0027Failed to update IKE Policy %s\u0027) % context[\u0027name\u0027]"},{"line_number":149,"context_line":"            LOG.info(msg)"},{"line_number":150,"context_line":"            redirect \u003d reverse(self.failure_url)"},{"line_number":151,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2Bw%2Bg%3D","line":149,"in_reply_to":"AAAAUH%2F%2F3HE%3D","updated":"2014-01-22 12:15:06.000000000","message":"Done","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"a0a9f4091e4d04634261e325769f998e5e6acb26","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    failure_url \u003d \u0027horizon:project:vpn:index\u0027"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":175,"context_line":"        super(UpdateIPSecPolicy, self).__init__(request, *args, **kwargs)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        auth_algorithm_choices \u003d [(\"sha1\", \"sha1\")]"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F8IA%3D","line":174,"updated":"2014-01-06 14:29:27.000000000","message":"ditto","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"cf20b34af092b839507e6bb55b6c8b095bb4e752","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    failure_url \u003d \u0027horizon:project:vpn:index\u0027"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":175,"context_line":"        super(UpdateIPSecPolicy, self).__init__(request, *args, **kwargs)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        auth_algorithm_choices \u003d [(\"sha1\", \"sha1\")]"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2Bxgs%3D","line":174,"in_reply_to":"AAAAUH%2F%2F8IA%3D","updated":"2014-01-22 12:15:06.000000000","message":"Done","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"a0a9f4091e4d04634261e325769f998e5e6acb26","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                                      (\"ah-esp\", \"ah-esp\")]"},{"line_number":207,"context_line":"        self.fields[\u0027transform_protocol\u0027].choices \u003d transform_protocol_choices"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def handle(self, request, context):"},{"line_number":210,"context_line":"        try:"},{"line_number":211,"context_line":"            context.update({\u0027lifetime\u0027: {\u0027units\u0027: context[\u0027lifetime_units\u0027],"},{"line_number":212,"context_line":"                                         \u0027value\u0027: context[\u0027lifetime_value\u0027]}})"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F8H0%3D","line":209,"updated":"2014-01-06 14:29:27.000000000","message":"ditto","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"cf20b34af092b839507e6bb55b6c8b095bb4e752","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                                      (\"ah-esp\", \"ah-esp\")]"},{"line_number":207,"context_line":"        self.fields[\u0027transform_protocol\u0027].choices \u003d transform_protocol_choices"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def handle(self, request, context):"},{"line_number":210,"context_line":"        try:"},{"line_number":211,"context_line":"            context.update({\u0027lifetime\u0027: {\u0027units\u0027: context[\u0027lifetime_units\u0027],"},{"line_number":212,"context_line":"                                         \u0027value\u0027: context[\u0027lifetime_value\u0027]}})"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2Bw%2BQ%3D","line":209,"in_reply_to":"AAAAUH%2F%2F8H0%3D","updated":"2014-01-22 12:15:06.000000000","message":"Done","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"4e0e669a46b225efbdc9b7f7560ba618282d5104","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            return ipsecpolicy"},{"line_number":236,"context_line":"        except Exception:"},{"line_number":237,"context_line":"            msg \u003d _(\u0027Failed to update IPSec Policy %s\u0027) % context[\u0027name\u0027]"},{"line_number":238,"context_line":"            LOG.info(msg)"},{"line_number":239,"context_line":"            redirect \u003d reverse(self.failure_url)"},{"line_number":240,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F3G0%3D","line":238,"updated":"2014-01-07 15:27:34.000000000","message":"ditto","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"cf20b34af092b839507e6bb55b6c8b095bb4e752","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            return ipsecpolicy"},{"line_number":236,"context_line":"        except Exception:"},{"line_number":237,"context_line":"            msg \u003d _(\u0027Failed to update IPSec Policy %s\u0027) % context[\u0027name\u0027]"},{"line_number":238,"context_line":"            LOG.info(msg)"},{"line_number":239,"context_line":"            redirect \u003d reverse(self.failure_url)"},{"line_number":240,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2Bw%2BY%3D","line":238,"in_reply_to":"AAAAUH%2F%2F3G0%3D","updated":"2014-01-22 12:15:06.000000000","message":"Done","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"a0a9f4091e4d04634261e325769f998e5e6acb26","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    failure_url \u003d \u0027horizon:project:vpn:index\u0027"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":291,"context_line":"        super(UpdateIPSecSiteConnection, self).__init__("},{"line_number":292,"context_line":"            request, *args, **kwargs)"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F8Hw%3D","line":290,"updated":"2014-01-06 14:29:27.000000000","message":"ditto","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"cf20b34af092b839507e6bb55b6c8b095bb4e752","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    failure_url \u003d \u0027horizon:project:vpn:index\u0027"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":291,"context_line":"        super(UpdateIPSecSiteConnection, self).__init__("},{"line_number":292,"context_line":"            request, *args, **kwargs)"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2BxgY%3D","line":290,"in_reply_to":"AAAAUH%2F%2F8Hw%3D","updated":"2014-01-22 12:15:06.000000000","message":"Done","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"a0a9f4091e4d04634261e325769f998e5e6acb26","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                              (\"restart-by-peer\", \"restart-by-peer\")]"},{"line_number":303,"context_line":"        self.fields[\u0027dpd_action\u0027].choices \u003d dpd_action_choices"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def handle(self, request, context):"},{"line_number":306,"context_line":"        try:"},{"line_number":307,"context_line":"            context.update({\u0027dpd\u0027: {\u0027action\u0027: context[\u0027dpd_action\u0027],"},{"line_number":308,"context_line":"                                    \u0027interval\u0027: context[\u0027dpd_interval\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F8Ho%3D","line":305,"updated":"2014-01-06 14:29:27.000000000","message":"ditto","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"cf20b34af092b839507e6bb55b6c8b095bb4e752","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                              (\"restart-by-peer\", \"restart-by-peer\")]"},{"line_number":303,"context_line":"        self.fields[\u0027dpd_action\u0027].choices \u003d dpd_action_choices"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def handle(self, request, context):"},{"line_number":306,"context_line":"        try:"},{"line_number":307,"context_line":"            context.update({\u0027dpd\u0027: {\u0027action\u0027: context[\u0027dpd_action\u0027],"},{"line_number":308,"context_line":"                                    \u0027interval\u0027: context[\u0027dpd_interval\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2Bw7s%3D","line":305,"in_reply_to":"AAAAUH%2F%2F8Ho%3D","updated":"2014-01-22 12:15:06.000000000","message":"Done","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"50b973f5de5a0233ca6cf226347d7625c5996092","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            messages.success(request, msg)"},{"line_number":58,"context_line":"            return vpnservice"},{"line_number":59,"context_line":"        except Exception:"},{"line_number":60,"context_line":"            msg \u003d _(\u0027Failed to update VPN Service %s\u0027) % context[\u0027name\u0027]"},{"line_number":61,"context_line":"            LOG.info(msg)"},{"line_number":62,"context_line":"            redirect \u003d reverse(self.failure_url)"},{"line_number":63,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BwTs%3D","line":60,"updated":"2014-01-22 14:53:52.000000000","message":"Could you include a reason of exception in the message? At least it is worth logged.","commit_id":"5e51b148adce4233b259ab4889809db399cef12b"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d4545d1a21b2e3f0d009780302d76816e1d8f8f7","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            messages.success(request, msg)"},{"line_number":58,"context_line":"            return vpnservice"},{"line_number":59,"context_line":"        except Exception:"},{"line_number":60,"context_line":"            msg \u003d _(\u0027Failed to update VPN Service %s\u0027) % context[\u0027name\u0027]"},{"line_number":61,"context_line":"            LOG.info(msg)"},{"line_number":62,"context_line":"            redirect \u003d reverse(self.failure_url)"},{"line_number":63,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BvoI%3D","line":60,"in_reply_to":"AAAAUH%2F%2BwTs%3D","updated":"2014-01-23 08:49:57.000000000","message":"Done","commit_id":"5e51b148adce4233b259ab4889809db399cef12b"}],"openstack_dashboard/dashboards/project/vpn/tables.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":102,"context_line":"        forbid_updates \u003d set("},{"line_number":103,"context_line":"            [\"PENDING_CREATE\", \"PENDING_UPDATE\", \"PENDING_DELETE\"])"},{"line_number":104,"context_line":"        if datum and datum.status not in forbid_updates:"},{"line_number":105,"context_line":"            return True"},{"line_number":106,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fuak%3D","line":103,"updated":"2013-10-10 17:20:25.000000000","message":"It is better to define outside of the method. It means the set is defined whenever allowed is called, and we reuse it.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":102,"context_line":"        forbid_updates \u003d set("},{"line_number":103,"context_line":"            [\"PENDING_CREATE\", \"PENDING_UPDATE\", \"PENDING_DELETE\"])"},{"line_number":104,"context_line":"        if datum and datum.status not in forbid_updates:"},{"line_number":105,"context_line":"            return True"},{"line_number":106,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fk0s%3D","line":103,"in_reply_to":"AAAATH%2F%2Fuak%3D","updated":"2013-10-14 14:11:30.000000000","message":"Done","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":120,"context_line":"        try:"},{"line_number":121,"context_line":"            ipsecsiteconnections \u003d api.vpn.ipsecsiteconnections_get(request)"},{"line_number":122,"context_line":"            for c in ipsecsiteconnections:"},{"line_number":123,"context_line":"                if c.ikepolicy_id \u003d\u003d datum[\u0027id\u0027]:"},{"line_number":124,"context_line":"                    return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuZ8%3D","line":121,"updated":"2013-10-10 17:20:25.000000000","message":"How about passing filters ikepolicy_id\u003ddatum[\u0027id\u0027] to list_ipsecsiteconnections? Neutron API supports filters.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"01833b46d6539513bb16f91f4a339226fb42df1a","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":120,"context_line":"        try:"},{"line_number":121,"context_line":"            ipsecsiteconnections \u003d api.vpn.ipsecsiteconnections_get(request)"},{"line_number":122,"context_line":"            for c in ipsecsiteconnections:"},{"line_number":123,"context_line":"                if c.ikepolicy_id \u003d\u003d datum[\u0027id\u0027]:"},{"line_number":124,"context_line":"                    return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FbOI%3D","line":121,"in_reply_to":"AAAATH%2F%2Ff60%3D","updated":"2013-10-16 11:23:33.000000000","message":"Found out. Fixed.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"634d12347796fef8b957fca9601c394c3d81c7c9","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":120,"context_line":"        try:"},{"line_number":121,"context_line":"            ipsecsiteconnections \u003d api.vpn.ipsecsiteconnections_get(request)"},{"line_number":122,"context_line":"            for c in ipsecsiteconnections:"},{"line_number":123,"context_line":"                if c.ikepolicy_id \u003d\u003d datum[\u0027id\u0027]:"},{"line_number":124,"context_line":"                    return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Ff60%3D","line":121,"in_reply_to":"AAAATH%2F%2FjyU%3D","updated":"2013-10-15 12:00:41.000000000","message":"Thanks! CLI filters connections list very well, but this code doesn\u0027t work though. I will try to find out why.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"667a8b686d7b7ea71905675e8c7f74b3396feeff","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":120,"context_line":"        try:"},{"line_number":121,"context_line":"            ipsecsiteconnections \u003d api.vpn.ipsecsiteconnections_get(request)"},{"line_number":122,"context_line":"            for c in ipsecsiteconnections:"},{"line_number":123,"context_line":"                if c.ikepolicy_id \u003d\u003d datum[\u0027id\u0027]:"},{"line_number":124,"context_line":"                    return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FjyU%3D","line":121,"in_reply_to":"AAAATH%2F%2FkFc%3D","updated":"2013-10-14 15:23:05.000000000","message":"I am not sure we are in the same page.\nWhat I mean is:\n\n  conns \u003d api.vpn.ipsecsiteconnections_get(request, ikepolicy_id\u003ddatum[\u0027id\u0027])\n  if conns:\n    return False\n\nI haven\u0027t tested the code. Sorry if it doesn\u0027t work.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":120,"context_line":"        try:"},{"line_number":121,"context_line":"            ipsecsiteconnections \u003d api.vpn.ipsecsiteconnections_get(request)"},{"line_number":122,"context_line":"            for c in ipsecsiteconnections:"},{"line_number":123,"context_line":"                if c.ikepolicy_id \u003d\u003d datum[\u0027id\u0027]:"},{"line_number":124,"context_line":"                    return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FkFc%3D","line":121,"in_reply_to":"AAAATH%2F%2FuZ8%3D","updated":"2013-10-14 14:11:30.000000000","message":"May be we should we use lambda filter here. What do you think?","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":142,"context_line":"        try:"},{"line_number":143,"context_line":"            ipsecsiteconnections \u003d api.vpn.ipsecsiteconnections_get(request)"},{"line_number":144,"context_line":"            for c in ipsecsiteconnections:"},{"line_number":145,"context_line":"                if c.ipsecpolicy_id \u003d\u003d datum[\u0027id\u0027]:"},{"line_number":146,"context_line":"                    return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuZ0%3D","line":143,"updated":"2013-10-10 17:20:25.000000000","message":"Same as the above.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":142,"context_line":"        try:"},{"line_number":143,"context_line":"            ipsecsiteconnections \u003d api.vpn.ipsecsiteconnections_get(request)"},{"line_number":144,"context_line":"            for c in ipsecsiteconnections:"},{"line_number":145,"context_line":"                if c.ipsecpolicy_id \u003d\u003d datum[\u0027id\u0027]:"},{"line_number":146,"context_line":"                    return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FkFY%3D","line":143,"in_reply_to":"AAAATH%2F%2FuZ0%3D","updated":"2013-10-14 14:11:30.000000000","message":"Same question.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"class UpdateIPSecSiteConnectionLink(tables.LinkAction):"},{"line_number":154,"context_line":"    name \u003d \"updateipsecsiteconnection\""},{"line_number":155,"context_line":"    verbose_name \u003d _(\"Edit IPSec Site Connection\")"},{"line_number":156,"context_line":"    classes \u003d (\"btn-update\",)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def get_link_url(self, ipsecsiteconnection):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuZg%3D","line":155,"updated":"2013-10-10 17:20:25.000000000","message":"It seems too long in the action column in the table. How about using just \"Edit\"? It is an action of IPSec Site Conn table so there is not ambiguous at all.\n\nIf you change it, it is better to change other update label too.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"667a8b686d7b7ea71905675e8c7f74b3396feeff","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"class UpdateIPSecSiteConnectionLink(tables.LinkAction):"},{"line_number":154,"context_line":"    name \u003d \"updateipsecsiteconnection\""},{"line_number":155,"context_line":"    verbose_name \u003d _(\"Edit IPSec Site Connection\")"},{"line_number":156,"context_line":"    classes \u003d (\"btn-update\",)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def get_link_url(self, ipsecsiteconnection):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fjxs%3D","line":155,"in_reply_to":"AAAATH%2F%2FkvI%3D","updated":"2013-10-14 15:23:05.000000000","message":"Agree. I commented this before I saw L.197.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"class UpdateIPSecSiteConnectionLink(tables.LinkAction):"},{"line_number":154,"context_line":"    name \u003d \"updateipsecsiteconnection\""},{"line_number":155,"context_line":"    verbose_name \u003d _(\"Edit IPSec Site Connection\")"},{"line_number":156,"context_line":"    classes \u003d (\"btn-update\",)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def get_link_url(self, ipsecsiteconnection):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FkvI%3D","line":155,"in_reply_to":"AAAATH%2F%2FuZg%3D","updated":"2013-10-14 14:11:30.000000000","message":"I think if we are going to move IPSec Site Connection tab to VPN Services tab, we have to use recognizable \"Edit\" buttons. I suggest to use \"Edit connection\".","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def get_link_url(self, ipsecsiteconnection):"},{"line_number":159,"context_line":"        base_url \u003d reverse(\"horizon:project:vpn:updateipsecsiteconnection\","},{"line_number":160,"context_line":"            kwargs\u003d{\u0027ipsecsiteconnection_id\u0027: ipsecsiteconnection.id})"},{"line_number":161,"context_line":"        return base_url"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def allowed(self, request, datum\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuZo%3D","line":160,"updated":"2013-10-10 17:20:25.000000000","message":"The indent level should be aligned with \"horizon:project:...\".","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def get_link_url(self, ipsecsiteconnection):"},{"line_number":159,"context_line":"        base_url \u003d reverse(\"horizon:project:vpn:updateipsecsiteconnection\","},{"line_number":160,"context_line":"            kwargs\u003d{\u0027ipsecsiteconnection_id\u0027: ipsecsiteconnection.id})"},{"line_number":161,"context_line":"        return base_url"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def allowed(self, request, datum\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fkw4%3D","line":160,"in_reply_to":"AAAATH%2F%2FuZo%3D","updated":"2013-10-14 14:11:30.000000000","message":"Done","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"de0f14dd9cc296b10b4ccb43642b0435e7dff399","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def get_link_url(self, ikepolicy):"},{"line_number":116,"context_line":"        base_url \u003d reverse(\"horizon:project:vpn:update_ikepolicy\","},{"line_number":117,"context_line":"                           kwargs\u003d{\u0027ikepolicy_id\u0027: ikepolicy.id})"},{"line_number":118,"context_line":"        return base_url"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":121,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fhcw%3D","line":118,"updated":"2013-11-02 15:28:09.000000000","message":"return reverse(...)","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"49da2cc3845c75cdef2ccd01f7fef399c477bc3e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def get_link_url(self, ikepolicy):"},{"line_number":116,"context_line":"        base_url \u003d reverse(\"horizon:project:vpn:update_ikepolicy\","},{"line_number":117,"context_line":"                           kwargs\u003d{\u0027ikepolicy_id\u0027: ikepolicy.id})"},{"line_number":118,"context_line":"        return base_url"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":121,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FeKw%3D","line":118,"in_reply_to":"AAAATn%2F%2Fhcw%3D","updated":"2013-11-05 13:04:43.000000000","message":"Done","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"de0f14dd9cc296b10b4ccb43642b0435e7dff399","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            conns \u003d api.vpn.ipsecsiteconnections_get("},{"line_number":123,"context_line":"                request, ikepolicy_id\u003ddatum[\u0027id\u0027])"},{"line_number":124,"context_line":"            if conns:"},{"line_number":125,"context_line":"                return False"},{"line_number":126,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fhbc%3D","line":123,"updated":"2013-11-02 15:28:09.000000000","message":"Can you move this to tabs.py and add retrieved info to an attribute of ikepolicy?\n\nThis implementation requires API call per resource. If we have 100 policies, 100 API calls will be issued.","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"57b38354e29cd17c8d79891ebfbe7c9c9e434d48","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            conns \u003d api.vpn.ipsecsiteconnections_get("},{"line_number":123,"context_line":"                request, ikepolicy_id\u003ddatum[\u0027id\u0027])"},{"line_number":124,"context_line":"            if conns:"},{"line_number":125,"context_line":"                return False"},{"line_number":126,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FP8s%3D","line":123,"in_reply_to":"AAAATn%2F%2FUw8%3D","updated":"2013-11-12 09:20:27.000000000","message":"Agreed, we should reduce the number of API calls. I got it from the first time. What I may got wrong, that\u0027s how could we add some attributes to ikepolicy and ipsecpolicy in get_ipsecsiteconnectionstable_data in tabs.py without any API calls. I think that we need both values of ikepolicy.id and ikepolicy.ipsecsiteconns: id for using api.vpn.ikepolicy_get and then ipsecsiteconns (a list of connections ids) for adding an attribute. Moreover, I tried to add some attributes to policies in vpn.py. That looks like more readable but uses the same number of API calls. Please correct if I get your suggestion wrong. As for caching mechanism, I think it should work. May be a memoize is a good substitute for API calls in that case. What do you think?","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"df24232a9d4d37790dd1f5cc7183e3eaddb3008c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            conns \u003d api.vpn.ipsecsiteconnections_get("},{"line_number":123,"context_line":"                request, ikepolicy_id\u003ddatum[\u0027id\u0027])"},{"line_number":124,"context_line":"            if conns:"},{"line_number":125,"context_line":"                return False"},{"line_number":126,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FUw8%3D","line":123,"in_reply_to":"AAAATn%2F%2Fdvc%3D","updated":"2013-11-10 21:46:26.000000000","message":"api.vpn.ipsecsiteconnections() is called for each IKE policy. If we have 100 policies, 100 API calls will be issued. It should be avoided.\n\nIt does not matter where the API call is done, but the number of API calls should be small.\n\nMy initial idea is to call api.vpn.ipsecsiteconns_get and add some attributes in get_ipsecsiteconnectionstable_data in tables.py.\nIt really helps us reduce the number of API calls.\nIf it cannot, we should use some caching mechanism to reduce the number of API calls.","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"49da2cc3845c75cdef2ccd01f7fef399c477bc3e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            conns \u003d api.vpn.ipsecsiteconnections_get("},{"line_number":123,"context_line":"                request, ikepolicy_id\u003ddatum[\u0027id\u0027])"},{"line_number":124,"context_line":"            if conns:"},{"line_number":125,"context_line":"                return False"},{"line_number":126,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fdvc%3D","line":123,"in_reply_to":"AAAATn%2F%2Fhbc%3D","updated":"2013-11-05 13:04:43.000000000","message":"tabs.py already imports tables.py. If we move anything to tabs.py, we have to import tabs.py here and get cross-import.","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"de0f14dd9cc296b10b4ccb43642b0435e7dff399","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":143,"context_line":"        try:"},{"line_number":144,"context_line":"            conns \u003d api.vpn.ipsecsiteconnections_get("},{"line_number":145,"context_line":"                request, ipsecpolicy_id\u003ddatum[\u0027id\u0027])"},{"line_number":146,"context_line":"            if conns:"},{"line_number":147,"context_line":"                return False"},{"line_number":148,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FhbQ%3D","line":145,"updated":"2013-11-02 15:28:09.000000000","message":"Same as the above.","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"de0f14dd9cc296b10b4ccb43642b0435e7dff399","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        base_url \u003d reverse("},{"line_number":161,"context_line":"            \"horizon:project:vpn:update_ipsecsiteconnection\","},{"line_number":162,"context_line":"            kwargs\u003d{\u0027ipsecsiteconnection_id\u0027: ipsecsiteconnection.id})"},{"line_number":163,"context_line":"        return base_url"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":166,"context_line":"        if datum and datum.status not in forbid_updates:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fhcs%3D","line":163,"updated":"2013-11-02 15:28:09.000000000","message":"return reverse(....)","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"49da2cc3845c75cdef2ccd01f7fef399c477bc3e","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        base_url \u003d reverse("},{"line_number":161,"context_line":"            \"horizon:project:vpn:update_ipsecsiteconnection\","},{"line_number":162,"context_line":"            kwargs\u003d{\u0027ipsecsiteconnection_id\u0027: ipsecsiteconnection.id})"},{"line_number":163,"context_line":"        return base_url"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":166,"context_line":"        if datum and datum.status not in forbid_updates:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FeKs%3D","line":163,"in_reply_to":"AAAATn%2F%2Fhcs%3D","updated":"2013-11-05 13:04:43.000000000","message":"Done","commit_id":"cccf5f9160110bb1206ab8516051a8fab4b93cb2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d1e846febdddc7687dd1b9adef0d435e4bf95151","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":119,"context_line":"        try:"},{"line_number":120,"context_line":"            conns \u003d api.vpn.ipsecsiteconnections_get("},{"line_number":121,"context_line":"                request, ikepolicy_id\u003ddatum[\u0027id\u0027])"},{"line_number":122,"context_line":"            if conns:"},{"line_number":123,"context_line":"                return False"},{"line_number":124,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FUu8%3D","line":121,"updated":"2013-11-10 22:03:53.000000000","message":"I added another comment about the reason I have an objection on this.\n\nMy idea to address this is to call api.vpn.ipsecsiteconnections_get() and add ipsecsiteconns attribute to each ikepolicy in get_ipsecsiteconnectionstable_data, and use it here. It reduces the number of API calls from N to 1.","commit_id":"73284581af59d4d0826092d38da5b75773d1b8c6"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"8180db27577b4b6a6b1f3d37fe9e673dd7d2821c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":119,"context_line":"        try:"},{"line_number":120,"context_line":"            conns \u003d api.vpn.ipsecsiteconnections_get("},{"line_number":121,"context_line":"                request, ikepolicy_id\u003ddatum[\u0027id\u0027])"},{"line_number":122,"context_line":"            if conns:"},{"line_number":123,"context_line":"                return False"},{"line_number":124,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FC7k%3D","line":121,"in_reply_to":"AAAATn%2F%2FUu8%3D","updated":"2013-11-15 07:57:16.000000000","message":"I added \u0027ipsecsiteconns\u0027 attributes to ikepolicy and ipsecpolicy and used decorator for API call. Then I replaced all filtered API calls with common ones (request only, no kwargs), so values could be cached.","commit_id":"73284581af59d4d0826092d38da5b75773d1b8c6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d1e846febdddc7687dd1b9adef0d435e4bf95151","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":140,"context_line":"        try:"},{"line_number":141,"context_line":"            conns \u003d api.vpn.ipsecsiteconnections_get("},{"line_number":142,"context_line":"                request, ipsecpolicy_id\u003ddatum[\u0027id\u0027])"},{"line_number":143,"context_line":"            if conns:"},{"line_number":144,"context_line":"                return False"},{"line_number":145,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FUu4%3D","line":142,"updated":"2013-11-10 22:03:53.000000000","message":"Same as the above.","commit_id":"73284581af59d4d0826092d38da5b75773d1b8c6"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"8180db27577b4b6a6b1f3d37fe9e673dd7d2821c","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":140,"context_line":"        try:"},{"line_number":141,"context_line":"            conns \u003d api.vpn.ipsecsiteconnections_get("},{"line_number":142,"context_line":"                request, ipsecpolicy_id\u003ddatum[\u0027id\u0027])"},{"line_number":143,"context_line":"            if conns:"},{"line_number":144,"context_line":"                return False"},{"line_number":145,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FC7Y%3D","line":142,"in_reply_to":"AAAATn%2F%2FUu4%3D","updated":"2013-11-15 07:57:16.000000000","message":"Done","commit_id":"73284581af59d4d0826092d38da5b75773d1b8c6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"50b973f5de5a0233ca6cf226347d7625c5996092","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":132,"context_line":"        try:"},{"line_number":133,"context_line":"            if datum[\u0027ipsecsiteconns\u0027]:"},{"line_number":134,"context_line":"                return False"},{"line_number":135,"context_line":"        except Exception:"},{"line_number":136,"context_line":"            exceptions.handle(request,"},{"line_number":137,"context_line":"                _(\u0027Failed to retrieve associations with connections.\u0027))"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BwUk%3D","line":134,"updated":"2014-01-22 14:53:52.000000000","message":"the following works:\n\n  return not datum[\u0027ipsecsiteconns\u0027]","commit_id":"5e51b148adce4233b259ab4889809db399cef12b"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d4545d1a21b2e3f0d009780302d76816e1d8f8f7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":132,"context_line":"        try:"},{"line_number":133,"context_line":"            if datum[\u0027ipsecsiteconns\u0027]:"},{"line_number":134,"context_line":"                return False"},{"line_number":135,"context_line":"        except Exception:"},{"line_number":136,"context_line":"            exceptions.handle(request,"},{"line_number":137,"context_line":"                _(\u0027Failed to retrieve associations with connections.\u0027))"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BrnU%3D","line":134,"in_reply_to":"AAAAUH%2F%2BwUk%3D","updated":"2014-01-23 08:49:57.000000000","message":"Thanks! Done.","commit_id":"5e51b148adce4233b259ab4889809db399cef12b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"50b973f5de5a0233ca6cf226347d7625c5996092","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                return False"},{"line_number":135,"context_line":"        except Exception:"},{"line_number":136,"context_line":"            exceptions.handle(request,"},{"line_number":137,"context_line":"                _(\u0027Failed to retrieve associations with connections.\u0027))"},{"line_number":138,"context_line":"        return True"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BwUs%3D","line":137,"updated":"2014-01-22 14:53:52.000000000","message":"When does this exception occur? In tabs.py, ipsecpoliciesFormated is returned and it seems \"ipsecsiteconns\" field always exists.","commit_id":"5e51b148adce4233b259ab4889809db399cef12b"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d4545d1a21b2e3f0d009780302d76816e1d8f8f7","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                return False"},{"line_number":135,"context_line":"        except Exception:"},{"line_number":136,"context_line":"            exceptions.handle(request,"},{"line_number":137,"context_line":"                _(\u0027Failed to retrieve associations with connections.\u0027))"},{"line_number":138,"context_line":"        return True"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Brmk%3D","line":137,"in_reply_to":"AAAAUH%2F%2BwUs%3D","updated":"2014-01-23 08:49:57.000000000","message":"You are right. Removed.","commit_id":"5e51b148adce4233b259ab4889809db399cef12b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"50b973f5de5a0233ca6cf226347d7625c5996092","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                return False"},{"line_number":154,"context_line":"        except Exception:"},{"line_number":155,"context_line":"            exceptions.handle(request,"},{"line_number":156,"context_line":"                _(\u0027Failed to retrieve associations with connections.\u0027))"},{"line_number":157,"context_line":"        return True"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2BwUc%3D","line":156,"updated":"2014-01-22 14:53:52.000000000","message":"Same as the above","commit_id":"5e51b148adce4233b259ab4889809db399cef12b"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d4545d1a21b2e3f0d009780302d76816e1d8f8f7","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                return False"},{"line_number":154,"context_line":"        except Exception:"},{"line_number":155,"context_line":"            exceptions.handle(request,"},{"line_number":156,"context_line":"                _(\u0027Failed to retrieve associations with connections.\u0027))"},{"line_number":157,"context_line":"        return True"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2Brmc%3D","line":156,"in_reply_to":"AAAAUH%2F%2BwUc%3D","updated":"2014-01-23 08:49:57.000000000","message":"Done","commit_id":"5e51b148adce4233b259ab4889809db399cef12b"}],"openstack_dashboard/dashboards/project/vpn/templates/vpn/_updatevpnservice.html":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003c/div\u003e"},{"line_number":16,"context_line":"\u003cdiv class\u003d\"right\"\u003e"},{"line_number":17,"context_line":"    \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":18,"context_line":"    \u003cp\u003e{% trans \"You may update VPN Service attributes here: edit name, description or admin state.\" %}\u003c/p\u003e"},{"line_number":19,"context_line":"\u003c/div\u003e"},{"line_number":20,"context_line":"{% endblock %}"},{"line_number":21,"context_line":""}],"source_content_type":"text/html","patch_set":2,"id":"AAAATH%2F%2Fubk%3D","line":18,"updated":"2013-10-10 17:20:25.000000000","message":"From my experience, we don\u0027t need to list editable fields here. It requires additional efforts in developers and translators. If we see the fields in the form, it is obvious and the help message brings nothing more.\n\nIt applies to other templates.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003c/div\u003e"},{"line_number":16,"context_line":"\u003cdiv class\u003d\"right\"\u003e"},{"line_number":17,"context_line":"    \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":18,"context_line":"    \u003cp\u003e{% trans \"You may update VPN Service attributes here: edit name, description or admin state.\" %}\u003c/p\u003e"},{"line_number":19,"context_line":"\u003c/div\u003e"},{"line_number":20,"context_line":"{% endblock %}"},{"line_number":21,"context_line":""}],"source_content_type":"text/html","patch_set":2,"id":"AAAATH%2F%2FkXs%3D","line":18,"in_reply_to":"AAAATH%2F%2Fubk%3D","updated":"2013-10-14 14:11:30.000000000","message":"Strongly agreed. It was almost a place holder. Done.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"}],"openstack_dashboard/dashboards/project/vpn/templates/vpn/updateikepolicy.html":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"},{"line_number":10,"context_line":"  {% include \u0027project/vpn/_updateikepolicy.html\u0027 %}"},{"line_number":11,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":2,"id":"AAAATH%2F%2FucQ%3D","line":10,"updated":"2013-10-10 17:20:25.000000000","message":"I prefer _update_ikepolicy.html (with a delimiter _ between update and ikepolicy) just because it is easier to read.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"},{"line_number":10,"context_line":"  {% include \u0027project/vpn/_updateikepolicy.html\u0027 %}"},{"line_number":11,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":2,"id":"AAAATH%2F%2FkK8%3D","line":10,"in_reply_to":"AAAATH%2F%2FucQ%3D","updated":"2013-10-14 14:11:30.000000000","message":"Done","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"}],"openstack_dashboard/dashboards/project/vpn/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    UPDATEIKEPOLICY_PATH \u003d \u0027horizon:%s:vpn:updateikepolicy\u0027 % DASHBOARD"},{"line_number":56,"context_line":"    UPDATEIPSECPOLICY_PATH \u003d \u0027horizon:%s:vpn:updateipsecpolicy\u0027 % DASHBOARD"},{"line_number":57,"context_line":"    UPDATEVPNSERVICE_PATH \u003d \u0027horizon:%s:vpn:updatevpnservice\u0027 % DASHBOARD"},{"line_number":58,"context_line":"    UPDATEVPNCONNECTION_PATH \u003d \u0027horizon:%s:vpn:updateipsecsiteconnection\u0027 %\\"},{"line_number":59,"context_line":"        DASHBOARD"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def set_up_expect(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuZA%3D","line":58,"updated":"2013-10-10 17:20:25.000000000","message":"IMHO, we can use \"conn\" instead of \"connection\". It allows us to use a shorter name.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    UPDATEIKEPOLICY_PATH \u003d \u0027horizon:%s:vpn:updateikepolicy\u0027 % DASHBOARD"},{"line_number":56,"context_line":"    UPDATEIPSECPOLICY_PATH \u003d \u0027horizon:%s:vpn:updateipsecpolicy\u0027 % DASHBOARD"},{"line_number":57,"context_line":"    UPDATEVPNSERVICE_PATH \u003d \u0027horizon:%s:vpn:updatevpnservice\u0027 % DASHBOARD"},{"line_number":58,"context_line":"    UPDATEVPNCONNECTION_PATH \u003d \u0027horizon:%s:vpn:updateipsecsiteconnection\u0027 %\\"},{"line_number":59,"context_line":"        DASHBOARD"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def set_up_expect(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FkgU%3D","line":58,"updated":"2013-10-14 14:11:30.000000000","message":"Right. But we use this name only twice, and it doesn\u0027t increase number of code lines.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"634d12347796fef8b957fca9601c394c3d81c7c9","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    UPDATEIKEPOLICY_PATH \u003d \u0027horizon:%s:vpn:updateikepolicy\u0027 % DASHBOARD"},{"line_number":56,"context_line":"    UPDATEIPSECPOLICY_PATH \u003d \u0027horizon:%s:vpn:updateipsecpolicy\u0027 % DASHBOARD"},{"line_number":57,"context_line":"    UPDATEVPNSERVICE_PATH \u003d \u0027horizon:%s:vpn:updatevpnservice\u0027 % DASHBOARD"},{"line_number":58,"context_line":"    UPDATEVPNCONNECTION_PATH \u003d \u0027horizon:%s:vpn:updateipsecsiteconnection\u0027 %\\"},{"line_number":59,"context_line":"        DASHBOARD"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def set_up_expect(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FgdY%3D","line":58,"in_reply_to":"AAAATH%2F%2Fjq4%3D","updated":"2013-10-15 12:00:41.000000000","message":"Ok :)","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"667a8b686d7b7ea71905675e8c7f74b3396feeff","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    UPDATEIKEPOLICY_PATH \u003d \u0027horizon:%s:vpn:updateikepolicy\u0027 % DASHBOARD"},{"line_number":56,"context_line":"    UPDATEIPSECPOLICY_PATH \u003d \u0027horizon:%s:vpn:updateipsecpolicy\u0027 % DASHBOARD"},{"line_number":57,"context_line":"    UPDATEVPNSERVICE_PATH \u003d \u0027horizon:%s:vpn:updatevpnservice\u0027 % DASHBOARD"},{"line_number":58,"context_line":"    UPDATEVPNCONNECTION_PATH \u003d \u0027horizon:%s:vpn:updateipsecsiteconnection\u0027 %\\"},{"line_number":59,"context_line":"        DASHBOARD"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def set_up_expect(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fjq4%3D","line":58,"in_reply_to":"AAAATH%2F%2FkgU%3D","updated":"2013-10-14 15:23:05.000000000","message":"No problem. I just want to say we can use abbrev names for such case :-)","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":607,"context_line":"        res \u003d self.client.post(reverse(self.ADDVPNCONNECTION_PATH), form_data)"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        self.assertFormErrors(res, 3)"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"    @test.create_stubs({api.vpn: (\u0027vpnservice_get\u0027, )})"},{"line_number":612,"context_line":"    def test_update_vpnservice_get(self):"},{"line_number":613,"context_line":"        vpnservice \u003d self.vpnservices.first()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuYc%3D","line":610,"updated":"2013-10-10 17:20:25.000000000","message":"It is better to add tests for post. It covers handle() method.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":607,"context_line":"        res \u003d self.client.post(reverse(self.ADDVPNCONNECTION_PATH), form_data)"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        self.assertFormErrors(res, 3)"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"    @test.create_stubs({api.vpn: (\u0027vpnservice_get\u0027, )})"},{"line_number":612,"context_line":"    def test_update_vpnservice_get(self):"},{"line_number":613,"context_line":"        vpnservice \u003d self.vpnservices.first()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FksM%3D","line":610,"in_reply_to":"AAAATH%2F%2FuYc%3D","updated":"2013-10-14 14:11:30.000000000","message":"Sure. I\u0027m working on it just now.","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"40ebfb361a37a2509616763d264e75fae71ee552","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # retrieves ipsecsiteconnections"},{"line_number":96,"context_line":"        api.vpn.ipsecsiteconnections_get("},{"line_number":97,"context_line":"            IsA(http.HttpRequest)).MultipleTimes() \\"},{"line_number":98,"context_line":"                .AndReturn(self.ipsecsiteconnections.list())"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def set_up_expect_with_exception(self):"},{"line_number":101,"context_line":"        api.vpn.vpnservices_get("}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9CJk%3D","line":98,"updated":"2013-12-17 13:47:49.000000000","message":"This backslash is not required, you can just add a break anywhere inside the parens.","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"a4f12c7250284fb6d86a35dcc2d7d20a39d4a0e1","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # retrieves ipsecsiteconnections"},{"line_number":96,"context_line":"        api.vpn.ipsecsiteconnections_get("},{"line_number":97,"context_line":"            IsA(http.HttpRequest)).MultipleTimes() \\"},{"line_number":98,"context_line":"                .AndReturn(self.ipsecsiteconnections.list())"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def set_up_expect_with_exception(self):"},{"line_number":101,"context_line":"        api.vpn.vpnservices_get("}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2Bx5I%3D","line":98,"in_reply_to":"AAAATn%2F9CJk%3D","updated":"2014-01-22 12:13:00.000000000","message":"You are right, the indentation itself is also bad here. I will fix it in the next patch set. However we have a lot of backslash breaks in similar cases in Horizon and it seems more readable to me.","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"40ebfb361a37a2509616763d264e75fae71ee552","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        vpnservice \u003d self.vpnservices.first()"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"        api.vpn.vpnservice_get(IsA(http.HttpRequest), vpnservice.id)\\"},{"line_number":616,"context_line":"            .AndReturn(vpnservice)"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        self.mox.ReplayAll()"},{"line_number":619,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9CJc%3D","line":616,"updated":"2013-12-17 13:47:49.000000000","message":"ditto","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"40ebfb361a37a2509616763d264e75fae71ee552","unresolved":false,"context_lines":[{"line_number":628,"context_line":"        vpnservice \u003d self.vpnservices.first()"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        api.vpn.vpnservice_get(IsA(http.HttpRequest), vpnservice.id)\\"},{"line_number":631,"context_line":"            .AndReturn(vpnservice)"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        data \u003d {\u0027name\u0027: vpnservice.name,"},{"line_number":634,"context_line":"                \u0027description\u0027: vpnservice.description,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9CJQ%3D","line":631,"updated":"2013-12-17 13:47:49.000000000","message":"ditto","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"40ebfb361a37a2509616763d264e75fae71ee552","unresolved":false,"context_lines":[{"line_number":652,"context_line":"    def test_update_ikepolicy_get(self):"},{"line_number":653,"context_line":"        ikepolicy \u003d self.ikepolicies.first()"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"        api.vpn.ikepolicy_get(IsA(http.HttpRequest), ikepolicy.id)\\"},{"line_number":656,"context_line":"            .AndReturn(ikepolicy)"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9CJA%3D","line":655,"updated":"2013-12-17 13:47:49.000000000","message":"etc.","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"}],"openstack_dashboard/dashboards/project/vpn/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b2b409563ef97de2620d1a7330016845a8be48e","unresolved":false,"context_lines":[{"line_number":268,"context_line":"            except Exception as e:"},{"line_number":269,"context_line":"                redirect \u003d self.success_url"},{"line_number":270,"context_line":"                msg \u003d _("},{"line_number":271,"context_line":"                    \u0027Unable to retrieve IPSec Site Connection details. %s\u0027) % e"},{"line_number":272,"context_line":"                exceptions.handle(self.request, msg, redirect\u003dredirect)"},{"line_number":273,"context_line":"        return self._object"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FuXs%3D","line":271,"updated":"2013-10-10 17:20:25.000000000","message":"Please consider:\n\n  msg \u003d _(\u0027Unable to retrieve IPSec Site \u0027\n          \u0027Connection details. %s\u0027) % e","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"72c788bdb4d8067141eab2281b1aeb8379672df1","unresolved":false,"context_lines":[{"line_number":268,"context_line":"            except Exception as e:"},{"line_number":269,"context_line":"                redirect \u003d self.success_url"},{"line_number":270,"context_line":"                msg \u003d _("},{"line_number":271,"context_line":"                    \u0027Unable to retrieve IPSec Site Connection details. %s\u0027) % e"},{"line_number":272,"context_line":"                exceptions.handle(self.request, msg, redirect\u003dredirect)"},{"line_number":273,"context_line":"        return self._object"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FksE%3D","line":271,"in_reply_to":"AAAATH%2F%2FuXs%3D","updated":"2013-10-14 14:11:30.000000000","message":"Done","commit_id":"d2b45d065a18204a80cb12b625e0bdae5e85c2a1"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"40ebfb361a37a2509616763d264e75fae71ee552","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        return context"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _get_object(self, *args, **kwargs):"},{"line_number":155,"context_line":"        if not hasattr(self, \"_object\"):"},{"line_number":156,"context_line":"            vpnservice_id \u003d self.kwargs[\u0027vpnservice_id\u0027]"},{"line_number":157,"context_line":"            try:"},{"line_number":158,"context_line":"                self._object \u003d api.vpn.vpnservice_get("}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9CIE%3D","line":155,"updated":"2013-12-17 13:47:49.000000000","message":"Please use @memoized for caching.","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"a4f12c7250284fb6d86a35dcc2d7d20a39d4a0e1","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        return context"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _get_object(self, *args, **kwargs):"},{"line_number":155,"context_line":"        if not hasattr(self, \"_object\"):"},{"line_number":156,"context_line":"            vpnservice_id \u003d self.kwargs[\u0027vpnservice_id\u0027]"},{"line_number":157,"context_line":"            try:"},{"line_number":158,"context_line":"                self._object \u003d api.vpn.vpnservice_get("}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2B0P4%3D","line":155,"in_reply_to":"AAAATn%2F8t8c%3D","updated":"2014-01-22 12:13:00.000000000","message":"@Radomir Thank you! I forgot about your patch replacing all \"hasattr\" with @mamoized. Done.\n\n@Akihiro It seems that MultpleTimes() will be unnecessary when we remove all AttributeDict from vpn.py: https://review.openstack.org/#/c/66144/5/openstack_dashboard/dashboards/project/vpn/tests.py","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3e66bfddfab413dcbe14d16972c882a6a3ade36a","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        return context"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _get_object(self, *args, **kwargs):"},{"line_number":155,"context_line":"        if not hasattr(self, \"_object\"):"},{"line_number":156,"context_line":"            vpnservice_id \u003d self.kwargs[\u0027vpnservice_id\u0027]"},{"line_number":157,"context_line":"            try:"},{"line_number":158,"context_line":"                self._object \u003d api.vpn.vpnservice_get("}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F8t8c%3D","line":155,"in_reply_to":"AAAATn%2F9CIE%3D","updated":"2013-12-21 10:42:40.000000000","message":"The only side effect when using @memoized is that @memoized does not work when API call is mocked. It makes hard to write tests and we need to use MultpleTimes(). Using MultipleTimes is not a good practice since we cannot check the exact order of API calls.\n\n@Radomir\nIf I remember correctly, you are working on @memoized decorator. Does @memoized decorator work with mocked API call now?\n\nPersonally this approach is easy to understand the behavior and we can use this apprach until @memoized decorator works will mocked API call.\n\nThought?","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"40ebfb361a37a2509616763d264e75fae71ee552","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        return context"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def _get_object(self, *args, **kwargs):"},{"line_number":186,"context_line":"        if not hasattr(self, \"_object\"):"},{"line_number":187,"context_line":"            ikepolicy_id \u003d self.kwargs[\u0027ikepolicy_id\u0027]"},{"line_number":188,"context_line":"            try:"},{"line_number":189,"context_line":"                self._object \u003d api.vpn.ikepolicy_get("}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9CII%3D","line":186,"updated":"2013-12-17 13:47:49.000000000","message":"Please use @memoized for caching.","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"a4f12c7250284fb6d86a35dcc2d7d20a39d4a0e1","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        return context"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def _get_object(self, *args, **kwargs):"},{"line_number":186,"context_line":"        if not hasattr(self, \"_object\"):"},{"line_number":187,"context_line":"            ikepolicy_id \u003d self.kwargs[\u0027ikepolicy_id\u0027]"},{"line_number":188,"context_line":"            try:"},{"line_number":189,"context_line":"                self._object \u003d api.vpn.ikepolicy_get("}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2B0Vo%3D","line":186,"in_reply_to":"AAAATn%2F9CII%3D","updated":"2014-01-22 12:13:00.000000000","message":"Done","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"40ebfb361a37a2509616763d264e75fae71ee552","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        return context"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def _get_object(self, *args, **kwargs):"},{"line_number":224,"context_line":"        if not hasattr(self, \"_object\"):"},{"line_number":225,"context_line":"            ipsecpolicy_id \u003d self.kwargs[\u0027ipsecpolicy_id\u0027]"},{"line_number":226,"context_line":"            try:"},{"line_number":227,"context_line":"                self._object \u003d api.vpn.ipsecpolicy_get("}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9CIM%3D","line":224,"updated":"2013-12-17 13:47:49.000000000","message":"Please use @memoized for caching","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"a4f12c7250284fb6d86a35dcc2d7d20a39d4a0e1","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        return context"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def _get_object(self, *args, **kwargs):"},{"line_number":224,"context_line":"        if not hasattr(self, \"_object\"):"},{"line_number":225,"context_line":"            ipsecpolicy_id \u003d self.kwargs[\u0027ipsecpolicy_id\u0027]"},{"line_number":226,"context_line":"            try:"},{"line_number":227,"context_line":"                self._object \u003d api.vpn.ipsecpolicy_get("}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2B0Vc%3D","line":224,"in_reply_to":"AAAATn%2F9CIM%3D","updated":"2014-01-22 12:13:00.000000000","message":"Done","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"40ebfb361a37a2509616763d264e75fae71ee552","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        return context"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def _get_object(self, *args, **kwargs):"},{"line_number":263,"context_line":"        if not hasattr(self, \"_object\"):"},{"line_number":264,"context_line":"            ipsecsiteconnection_id \u003d self.kwargs[\u0027ipsecsiteconnection_id\u0027]"},{"line_number":265,"context_line":"            try:"},{"line_number":266,"context_line":"                self._object \u003d api.vpn.ipsecsiteconnection_get("}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9CIU%3D","line":263,"updated":"2013-12-17 13:47:49.000000000","message":"Please use @memoized for caching.","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"a4f12c7250284fb6d86a35dcc2d7d20a39d4a0e1","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        return context"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def _get_object(self, *args, **kwargs):"},{"line_number":263,"context_line":"        if not hasattr(self, \"_object\"):"},{"line_number":264,"context_line":"            ipsecsiteconnection_id \u003d self.kwargs[\u0027ipsecsiteconnection_id\u0027]"},{"line_number":265,"context_line":"            try:"},{"line_number":266,"context_line":"                self._object \u003d api.vpn.ipsecsiteconnection_get("}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2B0VY%3D","line":263,"in_reply_to":"AAAATn%2F9CIU%3D","updated":"2014-01-22 12:13:00.000000000","message":"Done","commit_id":"3e9ec26f4dc23553523e538695d65f6e347845c9"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"4e0e669a46b225efbdc9b7f7560ba618282d5104","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    import forms as vpn_forms"},{"line_number":33,"context_line":"from openstack_dashboard.dashboards.project.vpn import tabs as vpn_tabs"},{"line_number":34,"context_line":"from openstack_dashboard.dashboards.project.vpn \\"},{"line_number":35,"context_line":"    import workflows as vpn_workflows"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"import re"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F3DE%3D","line":35,"updated":"2014-01-07 15:27:34.000000000","message":"Good cleanup","commit_id":"be656e8341e51fe6701cc707744d3a2bcf5bd799"}]}
