)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"1e988c7395042fa07769a0fa2daf34e671341f97","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix non-API bound filters in project and admin instance index pages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Non-API bound filters in instance index pages were broken by commit df194c"},{"line_number":10,"context_line":"(\"Make API calls in Instances view parallel\"). This fixes it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I504caaab2b6f256e7eb8c2605acaec39c004e80f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f515b1d_02f097fd","line":9,"range":{"start_line":9,"start_character":68,"end_line":9,"end_character":74},"updated":"2017-09-27 12:55:29.000000000","message":"Please, add Gerrit Change-Id here","commit_id":"650b093ebc6a4dc78842c53bc7d546510324fa47"},{"author":{"_account_id":26861,"name":"Huan Xiong","email":"huan.xiong@hxt-semitech.com","username":"rayx"},"change_message_id":"c48b6a7766a931e805f6ef5bdb0f9e2a115a679f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix non-API bound filters in project and admin instance index pages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Non-API bound filters in instance index pages were broken by commit df194c"},{"line_number":10,"context_line":"(\"Make API calls in Instances view parallel\"). This fixes it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I504caaab2b6f256e7eb8c2605acaec39c004e80f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f515b1d_3aa8428a","line":9,"range":{"start_line":9,"start_character":68,"end_line":9,"end_character":74},"in_reply_to":"7f515b1d_02f097fd","updated":"2017-09-28 07:50:18.000000000","message":"Ivan, I rewrote the commit message to make it more clear what \nthe issue is and how I fix it. I also include the complete\nUUID string of the commit in question. Could you please take\na look at the new version? Note that I didn\u0027t add Gerrit\nChange-Id as you suggested because I don\u0027t see others doing\nthat in git commit messages. Let me know if you have more\ncomments on that.","commit_id":"650b093ebc6a4dc78842c53bc7d546510324fa47"}],"openstack_dashboard/dashboards/admin/instances/views.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"1e988c7395042fa07769a0fa2daf34e671341f97","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        with futurist.ThreadPoolExecutor(max_workers\u003d4) as e:"},{"line_number":166,"context_line":"            e.submit(fn\u003d_task_get_tenants)"},{"line_number":167,"context_line":"            e.submit(fn\u003d_task_get_images)"},{"line_number":168,"context_line":"            e.submit(fn\u003d_task_get_flavors)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        if \u0027project\u0027 in search_opts and \\"},{"line_number":171,"context_line":"                not swap_filter(tenants, search_opts, \u0027project\u0027, \u0027tenant_id\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_e257bbc9","line":168,"updated":"2017-09-27 12:55:29.000000000","message":"If we remove _task_get_instances call here, max_workers value should be changed to 3","commit_id":"650b093ebc6a4dc78842c53bc7d546510324fa47"},{"author":{"_account_id":26861,"name":"Huan Xiong","email":"huan.xiong@hxt-semitech.com","username":"rayx"},"change_message_id":"c48b6a7766a931e805f6ef5bdb0f9e2a115a679f","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        with futurist.ThreadPoolExecutor(max_workers\u003d4) as e:"},{"line_number":166,"context_line":"            e.submit(fn\u003d_task_get_tenants)"},{"line_number":167,"context_line":"            e.submit(fn\u003d_task_get_images)"},{"line_number":168,"context_line":"            e.submit(fn\u003d_task_get_flavors)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        if \u0027project\u0027 in search_opts and \\"},{"line_number":171,"context_line":"                not swap_filter(tenants, search_opts, \u0027project\u0027, \u0027tenant_id\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_fa7e2a17","line":168,"in_reply_to":"7f515b1d_e257bbc9","updated":"2017-09-28 07:50:18.000000000","message":"Done","commit_id":"650b093ebc6a4dc78842c53bc7d546510324fa47"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"1e988c7395042fa07769a0fa2daf34e671341f97","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                self._more \u003d False"},{"line_number":181,"context_line":"                return instances"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        _task_get_instances()"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        # Loop through instances to get flavor and tenant info."},{"line_number":186,"context_line":"        for inst in instances:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_e23e9b89","line":183,"updated":"2017-09-27 12:55:29.000000000","message":"Why do we need to move it here?","commit_id":"650b093ebc6a4dc78842c53bc7d546510324fa47"},{"author":{"_account_id":26861,"name":"Huan Xiong","email":"huan.xiong@hxt-semitech.com","username":"rayx"},"change_message_id":"c48b6a7766a931e805f6ef5bdb0f9e2a115a679f","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                self._more \u003d False"},{"line_number":181,"context_line":"                return instances"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        _task_get_instances()"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        # Loop through instances to get flavor and tenant info."},{"line_number":186,"context_line":"        for inst in instances:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_ba1e72b8","line":183,"in_reply_to":"7f515b1d_e23e9b89","updated":"2017-09-28 07:50:18.000000000","message":"I rewrote the commit message. Hopefully it answers that\nquestion. The key point is that _task_get_instances() calls\nNova List-Servers API with search_opts parameter. That\nparameter may contain keys that OpenStack Dashboard UI\nsupports but Nova API doesn\u0027t. So those keys have to be\nconverted first before calling _task_get_instances(). \nFrom what I tell in code history, that\u0027s how the code used\nto work. Commit df194c8b4c25c6128f03a98fd0e628ba14b743ff\nseemed to be misunderstand that piece of code (see comments\nin line 170-175 in original version, which I removed) and\nbroke it.","commit_id":"650b093ebc6a4dc78842c53bc7d546510324fa47"}]}
