)]}'
{"horizon/forms/fields.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"07b3b01036ca94f687bd69b175ffb72fe2555ace","unresolved":false,"context_lines":[{"line_number":527,"context_line":""},{"line_number":528,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":529,"context_line":"        super(ThemableCheckboxChoiceInput, self).__init__(*args, **kwargs)"},{"line_number":530,"context_line":"        if self.value:"},{"line_number":531,"context_line":"            self.value \u003d set(force_text(v) for v in self.value)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def is_checked(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_f12afde4","line":530,"range":{"start_line":530,"start_character":8,"end_line":530,"end_character":22},"updated":"2017-10-07 06:52:24.000000000","message":"Is there a case where self.value is None? If self.value is an empty list or collection, L.531 works correctly.\n\nIf we follow the existing django patterns, some pointers would be helpful.","commit_id":"6b083b1531a36c51f7c62e3e37b5cf5e73d54098"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"07b3b01036ca94f687bd69b175ffb72fe2555ace","unresolved":false,"context_lines":[{"line_number":531,"context_line":"            self.value \u003d set(force_text(v) for v in self.value)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def is_checked(self):"},{"line_number":534,"context_line":"        if self.value:"},{"line_number":535,"context_line":"            return self.choice_value in self.value"},{"line_number":536,"context_line":"        return False"},{"line_number":537,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_716ccd35","line":534,"range":{"start_line":534,"start_character":8,"end_line":534,"end_character":22},"updated":"2017-10-07 06:52:24.000000000","message":"Same as the above","commit_id":"6b083b1531a36c51f7c62e3e37b5cf5e73d54098"}],"openstack_dashboard/dashboards/project/instances/workflows/create_instance.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"07b3b01036ca94f687bd69b175ffb72fe2555ace","unresolved":false,"context_lines":[{"line_number":718,"context_line":""},{"line_number":719,"context_line":"        # NOTE(e0ne): we don\u0027t need \u0027required attribute for networks"},{"line_number":720,"context_line":"        # checkboxes to be able to select only one network"},{"line_number":721,"context_line":"        self.use_required_attribute \u003d False"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        network_list \u003d self.fields[\"network\"].choices"},{"line_number":724,"context_line":"        if len(network_list) \u003d\u003d 1:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_918509d2","line":721,"updated":"2017-10-07 06:52:24.000000000","message":"When do we need this?\n\nI tried the launch instance workflow after commenting out this line, but it seems to work well.\n- I created two tenant networks\n- launch an instance with one network\n- launch an instance with two networks\n\nboth instances succeeded to launch.","commit_id":"6b083b1531a36c51f7c62e3e37b5cf5e73d54098"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fcfa566aa55d088458c2de5d7647f5ba1e058945","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        # NOTE(e0ne): we don\u0027t need \u0027required attribute for networks"},{"line_number":720,"context_line":"        # checkboxes to be able to select only one network"},{"line_number":721,"context_line":"        # NOTE(e0ne): we need it for compatibility with different"},{"line_number":722,"context_line":"        # Django versions (prior to 1.11)"},{"line_number":723,"context_line":"        self.use_required_attribute \u003d False"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        network_list \u003d self.fields[\"network\"].choices"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f4e5783_21a870d9","line":722,"range":{"start_line":722,"start_character":26,"end_line":722,"end_character":41},"updated":"2017-10-12 04:40:38.000000000","message":"I updated the version information. In my testing with Django 1.11, this has no effect and per your comment it is needed for the other versions.","commit_id":"c13d6da80e7a68c28aa0adfe63459be8a6dbedfd"}]}
