)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"f09896adaf56b2a7e46f210189543a10b4726e68","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Leon \u003csteve.leon@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-11-22 13:09:20 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update troveclient to 1.0.1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes: Bug #1238121"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAATn%2F%2BlCo%3D","line":7,"updated":"2013-11-22 21:22:07.000000000","message":"please update to be \u003e\u003d 1.0.0","commit_id":"83b22edbab9cf1d9774f62889004c32655da425c"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"8152fc0011d3f0a5284a43f7fb41949070e1cb80","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update troveclient to 1.0.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes: Bug #1238121"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Author: Robert Myers \u003crobert.myers@rackspace.com\u003e"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"AAAATn%2F%2Bj4Y%3D","line":9,"updated":"2013-11-23 12:16:41.000000000","message":"Please correct:\nFixes Bug #1238121\nor\nCloses-bug: #1238121","commit_id":"3436761c19097f99e40a6ae069077e6476a15c5a"}],"openstack_dashboard/api/trove.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"787edb004793c92212b76075bbf66f9e00d77c24","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from django.conf import settings  # noqa"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from horizon import exceptions"},{"line_number":22,"context_line":"from openstack_dashboard.api import base"},{"line_number":23,"context_line":"try:"},{"line_number":24,"context_line":"    from troveclient.v1 import client"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FeZU%3D","line":21,"updated":"2013-10-15 18:10:45.000000000","message":"not needed","commit_id":"c4c336f8b5b3dbf0cdccfee6f6c371ace174c68d"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"787edb004793c92212b76075bbf66f9e00d77c24","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    insecure \u003d getattr(settings, \u0027OPENSTACK_SSL_NO_VERIFY\u0027, False)"},{"line_number":36,"context_line":"    cacert \u003d getattr(settings, \u0027OPENSTACK_SSL_CACERT\u0027, None)"},{"line_number":37,"context_line":"    trove_url \u003d None"},{"line_number":38,"context_line":"    try:"},{"line_number":39,"context_line":"        trove_url \u003d base.url_for(request, \u0027database\u0027)"},{"line_number":40,"context_line":"    except exceptions.ServiceCatalogException:"},{"line_number":41,"context_line":"        LOG.debug(\u0027no database service configured.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FeZs%3D","line":38,"updated":"2013-10-15 18:10:45.000000000","message":"remove.  If we just catch the error here and eat it, then then the next developer won\u0027t realize they are making a call to troveclient when the service is not available.  The way this is implemented you\u0027ll end up with a None doesn\u0027t have attibute/method exception anyway that masks the real error, that the service isn\u0027t in the catalog.  So let the original exception flow.  For now, the database panels already have the service check and we won\u0027t hit the exception case.","commit_id":"c4c336f8b5b3dbf0cdccfee6f6c371ace174c68d"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"787edb004793c92212b76075bbf66f9e00d77c24","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    trove_url \u003d None"},{"line_number":38,"context_line":"    try:"},{"line_number":39,"context_line":"        trove_url \u003d base.url_for(request, \u0027database\u0027)"},{"line_number":40,"context_line":"    except exceptions.ServiceCatalogException:"},{"line_number":41,"context_line":"        LOG.debug(\u0027no database service configured.\u0027)"},{"line_number":42,"context_line":"        return None"},{"line_number":43,"context_line":"    LOG.debug(\u0027troveclient connection created using token \"%s\" and url \"%s\"\u0027 %"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FeZg%3D","line":40,"updated":"2013-10-15 18:10:45.000000000","message":"remove","commit_id":"c4c336f8b5b3dbf0cdccfee6f6c371ace174c68d"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"787edb004793c92212b76075bbf66f9e00d77c24","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        trove_url \u003d base.url_for(request, \u0027database\u0027)"},{"line_number":40,"context_line":"    except exceptions.ServiceCatalogException:"},{"line_number":41,"context_line":"        LOG.debug(\u0027no database service configured.\u0027)"},{"line_number":42,"context_line":"        return None"},{"line_number":43,"context_line":"    LOG.debug(\u0027troveclient connection created using token \"%s\" and url \"%s\"\u0027 %"},{"line_number":44,"context_line":"              (request.user.token.id, trove_url))"},{"line_number":45,"context_line":"    c \u003d client.Client(request.user.username,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FeZw%3D","line":42,"updated":"2013-10-15 18:10:45.000000000","message":"return None just eats the error.","commit_id":"c4c336f8b5b3dbf0cdccfee6f6c371ace174c68d"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"787edb004793c92212b76075bbf66f9e00d77c24","unresolved":false,"context_lines":[{"line_number":44,"context_line":"              (request.user.token.id, trove_url))"},{"line_number":45,"context_line":"    c \u003d client.Client(request.user.username,"},{"line_number":46,"context_line":"                      request.user.token.id,"},{"line_number":47,"context_line":"                      project_id\u003drequest.user.tenant_id,"},{"line_number":48,"context_line":"                      auth_url\u003dtrove_url,"},{"line_number":49,"context_line":"                      insecure\u003dinsecure,"},{"line_number":50,"context_line":"                      cacert\u003dcacert,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Febg%3D","line":47,"updated":"2013-10-15 18:10:45.000000000","message":"replace tenant_id with project_id.  Slow conversion process in Horizon.","commit_id":"c4c336f8b5b3dbf0cdccfee6f6c371ace174c68d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0089c3e8895f4dab77e15481711cb6491558b559","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from django.conf import settings  # noqa"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from openstack_dashboard.api import base"},{"line_number":22,"context_line":"from troveclient.v1 import client"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2BiYM%3D","line":22,"updated":"2013-11-24 22:27:00.000000000","message":"troveclient is third party module from the point of view of Horizon/dashboard. Please move it before L.21 with a blank line.","commit_id":"acb8437e3b8dcff863a4f4fa7f208e3c1592be6f"}],"openstack_dashboard/dashboards/project/database_backups/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0089c3e8895f4dab77e15481711cb6491558b559","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class DatabasesBackupsTests(test.TestCase):"},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(DatabasesBackupsTests, self).setUp()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @test.create_stubs({api.trove: (\u0027backup_list\u0027, )})"},{"line_number":34,"context_line":"    def test_index(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2BiYw%3D","line":31,"updated":"2013-11-24 22:27:00.000000000","message":"setUp is no longer required.","commit_id":"acb8437e3b8dcff863a4f4fa7f208e3c1592be6f"}],"openstack_dashboard/dashboards/project/databases/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0089c3e8895f4dab77e15481711cb6491558b559","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class DatabaseTests(test.TestCase):"},{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        super(DatabaseTests, self).setUp()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @test.create_stubs("},{"line_number":39,"context_line":"        {api.trove: (\u0027instance_list\u0027, \u0027flavor_list\u0027)})"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2BiYs%3D","line":36,"updated":"2013-11-24 22:27:00.000000000","message":"setUp is no longer required.","commit_id":"acb8437e3b8dcff863a4f4fa7f208e3c1592be6f"}],"openstack_dashboard/exceptions.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0089c3e8895f4dab77e15481711cb6491558b559","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                neutronclient.Forbidden,"},{"line_number":40,"context_line":"                heatclient.HTTPUnauthorized,"},{"line_number":41,"context_line":"                heatclient.HTTPForbidden,"},{"line_number":42,"context_line":"                troveclient.Unauthorized,)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"NOT_FOUND \u003d (keystoneclient.NotFound,"},{"line_number":45,"context_line":"             cinderclient.NotFound,"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2BiYk%3D","line":42,"updated":"2013-11-24 22:27:00.000000000","message":"It is better to place the closing parenthesis in the next line. It reduces a diff in the future.","commit_id":"acb8437e3b8dcff863a4f4fa7f208e3c1592be6f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0089c3e8895f4dab77e15481711cb6491558b559","unresolved":false,"context_lines":[{"line_number":48,"context_line":"             neutronclient.NetworkNotFoundClient,"},{"line_number":49,"context_line":"             neutronclient.PortNotFoundClient,"},{"line_number":50,"context_line":"             heatclient.HTTPNotFound,"},{"line_number":51,"context_line":"             troveclient.NotFound,)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# NOTE(gabriel): This is very broad, and may need to be dialed in."},{"line_number":54,"context_line":"RECOVERABLE \u003d (keystoneclient.ClientException,"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2BiYg%3D","line":51,"updated":"2013-11-24 22:27:00.000000000","message":"ditto","commit_id":"acb8437e3b8dcff863a4f4fa7f208e3c1592be6f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0089c3e8895f4dab77e15481711cb6491558b559","unresolved":false,"context_lines":[{"line_number":68,"context_line":"               neutronclient.StateInvalidClient,"},{"line_number":69,"context_line":"               swiftclient.ClientException,"},{"line_number":70,"context_line":"               heatclient.HTTPException,"},{"line_number":71,"context_line":"               troveclient.ClientException,)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2BiYc%3D","line":71,"updated":"2013-11-24 22:27:00.000000000","message":"ditto","commit_id":"acb8437e3b8dcff863a4f4fa7f208e3c1592be6f"}],"openstack_dashboard/test/test_data/utils.py":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"9c11a9a42300cce958a0cb81ced692530f8f0d56","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"import troveclient"},{"line_number":15,"context_line":"assert troveclient"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2BlRs%3D","line":14,"updated":"2013-11-22 20:22:12.000000000","message":"This can be removed as it is not used in this file","commit_id":"fd5c651e9b5adb2706fe47231a2652c7e9e93673"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0089c3e8895f4dab77e15481711cb6491558b559","unresolved":false,"context_lines":[{"line_number":35,"context_line":"               swift_data.data,"},{"line_number":36,"context_line":"               heat_data.data,"},{"line_number":37,"context_line":"               ceilometer_data.data,"},{"line_number":38,"context_line":"               trove_data.data,)"},{"line_number":39,"context_line":"    if load_onto:"},{"line_number":40,"context_line":"        for data_func in loaders:"},{"line_number":41,"context_line":"            data_func(load_onto)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2BiYU%3D","line":38,"updated":"2013-11-24 22:27:00.000000000","message":"I prefer to placing the closing parenthesis at the next line.","commit_id":"acb8437e3b8dcff863a4f4fa7f208e3c1592be6f"}]}
