)]}'
{"openstack_dashboard/api/nova.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"c2339f21c6ed6519974a5c0645fd8eff8896f681","unresolved":false,"context_lines":[{"line_number":524,"context_line":"    # is a list and it is easiest to handle it here."},{"line_number":525,"context_line":"    if nics:"},{"line_number":526,"context_line":"        is_auto_allocate \u003d any([nic.get(\u0027net-id\u0027) \u003d\u003d \u0027__auto_allocate__\u0027"},{"line_number":527,"context_line":"                                for nic in nics])"},{"line_number":528,"context_line":"        if is_auto_allocate:"},{"line_number":529,"context_line":"            nics \u003d \u0027auto\u0027"},{"line_number":530,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_d6d730bf","line":527,"updated":"2018-05-07 09:01:06.000000000","message":"nit: no need for [] here","commit_id":"79262a3c4369e85ac4faa1d2c5feaacf804d34a7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"adab1195f531e38a404e6255ca4a7b7f761f4605","unresolved":false,"context_lines":[{"line_number":524,"context_line":"    # is a list and it is easiest to handle it here."},{"line_number":525,"context_line":"    if nics:"},{"line_number":526,"context_line":"        is_auto_allocate \u003d any([nic.get(\u0027net-id\u0027) \u003d\u003d \u0027__auto_allocate__\u0027"},{"line_number":527,"context_line":"                                for nic in nics])"},{"line_number":528,"context_line":"        if is_auto_allocate:"},{"line_number":529,"context_line":"            nics \u003d \u0027auto\u0027"},{"line_number":530,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_5ccc9f34","line":527,"in_reply_to":"5f7c97a3_d6d730bf","updated":"2018-05-07 11:09:02.000000000","message":"Yeah, I sometimes forget to do this :(","commit_id":"79262a3c4369e85ac4faa1d2c5feaacf804d34a7"}],"openstack_dashboard/dashboards/project/instances/utils.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"294c6059d01f6580ccc4c09930f1a8e968c3ddac","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    tenant_id \u003d request.user.tenant_id"},{"line_number":103,"context_line":"    networks \u003d []"},{"line_number":104,"context_line":"    if api.base.is_service_enabled(request, \u0027network\u0027):"},{"line_number":105,"context_line":"        extra_params \u003d {}"},{"line_number":106,"context_line":"        if for_launch:"},{"line_number":107,"context_line":"            extra_params[\u0027include_pre_auto_allocate\u0027] \u003d True"},{"line_number":108,"context_line":"        try:"},{"line_number":109,"context_line":"            networks \u003d api.neutron.network_list_for_tenant("},{"line_number":110,"context_line":"                request, tenant_id, **extra_params)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_9450fd34","line":107,"range":{"start_line":105,"start_character":7,"end_line":107,"end_character":60},"updated":"2018-05-03 11:33:51.000000000","message":"Can we change it to:\nextra_params \u003d {\u0027include_pre_auto_allocate\u0027: for_launch}\n?","commit_id":"79262a3c4369e85ac4faa1d2c5feaacf804d34a7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"88d28320685df91e330fe72bd992eb1842df8001","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    tenant_id \u003d request.user.tenant_id"},{"line_number":103,"context_line":"    networks \u003d []"},{"line_number":104,"context_line":"    if api.base.is_service_enabled(request, \u0027network\u0027):"},{"line_number":105,"context_line":"        extra_params \u003d {}"},{"line_number":106,"context_line":"        if for_launch:"},{"line_number":107,"context_line":"            extra_params[\u0027include_pre_auto_allocate\u0027] \u003d True"},{"line_number":108,"context_line":"        try:"},{"line_number":109,"context_line":"            networks \u003d api.neutron.network_list_for_tenant("},{"line_number":110,"context_line":"                request, tenant_id, **extra_params)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_0a0edd8c","line":107,"range":{"start_line":105,"start_character":7,"end_line":107,"end_character":60},"in_reply_to":"5f7c97a3_9450fd34","updated":"2018-05-07 01:33:11.000000000","message":"Yes, but IIRC I would like not to change the existing arguments of network_list_for_tenant as much as possible. If we change arguments (i.e., include_pre_auto_allocate \u003d False), we need to change many method mocking accordingly. Thus, I decided to specify this only when required.","commit_id":"79262a3c4369e85ac4faa1d2c5feaacf804d34a7"}],"openstack_dashboard/dashboards/project/networks/tables.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"c2339f21c6ed6519974a5c0645fd8eff8896f681","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"def get_network_link(network):"},{"line_number":154,"context_line":"    if network.id \u003d\u003d api.neutron.AUTO_ALLOCATE_ID:"},{"line_number":155,"context_line":"        return"},{"line_number":156,"context_line":"    return reverse(\u0027horizon:project:networks:detail\u0027, args\u003d[network.id])"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_36bea465","line":155,"updated":"2018-05-07 09:01:06.000000000","message":"nit: would be nice to return None explicitly","commit_id":"79262a3c4369e85ac4faa1d2c5feaacf804d34a7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"adab1195f531e38a404e6255ca4a7b7f761f4605","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"def get_network_link(network):"},{"line_number":154,"context_line":"    if network.id \u003d\u003d api.neutron.AUTO_ALLOCATE_ID:"},{"line_number":155,"context_line":"        return"},{"line_number":156,"context_line":"    return reverse(\u0027horizon:project:networks:detail\u0027, args\u003d[network.id])"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_3cf0c367","line":155,"in_reply_to":"5f7c97a3_36bea465","updated":"2018-05-07 11:09:02.000000000","message":"Is your recommendation like https://stackoverflow.com/questions/15300550/python-return-return-none-and-no-return-at-all ? I would like to confirm the guideline.","commit_id":"79262a3c4369e85ac4faa1d2c5feaacf804d34a7"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"86558e76331c25d4a127dedf00cf27da8aa0a6e1","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"def get_network_link(network):"},{"line_number":154,"context_line":"    if network.id \u003d\u003d api.neutron.AUTO_ALLOCATE_ID:"},{"line_number":155,"context_line":"        return"},{"line_number":156,"context_line":"    return reverse(\u0027horizon:project:networks:detail\u0027, args\u003d[network.id])"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_1014cbf4","line":155,"in_reply_to":"5f7c97a3_3cf0c367","updated":"2018-05-07 12:29:09.000000000","message":"I think that when you have in your function one return with an explicit value, then it\u0027s better to have all returns have explicit values — then you can see better what is happening. \n\nThe logic behind this is that when you have implicit return or return with an implicit value, that\u0027s usually when you don\u0027t use the return value of the function at all. But when you do return something explicitly, it\u0027s nice to see what you are returning in each case.","commit_id":"79262a3c4369e85ac4faa1d2c5feaacf804d34a7"}]}