)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"78501533f025501f1a416a3835146c74beb26187","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Partially was discussed here:"},{"line_number":24,"context_line":"https://review.openstack.org/519202"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Iaf6282819c26c12ca24d19ef7dee00a5c8586418"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f485f77_7516b04b","line":25,"updated":"2017-11-17 13:06:49.000000000","message":"Please, add \u0027Closes-Bug: #1732567\u0027 to the commit message","commit_id":"a96c4a950949f28aff9a286477f2ba71d5f068ea"},{"author":{"_account_id":12841,"name":"Ivan Udovichenko","email":"iudovichenko@itkey.com","username":"ai"},"change_message_id":"5dd603c5e9922a4bbe68e4366bbcc089f53ae7ec","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Partially was discussed here:"},{"line_number":24,"context_line":"https://review.openstack.org/519202"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Iaf6282819c26c12ca24d19ef7dee00a5c8586418"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f485f77_35a718c0","line":25,"in_reply_to":"1f485f77_7516b04b","updated":"2017-11-17 13:14:21.000000000","message":"Done","commit_id":"a96c4a950949f28aff9a286477f2ba71d5f068ea"}],"openstack_dashboard/utils/settings.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"abd5323f3e25bfe71383656c24c4059fce147d1c","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            # which is explicitly included in style/themes as appropriate)"},{"line_number":265,"context_line":"            files \u003d [file for file in files if file.endswith(\u0027.js\u0027)]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        if isinstance(files, list):"},{"line_number":268,"context_line":"            # add to the list of files to link in the HTML"},{"line_number":269,"context_line":"            for file in files:"},{"line_number":270,"context_line":"                file \u003d \u0027horizon/lib/\u0027 + module.NAME + \u0027/\u0027 + file"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_6f424140","line":267,"updated":"2017-11-07 03:20:03.000000000","message":"The second element of each element of BASE_XSTATIC_MODULES must be a list. Why do we need this check? Is it just a misconfiguration of BASE_XSTATIC_MODULES?","commit_id":"c0988271a52196e55e58c7bc5afbec45b8918612"},{"author":{"_account_id":12841,"name":"Ivan Udovichenko","email":"iudovichenko@itkey.com","username":"ai"},"change_message_id":"6737628d3a307792510faf695241d005a47f7681","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            # which is explicitly included in style/themes as appropriate)"},{"line_number":265,"context_line":"            files \u003d [file for file in files if file.endswith(\u0027.js\u0027)]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        if isinstance(files, list):"},{"line_number":268,"context_line":"            # add to the list of files to link in the HTML"},{"line_number":269,"context_line":"            for file in files:"},{"line_number":270,"context_line":"                file \u003d \u0027horizon/lib/\u0027 + module.NAME + \u0027/\u0027 + file"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_f51357b7","line":267,"in_reply_to":"1f485f77_d06cf609","updated":"2017-11-12 22:35:17.000000000","message":"No, I was talking about \u0027None\u0027 values and this change request. To avoid \u0027None\u0027 values in default configuration I\u0027ve replaced them with empty lists: https://review.openstack.org/519202\nPlease take a look, I guess the provided approach without any doubts is the right one in this case.","commit_id":"c0988271a52196e55e58c7bc5afbec45b8918612"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"486978e64c7d67011d0656fe6800d80c406ce6be","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            # which is explicitly included in style/themes as appropriate)"},{"line_number":265,"context_line":"            files \u003d [file for file in files if file.endswith(\u0027.js\u0027)]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        if isinstance(files, list):"},{"line_number":268,"context_line":"            # add to the list of files to link in the HTML"},{"line_number":269,"context_line":"            for file in files:"},{"line_number":270,"context_line":"                file \u003d \u0027horizon/lib/\u0027 + module.NAME + \u0027/\u0027 + file"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_02ea3174","line":267,"in_reply_to":"1f485f77_f51357b7","updated":"2017-11-13 09:43:52.000000000","message":"I don\u0027t think it is a good idea to start a new review. It makes hard track the discussion. Why don\u0027t you update this review?","commit_id":"c0988271a52196e55e58c7bc5afbec45b8918612"},{"author":{"_account_id":24054,"name":"Ivan Udovichenko","email":"ii@zmailbox.ru"},"change_message_id":"8216bed97c0eadf0464d8623ad744ae36720d3c7","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            # which is explicitly included in style/themes as appropriate)"},{"line_number":265,"context_line":"            files \u003d [file for file in files if file.endswith(\u0027.js\u0027)]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        if isinstance(files, list):"},{"line_number":268,"context_line":"            # add to the list of files to link in the HTML"},{"line_number":269,"context_line":"            for file in files:"},{"line_number":270,"context_line":"                file \u003d \u0027horizon/lib/\u0027 + module.NAME + \u0027/\u0027 + file"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_ead29cfc","line":267,"in_reply_to":"3f4b6375_6f424140","updated":"2017-11-07 08:57:48.000000000","message":"It depends, if we expect \u0027None\u0027 values in BASE_XSTATIC_MODULES then this is a normal behavior and this check is required. If it should be avoided, I can just replace \u0027None\u0027 values with empty list if you agree with it.","commit_id":"c0988271a52196e55e58c7bc5afbec45b8918612"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"496fd050664b771e6639d56f6c986e3af8097658","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            # which is explicitly included in style/themes as appropriate)"},{"line_number":265,"context_line":"            files \u003d [file for file in files if file.endswith(\u0027.js\u0027)]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        if isinstance(files, list):"},{"line_number":268,"context_line":"            # add to the list of files to link in the HTML"},{"line_number":269,"context_line":"            for file in files:"},{"line_number":270,"context_line":"                file \u003d \u0027horizon/lib/\u0027 + module.NAME + \u0027/\u0027 + file"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_d06cf609","line":267,"in_reply_to":"3f4b6375_73d0ca2c","updated":"2017-11-11 08:21:14.000000000","message":"What are in your mind when you said \u0027which approach\u0027? \nThe current version vs to raise an appropriate error message?\nAt least, I believe it is not a good idea to ignore this .","commit_id":"c0988271a52196e55e58c7bc5afbec45b8918612"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f1778029c793ea0aad78a3b789975d73d5f0ee8d","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            # which is explicitly included in style/themes as appropriate)"},{"line_number":265,"context_line":"            files \u003d [file for file in files if file.endswith(\u0027.js\u0027)]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        if isinstance(files, list):"},{"line_number":268,"context_line":"            # add to the list of files to link in the HTML"},{"line_number":269,"context_line":"            for file in files:"},{"line_number":270,"context_line":"                file \u003d \u0027horizon/lib/\u0027 + module.NAME + \u0027/\u0027 + file"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_f83b7936","line":267,"in_reply_to":"3f4b6375_ead29cfc","updated":"2017-11-08 13:24:59.000000000","message":"L.182-186 says None is a possible value. I didn\u0027t notice it. As an example, https://github.com/openstack/horizon/blob/master/openstack_dashboard/utils/settings.py#L199\n\nHowever, \u0027None\u0027 means that the xstatic module does define a MAIN. In this case, L.259-265 should be processed (as the above quoted comment says).\n\nThus, if files is None here, it must be a misconfiguration or a xstatic packaging bug. I think it is not a good idea just to ignore this. Some error should be raised.","commit_id":"c0988271a52196e55e58c7bc5afbec45b8918612"},{"author":{"_account_id":12841,"name":"Ivan Udovichenko","email":"iudovichenko@itkey.com","username":"ai"},"change_message_id":"e8d1a88c7af86701126d6984f8d2b9fb5fd31268","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            # which is explicitly included in style/themes as appropriate)"},{"line_number":265,"context_line":"            files \u003d [file for file in files if file.endswith(\u0027.js\u0027)]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        if isinstance(files, list):"},{"line_number":268,"context_line":"            # add to the list of files to link in the HTML"},{"line_number":269,"context_line":"            for file in files:"},{"line_number":270,"context_line":"                file \u003d \u0027horizon/lib/\u0027 + module.NAME + \u0027/\u0027 + file"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_73d0ca2c","line":267,"in_reply_to":"3f4b6375_f83b7936","updated":"2017-11-08 13:46:09.000000000","message":"I agree, that is should raise errors due to misconfiguration. But it shouldn\u0027t happen with default configuration in my opinion. So we should decide which approach is better in this particular case.","commit_id":"c0988271a52196e55e58c7bc5afbec45b8918612"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"220f17497eba6db9c67d11a2149e30d5c5de93c8","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        \u0027angular-route.js\u0027"},{"line_number":197,"context_line":"    ]),"},{"line_number":198,"context_line":"    (\u0027xstatic.pkg.angular_bootstrap\u0027, [\u0027angular-bootstrap.js\u0027]),"},{"line_number":199,"context_line":"    (\u0027xstatic.pkg.angular_gettext\u0027, []),"},{"line_number":200,"context_line":"    (\u0027xstatic.pkg.angular_lrdragndrop\u0027, []),"},{"line_number":201,"context_line":"    (\u0027xstatic.pkg.angular_smart_table\u0027, []),"},{"line_number":202,"context_line":"    (\u0027xstatic.pkg.angular_fileupload\u0027, [\u0027ng-file-upload-all.js\u0027]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_0c9a6013","line":199,"range":{"start_line":199,"start_character":36,"end_line":199,"end_character":38},"updated":"2017-11-13 13:32:25.000000000","message":"I still do not understand why we need to ignore an error. \nFrom the discussion in the past comment, a traceback is caused by a misconfiguration. If it is correct, ignoring an error is not a good idea.\n\nWhat is the original problem?\n\nDo you see a case where None is specified but MAIN is not defined in a xstatic module? If so, what we should do is to fix such xstatic module. Anyway, just ignoring this is not a good idea.","commit_id":"a96c4a950949f28aff9a286477f2ba71d5f068ea"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"78501533f025501f1a416a3835146c74beb26187","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        \u0027angular-route.js\u0027"},{"line_number":197,"context_line":"    ]),"},{"line_number":198,"context_line":"    (\u0027xstatic.pkg.angular_bootstrap\u0027, [\u0027angular-bootstrap.js\u0027]),"},{"line_number":199,"context_line":"    (\u0027xstatic.pkg.angular_gettext\u0027, []),"},{"line_number":200,"context_line":"    (\u0027xstatic.pkg.angular_lrdragndrop\u0027, []),"},{"line_number":201,"context_line":"    (\u0027xstatic.pkg.angular_smart_table\u0027, []),"},{"line_number":202,"context_line":"    (\u0027xstatic.pkg.angular_fileupload\u0027, [\u0027ng-file-upload-all.js\u0027]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_95492c61","line":199,"range":{"start_line":199,"start_character":36,"end_line":199,"end_character":38},"in_reply_to":"1f485f77_0c9a6013","updated":"2017-11-17 13:06:49.000000000","message":"I\u0027m all for fixing such issue in XStatic packages. \n\nBut from horizon\u0027s perspective, we should take care if somebody added such package to local_setting.\n\nWe already have empty files list for some packages, e.g.: font_awesom. Let\u0027s keep code consistent and use the empty list as a default value  everywhere for xstatic file list","commit_id":"a96c4a950949f28aff9a286477f2ba71d5f068ea"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"78501533f025501f1a416a3835146c74beb26187","unresolved":false,"context_lines":[{"line_number":265,"context_line":"            files \u003d [file for file in files if file.endswith(\u0027.js\u0027)]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        # add to the list of files to link in the HTML"},{"line_number":268,"context_line":"        for file in files:"},{"line_number":269,"context_line":"            file \u003d \u0027horizon/lib/\u0027 + module.NAME + \u0027/\u0027 + file"},{"line_number":270,"context_line":"            HORIZON_CONFIG[\u0027xstatic_lib_files\u0027].append(file)"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_b5c30889","line":268,"updated":"2017-11-17 13:06:49.000000000","message":"We should care here if somebody provided not working setting and files list is None.\n\nI\u0027m not sure what actually should we do here: add some logging only or raise an exception.","commit_id":"a96c4a950949f28aff9a286477f2ba71d5f068ea"},{"author":{"_account_id":12841,"name":"Ivan Udovichenko","email":"iudovichenko@itkey.com","username":"ai"},"change_message_id":"7d1fd3078cb6259f9c520cbb7ae264d6ceb78d91","unresolved":false,"context_lines":[{"line_number":265,"context_line":"            files \u003d [file for file in files if file.endswith(\u0027.js\u0027)]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        # add to the list of files to link in the HTML"},{"line_number":268,"context_line":"        for file in files:"},{"line_number":269,"context_line":"            file \u003d \u0027horizon/lib/\u0027 + module.NAME + \u0027/\u0027 + file"},{"line_number":270,"context_line":"            HORIZON_CONFIG[\u0027xstatic_lib_files\u0027].append(file)"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_d5d20428","line":268,"in_reply_to":"1f485f77_b5c30889","updated":"2017-11-17 13:13:42.000000000","message":"It will fail anyway like it does for me now.\nIf we want to be sure about list, then we may include the first proposal by adding if \"isinstance(files, list):\" before this line, but anyway it\u0027s going to fail if MAIN is not defined.","commit_id":"a96c4a950949f28aff9a286477f2ba71d5f068ea"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e9d0199492825d2c20374b9a3b86579f2964199d","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                file \u003d \u0027horizon/lib/\u0027 + module.NAME + \u0027/\u0027 + file"},{"line_number":271,"context_line":"                HORIZON_CONFIG[\u0027xstatic_lib_files\u0027].append(file)"},{"line_number":272,"context_line":"        except TypeError:"},{"line_number":273,"context_line":"            raise Exception(\u0027%s: Nothing to include. Please check Horizon \u0027"},{"line_number":274,"context_line":"                            \u0027XStatic dependencies.\u0027 % (module_name))"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    return STATICFILES_DIRS"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_2c197584","line":274,"range":{"start_line":273,"start_character":53,"end_line":274,"end_character":50},"updated":"2017-11-21 15:43:29.000000000","message":"It is better to explain what is the usual reason. I think the current message is not so friendly.","commit_id":"249be17b1f5c2d9a3b63f9419bd21b2dd5640745"},{"author":{"_account_id":12841,"name":"Ivan Udovichenko","email":"iudovichenko@itkey.com","username":"ai"},"change_message_id":"88a21082ef7849b46656d3dcbca086bda0d47822","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                file \u003d \u0027horizon/lib/\u0027 + module.NAME + \u0027/\u0027 + file"},{"line_number":271,"context_line":"                HORIZON_CONFIG[\u0027xstatic_lib_files\u0027].append(file)"},{"line_number":272,"context_line":"        except TypeError:"},{"line_number":273,"context_line":"            raise Exception(\u0027%s: Nothing to include. Please check Horizon \u0027"},{"line_number":274,"context_line":"                            \u0027XStatic dependencies.\u0027 % (module_name))"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    return STATICFILES_DIRS"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_32830e56","line":274,"range":{"start_line":273,"start_character":53,"end_line":274,"end_character":50},"in_reply_to":"ff82abbf_2c197584","updated":"2017-11-21 16:17:40.000000000","message":"Done","commit_id":"249be17b1f5c2d9a3b63f9419bd21b2dd5640745"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c26b2c26a5a99a73ecfe48ced8e5e146bfa3f4a5","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                file \u003d \u0027horizon/lib/\u0027 + module.NAME + \u0027/\u0027 + file"},{"line_number":271,"context_line":"                HORIZON_CONFIG[\u0027xstatic_lib_files\u0027].append(file)"},{"line_number":272,"context_line":"        except TypeError:"},{"line_number":273,"context_line":"            raise Exception(\u0027%s: Nothing to include. Files to include were not \u0027"},{"line_number":274,"context_line":"                            \u0027defined in BASE_XSTATIC_MODULES list or XStatic \u0027"},{"line_number":275,"context_line":"                            \u0027module does not define MAIN list.\u0027 % (module_name))"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_6c48d2cb","line":273,"range":{"start_line":273,"start_character":70,"end_line":273,"end_character":74},"updated":"2017-11-21 22:04:04.000000000","message":"-\u003e are","commit_id":"07b7d5250ba1683cb4b3dca0b38be578f0ccc4c7"},{"author":{"_account_id":12841,"name":"Ivan Udovichenko","email":"iudovichenko@itkey.com","username":"ai"},"change_message_id":"602aea07dc7bfe956f31404c6493f5ece57866a5","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                file \u003d \u0027horizon/lib/\u0027 + module.NAME + \u0027/\u0027 + file"},{"line_number":271,"context_line":"                HORIZON_CONFIG[\u0027xstatic_lib_files\u0027].append(file)"},{"line_number":272,"context_line":"        except TypeError:"},{"line_number":273,"context_line":"            raise Exception(\u0027%s: Nothing to include. Files to include were not \u0027"},{"line_number":274,"context_line":"                            \u0027defined in BASE_XSTATIC_MODULES list or XStatic \u0027"},{"line_number":275,"context_line":"                            \u0027module does not define MAIN list.\u0027 % (module_name))"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_da4f4290","line":273,"range":{"start_line":273,"start_character":70,"end_line":273,"end_character":74},"in_reply_to":"ff82abbf_6c48d2cb","updated":"2017-11-22 10:04:12.000000000","message":"Done","commit_id":"07b7d5250ba1683cb4b3dca0b38be578f0ccc4c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c26b2c26a5a99a73ecfe48ced8e5e146bfa3f4a5","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                HORIZON_CONFIG[\u0027xstatic_lib_files\u0027].append(file)"},{"line_number":272,"context_line":"        except TypeError:"},{"line_number":273,"context_line":"            raise Exception(\u0027%s: Nothing to include. Files to include were not \u0027"},{"line_number":274,"context_line":"                            \u0027defined in BASE_XSTATIC_MODULES list or XStatic \u0027"},{"line_number":275,"context_line":"                            \u0027module does not define MAIN list.\u0027 % (module_name))"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    return STATICFILES_DIRS"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_4c194ed5","line":274,"range":{"start_line":274,"start_character":66,"end_line":274,"end_character":68},"updated":"2017-11-21 22:04:04.000000000","message":"or -\u003e and?","commit_id":"07b7d5250ba1683cb4b3dca0b38be578f0ccc4c7"},{"author":{"_account_id":12841,"name":"Ivan Udovichenko","email":"iudovichenko@itkey.com","username":"ai"},"change_message_id":"602aea07dc7bfe956f31404c6493f5ece57866a5","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                HORIZON_CONFIG[\u0027xstatic_lib_files\u0027].append(file)"},{"line_number":272,"context_line":"        except TypeError:"},{"line_number":273,"context_line":"            raise Exception(\u0027%s: Nothing to include. Files to include were not \u0027"},{"line_number":274,"context_line":"                            \u0027defined in BASE_XSTATIC_MODULES list or XStatic \u0027"},{"line_number":275,"context_line":"                            \u0027module does not define MAIN list.\u0027 % (module_name))"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    return STATICFILES_DIRS"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_7a6dd602","line":274,"range":{"start_line":274,"start_character":66,"end_line":274,"end_character":68},"in_reply_to":"ff82abbf_4c194ed5","updated":"2017-11-22 10:04:12.000000000","message":"Or.","commit_id":"07b7d5250ba1683cb4b3dca0b38be578f0ccc4c7"},{"author":{"_account_id":12841,"name":"Ivan Udovichenko","email":"iudovichenko@itkey.com","username":"ai"},"change_message_id":"408bb21b22b3a7a2bc3108084f0bacf5eb10216e","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                HORIZON_CONFIG[\u0027xstatic_lib_files\u0027].append(file)"},{"line_number":272,"context_line":"        except TypeError:"},{"line_number":273,"context_line":"            raise Exception(\u0027%s: Nothing to include. Files to include were not \u0027"},{"line_number":274,"context_line":"                            \u0027defined in BASE_XSTATIC_MODULES list or XStatic \u0027"},{"line_number":275,"context_line":"                            \u0027module does not define MAIN list.\u0027 % (module_name))"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    return STATICFILES_DIRS"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_95b2ebe5","line":274,"range":{"start_line":274,"start_character":66,"end_line":274,"end_character":68},"in_reply_to":"ff82abbf_55e78313","updated":"2017-11-22 10:28:08.000000000","message":"Yep, either way it\u0027ll work. I do not see any better way to explain it as it\u0027ll work in both cases.","commit_id":"07b7d5250ba1683cb4b3dca0b38be578f0ccc4c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"92c938d496633579256ff91c136d4b402ca2673a","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                HORIZON_CONFIG[\u0027xstatic_lib_files\u0027].append(file)"},{"line_number":272,"context_line":"        except TypeError:"},{"line_number":273,"context_line":"            raise Exception(\u0027%s: Nothing to include. Files to include were not \u0027"},{"line_number":274,"context_line":"                            \u0027defined in BASE_XSTATIC_MODULES list or XStatic \u0027"},{"line_number":275,"context_line":"                            \u0027module does not define MAIN list.\u0027 % (module_name))"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    return STATICFILES_DIRS"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_55e78313","line":274,"range":{"start_line":274,"start_character":66,"end_line":274,"end_character":68},"in_reply_to":"ff82abbf_7a6dd602","updated":"2017-11-22 10:23:39.000000000","message":"Would you like to explain what is a problem or what it should be?\nIf you explain a problem, \u0027or\u0027 sounds incorrect.\nIf you explain what it should be, the sentence is still not correct because file to include needs to be defined in BASE_XSTATIC_MODULES \u0027or\u0027 xstatic module must define MAIN.","commit_id":"07b7d5250ba1683cb4b3dca0b38be578f0ccc4c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c26b2c26a5a99a73ecfe48ced8e5e146bfa3f4a5","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        except TypeError:"},{"line_number":273,"context_line":"            raise Exception(\u0027%s: Nothing to include. Files to include were not \u0027"},{"line_number":274,"context_line":"                            \u0027defined in BASE_XSTATIC_MODULES list or XStatic \u0027"},{"line_number":275,"context_line":"                            \u0027module does not define MAIN list.\u0027 % (module_name))"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    return STATICFILES_DIRS"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_0c1346b7","line":275,"range":{"start_line":275,"start_character":66,"end_line":275,"end_character":79},"updated":"2017-11-21 22:04:04.000000000","message":"No parentheses are needed\n\n ... % module_name)","commit_id":"07b7d5250ba1683cb4b3dca0b38be578f0ccc4c7"},{"author":{"_account_id":12841,"name":"Ivan Udovichenko","email":"iudovichenko@itkey.com","username":"ai"},"change_message_id":"602aea07dc7bfe956f31404c6493f5ece57866a5","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        except TypeError:"},{"line_number":273,"context_line":"            raise Exception(\u0027%s: Nothing to include. Files to include were not \u0027"},{"line_number":274,"context_line":"                            \u0027defined in BASE_XSTATIC_MODULES list or XStatic \u0027"},{"line_number":275,"context_line":"                            \u0027module does not define MAIN list.\u0027 % (module_name))"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    return STATICFILES_DIRS"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_ba4cbe9e","line":275,"range":{"start_line":275,"start_character":66,"end_line":275,"end_character":79},"in_reply_to":"ff82abbf_0c1346b7","updated":"2017-11-22 10:04:12.000000000","message":"Done","commit_id":"07b7d5250ba1683cb4b3dca0b38be578f0ccc4c7"},{"author":{"_account_id":12841,"name":"Ivan Udovichenko","email":"iudovichenko@itkey.com","username":"ai"},"change_message_id":"b7bd0ba927ff587afe8246969666f433febabd79","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        except TypeError:"},{"line_number":273,"context_line":"            raise Exception("},{"line_number":274,"context_line":"                \u0027%s: Nothing to include because files to include are not \u0027"},{"line_number":275,"context_line":"                \u0027defined (i.e., None) in BASE_XSTATIC_MODULES list and \u0027"},{"line_number":276,"context_line":"                \u0027a corresponding XStatic module does not define MAIN list.\u0027"},{"line_number":277,"context_line":"                % module_name)"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ff82abbf_f02729c6","line":275,"range":{"start_line":275,"start_character":67,"end_line":275,"end_character":70},"updated":"2017-11-29 15:04:42.000000000","message":"It should be \"or\" as it\u0027ll work in both cases. You don\u0027t have to define files in two places, as if you do so \"files\" will be reassigned anyway. See 259-th line.","commit_id":"d16f750b36db3f220bca63e8fab509074e49ed6d"},{"author":{"_account_id":12841,"name":"Ivan Udovichenko","email":"iudovichenko@itkey.com","username":"ai"},"change_message_id":"92b91e8c908c0baf845c1cd6f6fb5ced51e4719e","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        except TypeError:"},{"line_number":273,"context_line":"            raise Exception("},{"line_number":274,"context_line":"                \u0027%s: Nothing to include because files to include are not \u0027"},{"line_number":275,"context_line":"                \u0027defined (i.e., None) in BASE_XSTATIC_MODULES list and \u0027"},{"line_number":276,"context_line":"                \u0027a corresponding XStatic module does not define MAIN list.\u0027"},{"line_number":277,"context_line":"                % module_name)"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ff82abbf_c6bd8b02","line":275,"range":{"start_line":275,"start_character":67,"end_line":275,"end_character":70},"in_reply_to":"ff82abbf_f02729c6","updated":"2017-11-29 15:44:40.000000000","message":"As was discussed with you in IRC we\u0027re can stick to your change. As this message shows what lead to this error.","commit_id":"d16f750b36db3f220bca63e8fab509074e49ed6d"}]}
