)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f7906157817f8d4ee0ee14ad701ccffd56b05e16","unresolved":false,"context_lines":[{"line_number":23,"context_line":"settings of proper navigation will be fixed by subsequent patch."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ib9f1fe48b3cdecff5ad56e68a5ba58a41cb35f38"},{"line_number":26,"context_line":"Partial-Bug: #1681627"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f93b717_389ef0b8","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":11},"updated":"2018-02-01 10:54:40.000000000","message":"This needs to be \"Closes-Bug\" now.","commit_id":"fb1abffdabf54db84fbd92d95c1516128c5e88a7"}],"horizon/base.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"77619ff397f7080c7ac000269b54f9d9cb635b64","unresolved":false,"context_lines":[{"line_number":871,"context_line":"        urlpatterns.append(url(r\u0027^ngdetails/\u0027,"},{"line_number":872,"context_line":"                               views.AngularDetailsView.as_view(),"},{"line_number":873,"context_line":"                               name\u003d\u0027ngdetails\u0027))"},{"line_number":874,"context_line":"        _decorate_urlconf(urlpatterns, require_auth)"},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"        # Return the three arguments to django.conf.urls.include"},{"line_number":877,"context_line":"        return urlpatterns, self.namespace, self.slug"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_577124a7","line":874,"updated":"2017-11-29 21:07:47.000000000","message":"Could you add unit tests to cover this change?\n\nWhen I access non-existing URL under /ngdetails/, almost blank page is shown. Do you plan to improve it in the further patches?","commit_id":"19c3e671249d914153c9891c613596d66f851604"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"d128e869ba5c1e9aa243f17f8ee7c769e4dd380d","unresolved":false,"context_lines":[{"line_number":871,"context_line":"        urlpatterns.append(url(r\u0027^ngdetails/\u0027,"},{"line_number":872,"context_line":"                               views.AngularDetailsView.as_view(),"},{"line_number":873,"context_line":"                               name\u003d\u0027ngdetails\u0027))"},{"line_number":874,"context_line":"        _decorate_urlconf(urlpatterns, require_auth)"},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"        # Return the three arguments to django.conf.urls.include"},{"line_number":877,"context_line":"        return urlpatterns, self.namespace, self.slug"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_6a1f926b","line":874,"in_reply_to":"ff82abbf_577124a7","updated":"2017-11-30 07:05:40.000000000","message":"Function _urls seems to be covered by test_lazy_urls.\nRedirection to 404 page in Angular will be implemented in the future.","commit_id":"19c3e671249d914153c9891c613596d66f851604"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"023fd36b25704e0d2a93552a288470dbe36de167","unresolved":false,"context_lines":[{"line_number":871,"context_line":"        urlpatterns.append(url(r\u0027^ngdetails/\u0027,"},{"line_number":872,"context_line":"                               views.AngularDetailsView.as_view(),"},{"line_number":873,"context_line":"                               name\u003d\u0027ngdetails\u0027))"},{"line_number":874,"context_line":"        _decorate_urlconf(urlpatterns, require_auth)"},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"        # Return the three arguments to django.conf.urls.include"},{"line_number":877,"context_line":"        return urlpatterns, self.namespace, self.slug"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_0597d73b","line":874,"in_reply_to":"ff82abbf_6a1f926b","updated":"2017-11-30 07:35:44.000000000","message":"Regrading the first point, what I meant is we need to test whether all URLs starting with ngdetail are handled as expected. I think it is not covered by test_lazy_url.","commit_id":"19c3e671249d914153c9891c613596d66f851604"}],"horizon/browsers/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"77619ff397f7080c7ac000269b54f9d9cb635b64","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        return context"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class AngularDetailsView(AngularIndexView):"},{"line_number":90,"context_line":"    \u0027\u0027\u0027View for Angularized details view"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    To use surely the template same as AngularIndexView, this class"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_941faa6a","line":89,"range":{"start_line":89,"start_character":25,"end_line":89,"end_character":42},"updated":"2017-11-29 21:07:47.000000000","message":"This looks a tricky inheritance. IndexView and DetailView have different purposes, so inheriting IndexView looks tricky even though it works.","commit_id":"19c3e671249d914153c9891c613596d66f851604"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"d128e869ba5c1e9aa243f17f8ee7c769e4dd380d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        return context"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class AngularDetailsView(AngularIndexView):"},{"line_number":90,"context_line":"    \u0027\u0027\u0027View for Angularized details view"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    To use surely the template same as AngularIndexView, this class"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_ea0ac223","line":89,"range":{"start_line":89,"start_character":25,"end_line":89,"end_character":42},"in_reply_to":"ff82abbf_941faa6a","updated":"2017-11-30 07:05:40.000000000","message":"Done","commit_id":"19c3e671249d914153c9891c613596d66f851604"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"77619ff397f7080c7ac000269b54f9d9cb635b64","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        dashboard \u003d horizon.get_default_dashboard()"},{"line_number":100,"context_line":"        self.request.horizon[\u0027dashboard\u0027] \u003d dashboard"},{"line_number":101,"context_line":"        self.request.horizon[\u0027panel\u0027] \u003d dashboard.get_panels()[0]"},{"line_number":102,"context_line":"        return context"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_17107c4d","line":102,"updated":"2017-11-29 21:07:47.000000000","message":"The breadcrumb at the top will be \"ProjectAPI AccessHorizon\". Is it intended (when I login as non-admin user)?","commit_id":"19c3e671249d914153c9891c613596d66f851604"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"d128e869ba5c1e9aa243f17f8ee7c769e4dd380d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        dashboard \u003d horizon.get_default_dashboard()"},{"line_number":100,"context_line":"        self.request.horizon[\u0027dashboard\u0027] \u003d dashboard"},{"line_number":101,"context_line":"        self.request.horizon[\u0027panel\u0027] \u003d dashboard.get_panels()[0]"},{"line_number":102,"context_line":"        return context"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_a515cb3e","line":102,"in_reply_to":"ff82abbf_17107c4d","updated":"2017-11-30 07:05:40.000000000","message":"It will be set according to default dashboard. It will be set properly in subsequent patch.","commit_id":"19c3e671249d914153c9891c613596d66f851604"}],"releasenotes/notes/ngdetail-reload-e711a77b2d07191a.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cfce82b3ebabfe72afaf50b09954782423b61b1e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [:bug:`1681627`] When reloading or opening Angular-based detail page"},{"line_number":5,"context_line":"    directly, the navigation menu and breadcrumb list are not recovered"},{"line_number":6,"context_line":"    properly and the first panel is focused."},{"line_number":7,"context_line":"    [:bug:`1746709`] when we try to open non-existing Angular-based detail"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f93b717_9842a4aa","line":4,"range":{"start_line":4,"start_character":11,"end_line":4,"end_character":18},"updated":"2018-02-01 11:14:42.000000000","message":"This should be 1746706.","commit_id":"eea6cc7841c00c7c036ce9bb56687c0fc2770675"}]}
