)]}'
{"openstack_dashboard/dashboards/project/routers/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"40140de3d7c726710924a3d1b8e459b68f899951","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            del self.fields[\u0027external_network\u0027]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        self.ext_gw_mode_supported \u003d api.neutron.is_extension_supported("},{"line_number":83,"context_line":"            self.request, \u0027ext-gw-mode\u0027)"},{"line_number":84,"context_line":"        self.enable_snat_allowed \u003d self.initial[\u0027enable_snat_allowed\u0027]"},{"line_number":85,"context_line":"        if (not networks or not self.enable_snat_allowed):"},{"line_number":86,"context_line":"            del self.fields[\u0027enable_snat\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_b93e50be","line":83,"updated":"2017-11-18 13:44:49.000000000","message":"self.enable_snat_allowed checks whether \u0027ext-gw-mode\u0027 is available [1], so this is unnecessary. See my comment at L.128.\n\n[1] https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/routers/views.py#L189-L190","commit_id":"b34a1f6e7a2ef9e625963878ed20d8a8455e3049"},{"author":{"_account_id":24056,"name":"wei.ying","email":"wei.ying@easystack.cn","username":"wei.ying"},"change_message_id":"bcf1a04eba89480e7fdd1e57e0d5c32d8228ccde","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            del self.fields[\u0027external_network\u0027]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        self.ext_gw_mode_supported \u003d api.neutron.is_extension_supported("},{"line_number":83,"context_line":"            self.request, \u0027ext-gw-mode\u0027)"},{"line_number":84,"context_line":"        self.enable_snat_allowed \u003d self.initial[\u0027enable_snat_allowed\u0027]"},{"line_number":85,"context_line":"        if (not networks or not self.enable_snat_allowed):"},{"line_number":86,"context_line":"            del self.fields[\u0027enable_snat\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_22aa0e85","line":83,"in_reply_to":"1f485f77_b93e50be","updated":"2017-11-20 02:14:08.000000000","message":"Got it. Updated in a new patch. Thanks Akihiro.","commit_id":"b34a1f6e7a2ef9e625963878ed20d8a8455e3049"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"40140de3d7c726710924a3d1b8e459b68f899951","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            if \u0027external_network\u0027 in data and data[\u0027external_network\u0027]:"},{"line_number":126,"context_line":"                params[\u0027external_gateway_info\u0027] \u003d {\u0027network_id\u0027:"},{"line_number":127,"context_line":"                                                   data[\u0027external_network\u0027]}"},{"line_number":128,"context_line":"                if self.ext_gw_mode_supported and self.enable_snat_allowed:"},{"line_number":129,"context_line":"                    params[\u0027external_gateway_info\u0027][\u0027enable_snat\u0027] \u003d \\"},{"line_number":130,"context_line":"                        data[\u0027enable_snat\u0027]"},{"line_number":131,"context_line":"            if \u0027az_hints\u0027 in data and data[\u0027az_hints\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_993954d8","line":128,"range":{"start_line":128,"start_character":19,"end_line":128,"end_character":50},"updated":"2017-11-18 13:44:49.000000000","message":"This is unnecessary. The fix here should be to drop this.","commit_id":"b34a1f6e7a2ef9e625963878ed20d8a8455e3049"}]}
