)]}'
{"doc/source/configuration/settings.rst":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5f414458dc92cdb2891895e64c1811f940e8bd31","unresolved":false,"context_lines":[{"line_number":898,"context_line":"set theme.  The cookie expiration is currently set to a year."},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"USER_MENU_LINKS"},{"line_number":901,"context_line":"~~~~~~~~~~~~~~~~"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":".. versionadded:: 13.0.0(Queens)"},{"line_number":904,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_a5528466","line":901,"range":{"start_line":901,"start_character":0,"end_line":901,"end_character":16},"updated":"2018-01-11 18:02:12.000000000","message":"The title level is wrong. Use the same line as for L.891.","commit_id":"a5b76ed9a150ec5722ecfc5dd08c23191a204cde"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5f414458dc92cdb2891895e64c1811f940e8bd31","unresolved":false,"context_lines":[{"line_number":905,"context_line":"Default::"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"  ["},{"line_number":908,"context_line":"    {\u0027name\u0027: \u0027OpenStack RC File v2\u0027,"},{"line_number":909,"context_line":"     \u0027icon_classes\u0027: [\u0027fa-download\u0027, ],"},{"line_number":910,"context_line":"     \u0027url\u0027: \u0027horizon:project:api_access:openrcv2\u0027,"},{"line_number":911,"context_line":"     \u0027external\u0027: False,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_e5a3ac4e","line":908,"range":{"start_line":908,"start_character":13,"end_line":908,"end_character":36},"updated":"2018-01-11 18:02:12.000000000","message":"Needs the translation marker.","commit_id":"a5b76ed9a150ec5722ecfc5dd08c23191a204cde"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5f414458dc92cdb2891895e64c1811f940e8bd31","unresolved":false,"context_lines":[{"line_number":910,"context_line":"     \u0027url\u0027: \u0027horizon:project:api_access:openrcv2\u0027,"},{"line_number":911,"context_line":"     \u0027external\u0027: False,"},{"line_number":912,"context_line":"     },"},{"line_number":913,"context_line":"    {\u0027name\u0027: \u0027OpenStack RC File v3\u0027,"},{"line_number":914,"context_line":"     \u0027icon_classes\u0027: [\u0027fa-download\u0027, ],"},{"line_number":915,"context_line":"     \u0027url\u0027: \u0027horizon:project:api_access:openrc\u0027,"},{"line_number":916,"context_line":"     \u0027external\u0027: False,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_8588a8c6","line":913,"updated":"2018-01-11 18:02:12.000000000","message":"same as the above.","commit_id":"a5b76ed9a150ec5722ecfc5dd08c23191a204cde"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5f414458dc92cdb2891895e64c1811f940e8bd31","unresolved":false,"context_lines":[{"line_number":922,"context_line":"defaults to the standard OpenStack RC files."},{"line_number":923,"context_line":""},{"line_number":924,"context_line":"Each dictionary should contain these values:"},{"line_number":925,"context_line":".. code-block:: python"},{"line_number":926,"context_line":""},{"line_number":927,"context_line":"  \u0027name\u0027: The name of the link"},{"line_number":928,"context_line":"  \u0027url\u0027: Either the reversible Django url name or an absolute url"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_059578e4","line":925,"range":{"start_line":925,"start_character":0,"end_line":925,"end_character":22},"updated":"2018-01-11 18:02:12.000000000","message":"This is an incomplete directive.\nhttp://logs.openstack.org/26/525026/5/check/build-openstack-sphinx-docs/f0cb826/html/configuration/settings.html#user-menu-links","commit_id":"a5b76ed9a150ec5722ecfc5dd08c23191a204cde"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5f414458dc92cdb2891895e64c1811f940e8bd31","unresolved":false,"context_lines":[{"line_number":926,"context_line":""},{"line_number":927,"context_line":"  \u0027name\u0027: The name of the link"},{"line_number":928,"context_line":"  \u0027url\u0027: Either the reversible Django url name or an absolute url"},{"line_number":929,"context_line":"  \u0027external\u0027: True for absolute URLs, False otherwise. (Default False)"},{"line_number":930,"context_line":"  \u0027icon_classes\u0027: A list of classes for the icon next to the link. If none are"},{"line_number":931,"context_line":"  provided a download icon will show."},{"line_number":932,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_c5455072","line":929,"range":{"start_line":929,"start_character":38,"end_line":929,"end_character":54},"updated":"2018-01-11 18:02:12.000000000","message":"Does \u0027False\u0027 mean \"Django url\"? If so, it is much easier to understand rather than \u0027otherwise\u0027.","commit_id":"a5b76ed9a150ec5722ecfc5dd08c23191a204cde"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5f414458dc92cdb2891895e64c1811f940e8bd31","unresolved":false,"context_lines":[{"line_number":926,"context_line":""},{"line_number":927,"context_line":"  \u0027name\u0027: The name of the link"},{"line_number":928,"context_line":"  \u0027url\u0027: Either the reversible Django url name or an absolute url"},{"line_number":929,"context_line":"  \u0027external\u0027: True for absolute URLs, False otherwise. (Default False)"},{"line_number":930,"context_line":"  \u0027icon_classes\u0027: A list of classes for the icon next to the link. If none are"},{"line_number":931,"context_line":"  provided a download icon will show."},{"line_number":932,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_a5ae042c","line":929,"range":{"start_line":929,"start_character":2,"end_line":929,"end_character":11},"updated":"2018-01-11 18:02:12.000000000","message":"I don\u0027t think we use \u0027external\u0027 for this meaning. how about \"relative\"?","commit_id":"a5b76ed9a150ec5722ecfc5dd08c23191a204cde"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5f414458dc92cdb2891895e64c1811f940e8bd31","unresolved":false,"context_lines":[{"line_number":927,"context_line":"  \u0027name\u0027: The name of the link"},{"line_number":928,"context_line":"  \u0027url\u0027: Either the reversible Django url name or an absolute url"},{"line_number":929,"context_line":"  \u0027external\u0027: True for absolute URLs, False otherwise. (Default False)"},{"line_number":930,"context_line":"  \u0027icon_classes\u0027: A list of classes for the icon next to the link. If none are"},{"line_number":931,"context_line":"  provided a download icon will show."},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"WEBROOT"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_652b1c94","line":930,"range":{"start_line":930,"start_character":70,"end_line":930,"end_character":74},"updated":"2018-01-11 18:02:12.000000000","message":"Which do you mean a string \"none\" or python `None`? I think you need to clarify it as the configuration reference.","commit_id":"a5b76ed9a150ec5722ecfc5dd08c23191a204cde"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5f414458dc92cdb2891895e64c1811f940e8bd31","unresolved":false,"context_lines":[{"line_number":928,"context_line":"  \u0027url\u0027: Either the reversible Django url name or an absolute url"},{"line_number":929,"context_line":"  \u0027external\u0027: True for absolute URLs, False otherwise. (Default False)"},{"line_number":930,"context_line":"  \u0027icon_classes\u0027: A list of classes for the icon next to the link. If none are"},{"line_number":931,"context_line":"  provided a download icon will show."},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"WEBROOT"},{"line_number":934,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_65fa3c43","line":931,"updated":"2018-01-11 18:02:12.000000000","message":"Instead of code-block, consider using an item list.","commit_id":"a5b76ed9a150ec5722ecfc5dd08c23191a204cde"}],"openstack_dashboard/context_processors.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5f414458dc92cdb2891895e64c1811f940e8bd31","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    if not getattr(settings, \"SHOW_V2_KEYSTONE_RC\", True):"},{"line_number":92,"context_line":"        user_menu_links \u003d [link for link in user_menu_links"},{"line_number":93,"context_line":"                           if \u0027openrcv2\u0027 not in link[\u0027url\u0027]]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    context[\u0027USER_MENU_LINKS\u0027] \u003d user_menu_links"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_0514989f","line":93,"range":{"start_line":93,"start_character":30,"end_line":93,"end_character":40},"updated":"2018-01-11 18:02:12.000000000","message":"Could you use the full url rather than just openrcv2\u0027?","commit_id":"a5b76ed9a150ec5722ecfc5dd08c23191a204cde"}],"openstack_dashboard/settings.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a19d38c6f1a7fe94fe36cbd99dc432460d2e24df","unresolved":false,"context_lines":[{"line_number":292,"context_line":"ADD_INSTALLED_APPS \u003d []"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"USER_MENU_LINKS \u003d ["},{"line_number":295,"context_line":"    {\u0027name\u0027: \u0027OpenStack RC File v2\u0027,"},{"line_number":296,"context_line":"     \u0027icon_classes\u0027: [\u0027fa-download\u0027, ],"},{"line_number":297,"context_line":"     \u0027url\u0027: \u0027horizon:project:api_access:openrcv2\u0027"},{"line_number":298,"context_line":"     },"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_461affcb","line":295,"updated":"2018-01-10 06:37:50.000000000","message":"You lost translation support again. Could you keep translation support?\nI commented the same thing in the first patch set.","commit_id":"d803e50122ac6da7085139bcf7ff13574c4c4132"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5f414458dc92cdb2891895e64c1811f940e8bd31","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    \u0027js_spec_files\u0027: [],"},{"line_number":83,"context_line":"    \u0027external_templates\u0027: [],"},{"line_number":84,"context_line":"    \u0027plugins\u0027: [],"},{"line_number":85,"context_line":"    \u0027integration_tests_support\u0027: INTEGRATION_TESTS_SUPPORT,"},{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# The OPENSTACK_IMAGE_BACKEND settings can be used to customize features"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_4507001e","line":85,"range":{"start_line":85,"start_character":58,"end_line":85,"end_character":59},"updated":"2018-01-11 18:02:12.000000000","message":"Looks unrelated.","commit_id":"a5b76ed9a150ec5722ecfc5dd08c23191a204cde"}],"openstack_dashboard/templates/header/_user_menu.html":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5778f5de2328ffc2dd6e16aa66c64fc3dc581386","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      \u003cli\u003e"},{"line_number":44,"context_line":"        \u003ca href\u003d\"{% url \u0027horizon:project:api_access:openrc\u0027 %}\"\u003e"},{"line_number":45,"context_line":"          \u003cspan class\u003d\"fa fa-download\"\u003e\u003c/span\u003e"},{"line_number":46,"context_line":"          {% trans \"OpenStack RC File v3\" %}"},{"line_number":47,"context_line":"        \u003c/a\u003e"},{"line_number":48,"context_line":"      \u003c/li\u003e"},{"line_number":49,"context_line":"      {% themes as available_themes %}"}],"source_content_type":"text/html","patch_set":1,"id":"df87a7cf_03056ec2","side":"PARENT","line":46,"range":{"start_line":46,"start_character":10,"end_line":46,"end_character":44},"updated":"2017-12-04 04:07:28.000000000","message":"The previous string was translatable. Could you keep translatability?","commit_id":"d46246d476cd805be5f5cdea9959466df4129977"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bbf1fd640581654db01196c475fdcd16d5786e50","unresolved":false,"context_lines":[{"line_number":34,"context_line":"          \u003c/a\u003e"},{"line_number":35,"context_line":"        \u003c/li\u003e"},{"line_number":36,"context_line":"      {% endif %}"},{"line_number":37,"context_line":"      {% if SHOW_KEYSTONE_V2_RC %}"},{"line_number":38,"context_line":"        \u003cli\u003e"},{"line_number":39,"context_line":"          \u003ca href\u003d\"{% url \u0027horizon:project:api_access:openrcv2\u0027 %}\"\u003e"},{"line_number":40,"context_line":"            \u003cspan class\u003d\"fa fa-download\"\u003e\u003c/span\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"bf8cb3f7_bd4e38bf","side":"PARENT","line":37,"range":{"start_line":37,"start_character":11,"end_line":37,"end_character":32},"updated":"2017-12-20 19:25:47.000000000","message":"You are dropping the setting SHOW_KEYSTONE_V2_RC. If you go to this route, you also need to clean up the setting from the context process and related document as well.\n\nSHOW_KEYSTONE_V2_RC is still referred to from the other place and operators are forced to configure two settings if they just hide operc v2 link. I don\u0027t think it is a good idea, so it leads to my suggestion at L.37.","commit_id":"554bcfc8082e3c69033f55d235dcf908cd70c2a2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bbf1fd640581654db01196c475fdcd16d5786e50","unresolved":false,"context_lines":[{"line_number":34,"context_line":"          \u003c/a\u003e"},{"line_number":35,"context_line":"        \u003c/li\u003e"},{"line_number":36,"context_line":"      {% endif %}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"      {% for link in USER_MENU_LINKS %}"},{"line_number":39,"context_line":"        \u003cli\u003e"},{"line_number":40,"context_line":"          {% if link.external %}"}],"source_content_type":"text/html","patch_set":3,"id":"bf8cb3f7_9d7d74e9","line":37,"updated":"2017-12-20 19:25:47.000000000","message":"How about splitting the horizon default values and customizable user links? I mean the default value of USER_MENU_LINKS to an empty list and keep the default openrc links.","commit_id":"abc331da088f0b4a0e3d3f0d08a1f1057aed01b7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5f414458dc92cdb2891895e64c1811f940e8bd31","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            \u003ca href\u003d\"{% url link.url %}\"\u003e"},{"line_number":44,"context_line":"          {% endif %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"            {% if link.icon_classes %}"},{"line_number":47,"context_line":"                \u003cspan class\u003d\"fa {{ link.icon_classes | join:\" \"}}\"\u003e\u003c/span\u003e"},{"line_number":48,"context_line":"            {% else %}"},{"line_number":49,"context_line":"                \u003cspan class\u003d\"fa fa-download\"\u003e\u003c/span\u003e"}],"source_content_type":"text/html","patch_set":5,"id":"7f96bb07_4835d7d9","line":46,"updated":"2018-01-11 18:02:12.000000000","message":"Could you use the same indent level as for the above? I don\u0027t see a reasonable reason to use a different level of indent.","commit_id":"a5b76ed9a150ec5722ecfc5dd08c23191a204cde"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5f414458dc92cdb2891895e64c1811f940e8bd31","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                \u003cspan class\u003d\"fa fa-download\"\u003e\u003c/span\u003e"},{"line_number":50,"context_line":"            {% endif %}"},{"line_number":51,"context_line":"            {{ link.name }}"},{"line_number":52,"context_line":"          \u003c/a\u003e"},{"line_number":53,"context_line":"        \u003c/li\u003e"},{"line_number":54,"context_line":"      {% endfor %}"},{"line_number":55,"context_line":""}],"source_content_type":"text/html","patch_set":5,"id":"7f96bb07_c856c707","line":52,"range":{"start_line":52,"start_character":10,"end_line":52,"end_character":14},"updated":"2018-01-11 18:02:12.000000000","message":"The indent level does not match the level of the opening \u003ca\u003e.","commit_id":"a5b76ed9a150ec5722ecfc5dd08c23191a204cde"}]}
