)]}'
{"openstack_dashboard/dashboards/project/snapshots/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"27acedd9f211f2fb4c9f5f5614dae987460439a6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def get_data(self):"},{"line_number":39,"context_line":"        snapshots \u003d []"},{"line_number":40,"context_line":"        volumes \u003d {}"},{"line_number":41,"context_line":"        if api.base.is_service_enabled(self.request, \u0027volumev3\u0027):"},{"line_number":42,"context_line":"            try:"},{"line_number":43,"context_line":"                marker, sort_dir \u003d self._get_marker()"},{"line_number":44,"context_line":"                snapshots, self._has_more_data, self._has_prev_data \u003d \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_e73dc82c","line":41,"updated":"2017-12-15 11:26:42.000000000","message":"Is volumev2 support dropped?\n\nIn my understanding, this patch just makes volume v3 the default API version. Dropping volume v2 support is not intended. Right?","commit_id":"3ce3d320e329a8e8b41a3cc288e8ae5ac123811f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"82b6d966035595b60d15d6f634f1d988cc95d504","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def get_data(self):"},{"line_number":39,"context_line":"        snapshots \u003d []"},{"line_number":40,"context_line":"        volumes \u003d {}"},{"line_number":41,"context_line":"        if api.base.is_service_enabled(self.request, \u0027volumev3\u0027):"},{"line_number":42,"context_line":"            try:"},{"line_number":43,"context_line":"                marker, sort_dir \u003d self._get_marker()"},{"line_number":44,"context_line":"                snapshots, self._has_more_data, self._has_prev_data \u003d \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_2182b8c9","line":41,"in_reply_to":"df87a7cf_e73dc82c","updated":"2017-12-15 15:44:11.000000000","message":"good catch, I\u0027ll fix it!","commit_id":"3ce3d320e329a8e8b41a3cc288e8ae5ac123811f"}],"openstack_dashboard/test/unit/api/test_base.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"27acedd9f211f2fb4c9f5f5614dae987460439a6","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        url \u003d api_base.url_for(self.request, \u0027volumev3\u0027,"},{"line_number":260,"context_line":"                               endpoint_type\u003d\u0027adminURL\u0027)"},{"line_number":261,"context_line":"        self.assertEqual(\u0027http://admin.cinder.example.com:8776/v3\u0027, url)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        self.assertNotIn(\u0027notAnApi\u0027, self.request.user.service_catalog,"},{"line_number":264,"context_line":"                         \u0027Select a new nonexistent service catalog key\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_6761b839","line":261,"updated":"2017-12-15 11:26:42.000000000","message":"No check for volume v2 endpoints? This is the test code based on the keystone catalog based on the test data, so I am personally okay with it. Just a confirmation.","commit_id":"3ce3d320e329a8e8b41a3cc288e8ae5ac123811f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bb56e8a380c73fda0282300884432ff92b126dfe","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        url \u003d api_base.url_for(self.request, \u0027volumev3\u0027,"},{"line_number":260,"context_line":"                               endpoint_type\u003d\u0027adminURL\u0027)"},{"line_number":261,"context_line":"        self.assertEqual(\u0027http://admin.cinder.example.com:8776/v3\u0027, url)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        self.assertNotIn(\u0027notAnApi\u0027, self.request.user.service_catalog,"},{"line_number":264,"context_line":"                         \u0027Select a new nonexistent service catalog key\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_496035a6","line":261,"in_reply_to":"df87a7cf_61c68019","updated":"2017-12-16 10:01:46.000000000","message":"I am okay with either.","commit_id":"3ce3d320e329a8e8b41a3cc288e8ae5ac123811f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"82b6d966035595b60d15d6f634f1d988cc95d504","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        url \u003d api_base.url_for(self.request, \u0027volumev3\u0027,"},{"line_number":260,"context_line":"                               endpoint_type\u003d\u0027adminURL\u0027)"},{"line_number":261,"context_line":"        self.assertEqual(\u0027http://admin.cinder.example.com:8776/v3\u0027, url)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        self.assertNotIn(\u0027notAnApi\u0027, self.request.user.service_catalog,"},{"line_number":264,"context_line":"                         \u0027Select a new nonexistent service catalog key\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_61c68019","line":261,"in_reply_to":"df87a7cf_6761b839","updated":"2017-12-15 15:44:11.000000000","message":"I can add v2 endpoint to tests too if needed. There is other test that verifies that v2 still can be configured to use","commit_id":"3ce3d320e329a8e8b41a3cc288e8ae5ac123811f"}],"openstack_dashboard/test/unit/api/test_cinder.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"27acedd9f211f2fb4c9f5f5614dae987460439a6","unresolved":false,"context_lines":[{"line_number":466,"context_line":"    def test_v2_setting_returns_v2_client(self):"},{"line_number":467,"context_line":"        # FIXME(e0ne): this is a temporary workaround to bypass"},{"line_number":468,"context_line":"        # @memoized_with_request decorator caching. We have to find a better"},{"line_number":469,"context_line":"        # solution instead this hack."},{"line_number":470,"context_line":"        self.request.user.username \u003d \u0027test_user_cinder_v2\u0027"},{"line_number":471,"context_line":"        client \u003d api.cinder.cinderclient(self.request)"},{"line_number":472,"context_line":"        self.assertIsInstance(client, cinder_client.v2.client.Client)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_c71be4c7","line":469,"updated":"2017-12-15 11:26:42.000000000","message":"Could you file a bug on this?\n\nI am afraid the current @memoized_with_request decorator does not care the major version..... after reading this comment.","commit_id":"3ce3d320e329a8e8b41a3cc288e8ae5ac123811f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"052358b20fe9cbf2e5c6f4a647d8d1230a13fa80","unresolved":false,"context_lines":[{"line_number":466,"context_line":"    def test_v2_setting_returns_v2_client(self):"},{"line_number":467,"context_line":"        # FIXME(e0ne): this is a temporary workaround to bypass"},{"line_number":468,"context_line":"        # @memoized_with_request decorator caching. We have to find a better"},{"line_number":469,"context_line":"        # solution instead this hack."},{"line_number":470,"context_line":"        self.request.user.username \u003d \u0027test_user_cinder_v2\u0027"},{"line_number":471,"context_line":"        client \u003d api.cinder.cinderclient(self.request)"},{"line_number":472,"context_line":"        self.assertIsInstance(client, cinder_client.v2.client.Client)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_3a6715ba","line":469,"in_reply_to":"df87a7cf_0999cd6c","updated":"2017-12-18 09:01:19.000000000","message":"I agree that we need more investigation on this. It\u0027s not obvious behavior.","commit_id":"3ce3d320e329a8e8b41a3cc288e8ae5ac123811f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bb56e8a380c73fda0282300884432ff92b126dfe","unresolved":false,"context_lines":[{"line_number":466,"context_line":"    def test_v2_setting_returns_v2_client(self):"},{"line_number":467,"context_line":"        # FIXME(e0ne): this is a temporary workaround to bypass"},{"line_number":468,"context_line":"        # @memoized_with_request decorator caching. We have to find a better"},{"line_number":469,"context_line":"        # solution instead this hack."},{"line_number":470,"context_line":"        self.request.user.username \u003d \u0027test_user_cinder_v2\u0027"},{"line_number":471,"context_line":"        client \u003d api.cinder.cinderclient(self.request)"},{"line_number":472,"context_line":"        self.assertIsInstance(client, cinder_client.v2.client.Client)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_0999cd6c","line":469,"in_reply_to":"df87a7cf_c1de6cd9","updated":"2017-12-16 10:01:46.000000000","message":"It is no problem in most cases.\n\nA case I concern about is micro-version support. When micro-version is specified, we can use both version 3.43 and 2 at the same time.\n\nI am not sure a problem you mention about memoized_with_request hits this case or not, but it seems worth investigated.","commit_id":"3ce3d320e329a8e8b41a3cc288e8ae5ac123811f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"82b6d966035595b60d15d6f634f1d988cc95d504","unresolved":false,"context_lines":[{"line_number":466,"context_line":"    def test_v2_setting_returns_v2_client(self):"},{"line_number":467,"context_line":"        # FIXME(e0ne): this is a temporary workaround to bypass"},{"line_number":468,"context_line":"        # @memoized_with_request decorator caching. We have to find a better"},{"line_number":469,"context_line":"        # solution instead this hack."},{"line_number":470,"context_line":"        self.request.user.username \u003d \u0027test_user_cinder_v2\u0027"},{"line_number":471,"context_line":"        client \u003d api.cinder.cinderclient(self.request)"},{"line_number":472,"context_line":"        self.assertIsInstance(client, cinder_client.v2.client.Client)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_c1de6cd9","line":469,"in_reply_to":"df87a7cf_c71be4c7","updated":"2017-12-15 15:44:11.000000000","message":"It should not be an issue because we use API versions from the config (at least, we try to do it). I\u0027ll check and file a bug if needed","commit_id":"3ce3d320e329a8e8b41a3cc288e8ae5ac123811f"}]}
