)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"73f1e9a2efe6af79958023ef65938cba4e3becb9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ahmed Zaid \u003cahmed.zaid@exalt.ps\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-12-18 05:20:56 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Flavors names regex."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch drop name validation in horizon and let nova check if the is name is valid or not."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df87a7cf_21ad939a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":20},"updated":"2017-12-19 05:27:13.000000000","message":"Could you describe what change you made in the summary line?\nThe current message just says what is changed but it does not mention how it is changed.","commit_id":"34b2fd03c5d079674e1ca3fd7fe9d35884aeef8e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"889416cbbc6ba0ed51cad94d324ef30093e20e91","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ahmed Zaid \u003cahmed.zaid@exalt.ps\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-12-19 03:13:22 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Flavors names regex."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch drop name validation in horizon and"},{"line_number":10,"context_line":"let nova check if the is name is valid or not."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"df87a7cf_4d956632","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":20},"updated":"2017-12-19 13:14:49.000000000","message":"-\u003e \"Drop flavor name validation in horizon side\"","commit_id":"458d2b51318ae62330b0aa4bcd7dbd4ce87361e5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"889416cbbc6ba0ed51cad94d324ef30093e20e91","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Instead of using pattern in the flavors form,"},{"line_number":12,"context_line":"pattern will be checked in the nova client. Also"},{"line_number":13,"context_line":"I added limation for the name size with tests to"},{"line_number":14,"context_line":"check the max size since the min size has it\u0027s unit"},{"line_number":15,"context_line":"test."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: 1738328"},{"line_number":18,"context_line":"Change-Id: Ib4f6f9b87560df43819d992254603e55ea8ff6a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"df87a7cf_0d867e14","line":15,"range":{"start_line":14,"start_character":24,"end_line":15,"end_character":4},"updated":"2017-12-19 13:14:49.000000000","message":"Which test covers the min size case? I cannot identify it. Could you tell me it?","commit_id":"458d2b51318ae62330b0aa4bcd7dbd4ce87361e5"},{"author":{"_account_id":27288,"name":"Ahmed Zaid","email":"ahmed.zaid.ext@nokia.com","username":"ZaidA"},"change_message_id":"c86e0aa1fbbc184ebaf928c775e23aa65d52e48a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Instead of using pattern in the flavors form,"},{"line_number":12,"context_line":"pattern will be checked in the nova client. Also"},{"line_number":13,"context_line":"I added limation for the name size with tests to"},{"line_number":14,"context_line":"check the max size since the min size has it\u0027s unit"},{"line_number":15,"context_line":"test."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: 1738328"},{"line_number":18,"context_line":"Change-Id: Ib4f6f9b87560df43819d992254603e55ea8ff6a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"df87a7cf_27391ad6","line":15,"range":{"start_line":14,"start_character":24,"end_line":15,"end_character":4},"in_reply_to":"df87a7cf_0d867e14","updated":"2017-12-19 13:31:54.000000000","message":"https://github.com/openstack/horizon/blob/0f598182919df31e40c7630ee1bd42bea259310d/openstack_dashboard/dashboards/admin/flavors/tests.py#L381","commit_id":"458d2b51318ae62330b0aa4bcd7dbd4ce87361e5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f59d23d8221ff0733f8c5ec43d22c4ebacbd3cf0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch drop name validation in horizon and"},{"line_number":10,"context_line":"let nova check if the is name is valid or not."},{"line_number":11,"context_line":"Instead of using pattern in the flavors form,"},{"line_number":12,"context_line":"pattern will be checked in the nova client. Also"},{"line_number":13,"context_line":"I added limation for the name size with tests to"},{"line_number":14,"context_line":"check the max size since the min size has it\u0027s unit"},{"line_number":15,"context_line":"test."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"df87a7cf_8f5038d7","line":12,"range":{"start_line":12,"start_character":27,"end_line":12,"end_character":42},"updated":"2017-12-19 17:22:02.000000000","message":"novaclient does nothing. It is validated by nova.","commit_id":"53874f58627fcfed7316eae52bede22abef507f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f59d23d8221ff0733f8c5ec43d22c4ebacbd3cf0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"let nova check if the is name is valid or not."},{"line_number":11,"context_line":"Instead of using pattern in the flavors form,"},{"line_number":12,"context_line":"pattern will be checked in the nova client. Also"},{"line_number":13,"context_line":"I added limation for the name size with tests to"},{"line_number":14,"context_line":"check the max size since the min size has it\u0027s unit"},{"line_number":15,"context_line":"test."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: 1738328"},{"line_number":18,"context_line":"Change-Id: Ib4f6f9b87560df43819d992254603e55ea8ff6a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"df87a7cf_6f65b4b4","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":5},"updated":"2017-12-19 17:22:02.000000000","message":"This is no longer correct.","commit_id":"53874f58627fcfed7316eae52bede22abef507f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"07952b2c4c3b007ee6cafce7595b79950fb5fafa","unresolved":false,"context_lines":[{"line_number":10,"context_line":"let nova check if the is name is valid or not."},{"line_number":11,"context_line":"Instead of using pattern in the flavors form,"},{"line_number":12,"context_line":"pattern will be checked in the nova client. Also"},{"line_number":13,"context_line":"I added limation for the name size with tests to"},{"line_number":14,"context_line":"check the max size since the min size has it\u0027s unit"},{"line_number":15,"context_line":"test."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: 1738328"},{"line_number":18,"context_line":"Change-Id: Ib4f6f9b87560df43819d992254603e55ea8ff6a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"df87a7cf_8fa83878","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":5},"in_reply_to":"df87a7cf_4fd31039","updated":"2017-12-19 17:31:42.000000000","message":"Oh... my bad. I was confused with min_length. Let\u0027s keep the UT for max_length.","commit_id":"53874f58627fcfed7316eae52bede22abef507f7"},{"author":{"_account_id":27288,"name":"Ahmed Zaid","email":"ahmed.zaid.ext@nokia.com","username":"ZaidA"},"change_message_id":"fb54cd1e5bb62a7e1cd91871991ea0c4ff955b30","unresolved":false,"context_lines":[{"line_number":10,"context_line":"let nova check if the is name is valid or not."},{"line_number":11,"context_line":"Instead of using pattern in the flavors form,"},{"line_number":12,"context_line":"pattern will be checked in the nova client. Also"},{"line_number":13,"context_line":"I added limation for the name size with tests to"},{"line_number":14,"context_line":"check the max size since the min size has it\u0027s unit"},{"line_number":15,"context_line":"test."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: 1738328"},{"line_number":18,"context_line":"Change-Id: Ib4f6f9b87560df43819d992254603e55ea8ff6a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"df87a7cf_4fd31039","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":5},"in_reply_to":"df87a7cf_6f65b4b4","updated":"2017-12-19 17:25:42.000000000","message":"So no need to add unit test for max size ?","commit_id":"53874f58627fcfed7316eae52bede22abef507f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8fcc97f26b2b88a3fa749084b4c4ff17abafd732","unresolved":false,"context_lines":[{"line_number":12,"context_line":"pattern will be checked in the nova client. Also"},{"line_number":13,"context_line":"I added limation for the name size with tests to"},{"line_number":14,"context_line":"check the max size since the min size has it\u0027s unit"},{"line_number":15,"context_line":"test."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: 1738328"},{"line_number":18,"context_line":"Change-Id: Ib4f6f9b87560df43819d992254603e55ea8ff6a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"df87a7cf_ef70e474","line":15,"updated":"2017-12-19 17:22:33.000000000","message":"See my comments in patch set 11.","commit_id":"9e1abecbe32d7505c1f1767f24068af074e063f9"}],"openstack_dashboard/dashboards/admin/flavors/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"73f1e9a2efe6af79958023ef65938cba4e3becb9","unresolved":false,"context_lines":[{"line_number":792,"context_line":"    @test.create_stubs({api.keystone: (\u0027tenant_list\u0027,),"},{"line_number":793,"context_line":"                        api.nova: (\u0027flavor_get\u0027,"},{"line_number":794,"context_line":"                                   \u0027flavor_list\u0027,)})"},{"line_number":795,"context_line":"    def test_update_flavor_set_invalid_name(self):"},{"line_number":796,"context_line":"        flavor \u003d self.flavors.first()"},{"line_number":797,"context_line":"        projects \u003d self.tenants.list()"},{"line_number":798,"context_line":"        eph \u003d getattr(flavor, \u0027OS-FLV-EXT-DATA:ephemeral\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_418bf71d","side":"PARENT","line":795,"updated":"2017-12-19 05:27:13.000000000","message":"Instead of dropping the test, it is better to check min/max name length. You added a minimum requirement in the main code","commit_id":"bf88aaf245992a3c5849d71db7c81a796928a51c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b99f68adacd6d5eceae5ab5996833ff3f275d7d","unresolved":false,"context_lines":[{"line_number":796,"context_line":"        flavor \u003d self.flavors.first()"},{"line_number":797,"context_line":"        projects \u003d self.tenants.list()"},{"line_number":798,"context_line":"        eph \u003d getattr(flavor, \u0027OS-FLV-EXT-DATA:ephemeral\u0027)"},{"line_number":799,"context_line":"        invalid_flavor_name \u003d \"a\"*256"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"        # init"},{"line_number":802,"context_line":"        api.nova.flavor_get(IsA(http.HttpRequest), flavor.id) \\"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf8cb3f7_06859ead","line":799,"range":{"start_line":799,"start_character":30,"end_line":799,"end_character":37},"updated":"2017-12-20 14:49:36.000000000","message":"We need spaces around an operator:\n\n  \"a\" * 256\n\nI wonder why pep8 does not detect it.","commit_id":"f59f3c4aa03db118e544635f1d50807edf905b08"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b99f68adacd6d5eceae5ab5996833ff3f275d7d","unresolved":false,"context_lines":[{"line_number":827,"context_line":"        resp \u003d self.client.post(url, workflow_data)"},{"line_number":828,"context_line":"        self.assertFormErrors(resp)"},{"line_number":829,"context_line":"        self.assertContains(resp, \"Ensure this value has at \""},{"line_number":830,"context_line":"                                  \"most 255 characters (it has 256).\")"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"    @test.create_stubs({api.keystone: (\u0027tenant_list\u0027,),"},{"line_number":833,"context_line":"                        api.nova: (\u0027flavor_get\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf8cb3f7_c68ed6cf","line":830,"updated":"2017-12-20 14:49:36.000000000","message":"Consider using:\n\n  self.assertContains(\n      resp,\n      \"Ensure this value has at most 255 characters (it has 256).\")\n\nIt is not a good idea to use a manual adjustment of indentation.","commit_id":"f59f3c4aa03db118e544635f1d50807edf905b08"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e5c18e0f06277f7e7232a77bf6f7c619a10c2bfc","unresolved":false,"context_lines":[{"line_number":827,"context_line":"        resp \u003d self.client.post(url, workflow_data)"},{"line_number":828,"context_line":"        self.assertFormErrors(resp)"},{"line_number":829,"context_line":"        self.assertContains(resp, \"Ensure this value has at \""},{"line_number":830,"context_line":"                                  \"most 255 characters\")"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"    @test.create_stubs({api.keystone: (\u0027tenant_list\u0027,),"},{"line_number":833,"context_line":"                        api.nova: (\u0027flavor_get\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"bf8cb3f7_ef496d32","line":830,"updated":"2017-12-20 16:14:02.000000000","message":"This is not updated yet. let\u0027s update it before merging it.","commit_id":"dbe080ee47ec6be001ec37872b23fa6018b816ef"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"96393323dacdd1d7808fbc76093ebccdc42838b1","unresolved":false,"context_lines":[{"line_number":827,"context_line":"        resp \u003d self.client.post(url, workflow_data)"},{"line_number":828,"context_line":"        self.assertFormErrors(resp)"},{"line_number":829,"context_line":"        self.assertContains(resp, \"Ensure this value has at \""},{"line_number":830,"context_line":"                                  \"most 255 characters\")"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"    @test.create_stubs({api.keystone: (\u0027tenant_list\u0027,),"},{"line_number":833,"context_line":"                        api.nova: (\u0027flavor_get\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"bf8cb3f7_8f3221a7","line":830,"in_reply_to":"bf8cb3f7_ef496d32","updated":"2017-12-20 16:14:25.000000000","message":"Done","commit_id":"dbe080ee47ec6be001ec37872b23fa6018b816ef"}],"openstack_dashboard/dashboards/admin/flavors/workflows.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0f8c86da3b96317e2d2a809fb747d34682f022df","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                             \"a random UUID4.\")"},{"line_number":35,"context_line":"    name \u003d forms.CharField("},{"line_number":36,"context_line":"        label\u003d_(\"Name\"),"},{"line_number":37,"context_line":"        max_length\u003d255, min_length\u003d1)"},{"line_number":38,"context_line":"    flavor_id \u003d forms.RegexField(label\u003d_(\"ID\"),"},{"line_number":39,"context_line":"                                 regex\u003d_flavor_id_regex,"},{"line_number":40,"context_line":"                                 required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":7,"id":"df87a7cf_82c7b412","line":37,"range":{"start_line":37,"start_character":22,"end_line":37,"end_character":36},"updated":"2017-12-19 14:54:41.000000000","message":"The default value of required is True, so this is the required field. In the required field, if a user sends an empty string, it will raise a validation error. I think \"min_length\u003d1\" is unnecessary. Could you drop it?","commit_id":"fba9de6972ebafd32d13ffc19826ff890a262c22"}]}
