)]}'
{"horizon/static/horizon/js/horizon.modals.js":[{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"abbdc5a053ababeb7f32be7ea183d4558e93f080","unresolved":false,"context_lines":[{"line_number":171,"context_line":"      },"},{"line_number":172,"context_line":"      onNext: function(tab, navigation, index) {"},{"line_number":173,"context_line":"        // Validate current workflow step."},{"line_number":174,"context_line":"        "},{"line_number":175,"context_line":"        var $form \u003d $(\u0027.workflow \u003e form\u0027),"},{"line_number":176,"context_line":"            response \u003d {};"},{"line_number":177,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"AAAATn%2F%2FWYQ%3D","line":174,"updated":"2013-11-08 15:16:26.000000000","message":"empty spaceees :-o","commit_id":"665d0451136ab135318ee896f654ef4cf9558899"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"218cf4ced92a75ec816942374ee7e2cdb5cdc5b0","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    var _validate_steps \u003d function (start, end) {"},{"line_number":154,"context_line":"        var $form \u003d $(\u0027.workflow \u003e form\u0027),"},{"line_number":155,"context_line":"            response \u003d {};"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        if (typeof end \u003d\u003d\u003d \u0027undefined\u0027) {"},{"line_number":158,"context_line":"            end \u003d start;"},{"line_number":159,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":12,"id":"AAAATn%2F8yRE%3D","line":156,"updated":"2013-12-20 12:03:38.000000000","message":"better use end \u003d end || start;","commit_id":"28bd1bc60bdd7e281a9e6c23aa74b7cd783ac698"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"51a40d75437ef4270e858c586082306dc14accae","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    var _validate_steps \u003d function (start, end) {"},{"line_number":154,"context_line":"        var $form \u003d $(\u0027.workflow \u003e form\u0027),"},{"line_number":155,"context_line":"            response \u003d {};"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        if (typeof end \u003d\u003d\u003d \u0027undefined\u0027) {"},{"line_number":158,"context_line":"            end \u003d start;"},{"line_number":159,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":12,"id":"AAAATn%2F8x1I%3D","line":156,"in_reply_to":"AAAATn%2F8yRE%3D","updated":"2013-12-20 12:46:18.000000000","message":"It doesn\u0027t have the same effect when end\u003d0","commit_id":"28bd1bc60bdd7e281a9e6c23aa74b7cd783ac698"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"218cf4ced92a75ec816942374ee7e2cdb5cdc5b0","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            end \u003d start;"},{"line_number":159,"context_line":"        }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        // Clear old errors."},{"line_number":162,"context_line":"        $form.find(\u0027td.actions div.alert.alert-message.alert-error\u0027).remove();"},{"line_number":163,"context_line":"        $form.find(\u0027.control-group.error\u0027).each(function () {"},{"line_number":164,"context_line":"            var $group \u003d $(this);"}],"source_content_type":"text/javascript","patch_set":12,"id":"AAAATn%2F8yLU%3D","line":161,"updated":"2013-12-20 12:03:38.000000000","message":"all this selector is not needed and will slow down the request, $form.find(\u0027alert-error\u0027) will work perfectly if you really want to be sure use $form.find(\u0027td.actions alert-error\u0027) but I find it really overkill","commit_id":"28bd1bc60bdd7e281a9e6c23aa74b7cd783ac698"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"51a40d75437ef4270e858c586082306dc14accae","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            end \u003d start;"},{"line_number":159,"context_line":"        }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        // Clear old errors."},{"line_number":162,"context_line":"        $form.find(\u0027td.actions div.alert.alert-message.alert-error\u0027).remove();"},{"line_number":163,"context_line":"        $form.find(\u0027.control-group.error\u0027).each(function () {"},{"line_number":164,"context_line":"            var $group \u003d $(this);"}],"source_content_type":"text/javascript","patch_set":12,"id":"AAAATn%2F8x0w%3D","line":161,"in_reply_to":"AAAATn%2F8yLU%3D","updated":"2013-12-20 12:46:18.000000000","message":"Done","commit_id":"28bd1bc60bdd7e281a9e6c23aa74b7cd783ac698"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"218cf4ced92a75ec816942374ee7e2cdb5cdc5b0","unresolved":false,"context_lines":[{"line_number":223,"context_line":"      tabClass: \u0027wizard-tabs\u0027,"},{"line_number":224,"context_line":"      nextSelector: \u0027.button-next\u0027,"},{"line_number":225,"context_line":"      previousSelector: \u0027.button-previous\u0027,"},{"line_number":226,"context_line":"      onTabShow: function (tab, navigation, index) {"},{"line_number":227,"context_line":"        var $navs \u003d navigation.find(\u0027li\u0027);"},{"line_number":228,"context_line":"        var total \u003d $navs.length;"},{"line_number":229,"context_line":"        var current \u003d index;"}],"source_content_type":"text/javascript","patch_set":12,"id":"AAAATn%2F8yHM%3D","line":226,"updated":"2013-12-20 12:03:38.000000000","message":"use just one var statement separated by commas","commit_id":"28bd1bc60bdd7e281a9e6c23aa74b7cd783ac698"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"51a40d75437ef4270e858c586082306dc14accae","unresolved":false,"context_lines":[{"line_number":223,"context_line":"      tabClass: \u0027wizard-tabs\u0027,"},{"line_number":224,"context_line":"      nextSelector: \u0027.button-next\u0027,"},{"line_number":225,"context_line":"      previousSelector: \u0027.button-previous\u0027,"},{"line_number":226,"context_line":"      onTabShow: function (tab, navigation, index) {"},{"line_number":227,"context_line":"        var $navs \u003d navigation.find(\u0027li\u0027);"},{"line_number":228,"context_line":"        var total \u003d $navs.length;"},{"line_number":229,"context_line":"        var current \u003d index;"}],"source_content_type":"text/javascript","patch_set":12,"id":"AAAATn%2F8x0E%3D","line":226,"in_reply_to":"AAAATn%2F8yHM%3D","updated":"2013-12-20 12:46:18.000000000","message":"Can you point me to the section of the style guide that requires this? I didn\u0027t see it being done that way anywhere in horizon.","commit_id":"28bd1bc60bdd7e281a9e6c23aa74b7cd783ac698"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"218cf4ced92a75ec816942374ee7e2cdb5cdc5b0","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        var total \u003d $navs.length;"},{"line_number":229,"context_line":"        var current \u003d index;"},{"line_number":230,"context_line":"        _max_visited_step \u003d Math.max(_max_visited_step, current);"},{"line_number":231,"context_line":"        if (current + 1 \u003e\u003d total) {"},{"line_number":232,"context_line":"          $(\u0027.modal-footer\u0027).find(\u0027.button-next\u0027).hide();"},{"line_number":233,"context_line":"          $(\u0027.modal-footer\u0027).find(\u0027.button-final\u0027).show();"},{"line_number":234,"context_line":"        } else {"}],"source_content_type":"text/javascript","patch_set":12,"id":"AAAATn%2F8yHk%3D","line":231,"updated":"2013-12-20 12:03:38.000000000","message":"use a variable for $(\u0027.modal-footer\u0027) because each call will perform a DOM parsing to find the element","commit_id":"28bd1bc60bdd7e281a9e6c23aa74b7cd783ac698"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"51a40d75437ef4270e858c586082306dc14accae","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        var total \u003d $navs.length;"},{"line_number":229,"context_line":"        var current \u003d index;"},{"line_number":230,"context_line":"        _max_visited_step \u003d Math.max(_max_visited_step, current);"},{"line_number":231,"context_line":"        if (current + 1 \u003e\u003d total) {"},{"line_number":232,"context_line":"          $(\u0027.modal-footer\u0027).find(\u0027.button-next\u0027).hide();"},{"line_number":233,"context_line":"          $(\u0027.modal-footer\u0027).find(\u0027.button-final\u0027).show();"},{"line_number":234,"context_line":"        } else {"}],"source_content_type":"text/javascript","patch_set":12,"id":"AAAATn%2F8xz4%3D","line":231,"in_reply_to":"AAAATn%2F8yHk%3D","updated":"2013-12-20 12:46:18.000000000","message":"Done","commit_id":"28bd1bc60bdd7e281a9e6c23aa74b7cd783ac698"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"218cf4ced92a75ec816942374ee7e2cdb5cdc5b0","unresolved":false,"context_lines":[{"line_number":248,"context_line":"          return _validate_steps(index - 1);"},{"line_number":249,"context_line":"      },"},{"line_number":250,"context_line":"      onTabClick: function ($tab, $nav, current, index) {"},{"line_number":251,"context_line":"        // Validate if moving forward, but move backwards without validation"},{"line_number":252,"context_line":"        if (index \u003e current \u0026\u0026 _validate_steps(current, index - 1) \u003d\u003d\u003d false) {"},{"line_number":253,"context_line":"          return false;"},{"line_number":254,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":12,"id":"AAAATn%2F8yEI%3D","line":251,"updated":"2013-12-20 12:03:38.000000000","message":"tautology? just write \n\nreturn index \u003c\u003d current || _validate_steps(current, index - 1)","commit_id":"28bd1bc60bdd7e281a9e6c23aa74b7cd783ac698"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"51a40d75437ef4270e858c586082306dc14accae","unresolved":false,"context_lines":[{"line_number":248,"context_line":"          return _validate_steps(index - 1);"},{"line_number":249,"context_line":"      },"},{"line_number":250,"context_line":"      onTabClick: function ($tab, $nav, current, index) {"},{"line_number":251,"context_line":"        // Validate if moving forward, but move backwards without validation"},{"line_number":252,"context_line":"        if (index \u003e current \u0026\u0026 _validate_steps(current, index - 1) \u003d\u003d\u003d false) {"},{"line_number":253,"context_line":"          return false;"},{"line_number":254,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":12,"id":"AAAATn%2F8xyk%3D","line":251,"in_reply_to":"AAAATn%2F8yEI%3D","updated":"2013-12-20 12:46:18.000000000","message":"_validate_steps can return undefined, which is also falsy.\nBut good point, that if is no longer needed, as there is no extra code in it anymore, I will remove it.","commit_id":"28bd1bc60bdd7e281a9e6c23aa74b7cd783ac698"}],"horizon/templates/horizon/common/_workflow.html":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1305ae85730abb3d007018a556aad45ce539fcc9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \u003c/div\u003e"},{"line_number":51,"context_line":"  \u003c/form\u003e"},{"line_number":52,"context_line":"\u003c/div\u003e"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{% endwith %}"},{"line_number":55,"context_line":"{% block modal-js %}"},{"line_number":56,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":16,"id":"AAAATn%2F8t14%3D","line":53,"updated":"2013-12-21 12:45:11.000000000","message":"It seems unnecessary. There is no other blank line in this file.","commit_id":"9a98fa22a8df6940972325483d244abceaede935"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"280907234a695aa1ad6b0e56fa9b60d029970775","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \u003c/div\u003e"},{"line_number":51,"context_line":"  \u003c/form\u003e"},{"line_number":52,"context_line":"\u003c/div\u003e"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{% endwith %}"},{"line_number":55,"context_line":"{% block modal-js %}"},{"line_number":56,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":16,"id":"AAAATn%2F8rIA%3D","line":53,"in_reply_to":"AAAATn%2F8t14%3D","updated":"2013-12-23 12:11:06.000000000","message":"Done","commit_id":"9a98fa22a8df6940972325483d244abceaede935"}],"horizon/workflows/base.py":[{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"218cf4ced92a75ec816942374ee7e2cdb5cdc5b0","unresolved":false,"context_lines":[{"line_number":585,"context_line":"    success_message \u003d _(\"%s completed successfully.\")"},{"line_number":586,"context_line":"    failure_message \u003d _(\"%s did not complete.\")"},{"line_number":587,"context_line":"    redirect_param_name \u003d \"next\""},{"line_number":588,"context_line":"    multipart \u003d False"},{"line_number":589,"context_line":"    wizard \u003d False"},{"line_number":590,"context_line":"    _registerable_class \u003d Step"},{"line_number":591,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F8yDs%3D","line":588,"updated":"2013-12-20 12:03:38.000000000","message":"can you add a bit of documentation in the docstring?","commit_id":"28bd1bc60bdd7e281a9e6c23aa74b7cd783ac698"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"51a40d75437ef4270e858c586082306dc14accae","unresolved":false,"context_lines":[{"line_number":585,"context_line":"    success_message \u003d _(\"%s completed successfully.\")"},{"line_number":586,"context_line":"    failure_message \u003d _(\"%s did not complete.\")"},{"line_number":587,"context_line":"    redirect_param_name \u003d \"next\""},{"line_number":588,"context_line":"    multipart \u003d False"},{"line_number":589,"context_line":"    wizard \u003d False"},{"line_number":590,"context_line":"    _registerable_class \u003d Step"},{"line_number":591,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F8xwc%3D","line":588,"in_reply_to":"AAAATn%2F8yDs%3D","updated":"2013-12-20 12:46:18.000000000","message":"Good, catch, I was sure I did. Thanks.","commit_id":"28bd1bc60bdd7e281a9e6c23aa74b7cd783ac698"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1305ae85730abb3d007018a556aad45ce539fcc9","unresolved":false,"context_lines":[{"line_number":576,"context_line":"        the case of a workflow which updates a resource it would be the"},{"line_number":577,"context_line":"        resource being updated after it has been retrieved."},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"    .. attribute:: boolean"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        Whether to present the workflow as a wizard, with \"prev\" and \"next\""},{"line_number":582,"context_line":"        buttons and validation after every step."}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F8t10%3D","line":579,"updated":"2013-12-21 12:45:11.000000000","message":"boolean -\u003e wizard ?\n\nArgument of attribute should be a name. \"Boolean\" is a type of this parameter and should be moved to the description.","commit_id":"9a98fa22a8df6940972325483d244abceaede935"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"280907234a695aa1ad6b0e56fa9b60d029970775","unresolved":false,"context_lines":[{"line_number":576,"context_line":"        the case of a workflow which updates a resource it would be the"},{"line_number":577,"context_line":"        resource being updated after it has been retrieved."},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"    .. attribute:: boolean"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        Whether to present the workflow as a wizard, with \"prev\" and \"next\""},{"line_number":582,"context_line":"        buttons and validation after every step."}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F8rH8%3D","line":579,"in_reply_to":"AAAATn%2F8raM%3D","updated":"2013-12-23 12:11:06.000000000","message":"Done","commit_id":"9a98fa22a8df6940972325483d244abceaede935"},{"author":{"_account_id":9692,"name":"Gabriel Pettier","email":"gabriel.pettier@cloudwatt.com","username":"Gabriel-Pettier"},"change_message_id":"8281a3b54f066ddf1f6e8d487d3f9d41761005df","unresolved":false,"context_lines":[{"line_number":576,"context_line":"        the case of a workflow which updates a resource it would be the"},{"line_number":577,"context_line":"        resource being updated after it has been retrieved."},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"    .. attribute:: boolean"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        Whether to present the workflow as a wizard, with \"prev\" and \"next\""},{"line_number":582,"context_line":"        buttons and validation after every step."}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F8raM%3D","line":579,"in_reply_to":"AAAATn%2F8t10%3D","updated":"2013-12-23 11:01:40.000000000","message":"+1 i guess the confusion comes from the previous documented attribute being named `object`.","commit_id":"9a98fa22a8df6940972325483d244abceaede935"}],"horizon/workflows/views.py":[{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"218cf4ced92a75ec816942374ee7e2cdb5cdc5b0","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                \u0027HTTP_X_HORIZON_VALIDATE_STEP_START\u0027, \u0027\u0027))"},{"line_number":147,"context_line":"            validate_step_end \u003d int(self.request.META.get("},{"line_number":148,"context_line":"                \u0027HTTP_X_HORIZON_VALIDATE_STEP_END\u0027, \u0027\u0027))"},{"line_number":149,"context_line":"        except ValueError:"},{"line_number":150,"context_line":"            pass"},{"line_number":151,"context_line":"        else:"},{"line_number":152,"context_line":"            data \u003d self.validate_steps(request, workflow,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F8x8k%3D","line":149,"updated":"2013-12-20 12:03:38.000000000","message":"seems complicated, what happen if int fail, the else statement is not really needed because no more value error can be throw. This part is not very clear can you give some explanations. We have a really strange use case here.","commit_id":"28bd1bc60bdd7e281a9e6c23aa74b7cd783ac698"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"51a40d75437ef4270e858c586082306dc14accae","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                \u0027HTTP_X_HORIZON_VALIDATE_STEP_START\u0027, \u0027\u0027))"},{"line_number":147,"context_line":"            validate_step_end \u003d int(self.request.META.get("},{"line_number":148,"context_line":"                \u0027HTTP_X_HORIZON_VALIDATE_STEP_END\u0027, \u0027\u0027))"},{"line_number":149,"context_line":"        except ValueError:"},{"line_number":150,"context_line":"            pass"},{"line_number":151,"context_line":"        else:"},{"line_number":152,"context_line":"            data \u003d self.validate_steps(request, workflow,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F8xw4%3D","line":149,"in_reply_to":"AAAATn%2F8x8k%3D","updated":"2013-12-20 12:46:18.000000000","message":"It\u0027s explained in http://docs.python.org/2/reference/compound_stmts.html#the-try-statement","commit_id":"28bd1bc60bdd7e281a9e6c23aa74b7cd783ac698"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"218cf4ced92a75ec816942374ee7e2cdb5cdc5b0","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        else:"},{"line_number":152,"context_line":"            data \u003d self.validate_steps(request, workflow,"},{"line_number":153,"context_line":"                                       validate_step_start,"},{"line_number":154,"context_line":"                                       validate_step_end)"},{"line_number":155,"context_line":"            return http.HttpResponse(json.dumps(data),"},{"line_number":156,"context_line":"                                     mimetype\u003d\"application/json\")"},{"line_number":157,"context_line":"        if workflow.is_valid():"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F8x8g%3D","line":154,"updated":"2013-12-20 12:03:38.000000000","message":"return here is really confusing","commit_id":"28bd1bc60bdd7e281a9e6c23aa74b7cd783ac698"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"51a40d75437ef4270e858c586082306dc14accae","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        else:"},{"line_number":152,"context_line":"            data \u003d self.validate_steps(request, workflow,"},{"line_number":153,"context_line":"                                       validate_step_start,"},{"line_number":154,"context_line":"                                       validate_step_end)"},{"line_number":155,"context_line":"            return http.HttpResponse(json.dumps(data),"},{"line_number":156,"context_line":"                                     mimetype\u003d\"application/json\")"},{"line_number":157,"context_line":"        if workflow.is_valid():"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F8xww%3D","line":154,"in_reply_to":"AAAATn%2F8x8g%3D","updated":"2013-12-20 12:46:18.000000000","message":"Where would you rather put it?","commit_id":"28bd1bc60bdd7e281a9e6c23aa74b7cd783ac698"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"5742943a57bc9eb98af89de31e78b9c6957fe707","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            # with normal workflow handling for POSTs."},{"line_number":155,"context_line":"            pass"},{"line_number":156,"context_line":"        else:"},{"line_number":157,"context_line":"            # There are valid VALIDAE_STEP* headers, so only do validation"},{"line_number":158,"context_line":"            # for the specified steps and return results."},{"line_number":159,"context_line":"            data \u003d self.validate_steps(request, workflow,"},{"line_number":160,"context_line":"                                       validate_step_start,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F8xR0%3D","line":157,"updated":"2013-12-20 14:16:35.000000000","message":"Typo : VALIDAE_STEP -\u003e VALIDATE_STEP*","commit_id":"f891ecaedca34f15e3bbbd39c68845274b31a120"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"210005fc0c65a43697240e1e606cd4b1d21891c1","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            # with normal workflow handling for POSTs."},{"line_number":155,"context_line":"            pass"},{"line_number":156,"context_line":"        else:"},{"line_number":157,"context_line":"            # There are valid VALIDAE_STEP* headers, so only do validation"},{"line_number":158,"context_line":"            # for the specified steps and return results."},{"line_number":159,"context_line":"            data \u003d self.validate_steps(request, workflow,"},{"line_number":160,"context_line":"                                       validate_step_start,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F8xP4%3D","line":157,"in_reply_to":"AAAATn%2F8xR0%3D","updated":"2013-12-20 14:18:23.000000000","message":"Thanks!","commit_id":"f891ecaedca34f15e3bbbd39c68845274b31a120"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1305ae85730abb3d007018a556aad45ce539fcc9","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def validate_steps(self, request, workflow, start, end):"},{"line_number":128,"context_line":"        errors \u003d {}"},{"line_number":129,"context_line":"        for step in workflow.steps[start:end + 1]:"},{"line_number":130,"context_line":"            if not step.action.is_valid():"},{"line_number":131,"context_line":"                errors[step.slug] \u003d dict("},{"line_number":132,"context_line":"                    (field, [unicode(error) for error in errors])"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F8t1k%3D","line":129,"updated":"2013-12-21 12:45:11.000000000","message":"Is there any description \"end\" is included or not. We need a clear description about whether \"end\" is included or not to avoid off-by-one problem. It also should be applied thoughout the code of Horizon and Dashboard.","commit_id":"9a98fa22a8df6940972325483d244abceaede935"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"280907234a695aa1ad6b0e56fa9b60d029970775","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def validate_steps(self, request, workflow, start, end):"},{"line_number":128,"context_line":"        errors \u003d {}"},{"line_number":129,"context_line":"        for step in workflow.steps[start:end + 1]:"},{"line_number":130,"context_line":"            if not step.action.is_valid():"},{"line_number":131,"context_line":"                errors[step.slug] \u003d dict("},{"line_number":132,"context_line":"                    (field, [unicode(error) for error in errors])"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F8rH4%3D","line":129,"in_reply_to":"AAAATn%2F8t1k%3D","updated":"2013-12-23 12:11:06.000000000","message":"Done","commit_id":"9a98fa22a8df6940972325483d244abceaede935"}],"openstack_dashboard/dashboards/project/networks/workflows.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1305ae85730abb3d007018a556aad45ce539fcc9","unresolved":false,"context_lines":[{"line_number":265,"context_line":"class CreateNetwork(workflows.Workflow):"},{"line_number":266,"context_line":"    slug \u003d \"create_network\""},{"line_number":267,"context_line":"    name \u003d _(\"Create Network\")"},{"line_number":268,"context_line":"    finalize_button_name \u003d _(\"Create Network\")"},{"line_number":269,"context_line":"    success_message \u003d _(\u0027Created network \"%s\".\u0027)"},{"line_number":270,"context_line":"    failure_message \u003d _(\u0027Unable to create network \"%s\".\u0027)"},{"line_number":271,"context_line":"    default_steps \u003d (CreateNetworkInfo,"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F8t18%3D","line":268,"updated":"2013-12-21 12:45:11.000000000","message":"I am not sure why this change is required for this patch.","commit_id":"9a98fa22a8df6940972325483d244abceaede935"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"280907234a695aa1ad6b0e56fa9b60d029970775","unresolved":false,"context_lines":[{"line_number":265,"context_line":"class CreateNetwork(workflows.Workflow):"},{"line_number":266,"context_line":"    slug \u003d \"create_network\""},{"line_number":267,"context_line":"    name \u003d _(\"Create Network\")"},{"line_number":268,"context_line":"    finalize_button_name \u003d _(\"Create Network\")"},{"line_number":269,"context_line":"    success_message \u003d _(\u0027Created network \"%s\".\u0027)"},{"line_number":270,"context_line":"    failure_message \u003d _(\u0027Unable to create network \"%s\".\u0027)"},{"line_number":271,"context_line":"    default_steps \u003d (CreateNetworkInfo,"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F8rHY%3D","line":268,"in_reply_to":"AAAATn%2F8t18%3D","updated":"2013-12-23 12:11:06.000000000","message":"Done","commit_id":"9a98fa22a8df6940972325483d244abceaede935"}],"openstack_dashboard/static/dashboard/less/horizon.less":[{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"885665a1c57228d4130dd10871887c2309e9f0fb","unresolved":false,"context_lines":[{"line_number":884,"context_line":"    color:#f00;"},{"line_number":885,"context_line":"  }"},{"line_number":886,"context_line":"}"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":".clear {"},{"line_number":889,"context_line":"    clear: both;"},{"line_number":890,"context_line":"    width: 0;"}],"source_content_type":"text/x-less","patch_set":3,"id":"AAAATn%2F%2FShU%3D","line":887,"updated":"2013-11-11 16:05:22.000000000","message":"I\u0027m late to the dance, but would this be better to be in its own wizards.less file?  horizon.less is getting REALLY big.","commit_id":"cd7ebe0c6e015a098bf5c97d483866cd7799007e"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"dc40ea3b9bad50bc82cda5ae8327a54ce4b9d937","unresolved":false,"context_lines":[{"line_number":884,"context_line":"    color:#f00;"},{"line_number":885,"context_line":"  }"},{"line_number":886,"context_line":"}"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":".clear {"},{"line_number":889,"context_line":"    clear: both;"},{"line_number":890,"context_line":"    width: 0;"}],"source_content_type":"text/x-less","patch_set":3,"id":"AAAATn%2F%2FK%2FA%3D","line":887,"in_reply_to":"AAAATn%2F%2FShU%3D","updated":"2013-11-13 11:59:02.000000000","message":"Done","commit_id":"cd7ebe0c6e015a098bf5c97d483866cd7799007e"}]}
