)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b1c56a1357e3b98459900484dc43c5684ea32911","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Snapshots list should contain the one created with volume when launching instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In launch instance modal, a user select \u0027Instance Snapshots\u0027."},{"line_number":10,"context_line":"The snapshots listed,but not all. The snapshots, created from"},{"line_number":11,"context_line":"a intance with new volume or a instance created from volume"},{"line_number":12,"context_line":"or volume snapshot, don\u0027t have \u0027image_type\u0027 but \u0027block_device_mapping\u0027."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f9dbf25_b36423bb","line":9,"updated":"2018-02-27 21:27:15.000000000","message":"selects","commit_id":"6071aeb47e9ee7552952ed79e0fcf26668feb762"},{"author":{"_account_id":25946,"name":"Wangliangyu","email":"wangly2097@chinaunicom.cn","username":"wangliangyu"},"change_message_id":"45b974a3e41ff8299373453d17f3bfe4eaac7505","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Snapshots list should contain the one created with volume when launching instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In launch instance modal, a user select \u0027Instance Snapshots\u0027."},{"line_number":10,"context_line":"The snapshots listed,but not all. The snapshots, created from"},{"line_number":11,"context_line":"a intance with new volume or a instance created from volume"},{"line_number":12,"context_line":"or volume snapshot, don\u0027t have \u0027image_type\u0027 but \u0027block_device_mapping\u0027."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f9dbf25_b47392e7","line":9,"in_reply_to":"1f9dbf25_b36423bb","updated":"2018-03-01 09:34:05.000000000","message":"Done","commit_id":"6071aeb47e9ee7552952ed79e0fcf26668feb762"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b1c56a1357e3b98459900484dc43c5684ea32911","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Snapshots list should contain the one created with volume when launching instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In launch instance modal, a user select \u0027Instance Snapshots\u0027."},{"line_number":10,"context_line":"The snapshots listed,but not all. The snapshots, created from"},{"line_number":11,"context_line":"a intance with new volume or a instance created from volume"},{"line_number":12,"context_line":"or volume snapshot, don\u0027t have \u0027image_type\u0027 but \u0027block_device_mapping\u0027."},{"line_number":13,"context_line":"So, judging only by image_type is not enough."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f9dbf25_b30983de","line":10,"updated":"2018-02-27 21:27:15.000000000","message":"IMO, it should be better to change wording to something like:\nIn launch instance modal, a user selects \u0027Instance Snapshots\u0027 and not all snapshots are listed","commit_id":"6071aeb47e9ee7552952ed79e0fcf26668feb762"},{"author":{"_account_id":25946,"name":"Wangliangyu","email":"wangly2097@chinaunicom.cn","username":"wangliangyu"},"change_message_id":"45b974a3e41ff8299373453d17f3bfe4eaac7505","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Snapshots list should contain the one created with volume when launching instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In launch instance modal, a user select \u0027Instance Snapshots\u0027."},{"line_number":10,"context_line":"The snapshots listed,but not all. The snapshots, created from"},{"line_number":11,"context_line":"a intance with new volume or a instance created from volume"},{"line_number":12,"context_line":"or volume snapshot, don\u0027t have \u0027image_type\u0027 but \u0027block_device_mapping\u0027."},{"line_number":13,"context_line":"So, judging only by image_type is not enough."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f9dbf25_144cc69c","line":10,"in_reply_to":"1f9dbf25_b30983de","updated":"2018-03-01 09:34:05.000000000","message":"Done","commit_id":"6071aeb47e9ee7552952ed79e0fcf26668feb762"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3bf803c57e2b9b456976cca5debcdc0b6c6ce00e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     wangliangyu \u003cwangliangyu@gohighsec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-03-30 15:01:52 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Snapshots list should contain the one created with volume when launching instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In launch instance modal, a user selects \u0027Instance Snapshots\u0027 and"},{"line_number":10,"context_line":"not all snapshots are listed. The snapshots, created from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5f7c97a3_772763b8","line":7,"updated":"2018-05-03 11:42:34.000000000","message":"Please, change commit message according to https://docs.openstack.org/infra/manual/developers.html#committing-a-change","commit_id":"bd517bc733736469d0521ec63ff87b82b530a27a"}],"openstack_dashboard/dashboards/project/images/images/tables.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b1c56a1357e3b98459900484dc43c5684ea32911","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"def get_image_type(image):"},{"line_number":250,"context_line":"    if not hasattr(image, \u0027properties\u0027) or \\"},{"line_number":251,"context_line":"       not (image.properties.get(\u0027image_type\u0027) or"},{"line_number":252,"context_line":"            image.properties.get(\u0027block_device_mapping\u0027)):"},{"line_number":253,"context_line":"        return \u0027image\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f9dbf25_33cc9388","line":250,"updated":"2018-02-27 21:27:15.000000000","message":"I think, it would be good to make this part of code more readable like:\nif not any([hasattr(image, \u0027properties\u0027),\n    image.properties.get(\u0027image_type\u0027) or\n    image.properties.get(\u0027block_device_mapping\u0027)])\n    return \u0027image\u0027\n\nif image.properties.get(\u0027image_type\u0027):\n    return image.properties.get(\u0027image_type\u0027)\n\nblock_device_mapping \u003d json.loads(image.properties.get(\u0027block_device_mapping\u0027))\nreturn  block_device_mapping[0].get(\u0027source_type\u0027)\n\n\nI prefer more readable code even if it contains more lines","commit_id":"6071aeb47e9ee7552952ed79e0fcf26668feb762"},{"author":{"_account_id":25946,"name":"Wangliangyu","email":"wangly2097@chinaunicom.cn","username":"wangliangyu"},"change_message_id":"45b974a3e41ff8299373453d17f3bfe4eaac7505","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"def get_image_type(image):"},{"line_number":250,"context_line":"    if not hasattr(image, \u0027properties\u0027) or \\"},{"line_number":251,"context_line":"       not (image.properties.get(\u0027image_type\u0027) or"},{"line_number":252,"context_line":"            image.properties.get(\u0027block_device_mapping\u0027)):"},{"line_number":253,"context_line":"        return \u0027image\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f9dbf25_d445fe71","line":250,"in_reply_to":"1f9dbf25_33cc9388","updated":"2018-03-01 09:34:05.000000000","message":"Done","commit_id":"6071aeb47e9ee7552952ed79e0fcf26668feb762"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3bf803c57e2b9b456976cca5debcdc0b6c6ce00e","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    return getattr(image, \"name\", None) or image.id"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"def get_image_type(image):"},{"line_number":250,"context_line":"    if not hasattr(image, \u0027properties\u0027):"},{"line_number":251,"context_line":"        return \u0027image\u0027"},{"line_number":252,"context_line":"    if image.properties.get(\u0027image_type\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_9751df11","line":249,"updated":"2018-05-03 11:42:34.000000000","message":"Please, add unit-test to cover only this method to avoid a regression in the future","commit_id":"bd517bc733736469d0521ec63ff87b82b530a27a"}],"openstack_dashboard/test/test_data/glance_data.py":[{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"e552ccff412995c8a1fa7326864094daba86e80a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                                 \u0027status\u0027: \"queued\","},{"line_number":86,"context_line":"                                 \u0027owner\u0027: TEST.tenant.id,"},{"line_number":87,"context_line":"                                 \u0027properties\u0027: {"},{"line_number":88,"context_line":"                                     \u0027block_device_mapping\u0027: "},{"line_number":89,"context_line":"                                         \u0027[{\"source_type\": \"snapshot\"}]\u0027},"},{"line_number":90,"context_line":"                                 \u0027is_public\u0027: False,"},{"line_number":91,"context_line":"                                 \u0027protected\u0027: False}"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f9dbf25_8eb1a792","line":88,"range":{"start_line":88,"start_character":60,"end_line":88,"end_character":61},"updated":"2018-03-01 07:39:42.000000000","message":"should be removed","commit_id":"0028bb7b92b451b7e4d20812ee77a7a1b4ce60cc"},{"author":{"_account_id":25946,"name":"Wangliangyu","email":"wangly2097@chinaunicom.cn","username":"wangliangyu"},"change_message_id":"45b974a3e41ff8299373453d17f3bfe4eaac7505","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                                 \u0027status\u0027: \"queued\","},{"line_number":86,"context_line":"                                 \u0027owner\u0027: TEST.tenant.id,"},{"line_number":87,"context_line":"                                 \u0027properties\u0027: {"},{"line_number":88,"context_line":"                                     \u0027block_device_mapping\u0027: "},{"line_number":89,"context_line":"                                         \u0027[{\"source_type\": \"snapshot\"}]\u0027},"},{"line_number":90,"context_line":"                                 \u0027is_public\u0027: False,"},{"line_number":91,"context_line":"                                 \u0027protected\u0027: False}"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f9dbf25_94b1b692","line":88,"range":{"start_line":88,"start_character":60,"end_line":88,"end_character":61},"in_reply_to":"1f9dbf25_8eb1a792","updated":"2018-03-01 09:34:05.000000000","message":"Done","commit_id":"0028bb7b92b451b7e4d20812ee77a7a1b4ce60cc"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"e552ccff412995c8a1fa7326864094daba86e80a","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    }"},{"line_number":357,"context_line":"    TEST.snapshotsV2.add(api.glance.Image(APIResourceV2(snapshot_v2_dict)))"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    metadef_dict \u003d {"},{"line_number":361,"context_line":"        \u0027namespace\u0027: \u0027namespace_1\u0027,"},{"line_number":362,"context_line":"        \u0027display_name\u0027: \u0027Namespace 1\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f9dbf25_0e63571c","line":359,"updated":"2018-03-01 07:39:42.000000000","message":"1 line should be removed","commit_id":"0028bb7b92b451b7e4d20812ee77a7a1b4ce60cc"},{"author":{"_account_id":25946,"name":"Wangliangyu","email":"wangly2097@chinaunicom.cn","username":"wangliangyu"},"change_message_id":"45b974a3e41ff8299373453d17f3bfe4eaac7505","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    }"},{"line_number":357,"context_line":"    TEST.snapshotsV2.add(api.glance.Image(APIResourceV2(snapshot_v2_dict)))"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    metadef_dict \u003d {"},{"line_number":361,"context_line":"        \u0027namespace\u0027: \u0027namespace_1\u0027,"},{"line_number":362,"context_line":"        \u0027display_name\u0027: \u0027Namespace 1\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f9dbf25_b4ae322c","line":359,"in_reply_to":"1f9dbf25_0e63571c","updated":"2018-03-01 09:34:05.000000000","message":"Done","commit_id":"0028bb7b92b451b7e4d20812ee77a7a1b4ce60cc"}]}
