)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6d6e414bbd9d37f2aafa0fee15a2c39693c2de93","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug #1641383 was not fixed for REST API call."},{"line_number":10,"context_line":"The two implementation of create_image_metadata are merged in api/glance.py."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I41e9d94345151bc4473d704cdc040ed77870ce45"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df7087c5_6af2e308","line":11,"updated":"2018-03-20 14:56:57.000000000","message":"could you file a bug on this topic? bug 1641383 you mentioned is marked as fixed for Ocata release, so it is worth filing a new bug.","commit_id":"370753007278c39500691564bf26326bcfb45bac"}],"openstack_dashboard/api/glance.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"bc2dd8b7b20ca3b52f1b2e0e688e81a2cf49548d","unresolved":false,"context_lines":[{"line_number":450,"context_line":"    meta[\u0027min_disk\u0027] \u003d 0"},{"line_number":451,"context_line":"    meta[\u0027min_ram\u0027] \u003d 0"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    for k in data.keys():"},{"line_number":454,"context_line":"        if k in (\u0027min_disk\u0027, \u0027minimum_disk\u0027):"},{"line_number":455,"context_line":"            meta[\u0027min_disk\u0027] \u003d data[k]"},{"line_number":456,"context_line":"        elif k in (\u0027min_ram\u0027, \u0027minimum_ram\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_9e1e595d","line":453,"updated":"2018-03-22 16:17:29.000000000","message":"We can omit loop here:\nmin_disk \u003d data.get(\u0027min_disk\u0027, data.get(\u0027minimum_disk\u0027))\nif min_disk:\n    meta[\u0027min_disk\u0027] \u003d min_disk\n\nmin_ram \u003d data.get(\u0027min_ram\u0027, data.get(\u0027minimum_ram\u0027))\nif min_ram:\n    meta[\u0027min_ram\u0027] \u003d min_ram","commit_id":"647cc03aaf9b05bbef38747b844e394c1306aa77"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"bc2dd8b7b20ca3b52f1b2e0e688e81a2cf49548d","unresolved":false,"context_lines":[{"line_number":464,"context_line":"    # are handled has changed: in V2 empty metadata is kept in image"},{"line_number":465,"context_line":"    # properties, while in V1 they were omitted. Skip empty description (which"},{"line_number":466,"context_line":"    # is metadata) to keep the same behavior between V1 and V2"},{"line_number":467,"context_line":"    if data.get(\u0027description\u0027):"},{"line_number":468,"context_line":"        properties[\u0027description\u0027] \u003d data[\u0027description\u0027]"},{"line_number":469,"context_line":"    if data.get(\u0027kernel\u0027):"},{"line_number":470,"context_line":"        properties[\u0027kernel_id\u0027] \u003d data[\u0027kernel\u0027]"},{"line_number":471,"context_line":"    if data.get(\u0027ramdisk\u0027):"},{"line_number":472,"context_line":"        properties[\u0027ramdisk_id\u0027] \u003d data[\u0027ramdisk\u0027]"},{"line_number":473,"context_line":"    if data.get(\u0027architecture\u0027):"},{"line_number":474,"context_line":"        properties[\u0027architecture\u0027] \u003d data[\u0027architecture\u0027]"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    if VERSIONS.active \u003c 2:"},{"line_number":477,"context_line":"        meta.update({\u0027is_public\u0027: is_public, \u0027properties\u0027: properties})"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_3e494db6","line":474,"range":{"start_line":467,"start_character":4,"end_line":474,"end_character":57},"updated":"2018-03-22 16:17:29.000000000","message":"IMO, more pythonic way is:\nfor prop, value in [(\u0027description\u0027, \u0027description\u0027),\n                    (\u0027kernel_id\u0027, \u0027kernel\u0027),\n                    (\u0027ramdisk_id\u0027, \u0027ramdisk\u0027),\n                    (\u0027architecture\u0027, \u0027architecture\u0027)]:\n    if value in data:\n        properties[prop] \u003d data[value]","commit_id":"647cc03aaf9b05bbef38747b844e394c1306aa77"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"89304b57e21bf3dfa4f057629ed16845754abbbf","unresolved":false,"context_lines":[{"line_number":417,"context_line":"    \"\"\"Generate metadata dict for a new image from a given form data.\"\"\""},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    # Default metadata"},{"line_number":420,"context_line":"    meta \u003d {\u0027protected\u0027: data.get(\u0027protected\u0027),"},{"line_number":421,"context_line":"            \u0027disk_format\u0027: data.get(\u0027disk_format\u0027),"},{"line_number":422,"context_line":"            \u0027container_format\u0027: data.get(\u0027container_format\u0027, \u0027bare\u0027),"},{"line_number":423,"context_line":"            \u0027min_disk\u0027: data.get(\u0027min_disk\u0027, data.pop(\u0027minimum_disk\u0027, 0)),"}],"source_content_type":"text/x-python","patch_set":12,"id":"bf659307_3b83d106","line":420,"range":{"start_line":420,"start_character":25,"end_line":420,"end_character":47},"updated":"2018-04-09 14:55:01.000000000","message":"protected is a boolean value, so it needs to be:\n\n  data.get(\u0027protected\u0027, False)","commit_id":"7059100f307ccb00658f8c786ff03dacc78e97fb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"89304b57e21bf3dfa4f057629ed16845754abbbf","unresolved":false,"context_lines":[{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    # Default metadata"},{"line_number":420,"context_line":"    meta \u003d {\u0027protected\u0027: data.get(\u0027protected\u0027),"},{"line_number":421,"context_line":"            \u0027disk_format\u0027: data.get(\u0027disk_format\u0027),"},{"line_number":422,"context_line":"            \u0027container_format\u0027: data.get(\u0027container_format\u0027, \u0027bare\u0027),"},{"line_number":423,"context_line":"            \u0027min_disk\u0027: data.get(\u0027min_disk\u0027, data.pop(\u0027minimum_disk\u0027, 0)),"},{"line_number":424,"context_line":"            \u0027min_ram\u0027: data.get(\u0027min_ram\u0027, data.pop(\u0027minimum_ram\u0027, 0)),"}],"source_content_type":"text/x-python","patch_set":12,"id":"bf659307_7b8e2928","line":421,"range":{"start_line":421,"start_character":27,"end_line":421,"end_character":50},"updated":"2018-04-09 14:55:01.000000000","message":"question: Is None a valid value for disk_format?","commit_id":"7059100f307ccb00658f8c786ff03dacc78e97fb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"89304b57e21bf3dfa4f057629ed16845754abbbf","unresolved":false,"context_lines":[{"line_number":420,"context_line":"    meta \u003d {\u0027protected\u0027: data.get(\u0027protected\u0027),"},{"line_number":421,"context_line":"            \u0027disk_format\u0027: data.get(\u0027disk_format\u0027),"},{"line_number":422,"context_line":"            \u0027container_format\u0027: data.get(\u0027container_format\u0027, \u0027bare\u0027),"},{"line_number":423,"context_line":"            \u0027min_disk\u0027: data.get(\u0027min_disk\u0027, data.pop(\u0027minimum_disk\u0027, 0)),"},{"line_number":424,"context_line":"            \u0027min_ram\u0027: data.get(\u0027min_ram\u0027, data.pop(\u0027minimum_ram\u0027, 0)),"},{"line_number":425,"context_line":"            \u0027name\u0027: data.get(\u0027name\u0027)}"},{"line_number":426,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bf659307_bbab6173","line":423,"range":{"start_line":423,"start_character":50,"end_line":423,"end_character":53},"updated":"2018-04-09 14:55:01.000000000","message":"Why \u0027pop\u0027 is needed? We usually use .get() in this case. It is better to have a comment why \u0027pop\u0027 is needed here if we really need pop.","commit_id":"7059100f307ccb00658f8c786ff03dacc78e97fb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"89304b57e21bf3dfa4f057629ed16845754abbbf","unresolved":false,"context_lines":[{"line_number":422,"context_line":"            \u0027container_format\u0027: data.get(\u0027container_format\u0027, \u0027bare\u0027),"},{"line_number":423,"context_line":"            \u0027min_disk\u0027: data.get(\u0027min_disk\u0027, data.pop(\u0027minimum_disk\u0027, 0)),"},{"line_number":424,"context_line":"            \u0027min_ram\u0027: data.get(\u0027min_ram\u0027, data.pop(\u0027minimum_ram\u0027, 0)),"},{"line_number":425,"context_line":"            \u0027name\u0027: data.get(\u0027name\u0027)}"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    # Glance does not really do anything with container_format at the"},{"line_number":428,"context_line":"    # moment. It requires it is set to the same disk_format for the three"}],"source_content_type":"text/x-python","patch_set":12,"id":"bf659307_5bb485d1","line":425,"range":{"start_line":425,"start_character":20,"end_line":425,"end_character":36},"updated":"2018-04-09 14:55:01.000000000","message":"Is None a valid value for \u0027name\u0027? Doesn\u0027t an empty string (i.e. \u0027\u0027) make more sense?","commit_id":"7059100f307ccb00658f8c786ff03dacc78e97fb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"89304b57e21bf3dfa4f057629ed16845754abbbf","unresolved":false,"context_lines":[{"line_number":465,"context_line":"    return meta"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"def handle_visibility(data, meta):"},{"line_number":469,"context_line":"    is_public \u003d data.get(\u0027is_public\u0027, data.get(\u0027public\u0027, False))"},{"line_number":470,"context_line":"    visibility \u003d \u0027public\u0027 if is_public else data.get(\u0027visibility\u0027, \u0027private\u0027)"},{"line_number":471,"context_line":"    if not is_public:"}],"source_content_type":"text/x-python","patch_set":12,"id":"bf659307_2182c2c9","line":468,"updated":"2018-04-09 14:55:01.000000000","message":"This logic contains a lot of implicit assumptions.\n\nI have several questions.\n\nIs there a case where both visibility and is_public/public are specified? If not, we should check a key is contained in data rather than using .get() and default value.\n\nIn addition, we should have a clear priority between visibility and is_public/public to clarify the logic.\n\nThe current code SEEMS to be compatible with the previous logic, but it seems hard to maintain it.","commit_id":"7059100f307ccb00658f8c786ff03dacc78e97fb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"655f57ae951e31df4a9aa47bab3f320c699b5a1e","unresolved":false,"context_lines":[{"line_number":465,"context_line":"    return meta"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"def handle_visibility(data, meta):"},{"line_number":469,"context_line":"    is_public \u003d data.get(\u0027is_public\u0027, data.get(\u0027public\u0027, False))"},{"line_number":470,"context_line":"    visibility \u003d \u0027public\u0027 if is_public else data.get(\u0027visibility\u0027, \u0027private\u0027)"},{"line_number":471,"context_line":"    if not is_public:"}],"source_content_type":"text/x-python","patch_set":12,"id":"bf659307_9063c8dc","line":468,"in_reply_to":"bf659307_2182c2c9","updated":"2018-04-10 01:26:21.000000000","message":"(follow-up comment) The clean up can be done later in a separate patch.","commit_id":"7059100f307ccb00658f8c786ff03dacc78e97fb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"89304b57e21bf3dfa4f057629ed16845754abbbf","unresolved":false,"context_lines":[{"line_number":485,"context_line":"    # are assumed as metadata. To achieve this and continue to use the"},{"line_number":486,"context_line":"    # existing horizon api wrapper, we need this function.  This way, the"},{"line_number":487,"context_line":"    # client REST mirrors the Glance API."},{"line_number":488,"context_line":"    known_props \u003d [\u0027visibility\u0027, \u0027protected\u0027, \u0027disk_format\u0027,"},{"line_number":489,"context_line":"                   \u0027container_format\u0027, \u0027min_disk\u0027, \u0027min_ram\u0027, \u0027name\u0027,"},{"line_number":490,"context_line":"                   \u0027properties\u0027, \u0027kernel\u0027, \u0027ramdisk\u0027,"},{"line_number":491,"context_line":"                   \u0027tags\u0027, \u0027import_data\u0027, \u0027source\u0027, \u0027image_id\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bf659307_dbd415ec","line":488,"range":{"start_line":488,"start_character":4,"end_line":488,"end_character":15},"updated":"2018-04-09 14:55:01.000000000","message":"This should be moved to outside of the function. It is better to define a constant as the module level.\n\n  KWNON_PROPERTIES \u003d [....]","commit_id":"7059100f307ccb00658f8c786ff03dacc78e97fb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e3977b7a4488309353242a2a7b70b59040f7b3fb","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    # Glance v1 uses filter \u0027is_public\u0027 (True, False)."},{"line_number":178,"context_line":"    # Glance v2 uses filter \u0027visibility\u0027 (\u0027public\u0027, \u0027private\u0027, ...)."},{"line_number":179,"context_line":"    if VERSIONS.active \u003e\u003d 2:"},{"line_number":180,"context_line":"        if \u0027is_public\u0027 in filters:"},{"line_number":181,"context_line":"            # Glance v2: Replace \u0027is_public\u0027 with \u0027visibility\u0027."},{"line_number":182,"context_line":"            visibility \u003d PUBLIC_TO_VISIBILITY_MAP[filters[\u0027is_public\u0027]]"},{"line_number":183,"context_line":"            del filters[\u0027is_public\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f6a8fd7_5dc60b19","line":180,"range":{"start_line":180,"start_character":8,"end_line":180,"end_character":34},"updated":"2018-04-15 05:36:14.000000000","message":"When api/rest/glance.py is used, it seems only \u0027visibility\u0027 is updated in the submitted data and \u0027is_public\u0027 continue to keep the old data. As a result, when I tried to update the visibility from public to private in the Angular Edit Image form, I cannot change the visibility to private and the visibility continued to stay in \"public\". This is a regression.","commit_id":"bb7ba33d7268d3b1ea0ac397bec652bc44f1818f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b9cde94079e86608523bd16870ba1698c8aafe93","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    # Glance v1 uses filter \u0027is_public\u0027 (True, False)."},{"line_number":178,"context_line":"    # Glance v2 uses filter \u0027visibility\u0027 (\u0027public\u0027, \u0027private\u0027, ...)."},{"line_number":179,"context_line":"    if VERSIONS.active \u003e\u003d 2:"},{"line_number":180,"context_line":"        if \u0027is_public\u0027 in filters:"},{"line_number":181,"context_line":"            # Glance v2: Replace \u0027is_public\u0027 with \u0027visibility\u0027."},{"line_number":182,"context_line":"            visibility \u003d PUBLIC_TO_VISIBILITY_MAP[filters[\u0027is_public\u0027]]"},{"line_number":183,"context_line":"            del filters[\u0027is_public\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f6a8fd7_e0cf3855","line":180,"range":{"start_line":180,"start_character":8,"end_line":180,"end_character":34},"in_reply_to":"9f6a8fd7_5dc60b19","updated":"2018-04-15 08:59:45.000000000","message":"I added a logic to drop \u0027is_public\u0027 from a request data to api/rest/glance.py. It is specific to the REST API for Angular implementation so api/rest/glance.py is the right place to do it.","commit_id":"bb7ba33d7268d3b1ea0ac397bec652bc44f1818f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a3b463fa408f0ab06c1963aa6c7207de8d1b8161","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                filters[\u0027visibility\u0027] \u003d visibility"},{"line_number":186,"context_line":"    elif \u0027visibility\u0027 in filters:"},{"line_number":187,"context_line":"        # Glance v1: Replace \u0027visibility\u0027 with \u0027is_public\u0027."},{"line_number":188,"context_line":"        filters[\u0027is_public\u0027] \u003d ("},{"line_number":189,"context_line":"            filters[\u0027visibility\u0027] \u003d\u003d \"public\")"},{"line_number":190,"context_line":"        del filters[\u0027visibility\u0027]"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bf659307_fab99778","line":189,"range":{"start_line":188,"start_character":8,"end_line":189,"end_character":46},"updated":"2018-04-15 04:51:44.000000000","message":"There is no need to wrap lines.\n\n filters[\u0027is_public\u0027] \u003d filters[\u0027visibility\u0027] \u003d\u003d \"public\"","commit_id":"bb7ba33d7268d3b1ea0ac397bec652bc44f1818f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b9cde94079e86608523bd16870ba1698c8aafe93","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                filters[\u0027visibility\u0027] \u003d visibility"},{"line_number":186,"context_line":"    elif \u0027visibility\u0027 in filters:"},{"line_number":187,"context_line":"        # Glance v1: Replace \u0027visibility\u0027 with \u0027is_public\u0027."},{"line_number":188,"context_line":"        filters[\u0027is_public\u0027] \u003d ("},{"line_number":189,"context_line":"            filters[\u0027visibility\u0027] \u003d\u003d \"public\")"},{"line_number":190,"context_line":"        del filters[\u0027visibility\u0027]"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f6a8fd7_00e34c07","line":189,"range":{"start_line":188,"start_character":8,"end_line":189,"end_character":46},"in_reply_to":"bf659307_fab99778","updated":"2018-04-15 08:59:45.000000000","message":"Done","commit_id":"bb7ba33d7268d3b1ea0ac397bec652bc44f1818f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a3b463fa408f0ab06c1963aa6c7207de8d1b8161","unresolved":false,"context_lines":[{"line_number":480,"context_line":"    return meta"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"def handle_visibility(data):"},{"line_number":484,"context_line":"    visibility \u003d data.get(\u0027visibility\u0027, \u0027private\u0027)"},{"line_number":485,"context_line":"    if visibility not in [\u0027public\u0027, \u0027private\u0027, \u0027shared\u0027]:"},{"line_number":486,"context_line":"        raise KeyError(\u0027invalid visibility option: %s\u0027 % visibility)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf659307_33ae4681","line":483,"updated":"2018-04-15 04:51:44.000000000","message":"Could you make this function private?\n\n _handle_visibility(data)\n\nCound you also move it around (before?) _normalize_is_public_filter? These two do related things, so it makes sense to be placed in near places.","commit_id":"bb7ba33d7268d3b1ea0ac397bec652bc44f1818f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b9cde94079e86608523bd16870ba1698c8aafe93","unresolved":false,"context_lines":[{"line_number":480,"context_line":"    return meta"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"def handle_visibility(data):"},{"line_number":484,"context_line":"    visibility \u003d data.get(\u0027visibility\u0027, \u0027private\u0027)"},{"line_number":485,"context_line":"    if visibility not in [\u0027public\u0027, \u0027private\u0027, \u0027shared\u0027]:"},{"line_number":486,"context_line":"        raise KeyError(\u0027invalid visibility option: %s\u0027 % visibility)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f6a8fd7_20b530ef","line":483,"in_reply_to":"bf659307_33ae4681","updated":"2018-04-15 08:59:45.000000000","message":"This is simple enough. There is no need to be a separate function.","commit_id":"bb7ba33d7268d3b1ea0ac397bec652bc44f1818f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a3b463fa408f0ab06c1963aa6c7207de8d1b8161","unresolved":false,"context_lines":[{"line_number":481,"context_line":""},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"def handle_visibility(data):"},{"line_number":484,"context_line":"    visibility \u003d data.get(\u0027visibility\u0027, \u0027private\u0027)"},{"line_number":485,"context_line":"    if visibility not in [\u0027public\u0027, \u0027private\u0027, \u0027shared\u0027]:"},{"line_number":486,"context_line":"        raise KeyError(\u0027invalid visibility option: %s\u0027 % visibility)"},{"line_number":487,"context_line":"    _normalize_is_public_filter(data)"},{"line_number":488,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bf659307_53841ad3","line":485,"range":{"start_line":484,"start_character":4,"end_line":485,"end_character":57},"updated":"2018-04-15 04:51:44.000000000","message":"I think there is no need to use .get() and it looks straight-forward to me.\n\n  if (\u0027visibility\u0027 in data and\n          data[\u0027visibility\u0027] not in .....):\n      raise KeyError(....)","commit_id":"bb7ba33d7268d3b1ea0ac397bec652bc44f1818f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b9cde94079e86608523bd16870ba1698c8aafe93","unresolved":false,"context_lines":[{"line_number":481,"context_line":""},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"def handle_visibility(data):"},{"line_number":484,"context_line":"    visibility \u003d data.get(\u0027visibility\u0027, \u0027private\u0027)"},{"line_number":485,"context_line":"    if visibility not in [\u0027public\u0027, \u0027private\u0027, \u0027shared\u0027]:"},{"line_number":486,"context_line":"        raise KeyError(\u0027invalid visibility option: %s\u0027 % visibility)"},{"line_number":487,"context_line":"    _normalize_is_public_filter(data)"},{"line_number":488,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f6a8fd7_80c0bc52","line":485,"range":{"start_line":484,"start_character":4,"end_line":485,"end_character":57},"in_reply_to":"bf659307_53841ad3","updated":"2018-04-15 08:59:45.000000000","message":"Done","commit_id":"bb7ba33d7268d3b1ea0ac397bec652bc44f1818f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a3b463fa408f0ab06c1963aa6c7207de8d1b8161","unresolved":false,"context_lines":[{"line_number":484,"context_line":"    visibility \u003d data.get(\u0027visibility\u0027, \u0027private\u0027)"},{"line_number":485,"context_line":"    if visibility not in [\u0027public\u0027, \u0027private\u0027, \u0027shared\u0027]:"},{"line_number":486,"context_line":"        raise KeyError(\u0027invalid visibility option: %s\u0027 % visibility)"},{"line_number":487,"context_line":"    _normalize_is_public_filter(data)"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"def handle_unknown_properties(data, properties):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f6a8fd7_3d39d740","line":487,"updated":"2018-04-15 04:51:44.000000000","message":"In UpdateImageForm, \u0027public\u0027 is used instead of \u0027is_public\u0027. Where is it handled? I think testing coverage is not enough.","commit_id":"bb7ba33d7268d3b1ea0ac397bec652bc44f1818f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"41fca46285aafe896253204242eb4c837fef72ff","unresolved":false,"context_lines":[{"line_number":484,"context_line":"    visibility \u003d data.get(\u0027visibility\u0027, \u0027private\u0027)"},{"line_number":485,"context_line":"    if visibility not in [\u0027public\u0027, \u0027private\u0027, \u0027shared\u0027]:"},{"line_number":486,"context_line":"        raise KeyError(\u0027invalid visibility option: %s\u0027 % visibility)"},{"line_number":487,"context_line":"    _normalize_is_public_filter(data)"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"def handle_unknown_properties(data, properties):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f6a8fd7_7d18afd2","line":487,"in_reply_to":"9f6a8fd7_3d39d740","updated":"2018-04-15 04:56:45.000000000","message":"Using two names (public and is_public) is confusing. \nIMHO, it is better to rename \u0027public\u0027 in UpdateImageForm to \u0027is_public\u0027 [1]. If so, views.py also needs to be updated [2].\n\n[1] https://github.com/openstack/horizon/blob/7f3fc396026666ec57ba2f6cea006a9e6c91da00/openstack_dashboard/dashboards/project/images/images/forms.py#L391\n[2] https://github.com/openstack/horizon/blob/7f3fc396026666ec57ba2f6cea006a9e6c91da00/openstack_dashboard/dashboards/project/images/images/views.py#L116","commit_id":"bb7ba33d7268d3b1ea0ac397bec652bc44f1818f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b9cde94079e86608523bd16870ba1698c8aafe93","unresolved":false,"context_lines":[{"line_number":484,"context_line":"    visibility \u003d data.get(\u0027visibility\u0027, \u0027private\u0027)"},{"line_number":485,"context_line":"    if visibility not in [\u0027public\u0027, \u0027private\u0027, \u0027shared\u0027]:"},{"line_number":486,"context_line":"        raise KeyError(\u0027invalid visibility option: %s\u0027 % visibility)"},{"line_number":487,"context_line":"    _normalize_is_public_filter(data)"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"def handle_unknown_properties(data, properties):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f6a8fd7_00cd8c5c","line":487,"in_reply_to":"9f6a8fd7_7d18afd2","updated":"2018-04-15 08:59:45.000000000","message":"\u0027public\u0027 in UpdateImageForm is now renamed to \u0027is_public\u0027.","commit_id":"bb7ba33d7268d3b1ea0ac397bec652bc44f1818f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a3b463fa408f0ab06c1963aa6c7207de8d1b8161","unresolved":false,"context_lines":[{"line_number":487,"context_line":"    _normalize_is_public_filter(data)"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"def handle_unknown_properties(data, properties):"},{"line_number":491,"context_line":"    # The Glance API takes in both known and unknown fields. Unknown fields"},{"line_number":492,"context_line":"    # are assumed as metadata. To achieve this and continue to use the"},{"line_number":493,"context_line":"    # existing horizon api wrapper, we need this function.  This way, the"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f6a8fd7_dd3d3b2d","line":490,"updated":"2018-04-15 04:51:44.000000000","message":"Could you make this function private?\n\n _handle_unknown_properties(data)","commit_id":"bb7ba33d7268d3b1ea0ac397bec652bc44f1818f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b9cde94079e86608523bd16870ba1698c8aafe93","unresolved":false,"context_lines":[{"line_number":487,"context_line":"    _normalize_is_public_filter(data)"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"def handle_unknown_properties(data, properties):"},{"line_number":491,"context_line":"    # The Glance API takes in both known and unknown fields. Unknown fields"},{"line_number":492,"context_line":"    # are assumed as metadata. To achieve this and continue to use the"},{"line_number":493,"context_line":"    # existing horizon api wrapper, we need this function.  This way, the"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f6a8fd7_40baa4de","line":490,"in_reply_to":"9f6a8fd7_dd3d3b2d","updated":"2018-04-15 08:59:45.000000000","message":"Done","commit_id":"bb7ba33d7268d3b1ea0ac397bec652bc44f1818f"}],"openstack_dashboard/dashboards/project/images/images/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6d6e414bbd9d37f2aafa0fee15a2c39693c2de93","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        mock_image_list.assert_has_calls(image_calls)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @override_settings(OPENSTACK_API_VERSIONS\u003d{\u0027image\u0027: 1})"},{"line_number":92,"context_line":"    def test_create_image_metadata_docker_v1(self):"},{"line_number":93,"context_line":"        form_data \u003d {"},{"line_number":94,"context_line":"            \u0027name\u0027: u\u0027Docker image\u0027,"},{"line_number":95,"context_line":"            \u0027description\u0027: u\u0027Docker image test\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_aa5f9be3","line":92,"updated":"2018-03-20 14:56:57.000000000","message":"Could you move the test to openstack_dashboard/test/unit/api/test_glance.py?\napi.glance.create_image_metadata now does not belong to project.images.images.forms, so it is odd to have a test for another module.","commit_id":"370753007278c39500691564bf26326bcfb45bac"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6d6e414bbd9d37f2aafa0fee15a2c39693c2de93","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        self.assertEqual(meta[\u0027properties\u0027][\u0027architecture\u0027],"},{"line_number":115,"context_line":"                         form_data[\u0027architecture\u0027])"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_create_image_metadata_docker_v2(self):"},{"line_number":118,"context_line":"        form_data \u003d {"},{"line_number":119,"context_line":"            \u0027name\u0027: u\u0027Docker image\u0027,"},{"line_number":120,"context_line":"            \u0027description\u0027: u\u0027Docker image test\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_6a5983fc","line":117,"updated":"2018-03-20 14:56:57.000000000","message":"ditto","commit_id":"370753007278c39500691564bf26326bcfb45bac"}]}
