)]}'
{"openstack_dashboard/dashboards/project/images_and_snapshots/images/tabs.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"43c375f9864406dc2114a2c3d71bf059f446f813","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_context_data(self, request):"},{"line_number":29,"context_line":"        image \u003d self.tab_group.kwargs[\u0027image\u0027]"},{"line_number":30,"context_line":"        image_props \u003d sorted(image.properties.items())"},{"line_number":31,"context_line":"        return {\"image\": image,"},{"line_number":32,"context_line":"                \"image_props\": image_props}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUz0%3D","line":30,"updated":"2013-11-10 20:42:03.000000000","message":"Is it ensured that the properties attribute always exists?\n\nIn images/views.py, a case where properties does not exist is also considered: \nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/images_and_snapshots/images/views.py#L68","commit_id":"c43d31af8de0cdb933934b01600673c42479dfa7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b5736637d39dbb75ea246f9fabcd09fabee71a75","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_context_data(self, request):"},{"line_number":29,"context_line":"        image \u003d self.tab_group.kwargs[\u0027image\u0027]"},{"line_number":30,"context_line":"        image_props \u003d sorted(image.properties.items())"},{"line_number":31,"context_line":"        return {\"image\": image,"},{"line_number":32,"context_line":"                \"image_props\": image_props}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUBw%3D","line":30,"in_reply_to":"AAAATn%2F%2FUGI%3D","updated":"2013-11-11 06:40:30.000000000","message":"Thanks. I confirmed it with my test env too.","commit_id":"c43d31af8de0cdb933934b01600673c42479dfa7"},{"author":{"_account_id":8302,"name":"Ryan Hsu","email":"hryan@vmware.com","username":"rhsu"},"change_message_id":"e75018933c38fbff97780841d8e3ee0c93995688","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def get_context_data(self, request):"},{"line_number":29,"context_line":"        image \u003d self.tab_group.kwargs[\u0027image\u0027]"},{"line_number":30,"context_line":"        image_props \u003d sorted(image.properties.items())"},{"line_number":31,"context_line":"        return {\"image\": image,"},{"line_number":32,"context_line":"                \"image_props\": image_props}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FUGI%3D","line":30,"in_reply_to":"AAAATn%2F%2FUz0%3D","updated":"2013-11-11 06:21:02.000000000","message":"Yes, the properties attribute will be an empty dict if a given image does not have custom properties set, as per python-glanceclient code here: https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v1/images.py#L59","commit_id":"c43d31af8de0cdb933934b01600673c42479dfa7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e2e0707e8ae41a67120c132a91697d202e0af64a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                         \"ramdisk_id\": \"Ramdisk ID\","},{"line_number":37,"context_line":"                         \"image_state\": \"Euca2ools state\","},{"line_number":38,"context_line":"                         \"project_id\": \"Project ID\","},{"line_number":39,"context_line":"                         \"image_type\": \"Image Type\"}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        image_props \u003d []"},{"line_number":42,"context_line":"        for prop, val in image.properties.items():"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BiZY%3D","line":39,"updated":"2013-11-24 22:05:28.000000000","message":"Please mark the srings translatable: e.g., _(\"Architecture\")","commit_id":"4e46da56b55aae4c65789148edadfb27ef642159"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"ee57c866dac937caf1eaa5227eb3d87ef7cfce32","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        # A mapping of custom property key names to their desired titles. If"},{"line_number":32,"context_line":"        # not specified here, the display title will default to the image\u0027s"},{"line_number":33,"context_line":"        # key name."},{"line_number":34,"context_line":"        custom_titles \u003d {\"architecture\": _(\"Architecture\"),"},{"line_number":35,"context_line":"                         \"kernel_id\": _(\"Kernel ID\"),"},{"line_number":36,"context_line":"                         \"ramdisk_id\": _(\"Ramdisk ID\"),"},{"line_number":37,"context_line":"                         \"image_state\": _(\"Euca2ools state\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2Bgz8%3D","line":34,"updated":"2013-11-25 10:01:07.000000000","message":"Since we are displaying all the properties now, I would think the operator would definitely want to configure the title name for all their image properties. We should provide a way for operator to configure additional property name via local_settings file.","commit_id":"c11eab60aa042b00a017d33d32eb196c435a4f37"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"785ed39dbe7b802746c89bd9f966ccc53d0a89a8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        # A mapping of custom property key names to their desired titles. If"},{"line_number":32,"context_line":"        # not specified here, the display title will default to the image\u0027s"},{"line_number":33,"context_line":"        # key name."},{"line_number":34,"context_line":"        custom_titles \u003d {\"architecture\": _(\"Architecture\"),"},{"line_number":35,"context_line":"                         \"kernel_id\": _(\"Kernel ID\"),"},{"line_number":36,"context_line":"                         \"ramdisk_id\": _(\"Ramdisk ID\"),"},{"line_number":37,"context_line":"                         \"image_state\": _(\"Euca2ools state\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2Bb%2B8%3D","line":34,"in_reply_to":"AAAATn%2F%2BdWI%3D","updated":"2013-11-26 03:37:35.000000000","message":"Makes sense, thanks","commit_id":"c11eab60aa042b00a017d33d32eb196c435a4f37"},{"author":{"_account_id":8302,"name":"Ryan Hsu","email":"hryan@vmware.com","username":"rhsu"},"change_message_id":"e57c950cca38abc49cc9993c14d3f3c721e88402","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        # A mapping of custom property key names to their desired titles. If"},{"line_number":32,"context_line":"        # not specified here, the display title will default to the image\u0027s"},{"line_number":33,"context_line":"        # key name."},{"line_number":34,"context_line":"        custom_titles \u003d {\"architecture\": _(\"Architecture\"),"},{"line_number":35,"context_line":"                         \"kernel_id\": _(\"Kernel ID\"),"},{"line_number":36,"context_line":"                         \"ramdisk_id\": _(\"Ramdisk ID\"),"},{"line_number":37,"context_line":"                         \"image_state\": _(\"Euca2ools state\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BdWI%3D","line":34,"in_reply_to":"AAAATn%2F%2Bgz8%3D","updated":"2013-11-25 20:37:02.000000000","message":"I agree this would be useful, however, would it be possible to tackle this in a separate bug/commit? I was hoping to address the primary concern of the bug first.","commit_id":"c11eab60aa042b00a017d33d32eb196c435a4f37"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"ee57c866dac937caf1eaa5227eb3d87ef7cfce32","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            image_props.append((prop, title, val))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        return {\"image\": image,"},{"line_number":47,"context_line":"                \"image_props\": sorted(image_props)}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class ImageDetailTabs(tabs.TabGroup):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2Bg1U%3D","line":47,"updated":"2013-11-25 10:01:07.000000000","message":"Might be better to be sorted by title instead of property name.","commit_id":"c11eab60aa042b00a017d33d32eb196c435a4f37"},{"author":{"_account_id":8302,"name":"Ryan Hsu","email":"hryan@vmware.com","username":"rhsu"},"change_message_id":"a2c6b32c86d3b280463e04de4b3597eaff1c6f24","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            image_props.append((prop, title, val))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        return {\"image\": image,"},{"line_number":47,"context_line":"                \"image_props\": sorted(image_props)}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class ImageDetailTabs(tabs.TabGroup):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BcSw%3D","line":47,"in_reply_to":"AAAATn%2F%2Bg1U%3D","updated":"2013-11-26 01:09:41.000000000","message":"Done","commit_id":"c11eab60aa042b00a017d33d32eb196c435a4f37"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"c0512bc92bd5253f15eab17d6979124fd51ab884","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    slug \u003d \"overview\""},{"line_number":29,"context_line":"    template_name \u003d \"project/images_and_snapshots/images/_detail_overview.html\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def get_context_data(self, request):"},{"line_number":32,"context_line":"        image \u003d self.tab_group.kwargs[\u0027image\u0027]"},{"line_number":33,"context_line":"        custom_titles \u003d getattr(conf.settings,"},{"line_number":34,"context_line":"                                \u0027IMAGE_CUSTOM_PROPERTY_TITLES\u0027, {})"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9iDc%3D","line":31,"updated":"2013-12-10 14:40:36.000000000","message":"Could you add some unit tests to cover this functionality change?","commit_id":"1bd30a63ca913b0ab1b4b7f9d1f56133ee0aaa5c"},{"author":{"_account_id":8302,"name":"Ryan Hsu","email":"hryan@vmware.com","username":"rhsu"},"change_message_id":"1f4614a7fc1c296b90a51cfa3a8a461a84e04e65","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    slug \u003d \"overview\""},{"line_number":29,"context_line":"    template_name \u003d \"project/images_and_snapshots/images/_detail_overview.html\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def get_context_data(self, request):"},{"line_number":32,"context_line":"        image \u003d self.tab_group.kwargs[\u0027image\u0027]"},{"line_number":33,"context_line":"        custom_titles \u003d getattr(conf.settings,"},{"line_number":34,"context_line":"                                \u0027IMAGE_CUSTOM_PROPERTY_TITLES\u0027, {})"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9eAY%3D","line":31,"in_reply_to":"AAAATn%2F9iDc%3D","updated":"2013-12-11 07:14:57.000000000","message":"Done","commit_id":"1bd30a63ca913b0ab1b4b7f9d1f56133ee0aaa5c"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"c0512bc92bd5253f15eab17d6979124fd51ab884","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        return {\"image\": image,"},{"line_number":41,"context_line":"                \"image_props\": sorted(image_props, key\u003doperator.itemgetter(1))}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class ImageDetailTabs(tabs.TabGroup):"},{"line_number":45,"context_line":"    slug \u003d \"image_details\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9iD4%3D","line":42,"updated":"2013-12-10 14:40:36.000000000","message":"The same sorting behavior can be achieved by using\nkey\u003dlambda prop: prop[1]\nwithout the need to import additional modules.","commit_id":"1bd30a63ca913b0ab1b4b7f9d1f56133ee0aaa5c"},{"author":{"_account_id":8302,"name":"Ryan Hsu","email":"hryan@vmware.com","username":"rhsu"},"change_message_id":"1f4614a7fc1c296b90a51cfa3a8a461a84e04e65","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        return {\"image\": image,"},{"line_number":41,"context_line":"                \"image_props\": sorted(image_props, key\u003doperator.itemgetter(1))}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class ImageDetailTabs(tabs.TabGroup):"},{"line_number":45,"context_line":"    slug \u003d \"image_details\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9eVE%3D","line":42,"in_reply_to":"AAAATn%2F9iD4%3D","updated":"2013-12-11 07:14:57.000000000","message":"Done","commit_id":"1bd30a63ca913b0ab1b4b7f9d1f56133ee0aaa5c"}],"openstack_dashboard/dashboards/project/images_and_snapshots/templates/images_and_snapshots/images/_detail_overview.html":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"ee57c866dac937caf1eaa5227eb3d87ef7cfce32","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  \u003chr class\u003d\"header_rule\"\u003e"},{"line_number":56,"context_line":"  \u003cdl\u003e"},{"line_number":57,"context_line":"    {% for prop, title, val in image_props %}"},{"line_number":58,"context_line":"      \u003cdt title\u003d\"{{prop}}\"\u003e{% trans title %}\u003c/dt\u003e"},{"line_number":59,"context_line":"      \u003cdd\u003e{{val}}\u003c/dd\u003e"},{"line_number":60,"context_line":"    {% endfor %}"},{"line_number":61,"context_line":"  \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":4,"id":"AAAATn%2F%2Bg2U%3D","line":58,"updated":"2013-11-25 10:01:07.000000000","message":"Please add a space in between {{ variable }} for consistency with coding style.\n\nThe variable \u0027title\u0027 is already the translated value, so the \"trans\" keyword is no longer needed.","commit_id":"c11eab60aa042b00a017d33d32eb196c435a4f37"},{"author":{"_account_id":8302,"name":"Ryan Hsu","email":"hryan@vmware.com","username":"rhsu"},"change_message_id":"a2c6b32c86d3b280463e04de4b3597eaff1c6f24","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  \u003chr class\u003d\"header_rule\"\u003e"},{"line_number":56,"context_line":"  \u003cdl\u003e"},{"line_number":57,"context_line":"    {% for prop, title, val in image_props %}"},{"line_number":58,"context_line":"      \u003cdt title\u003d\"{{prop}}\"\u003e{% trans title %}\u003c/dt\u003e"},{"line_number":59,"context_line":"      \u003cdd\u003e{{val}}\u003c/dd\u003e"},{"line_number":60,"context_line":"    {% endfor %}"},{"line_number":61,"context_line":"  \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":4,"id":"AAAATn%2F%2BcSs%3D","line":58,"in_reply_to":"AAAATn%2F%2Bg2U%3D","updated":"2013-11-26 01:09:41.000000000","message":"Done","commit_id":"c11eab60aa042b00a017d33d32eb196c435a4f37"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"c0512bc92bd5253f15eab17d6979124fd51ab884","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    {% for prop, title, val in image_props %}"},{"line_number":66,"context_line":"      \u003cdt title\u003d\"{{ prop }}\"\u003e{{ title }}\u003c/dt\u003e"},{"line_number":67,"context_line":"      \u003cdd\u003e{{ val }}\u003c/dd\u003e"},{"line_number":68,"context_line":"    {% endfor %}"},{"line_number":69,"context_line":"  \u003c/dl\u003e"},{"line_number":70,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":7,"id":"AAAATn%2F9iBc%3D","line":68,"updated":"2013-12-10 14:40:36.000000000","message":"Since you are including all image properties here, if the description is present, it will now appears twice on the page: once in the \u0027Info\u0027 section and again in the \u0027Custom Properties\u0027 section.","commit_id":"1bd30a63ca913b0ab1b4b7f9d1f56133ee0aaa5c"},{"author":{"_account_id":8302,"name":"Ryan Hsu","email":"hryan@vmware.com","username":"rhsu"},"change_message_id":"1f4614a7fc1c296b90a51cfa3a8a461a84e04e65","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    {% for prop, title, val in image_props %}"},{"line_number":66,"context_line":"      \u003cdt title\u003d\"{{ prop }}\"\u003e{{ title }}\u003c/dt\u003e"},{"line_number":67,"context_line":"      \u003cdd\u003e{{ val }}\u003c/dd\u003e"},{"line_number":68,"context_line":"    {% endfor %}"},{"line_number":69,"context_line":"  \u003c/dl\u003e"},{"line_number":70,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":7,"id":"AAAATn%2F9eVI%3D","line":68,"in_reply_to":"AAAATn%2F9iBc%3D","updated":"2013-12-11 07:14:57.000000000","message":"Done","commit_id":"1bd30a63ca913b0ab1b4b7f9d1f56133ee0aaa5c"}]}
