)]}'
{"openstack_dashboard/dashboards/project/database_backups/tables.py":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"8d42a09df882a295993970836ff43dfbf61f51b6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    url \u003d \"horizon:project:databases:launch\""},{"line_number":48,"context_line":"    classes \u003d (\"btn-launch\", \"ajax-modal\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def get_link_url(self, datum):"},{"line_number":51,"context_line":"        url \u003d reverse(self.url)"},{"line_number":52,"context_line":"        return url + \u0027?backup\u003d%s\u0027 % datum.id"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Fjik%3D","line":50,"updated":"2014-01-11 11:01:42.000000000","message":"Good catch!","commit_id":"2a61d92eceb9fcdc74647615dfcea84d1229b13a"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"5f6803bc6d5c23e8cc88794caca9814df8aae311","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    classes \u003d (\"btn-launch\",)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def get_link_url(self, datum):"},{"line_number":62,"context_line":"        container_name, object_path \u003d datum.locationRef.split(\u0027/\u0027)[-2:]"},{"line_number":63,"context_line":"        return reverse(self.url,"},{"line_number":64,"context_line":"                       kwargs\u003d{\u0027container_name\u0027: container_name,"},{"line_number":65,"context_line":"                               \u0027object_path\u0027: object_path})"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FjZ8%3D","line":62,"updated":"2014-01-11 14:11:12.000000000","message":"Would there be a case when the backup is location inside a Pseudo-folder?  If yes, using [-2:] might not yield the full object_path.","commit_id":"2a61d92eceb9fcdc74647615dfcea84d1229b13a"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"16cbe629c60ee4f73938e107125bca44ab94a9b7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    classes \u003d (\"btn-launch\",)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def get_link_url(self, datum):"},{"line_number":62,"context_line":"        container_name, object_path \u003d datum.locationRef.split(\u0027/\u0027)[-2:]"},{"line_number":63,"context_line":"        return reverse(self.url,"},{"line_number":64,"context_line":"                       kwargs\u003d{\u0027container_name\u0027: container_name,"},{"line_number":65,"context_line":"                               \u0027object_path\u0027: object_path})"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FhTM%3D","line":62,"in_reply_to":"AAAAUH%2F%2FjZ8%3D","updated":"2014-01-12 22:42:07.000000000","message":"Good catch. It\u0027s possible if CONF.backup_swift_container in Trove is set to include a pseudo-folder (e.g. \u0027database_backups/foobar\u0027 vs. just \u0027database_backups\u0027)\n\nThe quick and dirty fix for this is:\n\n    ref \u003d datum.locationRef.split(\u0027/\u0027)\n    container_name \u003d ref[5]\n    object_path \u003d \u0027/\u0027.join(ref[6:])","commit_id":"2a61d92eceb9fcdc74647615dfcea84d1229b13a"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"1a2800b32cb6c4421af5aa13ec428bc1757b8428","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                               \u0027object_path\u0027: object_path})"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def allowed(self, request, datum):"},{"line_number":68,"context_line":"        return datum.status \u003d\u003d \u0027COMPLETED\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class DeleteBackup(tables.BatchAction):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Fmao%3D","line":68,"updated":"2014-01-10 16:08:29.000000000","message":"Need to make sure datum isn\u0027t None before dereferencing it.","commit_id":"2a61d92eceb9fcdc74647615dfcea84d1229b13a"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"43be8c91c59c1059068f79150e82c3c53fbbc7c1","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                               \u0027object_path\u0027: object_path})"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def allowed(self, request, datum):"},{"line_number":68,"context_line":"        return datum.status \u003d\u003d \u0027COMPLETED\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class DeleteBackup(tables.BatchAction):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FgJk%3D","line":68,"in_reply_to":"AAAAUH%2F%2FhTI%3D","updated":"2014-01-13 09:19:58.000000000","message":"agree with Lin, but there are many row_actions with None checked in horizon, should we put a new patch to clear the code.","commit_id":"2a61d92eceb9fcdc74647615dfcea84d1229b13a"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"16cbe629c60ee4f73938e107125bca44ab94a9b7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                               \u0027object_path\u0027: object_path})"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def allowed(self, request, datum):"},{"line_number":68,"context_line":"        return datum.status \u003d\u003d \u0027COMPLETED\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class DeleteBackup(tables.BatchAction):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FhTI%3D","line":68,"in_reply_to":"AAAAUH%2F%2FjaA%3D","updated":"2014-01-12 22:42:07.000000000","message":"+1 to Lin.","commit_id":"2a61d92eceb9fcdc74647615dfcea84d1229b13a"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"5f6803bc6d5c23e8cc88794caca9814df8aae311","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                               \u0027object_path\u0027: object_path})"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def allowed(self, request, datum):"},{"line_number":68,"context_line":"        return datum.status \u003d\u003d \u0027COMPLETED\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class DeleteBackup(tables.BatchAction):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FjaA%3D","line":68,"in_reply_to":"AAAAUH%2F%2Fjis%3D","updated":"2014-01-11 14:11:12.000000000","message":"It is just nice to have, this action is only used as row_action so it will never be None.  Only actions used as table_action could have datum as None","commit_id":"2a61d92eceb9fcdc74647615dfcea84d1229b13a"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"8d42a09df882a295993970836ff43dfbf61f51b6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                               \u0027object_path\u0027: object_path})"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def allowed(self, request, datum):"},{"line_number":68,"context_line":"        return datum.status \u003d\u003d \u0027COMPLETED\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class DeleteBackup(tables.BatchAction):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Fjis%3D","line":68,"in_reply_to":"AAAAUH%2F%2Fmao%3D","updated":"2014-01-11 11:01:42.000000000","message":"Strongly agreed.","commit_id":"2a61d92eceb9fcdc74647615dfcea84d1229b13a"}]}
