)]}'
{"doc/source/admin/customize-configure.rst":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"064f17a07f1aff776f0d6c3e43282c21cf4523cf","unresolved":false,"context_lines":[{"line_number":347,"context_line":"      \u003cDirectory /usr/share/openstack-dashboard/openstack_dashboard\u003e"},{"line_number":348,"context_line":"      # For Apache http server 2.2 and earlier:"},{"line_number":349,"context_line":"      Order allow,deny"},{"line_number":350,"context_line":"      Allow from all"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"      # For Apache http server 2.4 and later:"},{"line_number":353,"context_line":"      # Require all granted"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f6a8fd7_8e61743c","line":350,"updated":"2018-05-01 20:35:48.000000000","message":"I am in similar situation to you.\n\nI read the apache configuration documentation. According to this, \u003cLocation\u003e is based on URLs accessed and \u003cDirectory\u003e is based on paths on file system.\nIn other words, \u003cLocation\u003e matches URL like /project/networks/225e1537-cc6a-46e5-b4d3-ffe2b89edc84/detail so \u003cLocation /\u003e directive is fine and required.\nOn the other hand, \u003cDirectory xxxx\u003e mean \u0027xxxx\u0027 on a file system can be accessed and in general it should be retricted as minimum. This is my point.\nAccording to mod_wsgi document [1], WSGI application needs to be located to a directory that Apache can access, so \u003cDirectory\u003e directive on the WSGI directory is required, but I believe exposing the whole directory tree under \"openstack_dashboard\" is too much.\n\nHow about adding __init__.py to wsgi directory and add wsgi.py here?\n\n[1] https://modwsgi.readthedocs.io/en/develop/user-guides/quick-configuration-guide.html#mounting-the-wsgi-application","commit_id":"f29b5dfe23e34eae8cb70f2767f5a41eae03606a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8e8da4d9018ad6359624be84e6b4f88a640a75b4","unresolved":false,"context_lines":[{"line_number":346,"context_line":"      Alias /static /usr/share/openstack-dashboard/openstack_dashboard/static/"},{"line_number":347,"context_line":"      \u003cDirectory /usr/share/openstack-dashboard/openstack_dashboard\u003e"},{"line_number":348,"context_line":"      # For Apache http server 2.2 and earlier:"},{"line_number":349,"context_line":"      Order allow,deny"},{"line_number":350,"context_line":"      Allow from all"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"      # For Apache http server 2.4 and later:"},{"line_number":353,"context_line":"      # Require all granted"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f6a8fd7_07c6e217","line":350,"range":{"start_line":349,"start_character":5,"end_line":350,"end_character":20},"updated":"2018-04-27 17:49:32.000000000","message":"I have a bit concern on exporting all files under  /usr/share/openstack-dashboard/openstack_dashboard. I think this is the reason that a subdirectory is used now. It is not related to whether wsgi.py is importable or not.","commit_id":"f29b5dfe23e34eae8cb70f2767f5a41eae03606a"},{"author":{"_account_id":10420,"name":"Adrian Turjak","email":"devs+openstack@uncaught-exceptions.com","username":"adriant"},"change_message_id":"8c1d614a233742b55f51c66705d4c4329376c0a6","unresolved":false,"context_lines":[{"line_number":347,"context_line":"      \u003cDirectory /usr/share/openstack-dashboard/openstack_dashboard\u003e"},{"line_number":348,"context_line":"      # For Apache http server 2.2 and earlier:"},{"line_number":349,"context_line":"      Order allow,deny"},{"line_number":350,"context_line":"      Allow from all"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"      # For Apache http server 2.4 and later:"},{"line_number":353,"context_line":"      # Require all granted"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_326a1eb3","line":350,"in_reply_to":"5f7c97a3_1035b046","updated":"2018-05-07 23:54:47.000000000","message":"Works for me.","commit_id":"f29b5dfe23e34eae8cb70f2767f5a41eae03606a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8698eb5d82f18ec966be0db49e273b78bfae7054","unresolved":false,"context_lines":[{"line_number":347,"context_line":"      \u003cDirectory /usr/share/openstack-dashboard/openstack_dashboard\u003e"},{"line_number":348,"context_line":"      # For Apache http server 2.2 and earlier:"},{"line_number":349,"context_line":"      Order allow,deny"},{"line_number":350,"context_line":"      Allow from all"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"      # For Apache http server 2.4 and later:"},{"line_number":353,"context_line":"      # Require all granted"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_b22b8ee9","line":350,"in_reply_to":"5f7c97a3_326a1eb3","updated":"2018-05-08 00:46:39.000000000","message":"Proposed update https://review.openstack.org/#/c/566767/","commit_id":"f29b5dfe23e34eae8cb70f2767f5a41eae03606a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"33809bf65181c80e3b9eff3d00c3a82839b90360","unresolved":false,"context_lines":[{"line_number":347,"context_line":"      \u003cDirectory /usr/share/openstack-dashboard/openstack_dashboard\u003e"},{"line_number":348,"context_line":"      # For Apache http server 2.2 and earlier:"},{"line_number":349,"context_line":"      Order allow,deny"},{"line_number":350,"context_line":"      Allow from all"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"      # For Apache http server 2.4 and later:"},{"line_number":353,"context_line":"      # Require all granted"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_1035b046","line":350,"in_reply_to":"5f7c97a3_cdcb1f51","updated":"2018-05-07 06:16:00.000000000","message":"L.349-350 is for apache \u003c\u003d2.2 and L.353 is for apache \u003e\u003d2.4.\n\nIMHO you can keep the current proposed version as-is and we revisit \u003cDirectory\u003e directive itself later in a separate review.\n\nEven though \u003cDirectory\u003e directive allows  /usr/share/openstack-dashboard/openstack_dashboard, WSGI script (django app) catches requested URL first and handle it, so I believe the contents under this directory are not actually exposed.\n\nAre you okay with this direction?","commit_id":"f29b5dfe23e34eae8cb70f2767f5a41eae03606a"},{"author":{"_account_id":10420,"name":"Adrian Turjak","email":"devs+openstack@uncaught-exceptions.com","username":"adriant"},"change_message_id":"e5fe184ddd609e1bc48ddc027b54112496070648","unresolved":false,"context_lines":[{"line_number":346,"context_line":"      Alias /static /usr/share/openstack-dashboard/openstack_dashboard/static/"},{"line_number":347,"context_line":"      \u003cDirectory /usr/share/openstack-dashboard/openstack_dashboard\u003e"},{"line_number":348,"context_line":"      # For Apache http server 2.2 and earlier:"},{"line_number":349,"context_line":"      Order allow,deny"},{"line_number":350,"context_line":"      Allow from all"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"      # For Apache http server 2.4 and later:"},{"line_number":353,"context_line":"      # Require all granted"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f6a8fd7_44a5a1b4","line":350,"range":{"start_line":349,"start_character":5,"end_line":350,"end_character":20},"in_reply_to":"9f6a8fd7_07c6e217","updated":"2018-04-30 09:46:55.000000000","message":"Should these files even be exposed at all? Does mod_wsgi with Apache require that?\n\nMy Apache is rusty these days, been using only Nginx for the last 3 years. So apologies for potentially silly questions.\n\nWhat exactly does this even do in this context?:\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/management/commands/apache_vhost.conf.template#L26-L36","commit_id":"f29b5dfe23e34eae8cb70f2767f5a41eae03606a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1acaf3ed6bbde66cf5928e0b4310dde0e662053c","unresolved":false,"context_lines":[{"line_number":347,"context_line":"      \u003cDirectory /usr/share/openstack-dashboard/openstack_dashboard\u003e"},{"line_number":348,"context_line":"      # For Apache http server 2.2 and earlier:"},{"line_number":349,"context_line":"      Order allow,deny"},{"line_number":350,"context_line":"      Allow from all"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"      # For Apache http server 2.4 and later:"},{"line_number":353,"context_line":"      # Require all granted"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f6a8fd7_89d16e5a","line":350,"in_reply_to":"9f6a8fd7_2992a2a0","updated":"2018-05-01 20:52:57.000000000","message":"If my above testing result is correct, your wsgi.py needs not to be moved.","commit_id":"f29b5dfe23e34eae8cb70f2767f5a41eae03606a"},{"author":{"_account_id":10420,"name":"Adrian Turjak","email":"devs+openstack@uncaught-exceptions.com","username":"adriant"},"change_message_id":"625c71e4ccb87b119a7654dc9fb2bfe49f30ed99","unresolved":false,"context_lines":[{"line_number":347,"context_line":"      \u003cDirectory /usr/share/openstack-dashboard/openstack_dashboard\u003e"},{"line_number":348,"context_line":"      # For Apache http server 2.2 and earlier:"},{"line_number":349,"context_line":"      Order allow,deny"},{"line_number":350,"context_line":"      Allow from all"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"      # For Apache http server 2.4 and later:"},{"line_number":353,"context_line":"      # Require all granted"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f7c97a3_cdcb1f51","line":350,"in_reply_to":"9f6a8fd7_89d16e5a","updated":"2018-05-07 03:19:03.000000000","message":"I think we can potentially remove this if it was only for version 2.2, as that version is no longer maintained.\n\nWho can we ask that knows Apache better?","commit_id":"f29b5dfe23e34eae8cb70f2767f5a41eae03606a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"24238cf55c2c21fe9fe57030a76428fbc20da4e0","unresolved":false,"context_lines":[{"line_number":347,"context_line":"      \u003cDirectory /usr/share/openstack-dashboard/openstack_dashboard\u003e"},{"line_number":348,"context_line":"      # For Apache http server 2.2 and earlier:"},{"line_number":349,"context_line":"      Order allow,deny"},{"line_number":350,"context_line":"      Allow from all"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"      # For Apache http server 2.4 and later:"},{"line_number":353,"context_line":"      # Require all granted"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f6a8fd7_2992a2a0","line":350,"in_reply_to":"9f6a8fd7_8e61743c","updated":"2018-05-01 20:52:00.000000000","message":"Based on my further *testing*, this \u003cDirectory\u003e directive looks unnecessary. Some cross-check is required though.","commit_id":"f29b5dfe23e34eae8cb70f2767f5a41eae03606a"}],"openstack_dashboard/wsgi.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2da12e7be2178fba27459ef7c32bb3dd8a0bf439","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2017 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_7fe39e06","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":42},"updated":"2018-04-17 07:49:54.000000000","message":"This is unnecessary. We do not belong to OpenStack Foundation and the original author of django.wsgi is not from the foundation.","commit_id":"b1146c8bcfb6b8f44889bc9f0a1e24c874552a66"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"60f691f0d2440652cff6a31367a721c295e4c883","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":2,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":3,"context_line":"# You may obtain a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_105475fe","line":1,"updated":"2018-04-20 09:15:54.000000000","message":"This file will *not* be importable, because the name conflicts with the \"wsgi\" directory, which is a python package, and which will have precendence over the module.","commit_id":"cf7f597932fa27cdb7d4cc2a84f2d918aa1db103"},{"author":{"_account_id":10420,"name":"Adrian Turjak","email":"devs+openstack@uncaught-exceptions.com","username":"adriant"},"change_message_id":"df122df7ecc61c4733bf8cdc251cbed7bb6087e7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":2,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":3,"context_line":"# You may obtain a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_33198321","line":1,"in_reply_to":"9f6a8fd7_105475fe","updated":"2018-04-20 10:08:35.000000000","message":"It isn\u0027t:\nhttps://github.com/openstack/horizon/tree/master/openstack_dashboard/wsgi\n\nIt\u0027s just a folder called wsgi, no \u0027__init__\u0027, not actually a python module which is what makes all this weirder.","commit_id":"cf7f597932fa27cdb7d4cc2a84f2d918aa1db103"},{"author":{"_account_id":10420,"name":"Adrian Turjak","email":"devs+openstack@uncaught-exceptions.com","username":"adriant"},"change_message_id":"d293c0150a803a8cff8ce25811528c6f0bb9d79a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":2,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":3,"context_line":"# You may obtain a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_66fadbbd","line":1,"in_reply_to":"9f6a8fd7_33198321","updated":"2018-04-20 10:45:00.000000000","message":"Discussions from IRC:\nPython3 doesn\u0027t need \u0027__init__\u0027 but it seems that modules have precedence over packages when there isn\u0027t one. So this isn\u0027t actually broken.\n\nJust means we can never let anyone actually put a \u0027__init__\u0027 file here.","commit_id":"cf7f597932fa27cdb7d4cc2a84f2d918aa1db103"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a70f0e9c797bcec1a53a025bd643678aeca80ab3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":2,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":3,"context_line":"# You may obtain a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_c9b96115","line":1,"in_reply_to":"9f6a8fd7_66fadbbd","updated":"2018-04-21 17:54:41.000000000","message":"There is wsgi directory but there is no __init__ file in wsgi directory. I think it is okay with this change.","commit_id":"cf7f597932fa27cdb7d4cc2a84f2d918aa1db103"}],"openstack_dashboard/wsgi/django.wsgi":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2da12e7be2178fba27459ef7c32bb3dd8a0bf439","unresolved":false,"context_lines":[{"line_number":32,"context_line":"DEBUG \u003d False"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"logging.warning("},{"line_number":35,"context_line":"    \"Use of this \u0027djano.wsgi\u0027 file been deprecated in favor of \u0027wsgi.py\u0027 in \""},{"line_number":36,"context_line":"    \"the \u0027openstack_dashboard\u0027 module. This file is a legacy naming \""},{"line_number":37,"context_line":"    \"from before Django 1.4 and an importable \u0027wsgi.py\u0027 is now the default. \""},{"line_number":38,"context_line":"    \"This file will be removed in the T release cycle.\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9f6a8fd7_3f18c61b","line":35,"range":{"start_line":35,"start_character":35,"end_line":35,"end_character":39},"updated":"2018-04-17 07:49:54.000000000","message":"-\u003e \"has been deprecated since Rocky release in favor of .....\"","commit_id":"b1146c8bcfb6b8f44889bc9f0a1e24c874552a66"}],"releasenotes/notes/bug/1763204-7ffdeae78698ff93.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0eaa2a38260b1a24e873ceec33a639a0f1c4746b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9f6a8fd7_ad37794d","updated":"2018-04-20 03:33:58.000000000","message":"Hopefully the filename describe what is changed rather than a bug number like django-wsgi-deprecation-\u003chash\u003e.yaml.","commit_id":"8c418d8c335f1478569a31a2ce088675f36ee279"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0eaa2a38260b1a24e873ceec33a639a0f1c4746b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Use of this \u0027djano.wsgi\u0027 file has been deprecated since the Rocky"},{"line_number":5,"context_line":"    release in favor of \u0027wsgi.py\u0027 in the \u0027openstack_dashboard\u0027 module. This"},{"line_number":6,"context_line":"    file is a legacy naming from before Django 1.4 and an importable"},{"line_number":7,"context_line":"    \u0027wsgi.py\u0027 is now the default. This file will be removed in the T release"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f6a8fd7_ad10d9a9","line":4,"updated":"2018-04-20 03:33:58.000000000","message":"Could you add a bug link here?\n\n  [:bug:`1763204`]","commit_id":"8c418d8c335f1478569a31a2ce088675f36ee279"}]}
