)]}'
{"horizon/browsers/__init__.py":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"4ddf7ae34c64186a9128ed3542d0672bb8734654","unresolved":false,"context_lines":[{"line_number":20,"context_line":"__all__ \u003d ["},{"line_number":21,"context_line":"    \"ResourceBrowser\","},{"line_number":22,"context_line":"    \"ResourceBrowserView\","},{"line_number":23,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F89xo%3D","line":23,"updated":"2013-12-18 10:34:02.000000000","message":"The # noqa comment already silences the flake8 warning about unused imports, it seems we could simply get rid of the asserts and leave it at that.","commit_id":"ede5c1e5ff4538b0f3190fbaec2a73281d55583e"}],"horizon/forms/__init__.py":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"4ddf7ae34c64186a9128ed3542d0672bb8734654","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from django.core.exceptions import ValidationError  # noqa"},{"line_number":19,"context_line":"from django.forms.fields import *  # noqa"},{"line_number":20,"context_line":"from django.forms.forms import *  # noqa"},{"line_number":21,"context_line":"from django.forms import widgets"},{"line_number":22,"context_line":"from django.forms.widgets import *  # noqa"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F89yU%3D","line":21,"updated":"2013-12-18 10:34:02.000000000","message":"Everything but this import is already marked as # noqa - it sounds to me it would be better to simply add the marker there too, rather than attempt to keep track of everything from the submodules in the __all__ variable (it seems to me it\u0027ll be tricky to maintain, for little gain).","commit_id":"ede5c1e5ff4538b0f3190fbaec2a73281d55583e"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"dd1e5b2788ad70b27341726607fee813e73ee552","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from django.core.exceptions import ValidationError  # noqa"},{"line_number":19,"context_line":"from django.forms.fields import *  # noqa"},{"line_number":20,"context_line":"from django.forms.forms import *  # noqa"},{"line_number":21,"context_line":"from django.forms import widgets"},{"line_number":22,"context_line":"from django.forms.widgets import *  # noqa"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F89os%3D","line":21,"in_reply_to":"AAAATn%2F89yU%3D","updated":"2013-12-18 10:56:40.000000000","message":"I think that working autocompletion in an IDE is worth doing it. Also, they don\u0027t need maintaining -- they are legacy imports for compatibility and you never want to add anything to them. Keeping them frozen like this is actually an advantage.","commit_id":"ede5c1e5ff4538b0f3190fbaec2a73281d55583e"}],"horizon/tables/__init__.py":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"4ddf7ae34c64186a9128ed3542d0672bb8734654","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \"MultiTableView\","},{"line_number":44,"context_line":"    \"MultiTableMixin\","},{"line_number":45,"context_line":"    \"MixedDataTableView\","},{"line_number":46,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F89xE%3D","line":46,"updated":"2013-12-18 10:34:02.000000000","message":"Same re: noqa already there and simply removing the asserts","commit_id":"ede5c1e5ff4538b0f3190fbaec2a73281d55583e"}],"horizon/tabs/__init__.py":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"4ddf7ae34c64186a9128ed3542d0672bb8734654","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    \"TableTab\","},{"line_number":27,"context_line":"    \"TabView\","},{"line_number":28,"context_line":"    \"TabbedTableView\","},{"line_number":29,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F89w8%3D","line":29,"updated":"2013-12-18 10:34:02.000000000","message":"Same re: noqa already there and simply removing the asserts","commit_id":"ede5c1e5ff4538b0f3190fbaec2a73281d55583e"}],"horizon/workflows/__init__.py":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"4ddf7ae34c64186a9128ed3542d0672bb8734654","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \"UpdateMembersStep\","},{"line_number":13,"context_line":"    \"Workflow\","},{"line_number":14,"context_line":"    \"WorkflowView\","},{"line_number":15,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F89wo%3D","line":15,"updated":"2013-12-18 10:34:02.000000000","message":"Same re: noqa already there and simply removing the asserts","commit_id":"ede5c1e5ff4538b0f3190fbaec2a73281d55583e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d056917d67a52ae11997c9cbf3b0b18887c3bc7b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from horizon.workflows.base import Step  # noqa"},{"line_number":16,"context_line":"from horizon.workflows.base import UpdateMembersStep  # noqa"},{"line_number":17,"context_line":"from horizon.workflows.base import Workflow  # noqa"},{"line_number":18,"context_line":"from horizon.workflows.views import WorkflowView  # noqa"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F8t5I%3D","line":18,"updated":"2013-12-21 12:25:07.000000000","message":"I am not sure why __all__ is not used here. All modules are defined in horizon/workflows/*.py and there is no imports from django.","commit_id":"a41e33a2403728d8bcbf9c14109ca62abfe3701d"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"2735ef3b5f4767dee4ae7f6b0c3c76fb32121e3e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from horizon.workflows.base import Step  # noqa"},{"line_number":16,"context_line":"from horizon.workflows.base import UpdateMembersStep  # noqa"},{"line_number":17,"context_line":"from horizon.workflows.base import Workflow  # noqa"},{"line_number":18,"context_line":"from horizon.workflows.views import WorkflowView  # noqa"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F8rKw%3D","line":18,"in_reply_to":"AAAATn%2F8t5I%3D","updated":"2013-12-23 12:01:40.000000000","message":"Because __all__ would have no effect here. The module contains only the names that would be in __all__, so it doesn\u0027t limit the exported names. There are also #noqa comments there, to silence the warning about importing something that is not a module, so all other warnings get silenced too and thus __all__ is not required for silencing flake8 either. So putting __all__ here would only add noise and serve no purpose.","commit_id":"a41e33a2403728d8bcbf9c14109ca62abfe3701d"}],"openstack_dashboard/usage/__init__.py":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"4ddf7ae34c64186a9128ed3542d0672bb8734654","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"BaseUsageTable\","},{"line_number":32,"context_line":"    \"ProjectUsageTable\","},{"line_number":33,"context_line":"    \"GlobalUsageTable\","},{"line_number":34,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F89wQ%3D","line":34,"updated":"2013-12-18 10:34:02.000000000","message":"Same re: noqa already there and simply removing the asserts","commit_id":"ede5c1e5ff4538b0f3190fbaec2a73281d55583e"}]}