)]}'
{"openstack_dashboard/dashboards/project/instances/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d503eb12654dd23dac8205f5cb12d6f89bffef9a","unresolved":false,"context_lines":[{"line_number":1794,"context_line":"                        cinder: (\u0027volume_list\u0027,"},{"line_number":1795,"context_line":"                                 \u0027volume_snapshot_list\u0027,),"},{"line_number":1796,"context_line":"                        quotas: (\u0027tenant_quota_usages\u0027,)})"},{"line_number":1797,"context_line":"    def test_launch_form_instance_requirement_error(self):"},{"line_number":1798,"context_line":"        flavor \u003d self.flavors.first()"},{"line_number":1799,"context_line":"        image \u003d self.images.first()"},{"line_number":1800,"context_line":"        keypair \u003d self.keypairs.first()"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2Bv3c%3D","line":1797,"updated":"2014-01-22 15:17:57.000000000","message":"There are too many copy and paste code in this file.... it needs to be clean-up later.","commit_id":"4ccbce15900bc798288adbd9b6cc12dbaee47bbd"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"3d7d08b6141d2bf15d22dac2098311716b826618","unresolved":false,"context_lines":[{"line_number":1881,"context_line":"        # tests min_ram"},{"line_number":1882,"context_line":"        image.min_ram \u003d flavor.ram + 1"},{"line_number":1883,"context_line":"        image.min_disk \u003d flavor.disk"},{"line_number":1884,"context_line":"        msg \u003d \"The flavor \u0026#39;%s\u0026#39; is too small\" % flavor.name"},{"line_number":1885,"context_line":"        self.assertContains(res, msg)"},{"line_number":1886,"context_line":""},{"line_number":1887,"context_line":"    @test.create_stubs({api.nova: (\u0027flavor_list\u0027, \u0027server_list\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F%2Bp%2Fs%3D","line":1884,"updated":"2014-01-23 13:53:35.000000000","message":"the message can\u0027t change if you don\u0027t call the form again:\nres \u003d self.client.post(url, form_data)","commit_id":"f45f69ca6a88699b109cadc4f7b3aa72038b6ccd"}],"openstack_dashboard/dashboards/project/instances/workflows/create_instance.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"efdc91616cbf2b9cb53f93645f9265f0dbbc60f8","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                msg \u003d _(\"You must select an image.\")"},{"line_number":178,"context_line":"                self._errors[\u0027image_id\u0027] \u003d self.error_class([msg])"},{"line_number":179,"context_line":"            else:"},{"line_number":180,"context_line":"                # Prevents trying to launcg image needs more resources."},{"line_number":181,"context_line":"                image_id \u003d cleaned_data.get(\u0027image_id\u0027)"},{"line_number":182,"context_line":"                images \u003d utils.get_available_images("},{"line_number":183,"context_line":"                    self.request,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BKiI%3D","line":180,"updated":"2013-11-30 06:28:10.000000000","message":"Typo launcg","commit_id":"72299f5a4361d30ef8e0feae223de91baada4d97"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e7737a9514260382f51dff53e23d618d8a8e75e4","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                msg \u003d _(\"You must select an image.\")"},{"line_number":178,"context_line":"                self._errors[\u0027image_id\u0027] \u003d self.error_class([msg])"},{"line_number":179,"context_line":"            else:"},{"line_number":180,"context_line":"                # Prevents trying to launcg image needs more resources."},{"line_number":181,"context_line":"                image_id \u003d cleaned_data.get(\u0027image_id\u0027)"},{"line_number":182,"context_line":"                images \u003d utils.get_available_images("},{"line_number":183,"context_line":"                    self.request,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BKGE%3D","line":180,"in_reply_to":"AAAATn%2F%2BKiI%3D","updated":"2013-11-30 19:15:05.000000000","message":"Done","commit_id":"72299f5a4361d30ef8e0feae223de91baada4d97"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"efdc91616cbf2b9cb53f93645f9265f0dbbc60f8","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                image \u003d [x for x in images if x.id \u003d\u003d image_id][0]"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"                flavor_id \u003d cleaned_data.get(\u0027flavor\u0027)"},{"line_number":189,"context_line":"                flavors \u003d api.nova.flavor_list(self.request)"},{"line_number":190,"context_line":"                flavor \u003d [x for x in flavors if x.id \u003d\u003d flavor_id][0]"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"                flv_img_props_to_check \u003d ((\"min_ram\", \"ram\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BKiY%3D","line":189,"updated":"2013-11-30 06:28:10.000000000","message":"This api call should be in a try/except block.","commit_id":"72299f5a4361d30ef8e0feae223de91baada4d97"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e7737a9514260382f51dff53e23d618d8a8e75e4","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                image \u003d [x for x in images if x.id \u003d\u003d image_id][0]"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"                flavor_id \u003d cleaned_data.get(\u0027flavor\u0027)"},{"line_number":189,"context_line":"                flavors \u003d api.nova.flavor_list(self.request)"},{"line_number":190,"context_line":"                flavor \u003d [x for x in flavors if x.id \u003d\u003d flavor_id][0]"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"                flv_img_props_to_check \u003d ((\"min_ram\", \"ram\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BKGM%3D","line":189,"in_reply_to":"AAAATn%2F%2BKiY%3D","updated":"2013-11-30 19:15:05.000000000","message":"Thanks for your review, i\u0027m working on that.","commit_id":"72299f5a4361d30ef8e0feae223de91baada4d97"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"efdc91616cbf2b9cb53f93645f9265f0dbbc60f8","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                            getattr(image, iprop) \u003e getattr(flavor, fprop):"},{"line_number":197,"context_line":"                        msg \u003d _(\"The flavor \u0027%(flavor)s\u0027 is too small for \""},{"line_number":198,"context_line":"                                \"requested image.\\n\""},{"line_number":199,"context_line":"                                \"Minimun requirements: \""},{"line_number":200,"context_line":"                                \"%(min_ram)s MB of RAM and \""},{"line_number":201,"context_line":"                                \"%(min_disk)s GB of Root Disk.\" %"},{"line_number":202,"context_line":"                                {\u0027flavor\u0027: flavor.name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BKhs%3D","line":199,"updated":"2013-11-30 06:28:10.000000000","message":"Typo minimum","commit_id":"72299f5a4361d30ef8e0feae223de91baada4d97"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e7737a9514260382f51dff53e23d618d8a8e75e4","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                            getattr(image, iprop) \u003e getattr(flavor, fprop):"},{"line_number":197,"context_line":"                        msg \u003d _(\"The flavor \u0027%(flavor)s\u0027 is too small for \""},{"line_number":198,"context_line":"                                \"requested image.\\n\""},{"line_number":199,"context_line":"                                \"Minimun requirements: \""},{"line_number":200,"context_line":"                                \"%(min_ram)s MB of RAM and \""},{"line_number":201,"context_line":"                                \"%(min_disk)s GB of Root Disk.\" %"},{"line_number":202,"context_line":"                                {\u0027flavor\u0027: flavor.name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BKGI%3D","line":199,"in_reply_to":"AAAATn%2F%2BKhs%3D","updated":"2013-11-30 19:15:05.000000000","message":"Done","commit_id":"72299f5a4361d30ef8e0feae223de91baada4d97"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"e0a4515805892fa2d387a037a062222748d6b811","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                msg \u003d _(\"You must select an image.\")"},{"line_number":189,"context_line":"                self._errors[\u0027image_id\u0027] \u003d self.error_class([msg])"},{"line_number":190,"context_line":"            else:"},{"line_number":191,"context_line":"                # Prevents trying to launch image needs more resources."},{"line_number":192,"context_line":"                try:"},{"line_number":193,"context_line":"                    image_id \u003d cleaned_data.get(\u0027image_id\u0027)"},{"line_number":194,"context_line":"                    images \u003d utils.get_available_images("}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9ueY%3D","line":191,"updated":"2013-12-06 17:14:45.000000000","message":"Grammar:\n\"Prevents trying to launch an image needing more resources.\"\nOr\n\"Prevents trying to launch an image which needs more resources.\"\nOr\n\"Prevent launching an image needing more resources.\"\n(As you wish :-) )","commit_id":"98ddaacfd76f0f610885ce6c972111d92f21d6b2"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"30c1c8376d578224b9d729e8443571e79348f14b","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                msg \u003d _(\"You must select an image.\")"},{"line_number":189,"context_line":"                self._errors[\u0027image_id\u0027] \u003d self.error_class([msg])"},{"line_number":190,"context_line":"            else:"},{"line_number":191,"context_line":"                # Prevents trying to launch image needs more resources."},{"line_number":192,"context_line":"                try:"},{"line_number":193,"context_line":"                    image_id \u003d cleaned_data.get(\u0027image_id\u0027)"},{"line_number":194,"context_line":"                    images \u003d utils.get_available_images("}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9h%2B4%3D","line":191,"in_reply_to":"AAAATn%2F9ueY%3D","updated":"2013-12-10 14:48:46.000000000","message":"Done","commit_id":"98ddaacfd76f0f610885ce6c972111d92f21d6b2"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"8e00b3c9ee2c1cf83d96ac8e3a47b4b3a2803d42","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"            return [(flavor.id, \"%s\" % flavor.name)"},{"line_number":297,"context_line":"                    for flavor in sorted(flavors, key\u003dkey, reverse\u003drev)]"},{"line_number":298,"context_line":"        return []"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def populate_availability_zone_choices(self, request, context):"},{"line_number":301,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FXxA%3D","line":298,"updated":"2014-01-14 14:45:32.000000000","message":"Block 289-297 -- awesome!","commit_id":"4bc89d8051cb3937ed2b27cbf07ff86b8a9264d5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"731f48a1e3075cf47964864594f1e034551a2b6f","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"            return [(flavor.id, \"%s\" % flavor.name)"},{"line_number":297,"context_line":"                    for flavor in sorted(flavors, key\u003dkey, reverse\u003drev)]"},{"line_number":298,"context_line":"        return []"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def populate_availability_zone_choices(self, request, context):"},{"line_number":301,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FTng%3D","line":298,"in_reply_to":"AAAAUH%2F%2FXxA%3D","updated":"2014-01-15 13:18:54.000000000","message":"thanks. :)","commit_id":"4bc89d8051cb3937ed2b27cbf07ff86b8a9264d5"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"8e00b3c9ee2c1cf83d96ac8e3a47b4b3a2803d42","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            flavors \u003d json.dumps([f._info for f in _flavor_list(self.request)])"},{"line_number":323,"context_line":"            extra[\u0027flavors\u0027] \u003d flavors"},{"line_number":324,"context_line":"            images \u003d utils.get_available_images(self.request,"},{"line_number":325,"context_line":"                                          self.initial[\u0027project_id\u0027],"},{"line_number":326,"context_line":"                                          self._images_cache)"},{"line_number":327,"context_line":"            if images is not None:"},{"line_number":328,"context_line":"                attrs \u003d [{\u0027id\u0027: i.id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FXwo%3D","line":325,"updated":"2014-01-14 14:45:32.000000000","message":"Is pep-8 okay with this indenting?  It usually makes me line up the arguments.","commit_id":"4bc89d8051cb3937ed2b27cbf07ff86b8a9264d5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"731f48a1e3075cf47964864594f1e034551a2b6f","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            flavors \u003d json.dumps([f._info for f in _flavor_list(self.request)])"},{"line_number":323,"context_line":"            extra[\u0027flavors\u0027] \u003d flavors"},{"line_number":324,"context_line":"            images \u003d utils.get_available_images(self.request,"},{"line_number":325,"context_line":"                                          self.initial[\u0027project_id\u0027],"},{"line_number":326,"context_line":"                                          self._images_cache)"},{"line_number":327,"context_line":"            if images is not None:"},{"line_number":328,"context_line":"                attrs \u003d [{\u0027id\u0027: i.id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FToM%3D","line":325,"in_reply_to":"AAAAUH%2F%2FXwo%3D","updated":"2014-01-15 13:18:54.000000000","message":"Done","commit_id":"4bc89d8051cb3937ed2b27cbf07ff86b8a9264d5"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"8e00b3c9ee2c1cf83d96ac8e3a47b4b3a2803d42","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            exceptions.handle(self.request,"},{"line_number":393,"context_line":"                              _(\u0027Unable to retrieve list of volumes.\u0027))"},{"line_number":394,"context_line":"        if volumes:"},{"line_number":395,"context_line":"            volumes.insert(0, (\"\", _(\"Select Volume\")))"},{"line_number":396,"context_line":"        else:"},{"line_number":397,"context_line":"            volumes.insert(0, (\"\", _(\"No volumes available\")))"},{"line_number":398,"context_line":"        return volumes"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FXwM%3D","line":395,"updated":"2014-01-14 14:45:32.000000000","message":"If you want, you could move line 395 to before line 390; and move line 397 to before line 392.  Then you could eliminate the if.","commit_id":"4bc89d8051cb3937ed2b27cbf07ff86b8a9264d5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"731f48a1e3075cf47964864594f1e034551a2b6f","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            exceptions.handle(self.request,"},{"line_number":393,"context_line":"                              _(\u0027Unable to retrieve list of volumes.\u0027))"},{"line_number":394,"context_line":"        if volumes:"},{"line_number":395,"context_line":"            volumes.insert(0, (\"\", _(\"Select Volume\")))"},{"line_number":396,"context_line":"        else:"},{"line_number":397,"context_line":"            volumes.insert(0, (\"\", _(\"No volumes available\")))"},{"line_number":398,"context_line":"        return volumes"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FTnc%3D","line":395,"in_reply_to":"AAAAUH%2F%2FXwM%3D","updated":"2014-01-15 13:18:54.000000000","message":"Not sure is relevant to do it. Reviewers have to check for potential bugs not in relation with the aim of this commit.","commit_id":"4bc89d8051cb3937ed2b27cbf07ff86b8a9264d5"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"8e00b3c9ee2c1cf83d96ac8e3a47b4b3a2803d42","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                              _(\u0027Unable to retrieve list of volume \u0027"},{"line_number":409,"context_line":"                                \u0027snapshots.\u0027))"},{"line_number":410,"context_line":"        if snapshots:"},{"line_number":411,"context_line":"            snapshots.insert(0, (\"\", _(\"Select Volume Snapshot\")))"},{"line_number":412,"context_line":"        else:"},{"line_number":413,"context_line":"            snapshots.insert(0, (\"\", _(\"No volume snapshots available\")))"},{"line_number":414,"context_line":"        return snapshots"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FXwI%3D","line":411,"updated":"2014-01-14 14:45:32.000000000","message":"Ditto","commit_id":"4bc89d8051cb3937ed2b27cbf07ff86b8a9264d5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"731f48a1e3075cf47964864594f1e034551a2b6f","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                              _(\u0027Unable to retrieve list of volume \u0027"},{"line_number":409,"context_line":"                                \u0027snapshots.\u0027))"},{"line_number":410,"context_line":"        if snapshots:"},{"line_number":411,"context_line":"            snapshots.insert(0, (\"\", _(\"Select Volume Snapshot\")))"},{"line_number":412,"context_line":"        else:"},{"line_number":413,"context_line":"            snapshots.insert(0, (\"\", _(\"No volume snapshots available\")))"},{"line_number":414,"context_line":"        return snapshots"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FTnY%3D","line":411,"in_reply_to":"AAAAUH%2F%2FXwI%3D","updated":"2014-01-15 13:18:54.000000000","message":"ditto","commit_id":"4bc89d8051cb3937ed2b27cbf07ff86b8a9264d5"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"8e00b3c9ee2c1cf83d96ac8e3a47b4b3a2803d42","unresolved":false,"context_lines":[{"line_number":705,"context_line":"                msg \u003d (_(\u0027Port not created for profile-id (%s).\u0027) %"},{"line_number":706,"context_line":"                       context[\u0027profile_id\u0027])"},{"line_number":707,"context_line":"                exceptions.handle(request, msg)"},{"line_number":708,"context_line":"            if port and port.id:"},{"line_number":709,"context_line":"                nics \u003d [{\"port-id\": port.id}]"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FXvg%3D","line":708,"updated":"2014-01-14 14:45:32.000000000","message":"I know this isn\u0027t your code, but putting a blank line above line 708 would make it a little more readable.","commit_id":"4bc89d8051cb3937ed2b27cbf07ff86b8a9264d5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"731f48a1e3075cf47964864594f1e034551a2b6f","unresolved":false,"context_lines":[{"line_number":705,"context_line":"                msg \u003d (_(\u0027Port not created for profile-id (%s).\u0027) %"},{"line_number":706,"context_line":"                       context[\u0027profile_id\u0027])"},{"line_number":707,"context_line":"                exceptions.handle(request, msg)"},{"line_number":708,"context_line":"            if port and port.id:"},{"line_number":709,"context_line":"                nics \u003d [{\"port-id\": port.id}]"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FSZM%3D","line":708,"in_reply_to":"AAAAUH%2F%2FXvg%3D","updated":"2014-01-15 13:18:54.000000000","message":"Done","commit_id":"4bc89d8051cb3937ed2b27cbf07ff86b8a9264d5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d503eb12654dd23dac8205f5cb12d6f89bffef9a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    except Exception:"},{"line_number":53,"context_line":"        exceptions.handle(request,"},{"line_number":54,"context_line":"                          _(\u0027Unable to retrieve instance flavors.\u0027))"},{"line_number":55,"context_line":"    return []"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class SelectProjectUserAction(workflows.Action):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2Bv2o%3D","line":55,"updated":"2014-01-22 15:17:57.000000000","message":"It is better to place \"return []\" inside except-clause.","commit_id":"4ccbce15900bc798288adbd9b6cc12dbaee47bbd"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b71ebcd2171e93e4d8119eaa41cea366b24dfe89","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    except Exception:"},{"line_number":53,"context_line":"        exceptions.handle(request,"},{"line_number":54,"context_line":"                          _(\u0027Unable to retrieve instance flavors.\u0027))"},{"line_number":55,"context_line":"    return []"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class SelectProjectUserAction(workflows.Action):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2BvsI%3D","line":55,"in_reply_to":"AAAAUH%2F%2Bv2o%3D","updated":"2014-01-22 15:35:56.000000000","message":"why it is better?","commit_id":"4ccbce15900bc798288adbd9b6cc12dbaee47bbd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c3f0a70f5e655100c4289a0460394c9d931296ba","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    except Exception:"},{"line_number":53,"context_line":"        exceptions.handle(request,"},{"line_number":54,"context_line":"                          _(\u0027Unable to retrieve instance flavors.\u0027))"},{"line_number":55,"context_line":"    return []"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class SelectProjectUserAction(workflows.Action):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2BrPg%3D","line":55,"in_reply_to":"AAAAUH%2F%2BvsI%3D","updated":"2014-01-23 10:06:47.000000000","message":"It is just my preference, so I am okay. My preference is to keep \"return\" in the same level as possible as I can. Unless there is more complicated exception handling, On the other hand, placing a \"sentinel\" logic at the bottom is another good style and your code makes sense from the point of view.","commit_id":"4ccbce15900bc798288adbd9b6cc12dbaee47bbd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d503eb12654dd23dac8205f5cb12d6f89bffef9a","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                        self.request,"},{"line_number":202,"context_line":"                        self.context.get(\u0027project_id\u0027),"},{"line_number":203,"context_line":"                        self._images_cache)"},{"line_number":204,"context_line":"                    image \u003d [x for x in images if x.id \u003d\u003d image_id][0]"},{"line_number":205,"context_line":"                except IndexError:"},{"line_number":206,"context_line":"                    image \u003d None"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2Bvyw%3D","line":204,"updated":"2014-01-22 15:17:57.000000000","message":"Why do we need to use image_list here? I think we can use image_get instead.","commit_id":"4ccbce15900bc798288adbd9b6cc12dbaee47bbd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c3f0a70f5e655100c4289a0460394c9d931296ba","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                        self.request,"},{"line_number":202,"context_line":"                        self.context.get(\u0027project_id\u0027),"},{"line_number":203,"context_line":"                        self._images_cache)"},{"line_number":204,"context_line":"                    image \u003d [x for x in images if x.id \u003d\u003d image_id][0]"},{"line_number":205,"context_line":"                except IndexError:"},{"line_number":206,"context_line":"                    image \u003d None"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2BrUs%3D","line":204,"in_reply_to":"AAAAUH%2F%2BvqQ%3D","updated":"2014-01-23 10:06:47.000000000","message":"I see. Could you add a comment that there is a cache of image list and it reduces the number of API calls.","commit_id":"4ccbce15900bc798288adbd9b6cc12dbaee47bbd"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b71ebcd2171e93e4d8119eaa41cea366b24dfe89","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                        self.request,"},{"line_number":202,"context_line":"                        self.context.get(\u0027project_id\u0027),"},{"line_number":203,"context_line":"                        self._images_cache)"},{"line_number":204,"context_line":"                    image \u003d [x for x in images if x.id \u003d\u003d image_id][0]"},{"line_number":205,"context_line":"                except IndexError:"},{"line_number":206,"context_line":"                    image \u003d None"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2BvqQ%3D","line":204,"in_reply_to":"AAAAUH%2F%2Bvyw%3D","updated":"2014-01-22 15:35:56.000000000","message":"There is a cache. This list is used in an other part of the code to print the list of available images. It\u0027s not necessary to call the api.","commit_id":"4ccbce15900bc798288adbd9b6cc12dbaee47bbd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d503eb12654dd23dac8205f5cb12d6f89bffef9a","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                try:"},{"line_number":209,"context_line":"                    flavor_id \u003d cleaned_data.get(\u0027flavor\u0027)"},{"line_number":210,"context_line":"                    flavors \u003d _flavor_list(self.request)"},{"line_number":211,"context_line":"                    flavor \u003d [x for x in flavors if x.id \u003d\u003d flavor_id][0]"},{"line_number":212,"context_line":"                except IndexError:"},{"line_number":213,"context_line":"                    flavor \u003d None"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2BvyY%3D","line":211,"updated":"2014-01-22 15:17:57.000000000","message":"Same as the above. We don\u0027t need to use flavor_list. Can we use flavor_get instead?","commit_id":"4ccbce15900bc798288adbd9b6cc12dbaee47bbd"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b71ebcd2171e93e4d8119eaa41cea366b24dfe89","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                try:"},{"line_number":209,"context_line":"                    flavor_id \u003d cleaned_data.get(\u0027flavor\u0027)"},{"line_number":210,"context_line":"                    flavors \u003d _flavor_list(self.request)"},{"line_number":211,"context_line":"                    flavor \u003d [x for x in flavors if x.id \u003d\u003d flavor_id][0]"},{"line_number":212,"context_line":"                except IndexError:"},{"line_number":213,"context_line":"                    flavor \u003d None"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2Bvp8%3D","line":211,"in_reply_to":"AAAAUH%2F%2BvyY%3D","updated":"2014-01-22 15:35:56.000000000","message":"ditto","commit_id":"4ccbce15900bc798288adbd9b6cc12dbaee47bbd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d503eb12654dd23dac8205f5cb12d6f89bffef9a","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        if flavors:"},{"line_number":285,"context_line":"            flavor_sort \u003d getattr(settings, \u0027CREATE_INSTANCE_FLAVOR_SORT\u0027, {})"},{"line_number":286,"context_line":"            rev \u003d flavor_sort.get(\u0027reverse\u0027, False)"},{"line_number":287,"context_line":"            key \u003d flavor_sort.get(\u0027key\u0027, lambda flavor: flavor.ram)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"            sort_key \u003d flavor_sort.get(\u0027key\u0027, \u0027ram\u0027)"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2Bv1A%3D","line":287,"updated":"2014-01-22 15:17:57.000000000","message":"It looks unnecessary. \"key\" is substituted at L.292 or L.294.","commit_id":"4ccbce15900bc798288adbd9b6cc12dbaee47bbd"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b71ebcd2171e93e4d8119eaa41cea366b24dfe89","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        if flavors:"},{"line_number":285,"context_line":"            flavor_sort \u003d getattr(settings, \u0027CREATE_INSTANCE_FLAVOR_SORT\u0027, {})"},{"line_number":286,"context_line":"            rev \u003d flavor_sort.get(\u0027reverse\u0027, False)"},{"line_number":287,"context_line":"            key \u003d flavor_sort.get(\u0027key\u0027, lambda flavor: flavor.ram)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"            sort_key \u003d flavor_sort.get(\u0027key\u0027, \u0027ram\u0027)"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2Bvos%3D","line":287,"in_reply_to":"AAAAUH%2F%2Bv1A%3D","updated":"2014-01-22 15:35:56.000000000","message":"good catch","commit_id":"4ccbce15900bc798288adbd9b6cc12dbaee47bbd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d503eb12654dd23dac8205f5cb12d6f89bffef9a","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"            return [(flavor.id, \"%s\" % flavor.name)"},{"line_number":297,"context_line":"                    for flavor in sorted(flavors, key\u003dkey, reverse\u003drev)]"},{"line_number":298,"context_line":"        return []"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def populate_availability_zone_choices(self, request, context):"},{"line_number":301,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2Bv0U%3D","line":298,"updated":"2014-01-22 15:17:57.000000000","message":"IMO the following is easier to read in this case:\n\n  if not flavors:\n      return []\n  flavor_sort \u003d getattr(...)\n  rev \u003d flavor_sort.get(....)\n  ....","commit_id":"4ccbce15900bc798288adbd9b6cc12dbaee47bbd"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b71ebcd2171e93e4d8119eaa41cea366b24dfe89","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"            return [(flavor.id, \"%s\" % flavor.name)"},{"line_number":297,"context_line":"                    for flavor in sorted(flavors, key\u003dkey, reverse\u003drev)]"},{"line_number":298,"context_line":"        return []"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def populate_availability_zone_choices(self, request, context):"},{"line_number":301,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2BvpE%3D","line":298,"in_reply_to":"AAAAUH%2F%2Bv0U%3D","updated":"2014-01-22 15:35:56.000000000","message":"could be discussed...","commit_id":"4ccbce15900bc798288adbd9b6cc12dbaee47bbd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c3f0a70f5e655100c4289a0460394c9d931296ba","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"            return [(flavor.id, \"%s\" % flavor.name)"},{"line_number":297,"context_line":"                    for flavor in sorted(flavors, key\u003dkey, reverse\u003drev)]"},{"line_number":298,"context_line":"        return []"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def populate_availability_zone_choices(self, request, context):"},{"line_number":301,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2BrSo%3D","line":298,"in_reply_to":"AAAAUH%2F%2BvpE%3D","updated":"2014-01-23 10:06:47.000000000","message":"IMO, generally speaking, it is easier to read if a condition and a logic are placed nearer.\n\nIn this case, \"return []\" is only processed when \"not flavors\" is True. During  reviewing the code, when I reached this line I could not remember what is the condition *immediately* and needed to move move back to L.284 and got it.\n\nIt is a kind of coding style policies, so I am okay if you prefer to the current style.","commit_id":"4ccbce15900bc798288adbd9b6cc12dbaee47bbd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4017e182797667a7d95b6b61364311dc8c2b60c0","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                # Prevents trying to launch an image needing more resources."},{"line_number":198,"context_line":"                try:"},{"line_number":199,"context_line":"                    image_id \u003d cleaned_data.get(\u0027image_id\u0027)"},{"line_number":200,"context_line":"                    images \u003d utils.get_available_images("},{"line_number":201,"context_line":"                        self.request,"},{"line_number":202,"context_line":"                        self.context.get(\u0027project_id\u0027),"},{"line_number":203,"context_line":"                        self._images_cache)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F%2BrOE%3D","line":200,"updated":"2014-01-23 10:11:42.000000000","message":"Could you add a comment why using a list is better rather than calling image_get API call? Your reply in the previous patch set makes sense to me.","commit_id":"f45f69ca6a88699b109cadc4f7b3aa72038b6ccd"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2470d68645e9b26d1920a02c644797fc57a7c1ca","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                # Prevents trying to launch an image needing more resources."},{"line_number":198,"context_line":"                try:"},{"line_number":199,"context_line":"                    image_id \u003d cleaned_data.get(\u0027image_id\u0027)"},{"line_number":200,"context_line":"                    images \u003d utils.get_available_images("},{"line_number":201,"context_line":"                        self.request,"},{"line_number":202,"context_line":"                        self.context.get(\u0027project_id\u0027),"},{"line_number":203,"context_line":"                        self._images_cache)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F%2BrCg%3D","line":200,"in_reply_to":"AAAAUH%2F%2BrOE%3D","updated":"2014-01-23 10:41:15.000000000","message":"I can sure.","commit_id":"f45f69ca6a88699b109cadc4f7b3aa72038b6ccd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4017e182797667a7d95b6b61364311dc8c2b60c0","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"                try:"},{"line_number":209,"context_line":"                    flavor_id \u003d cleaned_data.get(\u0027flavor\u0027)"},{"line_number":210,"context_line":"                    flavors \u003d _flavor_list(self.request)"},{"line_number":211,"context_line":"                    flavor \u003d [x for x in flavors if x.id \u003d\u003d flavor_id][0]"},{"line_number":212,"context_line":"                except IndexError:"},{"line_number":213,"context_line":"                    flavor \u003d None"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F%2BrNo%3D","line":210,"updated":"2014-01-23 10:11:42.000000000","message":"Same as the above.","commit_id":"f45f69ca6a88699b109cadc4f7b3aa72038b6ccd"},{"author":{"_account_id":8176,"name":"Jerry Johnson","email":"jerryj@hp.com","username":"johnsjer"},"change_message_id":"ade9cd05fab15673d7bac7fccb938e0ec0f76c5e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    except Exception:"},{"line_number":53,"context_line":"        exceptions.handle(request,"},{"line_number":54,"context_line":"                          _(\u0027Unable to retrieve instance flavors.\u0027))"},{"line_number":55,"context_line":"    return []"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class SelectProjectUserAction(workflows.Action):"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2BoG0%3D","line":55,"updated":"2014-01-23 19:33:30.000000000","message":"Suggest that this \u0027return []\u0027 be explicitly part of except block if that is what is intended by exceptions.handle().","commit_id":"5a238d647b9847e5f869c56b060f39f639fb3b05"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a4e4f7255875eab115607e0c3b8698c818d4f8a0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    except Exception:"},{"line_number":53,"context_line":"        exceptions.handle(request,"},{"line_number":54,"context_line":"                          _(\u0027Unable to retrieve instance flavors.\u0027))"},{"line_number":55,"context_line":"    return []"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class SelectProjectUserAction(workflows.Action):"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2BhkE%3D","line":55,"in_reply_to":"AAAAUH%2F%2BkL0%3D","updated":"2014-01-24 18:55:23.000000000","message":"Ok i will do it.","commit_id":"5a238d647b9847e5f869c56b060f39f639fb3b05"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"61e9335352b28fc0da4082829f983d75e89d1730","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    except Exception:"},{"line_number":53,"context_line":"        exceptions.handle(request,"},{"line_number":54,"context_line":"                          _(\u0027Unable to retrieve instance flavors.\u0027))"},{"line_number":55,"context_line":"    return []"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class SelectProjectUserAction(workflows.Action):"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2BkL0%3D","line":55,"in_reply_to":"AAAAUH%2F%2BoG0%3D","updated":"2014-01-24 10:45:52.000000000","message":"I made the same comment in patch set 11.","commit_id":"5a238d647b9847e5f869c56b060f39f639fb3b05"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1bc5dd9eb62bafdadfe3f97d40541b4aa403a310","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                # Prevents trying to launch an image needing more resources."},{"line_number":198,"context_line":"                try:"},{"line_number":199,"context_line":"                    image_id \u003d cleaned_data.get(\u0027image_id\u0027)"},{"line_number":200,"context_line":"                    images \u003d utils.get_available_images("},{"line_number":201,"context_line":"                        self.request,"},{"line_number":202,"context_line":"                        self.context.get(\u0027project_id\u0027),"},{"line_number":203,"context_line":"                        self._images_cache)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2BkKw%3D","line":200,"updated":"2014-01-24 10:48:54.000000000","message":"(copied from patch set 12) \nCould you add a comment why using a list is better rather than calling image_get API call? Your reply in the previous patch set makes sense to me.","commit_id":"5a238d647b9847e5f869c56b060f39f639fb3b05"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6b5c3027e534c062358c679e32f33e90c371eca8","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                # Prevents trying to launch an image needing more resources."},{"line_number":198,"context_line":"                try:"},{"line_number":199,"context_line":"                    image_id \u003d cleaned_data.get(\u0027image_id\u0027)"},{"line_number":200,"context_line":"                    images \u003d utils.get_available_images("},{"line_number":201,"context_line":"                        self.request,"},{"line_number":202,"context_line":"                        self.context.get(\u0027project_id\u0027),"},{"line_number":203,"context_line":"                        self._images_cache)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2BbvM%3D","line":200,"in_reply_to":"AAAAUH%2F%2Bbwc%3D","updated":"2014-01-26 18:24:59.000000000","message":"ok thanks, I rewrote it a little bit to be more concise","commit_id":"5a238d647b9847e5f869c56b060f39f639fb3b05"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0762f00773a4e0fb7f37eed9cc515bed239475fb","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                # Prevents trying to launch an image needing more resources."},{"line_number":198,"context_line":"                try:"},{"line_number":199,"context_line":"                    image_id \u003d cleaned_data.get(\u0027image_id\u0027)"},{"line_number":200,"context_line":"                    images \u003d utils.get_available_images("},{"line_number":201,"context_line":"                        self.request,"},{"line_number":202,"context_line":"                        self.context.get(\u0027project_id\u0027),"},{"line_number":203,"context_line":"                        self._images_cache)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2Bbwc%3D","line":200,"in_reply_to":"AAAAUH%2F%2Bhj0%3D","updated":"2014-01-26 18:08:08.000000000","message":"I think the following comment is useful. It is what you described in patch set 11.\n\n  # We just want to retrieve details for a given image here,\n  # however we already have a cache of image list,\n  # so get_available_images is used instead of image_get.\n  # It reduces the number of API calls.","commit_id":"5a238d647b9847e5f869c56b060f39f639fb3b05"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a4e4f7255875eab115607e0c3b8698c818d4f8a0","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                # Prevents trying to launch an image needing more resources."},{"line_number":198,"context_line":"                try:"},{"line_number":199,"context_line":"                    image_id \u003d cleaned_data.get(\u0027image_id\u0027)"},{"line_number":200,"context_line":"                    images \u003d utils.get_available_images("},{"line_number":201,"context_line":"                        self.request,"},{"line_number":202,"context_line":"                        self.context.get(\u0027project_id\u0027),"},{"line_number":203,"context_line":"                        self._images_cache)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2Bhj0%3D","line":200,"in_reply_to":"AAAAUH%2F%2BkKw%3D","updated":"2014-01-24 18:55:23.000000000","message":"Can you give me an example? Actually I don\u0027t see what kind of comment  I can add. Thanks","commit_id":"5a238d647b9847e5f869c56b060f39f639fb3b05"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1bc5dd9eb62bafdadfe3f97d40541b4aa403a310","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"                try:"},{"line_number":209,"context_line":"                    flavor_id \u003d cleaned_data.get(\u0027flavor\u0027)"},{"line_number":210,"context_line":"                    flavors \u003d _flavor_list(self.request)"},{"line_number":211,"context_line":"                    flavor \u003d [x for x in flavors if x.id \u003d\u003d flavor_id][0]"},{"line_number":212,"context_line":"                except IndexError:"},{"line_number":213,"context_line":"                    flavor \u003d None"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUH%2F%2BkKs%3D","line":210,"updated":"2014-01-24 10:48:54.000000000","message":"same as the above.","commit_id":"5a238d647b9847e5f869c56b060f39f639fb3b05"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e159e6015c16b1980b53985498353f6fac05a027","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                try:"},{"line_number":199,"context_line":"                    image_id \u003d cleaned_data.get(\u0027image_id\u0027)"},{"line_number":200,"context_line":"                    # We are using get_available_images instead of"},{"line_number":201,"context_line":"                    # image_get to reduces the number of API calls."},{"line_number":202,"context_line":"                    images \u003d utils.get_available_images("},{"line_number":203,"context_line":"                        self.request,"},{"line_number":204,"context_line":"                        self.context.get(\u0027project_id\u0027),"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2BZgI%3D","line":201,"updated":"2014-01-27 11:04:27.000000000","message":"IMO the most important is why because it is not obvious to every developer that image list is cached. but it is okay... and not a blocking issue.","commit_id":"3c87481e2a86803b6d04fe560c44c56fc3e3de16"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3b787b8a5318129378abb56a057305d7d54cb3de","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                    # We want to retrieve details for a given image,"},{"line_number":201,"context_line":"                    # however get_available_images uses a cache of image list,"},{"line_number":202,"context_line":"                    # so it is used instead of image_get to reduce the number"},{"line_number":203,"context_line":"                    # of API calls."},{"line_number":204,"context_line":"                    images \u003d utils.get_available_images("},{"line_number":205,"context_line":"                        self.request,"},{"line_number":206,"context_line":"                        self.context.get(\u0027project_id\u0027),"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2BZcY%3D","line":203,"updated":"2014-01-27 11:19:32.000000000","message":"I hope it is better now?","commit_id":"1f86a6991350192b1b5e301eb493013b5a61f6a4"}],"openstack_dashboard/test/test_data/glance_data.py":[{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"c177562f3fceb0bb9d8da94c8aac210e9e4f9556","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                  \u0027name\u0027: \u0027public_image\u0027,"},{"line_number":59,"context_line":"                  \u0027status\u0027: \"active\","},{"line_number":60,"context_line":"                  \u0027size\u0027: 20 * 1024 ** 3,"},{"line_number":61,"context_line":"                  \u0027min_disk\u0027: 0,"},{"line_number":62,"context_line":"                  \u0027owner\u0027: TEST.tenant.id,"},{"line_number":63,"context_line":"                  \u0027container_format\u0027: \u0027novaImage\u0027,"},{"line_number":64,"context_line":"                  \u0027properties\u0027: {\u0027image_type\u0027: u\u0027image\u0027},"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F%2BqSg%3D","line":61,"updated":"2014-01-23 12:59:42.000000000","message":"min_disk is arlead set here...","commit_id":"f45f69ca6a88699b109cadc4f7b3aa72038b6ccd"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"c177562f3fceb0bb9d8da94c8aac210e9e4f9556","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                  \u0027properties\u0027: {\u0027image_type\u0027: u\u0027image\u0027},"},{"line_number":65,"context_line":"                  \u0027is_public\u0027: True,"},{"line_number":66,"context_line":"                  \u0027protected\u0027: False,"},{"line_number":67,"context_line":"                  \u0027min_disk\u0027: 0,"},{"line_number":68,"context_line":"                  \u0027min_ram\u0027: 0}"},{"line_number":69,"context_line":"    public_image \u003d images.Image(images.ImageManager(None), image_dict)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F%2BqSc%3D","line":67,"updated":"2014-01-23 12:59:42.000000000","message":"...so no need to set it here.","commit_id":"f45f69ca6a88699b109cadc4f7b3aa72038b6ccd"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"c177562f3fceb0bb9d8da94c8aac210e9e4f9556","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                  \u0027container_format\u0027: \u0027aki\u0027,"},{"line_number":78,"context_line":"                  \u0027is_public\u0027: False,"},{"line_number":79,"context_line":"                  \u0027protected\u0027: False,"},{"line_number":80,"context_line":"                  \u0027min_disk\u0027: 0,"},{"line_number":81,"context_line":"                  \u0027min_ram\u0027: 0}"},{"line_number":82,"context_line":"    private_image \u003d images.Image(images.ImageManager(None), image_dict)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F%2BqSk%3D","line":80,"updated":"2014-01-23 12:59:42.000000000","message":"Same as above.","commit_id":"f45f69ca6a88699b109cadc4f7b3aa72038b6ccd"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"c177562f3fceb0bb9d8da94c8aac210e9e4f9556","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                  \u0027properties\u0027: {\u0027image_type\u0027: u\u0027image\u0027},"},{"line_number":92,"context_line":"                  \u0027is_public\u0027: True,"},{"line_number":93,"context_line":"                  \u0027protected\u0027: True,"},{"line_number":94,"context_line":"                  \u0027min_disk\u0027: 0,"},{"line_number":95,"context_line":"                  \u0027min_ram\u0027: 0}"},{"line_number":96,"context_line":"    protected_image \u003d images.Image(images.ImageManager(None), image_dict)"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F%2BqSo%3D","line":94,"updated":"2014-01-23 12:59:42.000000000","message":"This time you override the min_disk (line 89) which was set to 30","commit_id":"f45f69ca6a88699b109cadc4f7b3aa72038b6ccd"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"c177562f3fceb0bb9d8da94c8aac210e9e4f9556","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                  \u0027properties\u0027: {\u0027image_type\u0027: u\u0027image\u0027},"},{"line_number":106,"context_line":"                  \u0027is_public\u0027: True,"},{"line_number":107,"context_line":"                  \u0027protected\u0027: False,"},{"line_number":108,"context_line":"                  \u0027min_disk\u0027: 0,"},{"line_number":109,"context_line":"                  \u0027min_ram\u0027: 0}"},{"line_number":110,"context_line":"    public_image2 \u003d images.Image(images.ImageManager(None), image_dict)"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F%2BqSU%3D","line":108,"updated":"2014-01-23 12:59:42.000000000","message":"Same as above.","commit_id":"f45f69ca6a88699b109cadc4f7b3aa72038b6ccd"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"c177562f3fceb0bb9d8da94c8aac210e9e4f9556","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                  \u0027container_format\u0027: \u0027aki\u0027,"},{"line_number":119,"context_line":"                  \u0027is_public\u0027: False,"},{"line_number":120,"context_line":"                  \u0027protected\u0027: False,"},{"line_number":121,"context_line":"                  \u0027min_disk\u0027: 0,"},{"line_number":122,"context_line":"                  \u0027min_ram\u0027: 0}"},{"line_number":123,"context_line":"    private_image2 \u003d images.Image(images.ImageManager(None), image_dict)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F%2BqSQ%3D","line":121,"updated":"2014-01-23 12:59:42.000000000","message":"Same as above.","commit_id":"f45f69ca6a88699b109cadc4f7b3aa72038b6ccd"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"c177562f3fceb0bb9d8da94c8aac210e9e4f9556","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                  \u0027container_format\u0027: \u0027aki\u0027,"},{"line_number":132,"context_line":"                  \u0027is_public\u0027: False,"},{"line_number":133,"context_line":"                  \u0027protected\u0027: False,"},{"line_number":134,"context_line":"                  \u0027min_disk\u0027: 0,"},{"line_number":135,"context_line":"                  \u0027min_ram\u0027: 0}"},{"line_number":136,"context_line":"    private_image3 \u003d images.Image(images.ImageManager(None), image_dict)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F%2BqSM%3D","line":134,"updated":"2014-01-23 12:59:42.000000000","message":"Same as above.","commit_id":"f45f69ca6a88699b109cadc4f7b3aa72038b6ccd"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"c177562f3fceb0bb9d8da94c8aac210e9e4f9556","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                  \u0027container_format\u0027: \u0027aki\u0027,"},{"line_number":146,"context_line":"                  \u0027is_public\u0027: False,"},{"line_number":147,"context_line":"                  \u0027protected\u0027: False,"},{"line_number":148,"context_line":"                  \u0027min_disk\u0027: 0,"},{"line_number":149,"context_line":"                  \u0027min_ram\u0027: 0}"},{"line_number":150,"context_line":"    shared_image1 \u003d images.Image(images.ImageManager(None), image_dict)"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F%2BqSI%3D","line":148,"updated":"2014-01-23 12:59:42.000000000","message":"Same as above.","commit_id":"f45f69ca6a88699b109cadc4f7b3aa72038b6ccd"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"c177562f3fceb0bb9d8da94c8aac210e9e4f9556","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                  \u0027container_format\u0027: \u0027aki\u0027,"},{"line_number":161,"context_line":"                  \u0027is_public\u0027: True,"},{"line_number":162,"context_line":"                  \u0027protected\u0027: False,"},{"line_number":163,"context_line":"                  \u0027min_disk\u0027: 0,"},{"line_number":164,"context_line":"                  \u0027min_ram\u0027: 0}"},{"line_number":165,"context_line":"    official_image1 \u003d images.Image(images.ImageManager(None), image_dict)"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F%2BqR8%3D","line":163,"updated":"2014-01-23 12:59:42.000000000","message":"Same as above.","commit_id":"f45f69ca6a88699b109cadc4f7b3aa72038b6ccd"}]}
