)]}'
{"openstack_dashboard/api/cinder.py":[{"author":{"_account_id":9571,"name":"Gabriel Pettier","email":"gabriel.pettier@gmail.com","username":"GabrielPettier"},"change_message_id":"bd0303bb5532fb7700ae37d382f826b703c9381c","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"def volume_snapshot_create(request, volume_id, force\u003dFalse,"},{"line_number":120,"context_line":"                           name\u003dNone, description\u003dNone):"},{"line_number":121,"context_line":"    return cinderclient(request).volume_snapshots.create(volume_id,"},{"line_number":122,"context_line":"            force\u003dforce, display_name\u003dname, display_description\u003ddescription)"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F96cg%3D","line":120,"updated":"2013-12-04 15:17:48.000000000","message":"shouldn\u0027t the new keyword parameters be added at the end to avoid changing the current signature and avoid possible api breaks?","commit_id":"aeb0cefbf0ec1306cddcb5f35d45742c6478b643"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"b2273f4e420c9de467c13ccd0bf8346aa2cc152f","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"def volume_snapshot_create(request, volume_id, force\u003dFalse,"},{"line_number":120,"context_line":"                           name\u003dNone, description\u003dNone):"},{"line_number":121,"context_line":"    return cinderclient(request).volume_snapshots.create(volume_id,"},{"line_number":122,"context_line":"            force\u003dforce, display_name\u003dname, display_description\u003ddescription)"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9sM4%3D","line":120,"in_reply_to":"AAAATn%2F96cg%3D","updated":"2013-12-07 23:03:33.000000000","message":"+1, please move force\u003d to the end.","commit_id":"aeb0cefbf0ec1306cddcb5f35d45742c6478b643"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"062e4633d8cd5a4d6f2059e3ca2672454231e6f8","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    return c_client.volume_snapshots.list()"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"def volume_snapshot_create(request, volume_id, name\u003dNone,"},{"line_number":120,"context_line":"                           description\u003dNone, force\u003dFalse):"},{"line_number":121,"context_line":"    return cinderclient(request).volume_snapshots.create(volume_id,"},{"line_number":122,"context_line":"            force\u003dforce, display_name\u003dname, display_description\u003ddescription)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F83lE%3D","line":119,"updated":"2013-12-19 12:02:42.000000000","message":"name is a required field, probably better to leave it with no default value.","commit_id":"e7580017976c6bc1c4ddfc5ca874e63594ff5236"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"30f06ba76d3431efd641f511ad3d34fd81e59873","unresolved":false,"context_lines":[{"line_number":119,"context_line":"def volume_snapshot_create(request, volume_id, name,"},{"line_number":120,"context_line":"                           description\u003dNone, force\u003dFalse):"},{"line_number":121,"context_line":"    return cinderclient(request).volume_snapshots.create(volume_id,"},{"line_number":122,"context_line":"            force\u003dforce, display_name\u003dname, display_description\u003ddescription)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"def volume_snapshot_delete(request, snapshot_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAT3%2F%2Fsns%3D","line":122,"updated":"2014-01-03 09:28:38.000000000","message":"Nit: bad indentation.","commit_id":"79bb7851c8773b93592c43148a6e6cdc23e860fe"}],"openstack_dashboard/dashboards/project/images_and_snapshots/volume_snapshots/tests.py":[{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"b2273f4e420c9de467c13ccd0bf8346aa2cc152f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            .AndReturn(volume)"},{"line_number":63,"context_line":"        cinder.volume_snapshot_create(IsA(http.HttpRequest),"},{"line_number":64,"context_line":"                                      volume.id,"},{"line_number":65,"context_line":"                                      False,"},{"line_number":66,"context_line":"                                      snapshot.display_name,"},{"line_number":67,"context_line":"                                      snapshot.display_description) \\"},{"line_number":68,"context_line":"            .AndReturn(snapshot)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9sMo%3D","line":65,"updated":"2013-12-07 23:03:33.000000000","message":"Use the keyword for this argument so it\u0027s clear what False means.","commit_id":"aeb0cefbf0ec1306cddcb5f35d45742c6478b643"}],"openstack_dashboard/dashboards/project/volumes/forms.py":[{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"b2273f4e420c9de467c13ccd0bf8346aa2cc152f","unresolved":false,"context_lines":[{"line_number":372,"context_line":"            if volume.status \u003d\u003d \u0027in-use\u0027:"},{"line_number":373,"context_line":"                force \u003d True"},{"line_number":374,"context_line":"                message \u003d _(\u0027Forcing to create snapshot \"%s\" \u0027"},{"line_number":375,"context_line":"                            \u0027from in-use volume\u0027) % data[\u0027name\u0027]"},{"line_number":376,"context_line":"            snapshot \u003d cinder.volume_snapshot_create(request,"},{"line_number":377,"context_line":"                                                     data[\u0027volume_id\u0027],"},{"line_number":378,"context_line":"                                                     force,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9sMg%3D","line":375,"updated":"2013-12-07 23:03:33.000000000","message":"Add a period to the end of both of these messages.","commit_id":"aeb0cefbf0ec1306cddcb5f35d45742c6478b643"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"062e4633d8cd5a4d6f2059e3ca2672454231e6f8","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            if volume.status \u003d\u003d \u0027in-use\u0027:"},{"line_number":387,"context_line":"                force \u003d True"},{"line_number":388,"context_line":"                message \u003d _(\u0027Forcing to create snapshot \"%s\" \u0027"},{"line_number":389,"context_line":"                            \u0027from in-use volume.\u0027) % data[\u0027name\u0027]"},{"line_number":390,"context_line":"            snapshot \u003d cinder.volume_snapshot_create(request,"},{"line_number":391,"context_line":"                                                     data[\u0027volume_id\u0027],"},{"line_number":392,"context_line":"                                                     data[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F83jk%3D","line":389,"updated":"2013-12-19 12:02:42.000000000","message":"Instead of using \"in-use\", maybe we should use the term \"attached\" for consistency with the warning message.","commit_id":"e7580017976c6bc1c4ddfc5ca874e63594ff5236"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"7d3e34d19c2996bbbe7f0d7ec1b8ffffeaf9830c","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            if volume.status \u003d\u003d \u0027in-use\u0027:"},{"line_number":387,"context_line":"                force \u003d True"},{"line_number":388,"context_line":"                message \u003d _(\u0027Forcing to create snapshot \"%s\" \u0027"},{"line_number":389,"context_line":"                            \u0027from in-use volume.\u0027) % data[\u0027name\u0027]"},{"line_number":390,"context_line":"            snapshot \u003d cinder.volume_snapshot_create(request,"},{"line_number":391,"context_line":"                                                     data[\u0027volume_id\u0027],"},{"line_number":392,"context_line":"                                                     data[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F80ig%3D","line":389,"in_reply_to":"AAAATn%2F83jk%3D","updated":"2013-12-20 00:20:05.000000000","message":"+1","commit_id":"e7580017976c6bc1c4ddfc5ca874e63594ff5236"}],"openstack_dashboard/dashboards/project/volumes/templates/volumes/_create_snapshot.html":[{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"b2273f4e420c9de467c13ccd0bf8346aa2cc152f","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% block modal-footer %}"},{"line_number":23,"context_line":"  {% if attached %}"},{"line_number":24,"context_line":"    \u003cinput class\u003d\"btn btn-primary btn-danger pull-right\" type\u003d\"submit\" value\u003d\"{% trans \"Create Volume Snapshot (Force)\" %}\" /\u003e"},{"line_number":25,"context_line":"  {% else %}"},{"line_number":26,"context_line":"    \u003cinput class\u003d\"btn btn-primary pull-right\" type\u003d\"submit\" value\u003d\"{% trans \"Create Volume Snapshot\" %}\" /\u003e"},{"line_number":27,"context_line":"  {% endif %}"}],"source_content_type":"text/html","patch_set":5,"id":"AAAATn%2F9sMY%3D","line":24,"updated":"2013-12-07 23:03:33.000000000","message":"Looks good.","commit_id":"aeb0cefbf0ec1306cddcb5f35d45742c6478b643"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"062e4633d8cd5a4d6f2059e3ca2672454231e6f8","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% block modal-footer %}"},{"line_number":23,"context_line":"  {% if attached %}"},{"line_number":24,"context_line":"    \u003cinput class\u003d\"btn btn-primary btn-danger pull-right\" type\u003d\"submit\" value\u003d\"{% trans \"Create Volume Snapshot (Force)\" %}\" /\u003e"},{"line_number":25,"context_line":"  {% else %}"},{"line_number":26,"context_line":"    \u003cinput class\u003d\"btn btn-primary pull-right\" type\u003d\"submit\" value\u003d\"{% trans \"Create Volume Snapshot\" %}\" /\u003e"},{"line_number":27,"context_line":"  {% endif %}"}],"source_content_type":"text/html","patch_set":9,"id":"AAAATn%2F83iM%3D","line":24,"updated":"2013-12-19 12:02:42.000000000","message":"Just a comment, you could either change it or not. I am not sure if this should be btn-danger as it doesn\u0027t negatively impact the attached volume (like purging/disassociate actions).","commit_id":"e7580017976c6bc1c4ddfc5ca874e63594ff5236"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"7d3e34d19c2996bbbe7f0d7ec1b8ffffeaf9830c","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% block modal-footer %}"},{"line_number":23,"context_line":"  {% if attached %}"},{"line_number":24,"context_line":"    \u003cinput class\u003d\"btn btn-primary btn-danger pull-right\" type\u003d\"submit\" value\u003d\"{% trans \"Create Volume Snapshot (Force)\" %}\" /\u003e"},{"line_number":25,"context_line":"  {% else %}"},{"line_number":26,"context_line":"    \u003cinput class\u003d\"btn btn-primary pull-right\" type\u003d\"submit\" value\u003d\"{% trans \"Create Volume Snapshot\" %}\" /\u003e"},{"line_number":27,"context_line":"  {% endif %}"}],"source_content_type":"text/html","patch_set":9,"id":"AAAATn%2F80i0%3D","line":24,"in_reply_to":"AAAATn%2F83iM%3D","updated":"2013-12-20 00:20:05.000000000","message":"True. btn-warning would match the warning text but I don\u0027t have any strong opinion about this either.","commit_id":"e7580017976c6bc1c4ddfc5ca874e63594ff5236"}],"openstack_dashboard/dashboards/project/volumes/templates/volumes/_limits.html":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"cd6346c2533d0a19b13b3dcf5a8993790c1d5f0b","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% if attached %}"},{"line_number":6,"context_line":"  \u003cp\u003e{% trans \"If you know what you\u0027re doing, and you accept the fact that you could be creating a corrupted snapshot, you can certainly request on while attached.\" %}\u003c/p\u003e"},{"line_number":7,"context_line":"{% else %}"},{"line_number":8,"context_line":"  \u003cp\u003e{% trans \"Volumes are block devices that can be attached to instances.\" %}\u003c/p\u003e"},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":""}],"source_content_type":"text/html","patch_set":5,"id":"AAAATn%2F%2BB2k%3D","line":7,"updated":"2013-12-03 09:44:41.000000000","message":"The description of what is a block device would be hidden in case the volume is attached, right ?","commit_id":"aeb0cefbf0ec1306cddcb5f35d45742c6478b643"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"54b6dc17319d46c90118754c18e9552199f4e7fc","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% if attached %}"},{"line_number":6,"context_line":"  \u003cp\u003e{% trans \"If you know what you\u0027re doing, and you accept the fact that you could be creating a corrupted snapshot, you can certainly request on while attached.\" %}\u003c/p\u003e"},{"line_number":7,"context_line":"{% else %}"},{"line_number":8,"context_line":"  \u003cp\u003e{% trans \"Volumes are block devices that can be attached to instances.\" %}\u003c/p\u003e"},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":""}],"source_content_type":"text/html","patch_set":5,"id":"AAAATn%2F98HA%3D","line":7,"in_reply_to":"AAAATn%2F%2BB2k%3D","updated":"2013-12-04 08:36:24.000000000","message":"yes, attached volumes will only show warning message here.","commit_id":"aeb0cefbf0ec1306cddcb5f35d45742c6478b643"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f081599aa37ce0b934c7191ba8b149fa7be633f7","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% if attached %}"},{"line_number":6,"context_line":"  \u003cp\u003e{% trans \"If you know what you\u0027re doing, and you accept the fact that you could be creating a corrupted snapshot, you can certainly request on while attached.\" %}\u003c/p\u003e"},{"line_number":7,"context_line":"{% else %}"},{"line_number":8,"context_line":"  \u003cp\u003e{% trans \"Volumes are block devices that can be attached to instances.\" %}\u003c/p\u003e"},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":""}],"source_content_type":"text/html","patch_set":5,"id":"AAAATn%2F97%2Fw%3D","line":7,"in_reply_to":"AAAATn%2F98HA%3D","updated":"2013-12-04 09:07:29.000000000","message":"I am not talking about the warning message.  I am talking about the message :  \"Volumes are block devices that can be attached to instances.\" that will be hidden if the volume is attached. IMHO, this is not good.","commit_id":"aeb0cefbf0ec1306cddcb5f35d45742c6478b643"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"b2273f4e420c9de467c13ccd0bf8346aa2cc152f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% if attached %}"},{"line_number":6,"context_line":"  \u003cp\u003e{% trans \"If you know what you\u0027re doing, and you accept the fact that you could be creating a corrupted snapshot, you can certainly request on while attached.\" %}\u003c/p\u003e"},{"line_number":7,"context_line":"{% else %}"},{"line_number":8,"context_line":"  \u003cp\u003e{% trans \"Volumes are block devices that can be attached to instances.\" %}\u003c/p\u003e"},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"\u003ch3\u003e{% trans \"Volume Limits\" %}\u003c/h3\u003e"}],"source_content_type":"text/html","patch_set":5,"id":"AAAATn%2F9sMI%3D","line":8,"updated":"2013-12-07 23:03:33.000000000","message":"This sentence is helpful in either case and needs to be always shown. But I think the warning should be more obvious than this - at the top of the form rather than in the help text.","commit_id":"aeb0cefbf0ec1306cddcb5f35d45742c6478b643"}],"openstack_dashboard/dashboards/project/volumes/views.py":[{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"b2273f4e420c9de467c13ccd0bf8346aa2cc152f","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    def get_context_data(self, **kwargs):"},{"line_number":141,"context_line":"        context \u003d super(CreateSnapshotView, self).get_context_data(**kwargs)"},{"line_number":142,"context_line":"        context[\u0027volume_id\u0027] \u003d self.kwargs[\u0027volume_id\u0027]"},{"line_number":143,"context_line":"        volume \u003d cinder.volume_get(self.request, context[\u0027volume_id\u0027])"},{"line_number":144,"context_line":"        if volume.status \u003d\u003d \u0027in-use\u0027:"},{"line_number":145,"context_line":"            context[\u0027attached\u0027] \u003d True"},{"line_number":146,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9sLs%3D","line":143,"updated":"2013-12-07 23:03:33.000000000","message":"try/catch?","commit_id":"aeb0cefbf0ec1306cddcb5f35d45742c6478b643"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"b2273f4e420c9de467c13ccd0bf8346aa2cc152f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        context[\u0027volume_id\u0027] \u003d self.kwargs[\u0027volume_id\u0027]"},{"line_number":143,"context_line":"        volume \u003d cinder.volume_get(self.request, context[\u0027volume_id\u0027])"},{"line_number":144,"context_line":"        if volume.status \u003d\u003d \u0027in-use\u0027:"},{"line_number":145,"context_line":"            context[\u0027attached\u0027] \u003d True"},{"line_number":146,"context_line":"        try:"},{"line_number":147,"context_line":"            context[\u0027usages\u0027] \u003d quotas.tenant_limit_usages(self.request)"},{"line_number":148,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9sME%3D","line":145,"updated":"2013-12-07 23:03:33.000000000","message":"This can probably be simplified to:\n\n    context[\u0027attached\u0027] \u003d (volume.status \u003d\u003d \u0027in-use\u0027)","commit_id":"aeb0cefbf0ec1306cddcb5f35d45742c6478b643"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"485f0d9af49872baccb3474c7331bf704811220d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            exceptions.handle(self.request)"},{"line_number":147,"context_line":"        if (volume.status \u003d\u003d \u0027in-use\u0027):"},{"line_number":148,"context_line":"            context[\u0027attached\u0027] \u003d True"},{"line_number":149,"context_line":"            context[\u0027form\u0027].set_warning(_(\"If you know what you\u0027re doing, \""},{"line_number":150,"context_line":"                                \"and you accept the fact that you could be \""},{"line_number":151,"context_line":"                                \"creating a corrupted snapshot, you can \""},{"line_number":152,"context_line":"                                \"certainly request on while attached.\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9JiA%3D","line":149,"updated":"2013-12-16 10:00:08.000000000","message":"I like the place of this warning message. But I am not sure about the wording. I would start the sentence with \"This volume is currently attached. If you know what you\u0027re doing and you accept the [...]\" This would give the user an explanation of why this warning appears, in case he didn\u0027t notice his volume was attached.","commit_id":"5a6c4d463a8c545862753a1e08c7e0e457091699"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"f0f67f70687812916ee433c81221709a670dd580","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            exceptions.handle(self.request)"},{"line_number":147,"context_line":"        if (volume.status \u003d\u003d \u0027in-use\u0027):"},{"line_number":148,"context_line":"            context[\u0027attached\u0027] \u003d True"},{"line_number":149,"context_line":"            context[\u0027form\u0027].set_warning(_(\"If you know what you\u0027re doing, \""},{"line_number":150,"context_line":"                                \"and you accept the fact that you could be \""},{"line_number":151,"context_line":"                                \"creating a corrupted snapshot, you can \""},{"line_number":152,"context_line":"                                \"certainly request on while attached.\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9ENM%3D","line":149,"in_reply_to":"AAAATn%2F9JiA%3D","updated":"2013-12-17 05:44:41.000000000","message":"agree, i\u0027ll add the words in the next patch.","commit_id":"5a6c4d463a8c545862753a1e08c7e0e457091699"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"b37ea7d8f247dd7ed28e4f7d108b66e178fc50d2","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                                \"attached. If you know what you\u0027re doing, \""},{"line_number":151,"context_line":"                                \"and you accept the fact that you could be \""},{"line_number":152,"context_line":"                                \"creating a corrupted snapshot, you can \""},{"line_number":153,"context_line":"                                \"certainly request on while attached.\"))"},{"line_number":154,"context_line":"        try:"},{"line_number":155,"context_line":"            context[\u0027usages\u0027] \u003d quotas.tenant_limit_usages(self.request)"},{"line_number":156,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F85oM%3D","line":153,"updated":"2013-12-19 01:09:54.000000000","message":"\"request on while attached\" doesn\u0027t sound right. It is meant to be \"request one while attached\"?\n\nAlternatively, what about something like:\n\n\"This volume is currently attached to an instance. In some cases, creating a snapshot from an attached volume can result in a corrupted snapshot.\"","commit_id":"0d3bda5c2840b179c6ca9b41511ede04e5c824af"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"7d3e34d19c2996bbbe7f0d7ec1b8ffffeaf9830c","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        try:"},{"line_number":144,"context_line":"            volume \u003d cinder.volume_get(self.request, context[\u0027volume_id\u0027])"},{"line_number":145,"context_line":"        except Exception:"},{"line_number":146,"context_line":"            exceptions.handle(self.request)"},{"line_number":147,"context_line":"        if (volume.status \u003d\u003d \u0027in-use\u0027):"},{"line_number":148,"context_line":"            context[\u0027attached\u0027] \u003d True"},{"line_number":149,"context_line":"            context[\u0027form\u0027].set_warning(_(\"This volume is currently \""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F80kc%3D","line":146,"updated":"2013-12-20 00:20:05.000000000","message":"There should probably be an exception message here. Also, if an exception happens, \u0027volume\u0027 will be undefined when used below. If we don\u0027t know whether the volume is attached or not, should we continue anyway or make the user click \"Create snapshot\" again?","commit_id":"e7580017976c6bc1c4ddfc5ca874e63594ff5236"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"303c0a9dcfb93c5725a12bf5850ce5a6d171c25d","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        try:"},{"line_number":144,"context_line":"            volume \u003d cinder.volume_get(self.request, context[\u0027volume_id\u0027])"},{"line_number":145,"context_line":"        except Exception:"},{"line_number":146,"context_line":"            exceptions.handle(self.request)"},{"line_number":147,"context_line":"        if (volume.status \u003d\u003d \u0027in-use\u0027):"},{"line_number":148,"context_line":"            context[\u0027attached\u0027] \u003d True"},{"line_number":149,"context_line":"            context[\u0027form\u0027].set_warning(_(\"This volume is currently \""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F8z%2FE%3D","line":146,"in_reply_to":"AAAATn%2F80kc%3D","updated":"2013-12-20 02:36:49.000000000","message":"I\u0027ll combine this and below try-except into one block, IMO, if an exception happens, we should not continue.","commit_id":"e7580017976c6bc1c4ddfc5ca874e63594ff5236"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"274328d202c2163922ad5cac6bb62065c4f431f3","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            context[\u0027form\u0027].set_warning(_(\"This volume is currently \""},{"line_number":150,"context_line":"                                \"attached to an instance. In some cases, \""},{"line_number":151,"context_line":"                                \"creating a snapshot from an attached volume \""},{"line_number":152,"context_line":"                                \"can result in a corrupted snapshot.\"))"},{"line_number":153,"context_line":"        try:"},{"line_number":154,"context_line":"            context[\u0027usages\u0027] \u003d quotas.tenant_limit_usages(self.request)"},{"line_number":155,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F84uc%3D","line":152,"updated":"2013-12-19 06:51:58.000000000","message":"The indent level is better to match an opening parenthesis. Otherwise it is better to move \"_(\" to new line.","commit_id":"e7580017976c6bc1c4ddfc5ca874e63594ff5236"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"062e4633d8cd5a4d6f2059e3ca2672454231e6f8","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                                \"attached to an instance. In some cases, \""},{"line_number":151,"context_line":"                                \"creating a snapshot from an attached volume \""},{"line_number":152,"context_line":"                                \"can result in a corrupted snapshot.\"))"},{"line_number":153,"context_line":"        try:"},{"line_number":154,"context_line":"            context[\u0027usages\u0027] \u003d quotas.tenant_limit_usages(self.request)"},{"line_number":155,"context_line":"        except Exception:"},{"line_number":156,"context_line":"            exceptions.handle(self.request)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F83kg%3D","line":153,"updated":"2013-12-19 12:02:42.000000000","message":"I think we can just combine this into one try-except block, it is handled the same way anyway.","commit_id":"e7580017976c6bc1c4ddfc5ca874e63594ff5236"}]}