)]}'
{"openstack_dashboard/dashboards/project/access_and_security/keypairs/tables.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"184fd5e8631017e1c18febb08308f4baa6402093","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def allowed(self, request, keypair\u003dNone):"},{"line_number":48,"context_line":"        usages \u003d quotas.tenant_quota_usages(request)"},{"line_number":49,"context_line":"        count \u003d len(self.table.data)"},{"line_number":50,"context_line":"        if usages[\u0027key_pairs\u0027][\u0027quota\u0027] \u003c\u003d count:"},{"line_number":51,"context_line":"            if \"disabled\" not in self.classes:"},{"line_number":52,"context_line":"                self.classes \u003d [c for c in self.classes] + [\u0027disabled\u0027]"},{"line_number":53,"context_line":"                self.verbose_name \u003d string_concat(self.verbose_name, \u0027 \u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9g%2Bo%3D","line":50,"updated":"2013-12-10 17:54:38.000000000","message":"For simplicity, you can just check if [\u0027key_pairs\u0027][\u0027available\u0027] is greater than zero.\n\nAlso, not sure if \u0027key_pairs\u0027 is always available in nova. It would be a bonus if you can make the code work even if \u0027keypairs\u0027 is not available in the usages. \nSomething like: usages.get(\u0027key_pairs\u0027, {}).get(\u0027available\u0027, 1) \n\nThanks for the patch.","commit_id":"dd1c12f33234dc304f083e4adb3d66aff5e3aef0"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"5a9755d0c4a7ce65c912f1bfbed58dfd5035f7c2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def allowed(self, request, keypair\u003dNone):"},{"line_number":48,"context_line":"        usages \u003d quotas.tenant_quota_usages(request)"},{"line_number":49,"context_line":"        count \u003d len(self.table.data)"},{"line_number":50,"context_line":"        if usages[\u0027key_pairs\u0027][\u0027quota\u0027] \u003c\u003d count:"},{"line_number":51,"context_line":"            if \"disabled\" not in self.classes:"},{"line_number":52,"context_line":"                self.classes \u003d [c for c in self.classes] + [\u0027disabled\u0027]"},{"line_number":53,"context_line":"                self.verbose_name \u003d string_concat(self.verbose_name, \u0027 \u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9e5A%3D","line":50,"in_reply_to":"AAAATn%2F9g%2Bo%3D","updated":"2013-12-11 01:59:35.000000000","message":"in fact, there is no ‘available’ attribute in key_pairs dict.\n\nI\u0027ll change the code work like: if usages.get(\u0027key_pairs\u0027, {}) and (usages[\u0027key_pairs\u0027][\u0027quota\u0027] \u003c\u003d count):","commit_id":"dd1c12f33234dc304f083e4adb3d66aff5e3aef0"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"f09f657aca5b2f7275d9b862480debc1f8e9a19d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def allowed(self, request, keypair\u003dNone):"},{"line_number":48,"context_line":"        usages \u003d quotas.tenant_quota_usages(request)"},{"line_number":49,"context_line":"        count \u003d len(self.table.data)"},{"line_number":50,"context_line":"        if usages.get(\u0027key_pairs\u0027, {}) and\\"},{"line_number":51,"context_line":"           usages[\u0027key_pairs\u0027][\u0027quota\u0027] \u003c\u003d count:"},{"line_number":52,"context_line":"            if \"disabled\" not in self.classes:"},{"line_number":53,"context_line":"                self.classes \u003d [c for c in self.classes] + [\u0027disabled\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9PoI%3D","line":50,"updated":"2013-12-13 15:22:48.000000000","message":"Just some nits:\n- The default value of empty {} is not needed.\n- Use parenthesis to wrap the two lines\n\nFrom hacking guide: \"Long lines should be wrapped in parentheses in preference to using a backslash for line continuation.\"","commit_id":"11b1271b5cc5736db3af27bfe38a1297bf922fc7"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"98632ffc1cb6c8290e6cdccac2c4191d065d3340","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                                                  _(\"(Quota exceeded)\"))"},{"line_number":56,"context_line":"        else:"},{"line_number":57,"context_line":"            self.verbose_name \u003d _(\"Create Keypair\")"},{"line_number":58,"context_line":"            classes \u003d [c for c in self.classes if c !\u003d \"disabled\"]"},{"line_number":59,"context_line":"            self.classes \u003d classes"},{"line_number":60,"context_line":"        return True"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F8xwQ%3D","line":58,"updated":"2013-12-20 12:41:08.000000000","message":"In which case \u0027c\u0027 will be \u003d\u003d \u0027disabled\u0027 here?","commit_id":"31f7bb49a0982a851b9ee55cf1daeb769355c2d2"}]}
