)]}'
{"horizon/static/horizon/js/angular/membership.js":[{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"2a42dafaa1d7594c9a27d81948e705bde16b9b0d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"angular.module(\u0027horizonApp\u0027).directive(\u0027hrMembership\u0027,"},{"line_number":2,"context_line":"["},{"line_number":3,"context_line":"    function() {"},{"line_number":4,"context_line":"        return {"}],"source_content_type":"text/javascript","patch_set":4,"id":"AAAATn%2F%2BmmU%3D","line":1,"updated":"2013-11-22 23:44:20.000000000","message":"as long as you do not inject any dependency the array syntax is not needed, ie: directive(\u0027name\u0027, function(){....})","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"2a42dafaa1d7594c9a27d81948e705bde16b9b0d","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"        };"},{"line_number":22,"context_line":"    }]);"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"angular.module(\u0027horizonApp\u0027).factory(\u0027MembershipFactory\u0027, function() {"},{"line_number":25,"context_line":"    return {"},{"line_number":26,"context_line":"        inGroup: function(group, membership) {"}],"source_content_type":"text/javascript","patch_set":4,"id":"AAAATn%2F%2Bk6Q%3D","line":23,"updated":"2013-11-22 23:44:20.000000000","message":"Do not recall angular.module each time, you can link each use in the same file angular.module(\u0027name\u0027).factory(....).directive(....).controller(...).controller(....).factory(....) etc","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"a4bdc0f9d702d3d116f00301580451d00b678e7e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        },"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        getRoleMembers: function(members, role_id) {"},{"line_number":48,"context_line":"            var role_members \u003d [];"},{"line_number":49,"context_line":"            // angular.forEach redefines this"},{"line_number":50,"context_line":"            var that \u003d this;"},{"line_number":51,"context_line":"            angular.forEach(members, function(member) {"}],"source_content_type":"text/javascript","patch_set":4,"id":"AAAATn%2F%2Bkms%3D","line":48,"updated":"2013-11-23 00:12:44.000000000","message":"not exactly, this represent the javascript function which you are into, so every time function(){...} is called this change for the current function","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"a4bdc0f9d702d3d116f00301580451d00b678e7e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            // angular.forEach redefines this"},{"line_number":62,"context_line":"            var that \u003d this;"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"            angular.forEach(roles, function(role) {"},{"line_number":65,"context_line":"                if(that.hasRole(member, role.id)) {"},{"line_number":66,"context_line":"                    if (this.length \u003d\u003d\u003d 2){"},{"line_number":67,"context_line":"                        this.push(\u0027...\u0027)"}],"source_content_type":"text/javascript","patch_set":4,"id":"AAAATn%2F%2Bkl0%3D","line":64,"updated":"2013-11-23 00:12:44.000000000","message":"in getRoleMembers you do not pass role_members as the this attribute, but here you do. It is just a choice you have to do, with the use of that, maybe keeping the variable name is better to avoid confusion","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"a4bdc0f9d702d3d116f00301580451d00b678e7e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            return name.join(\u0027,\u0027);"},{"line_number":75,"context_line":"        },"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        hasRole: function(member, roleId) {"},{"line_number":78,"context_line":"            var index \u003d member.roles.indexOf(roleId);"},{"line_number":79,"context_line":"            return index \u003e\u003d 0;"},{"line_number":80,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":4,"id":"AAAATn%2F%2Bklg%3D","line":77,"updated":"2013-11-23 00:12:44.000000000","message":"no variable needed: \n\nreturn member.roles.indexOf(roleId) \u003e\u003d 0;","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"a4bdc0f9d702d3d116f00301580451d00b678e7e","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            $scope.parseMembers($scope.data_list, $scope.current_membership);"},{"line_number":100,"context_line":"        };"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        $scope.hasRole \u003d function(member, roleId) {"},{"line_number":103,"context_line":"            return MembershipFactory.hasRole(member, roleId);"},{"line_number":104,"context_line":"        };"}],"source_content_type":"text/javascript","patch_set":4,"id":"AAAATn%2F%2BklE%3D","line":101,"updated":"2013-11-23 00:12:44.000000000","message":"I really do not like this, we really need the karma testing framework","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"a4bdc0f9d702d3d116f00301580451d00b678e7e","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        $scope.makeGroup \u003d function(id, name) {"},{"line_number":107,"context_line":"            return { id: id, name: name, roles: [] }"},{"line_number":108,"context_line":"        };"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        $scope.toggleRole \u003d function(member, role) {"},{"line_number":111,"context_line":"            if(MembershipFactory.hasRole(member, role.id)) {"},{"line_number":112,"context_line":"                var index \u003d member.roles.indexOf(role.id);"}],"source_content_type":"text/javascript","patch_set":4,"id":"AAAATn%2F%2Bkjg%3D","line":109,"updated":"2013-11-23 00:12:44.000000000","message":"Why don\u0027t you pass role.id directly, we do not use other members of role","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"a4bdc0f9d702d3d116f00301580451d00b678e7e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            return { id: id, name: name, roles: [] }"},{"line_number":108,"context_line":"        };"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        $scope.toggleRole \u003d function(member, role) {"},{"line_number":111,"context_line":"            if(MembershipFactory.hasRole(member, role.id)) {"},{"line_number":112,"context_line":"                var index \u003d member.roles.indexOf(role.id);"},{"line_number":113,"context_line":"                member.roles.splice(index, 1);"}],"source_content_type":"text/javascript","patch_set":4,"id":"AAAATn%2F%2Bkjk%3D","line":110,"updated":"2013-11-23 00:12:44.000000000","message":"redundancy\ndo not declare variables in the middle of the function\n\nhttp://pastebin.com/XYC21y2G","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"a4bdc0f9d702d3d116f00301580451d00b678e7e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            }"},{"line_number":121,"context_line":"        }"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        $scope.parseMembers \u003d function(data, members) {"},{"line_number":124,"context_line":"            for (var group in data) {"},{"line_number":125,"context_line":"                g \u003d $scope.makeGroup(group, data[group]);"},{"line_number":126,"context_line":"                if(MembershipFactory.inGroup(g, members) \u003d\u003d\u003d true) {"}],"source_content_type":"text/javascript","patch_set":4,"id":"AAAATn%2F%2BkjM%3D","line":123,"updated":"2013-11-23 00:12:44.000000000","message":"angular.forEach, never ever use in javascript without hasOwnProperty","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"a4bdc0f9d702d3d116f00301580451d00b678e7e","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        $scope.parseMembers \u003d function(data, members) {"},{"line_number":124,"context_line":"            for (var group in data) {"},{"line_number":125,"context_line":"                g \u003d $scope.makeGroup(group, data[group]);"},{"line_number":126,"context_line":"                if(MembershipFactory.inGroup(g, members) \u003d\u003d\u003d true) {"},{"line_number":127,"context_line":"                    $scope.members.push(g);"},{"line_number":128,"context_line":"                } else {"}],"source_content_type":"text/javascript","patch_set":4,"id":"AAAATn%2F%2Bkis%3D","line":125,"updated":"2013-11-23 00:12:44.000000000","message":"use ternary operator\n\nMembershipFactory.inGroup(g, members)? $scope.members.push(g): $scope.available.push(g);","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"a4bdc0f9d702d3d116f00301580451d00b678e7e","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            return MembershipFactory.printLongList(member, $scope.all_roles);"},{"line_number":136,"context_line":"        }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        $scope.addMember \u003d function(member) {"},{"line_number":139,"context_line":"            member.roles.push($scope.default_role_id);"},{"line_number":140,"context_line":"            $scope.members.push(member);"},{"line_number":141,"context_line":"            var index \u003d $scope.available.indexOf(member);"}],"source_content_type":"text/javascript","patch_set":4,"id":"AAAATn%2F%2BkiA%3D","line":138,"updated":"2013-11-23 00:12:44.000000000","message":"$scope.default_role_id can be passed as an argument of the function","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"a4bdc0f9d702d3d116f00301580451d00b678e7e","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        $scope.addMember \u003d function(member) {"},{"line_number":139,"context_line":"            member.roles.push($scope.default_role_id);"},{"line_number":140,"context_line":"            $scope.members.push(member);"},{"line_number":141,"context_line":"            var index \u003d $scope.available.indexOf(member);"},{"line_number":142,"context_line":"            $scope.available.splice(index, 1);"},{"line_number":143,"context_line":""}],"source_content_type":"text/javascript","patch_set":4,"id":"AAAATn%2F%2Bkh0%3D","line":140,"updated":"2013-11-23 00:12:44.000000000","message":"declare all variables at the top of the function separated by comas","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"a4bdc0f9d702d3d116f00301580451d00b678e7e","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            $scope.members.push(member);"},{"line_number":141,"context_line":"            var index \u003d $scope.available.indexOf(member);"},{"line_number":142,"context_line":"            $scope.available.splice(index, 1);"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"            var role_members \u003d MembershipFactory.getRoleMembers($scope.members, $scope.default_role_id);"},{"line_number":145,"context_line":"            horizon.membership.update_role_lists($scope.stepSlug, $scope.default_role_id, role_members);"},{"line_number":146,"context_line":"        };"}],"source_content_type":"text/javascript","patch_set":4,"id":"AAAATn%2F%2Bkhs%3D","line":143,"updated":"2013-11-23 00:12:44.000000000","message":"definitely pass $scope.default_role_id as a parameter","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"a4bdc0f9d702d3d116f00301580451d00b678e7e","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        $scope.removeMember \u003d function(member) {"},{"line_number":149,"context_line":"            member.roles \u003d [];"},{"line_number":150,"context_line":"            $scope.available.push(member);"},{"line_number":151,"context_line":"            var index \u003d $scope.members.indexOf(member);"},{"line_number":152,"context_line":"            $scope.members.splice(index, 1);"},{"line_number":153,"context_line":""}],"source_content_type":"text/javascript","patch_set":4,"id":"AAAATn%2F%2Bkhk%3D","line":150,"updated":"2013-11-23 00:12:44.000000000","message":"variable at top","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"2f2d8907ad90dfa59b41cda425852222bfcaf6f5","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        },"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        getRoleMembers: function(members, role_id) {"},{"line_number":46,"context_line":"            var role_members \u003d [];"},{"line_number":47,"context_line":"            var that \u003d this;"},{"line_number":48,"context_line":"            angular.forEach(members, function(member) {"},{"line_number":49,"context_line":"                if(that.hasRole(member, role_id)) {"}],"source_content_type":"text/javascript","patch_set":5,"id":"AAAATn%2F%2BSm8%3D","line":46,"updated":"2013-11-27 20:06:57.000000000","message":"that \u003d this not needed and confusing\n\nangular.forEach(members, function(member) {\n  if(this.hasRole(member, role_id)) {\n    role_members.push(member.id);\n  }\n}, this);\nPassing argument to be the this object inside the function allow you to avoid storing this in a separated variable.","commit_id":"1096f50da7892b81a4f07618025f7c773e3c2d6d"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"2f2d8907ad90dfa59b41cda425852222bfcaf6f5","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        printLongList: function(member, roles) {"},{"line_number":57,"context_line":"            var name \u003d [];"},{"line_number":58,"context_line":"            var that \u003d this;"},{"line_number":59,"context_line":"            angular.forEach(roles, function(role) {"},{"line_number":60,"context_line":"                if(that.hasRole(member, role.id)) {"},{"line_number":61,"context_line":"                    if (this.length \u003d\u003d\u003d 2){"}],"source_content_type":"text/javascript","patch_set":5,"id":"AAAATn%2F%2BSm4%3D","line":58,"updated":"2013-11-27 20:06:57.000000000","message":"same as line 47","commit_id":"1096f50da7892b81a4f07618025f7c773e3c2d6d"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"2f2d8907ad90dfa59b41cda425852222bfcaf6f5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            var that \u003d this;"},{"line_number":59,"context_line":"            angular.forEach(roles, function(role) {"},{"line_number":60,"context_line":"                if(that.hasRole(member, role.id)) {"},{"line_number":61,"context_line":"                    if (this.length \u003d\u003d\u003d 2){"},{"line_number":62,"context_line":"                        this.push(\u0027...\u0027)"},{"line_number":63,"context_line":"                        return"},{"line_number":64,"context_line":"                    } else {"}],"source_content_type":"text/javascript","patch_set":5,"id":"AAAATn%2F%2BSmY%3D","line":61,"updated":"2013-11-27 20:06:57.000000000","message":"missing semicolons","commit_id":"1096f50da7892b81a4f07618025f7c773e3c2d6d"}],"horizon/static/horizon/js/horizon.membership.js":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"57c0428f1454754fa3f35d4b89dbd311bbf2d0fa","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    modal \u003d $(\u0027#modal_wrapper .workflow\u0027);"},{"line_number":215,"context_line":"    if(!modal.hasClass(\"ng-scope\")) {"},{"line_number":216,"context_line":"        angular.bootstrap(modal, [\u0027horizonApp\u0027]);"},{"line_number":217,"context_line":"    }"},{"line_number":218,"context_line":"  }"},{"line_number":219,"context_line":"};"}],"source_content_type":"text/javascript","patch_set":3,"id":"AAAATn%2F%2BtOw%3D","line":217,"updated":"2013-11-21 09:36:12.000000000","message":"this prevents us from moving ng-app directive into \u003cbody\u003e tag. There is probably a reason you do it this way, which has to do with modals...","commit_id":"70a8b30ba659bc2804762ce1eeb9716fac7a5fc4"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"2a42dafaa1d7594c9a27d81948e705bde16b9b0d","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    role_list.push(data_id);"},{"line_number":152,"context_line":"    horizon.membership.update_role_lists(step_slug, role_id, role_list);"},{"line_number":153,"context_line":"  },"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"  compile_modal_template: function() {"},{"line_number":156,"context_line":"    var modal \u003d $(\u0027#modal_wrapper .modal-body\u0027);"},{"line_number":157,"context_line":"    var html \u003d modal.html();"}],"source_content_type":"text/javascript","patch_set":4,"id":"AAAATn%2F%2Bkp8%3D","line":154,"updated":"2013-11-22 23:44:20.000000000","message":"look at http://plnkr.co/edit/gRvsJhGCglnQS0tDSjOV?p\u003dpreview it is a cleanest way to do this, the goal of using angular is to avoid the use of jquery","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"2a42dafaa1d7594c9a27d81948e705bde16b9b0d","unresolved":false,"context_lines":[{"line_number":168,"context_line":"  workflow_init: function(modal, step_slug, step_id) {"},{"line_number":169,"context_line":"    // fix the dropdown menu overflow issues"},{"line_number":170,"context_line":"    $(\".tab-content, .workflow\").addClass(\"dropdown_fix\");"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    $(modal).find(\u0027form\u0027).each( function () {"},{"line_number":173,"context_line":"        var $form \u003d $(this);"},{"line_number":174,"context_line":""}],"source_content_type":"text/javascript","patch_set":4,"id":"AAAATn%2F%2Bkp4%3D","line":171,"updated":"2013-11-22 23:44:20.000000000","message":"this has to be handle by modal controller","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"a23b142ba90dbbb7af7f8595bdb15c0b07a64d41","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  /*"},{"line_number":48,"context_line":"   * Initializes an associative array mapping data ids to display names."},{"line_number":49,"context_line":"   **/"},{"line_number":50,"context_line":"  init_data_list: function(step_slug) {"},{"line_number":51,"context_line":"    horizon.membership.data[step_slug] \u003d [];"},{"line_number":52,"context_line":"    angular.forEach($(this.get_role_element(step_slug, \"\")).find(\"option\"), function (option) {"},{"line_number":53,"context_line":"      horizon.membership.data[step_slug][option.value] \u003d option.text;"}],"source_content_type":"text/javascript","patch_set":7,"id":"AAAAUH%2F93Wo%3D","line":50,"updated":"2014-02-03 05:41:06.000000000","message":"Should be an object. It was done right in a previous commits, so i assume it\u0027s just a merging error.","commit_id":"04399164b085aa5d79cb96e81bd4ef1582794d53"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"a23b142ba90dbbb7af7f8595bdb15c0b07a64d41","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  /*"},{"line_number":58,"context_line":"   * Initializes an associative array mapping role ids to role names."},{"line_number":59,"context_line":"   **/"},{"line_number":60,"context_line":"  init_role_list: function(step_slug) {"},{"line_number":61,"context_line":"    horizon.membership.roles[step_slug] \u003d [];"},{"line_number":62,"context_line":"    angular.forEach($(\u0027label[for^\u003d\"id_\u0027 + step_slug + \u0027_role_\"]\u0027), function(role) {"},{"line_number":63,"context_line":"      var id \u003d horizon.membership.get_field_id($(role).attr(\u0027for\u0027));"}],"source_content_type":"text/javascript","patch_set":7,"id":"AAAAUH%2F93Wg%3D","line":60,"updated":"2014-02-03 05:41:06.000000000","message":"Should be an object too.","commit_id":"04399164b085aa5d79cb96e81bd4ef1582794d53"}],"horizon/static/horizon/tests/membership.js":[{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"2f2d8907ad90dfa59b41cda425852222bfcaf6f5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    ok(ctrlScope.makeGroup(\u00275\u0027, \u0027member\u0027).id \u003d\u003d\u003d \u00275\u0027, \"Make group sets id correctly\");"},{"line_number":58,"context_line":"});"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"test(\"Role show prints roles correctly\", function() {"},{"line_number":61,"context_line":"    var roles \u003d { 1: \"role1\", 2: \"role2\" }"},{"line_number":62,"context_line":"    var croles \u003d factory.convertRoles(roles);"},{"line_number":63,"context_line":"    ctrlScope.all_roles \u003d croles;"}],"source_content_type":"text/javascript","patch_set":5,"id":"AAAATn%2F%2BSiU%3D","line":60,"updated":"2013-11-27 20:06:57.000000000","message":"missing semicolon","commit_id":"1096f50da7892b81a4f07618025f7c773e3c2d6d"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"2f2d8907ad90dfa59b41cda425852222bfcaf6f5","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    ok(str.indexOf(\u0027role2\u0027) \u003e\u003d 0, \u0027Show Role contains role names\u0027);"},{"line_number":68,"context_line":"});"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"test(\"Add member adds member\", function() {"},{"line_number":71,"context_line":"    var roles \u003d { 1: \"role1\", 2: \"role2\" }"},{"line_number":72,"context_line":"    var croles \u003d factory.convertRoles(roles);"},{"line_number":73,"context_line":"    ctrlScope.all_roles \u003d croles;"}],"source_content_type":"text/javascript","patch_set":5,"id":"AAAATn%2F%2BSic%3D","line":70,"updated":"2013-11-27 20:06:57.000000000","message":"missing semicolon","commit_id":"1096f50da7892b81a4f07618025f7c773e3c2d6d"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"2f2d8907ad90dfa59b41cda425852222bfcaf6f5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"test(\"Add member adds member\", function() {"},{"line_number":71,"context_line":"    var roles \u003d { 1: \"role1\", 2: \"role2\" }"},{"line_number":72,"context_line":"    var croles \u003d factory.convertRoles(roles);"},{"line_number":73,"context_line":"    ctrlScope.all_roles \u003d croles;"},{"line_number":74,"context_line":"    var member \u003d { id: 1, name: \u0027member\u0027, roles: [] }"},{"line_number":75,"context_line":"    ctrlScope.available.push(member);"},{"line_number":76,"context_line":"    ctrlScope.stepSlug \u003d \u0027testslug\u0027;"}],"source_content_type":"text/javascript","patch_set":5,"id":"AAAATn%2F%2BSik%3D","line":73,"updated":"2013-11-27 20:06:57.000000000","message":"missing semicolon","commit_id":"1096f50da7892b81a4f07618025f7c773e3c2d6d"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"2f2d8907ad90dfa59b41cda425852222bfcaf6f5","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    var croles \u003d factory.convertRoles(roles);"},{"line_number":88,"context_line":"    ctrlScope.all_roles \u003d croles;"},{"line_number":89,"context_line":"    var member \u003d { id: 1, name: \u0027member\u0027, roles: [] }"},{"line_number":90,"context_line":"    ctrlScope.members.push(member);"},{"line_number":91,"context_line":"    ctrlScope.default_role_id \u003d \u00271\u0027"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    ctrlScope.removeMember(member);"}],"source_content_type":"text/javascript","patch_set":5,"id":"AAAATn%2F%2BSiw%3D","line":90,"updated":"2013-11-27 20:06:57.000000000","message":"missing semicolon","commit_id":"1096f50da7892b81a4f07618025f7c773e3c2d6d"}],"horizon/templates/horizon/common/_workflow_step_update_members.html":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"96e53c89fac4bb3cb2f5d35cbdf4bd4bbbb55a55","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003cnoscript\u003e\u003ch3\u003e{{ step }}\u003c/h3\u003e\u003c/noscript\u003e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"\u003cdiv ng-app\u003d\"horizonApp\"\u003e"},{"line_number":6,"context_line":"    \u003cdiv hr-membership step\u003d\"\u0027{{ step }}\u0027\""},{"line_number":7,"context_line":"                       step-slug\u003d\"\u0027{{ step.slug }}\u0027\""},{"line_number":8,"context_line":"                       step-show-roles\u003d\"\u0027{{ step.show_roles }}\u0027\""}],"source_content_type":"text/html","patch_set":2,"id":"AAAATn%2F%2BwkQ%3D","line":5,"updated":"2013-11-20 15:39:17.000000000","message":"This div should go away as it is going to body tag in the other patch.","commit_id":"066ce40ea54d00b70b57ba91da68c5e7d0f8176b"},{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"57c0428f1454754fa3f35d4b89dbd311bbf2d0fa","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003cnoscript\u003e\u003ch3\u003e{{ step }}\u003c/h3\u003e\u003c/noscript\u003e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"\u003cdiv ng-app\u003d\"horizonApp\"\u003e"},{"line_number":6,"context_line":"    \u003cdiv hr-membership step\u003d\"\u0027{{ step }}\u0027\""},{"line_number":7,"context_line":"                       step-slug\u003d\"\u0027{{ step.slug }}\u0027\""},{"line_number":8,"context_line":"                       step-show-roles\u003d\"\u0027{{ step.show_roles }}\u0027\""}],"source_content_type":"text/html","patch_set":3,"id":"AAAATn%2F%2BtQA%3D","line":5,"updated":"2013-11-21 09:36:12.000000000","message":"This should go away, at best ng-app directive should be called on \u003cbody\u003e tag in base.html template. I can see, that you are initializing horizonApp using angular.bootstrap in horizon.membership.js could you elaborate why it is needed?","commit_id":"70a8b30ba659bc2804762ce1eeb9716fac7a5fc4"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"2a42dafaa1d7594c9a27d81948e705bde16b9b0d","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003cnoscript\u003e\u003ch3\u003e{{ step }}\u003c/h3\u003e\u003c/noscript\u003e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"\u003cdiv\u003e"},{"line_number":6,"context_line":"    \u003cdiv hr-membership step\u003d\"\u0027{{ step }}\u0027\""},{"line_number":7,"context_line":"                       step-slug\u003d\"\u0027{{ step.slug }}\u0027\""},{"line_number":8,"context_line":"                       step-show-roles\u003d\"\u0027{{ step.show_roles }}\u0027\""}],"source_content_type":"text/html","patch_set":4,"id":"AAAATn%2F%2Bkqo%3D","line":5,"updated":"2013-11-22 23:44:20.000000000","message":"inject http into the controller and load a json instead of using django html template injection\n\nhere is an example on how I think we can do this: http://plnkr.co/edit/gRvsJhGCglnQS0tDSjOV?p\u003dcatalogue","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"2a42dafaa1d7594c9a27d81948e705bde16b9b0d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"                       step-members-list-title\u003d\"\u0027{{ step.members_list_title }}\u0027\""},{"line_number":12,"context_line":"                       step-no-available-text\u003d\"\u0027{{ step.no_available_text}}\u0027\""},{"line_number":13,"context_line":"                       step-no-members-text\u003d\"\u0027{{ step.no_members_text }}\u0027\"\u003e"},{"line_number":14,"context_line":"    \u003c/div\u003e"},{"line_number":15,"context_line":"    \u003cscript type\u003d\"text/ng-template\" id\u003d\"membership_workflow.html\"\u003e"},{"line_number":16,"context_line":"        \u003cdiv class\u003d\"membership\"\u003e"},{"line_number":17,"context_line":"            \u003ch3 ng-bind\u003d\"step\"\u003e\u003c/h3\u003e"}],"source_content_type":"text/html","patch_set":4,"id":"AAAATn%2F%2Bk20%3D","line":14,"updated":"2013-11-22 23:44:20.000000000","message":"I had prefer you put the template into a dedicated file, it is more readable. The div hr-membership div can be contruct into the controller compiled and then injected with an ng-bind (contact me if it is not clear)","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":7976,"name":"Maxime Vidori","email":"mvidori@redhat.com","username":"MaxV"},"change_message_id":"2a42dafaa1d7594c9a27d81948e705bde16b9b0d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  {% include \"horizon/common/_form_fields.html\" %}"},{"line_number":93,"context_line":"\u003c/div\u003e"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"\u003cscript\u003e"},{"line_number":96,"context_line":"  if (typeof $ !\u003d\u003d \u0027undefined\u0027) {"},{"line_number":97,"context_line":"    horizon.membership.workflow_init($(\".workflow\"), \"{{ step.slug }}\", \"{{ step.get_id }}\");"},{"line_number":98,"context_line":"  } else {"}],"source_content_type":"text/html","patch_set":4,"id":"AAAATn%2F%2BkqE%3D","line":95,"updated":"2013-11-22 23:44:20.000000000","message":"this has to be done into the modal controller","commit_id":"46e6daf5c8db5c22bcd3b3498cdb7ce988d4616e"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"88fc562749e35a2ed4c145b1d38448ab6df2cd5d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                    \u003cspan class\u003d\"members_title\" ng-bind\u003d\"stepAvailableListTitle\"\u003e\u003c/span\u003e"},{"line_number":24,"context_line":"                    \u003cinput type\u003d\"text\" name\u003d\"available_{$ stepSlug $}_filter\" id\u003d\"available_{$ stepSlug $}\""},{"line_number":25,"context_line":"                           ng-model\u003d\"available_filter.name\" class\u003d\"filter\" ng-class\u003d\"{$ stepSlug $}_filter\""},{"line_number":26,"context_line":"                           placeholder\u003d\"Filter\"/\u003e"},{"line_number":27,"context_line":"                  \u003c/div\u003e"},{"line_number":28,"context_line":"                \u003c/div\u003e"},{"line_number":29,"context_line":"                \u003cdiv class\u003d\"right\"\u003e"}],"source_content_type":"text/html","patch_set":8,"id":"AAAAUH%2F9wM4%3D","line":26,"updated":"2014-02-04 16:40:57.000000000","message":"\"Filter\" should be \"{% trans \"Filter\" %}\" (https://review.openstack.org/#/c/51832/)","commit_id":"b4f6b9f47c5f799b4ecc410aba5c435c00fba089"},{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"88fc562749e35a2ed4c145b1d38448ab6df2cd5d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                    \u003cspan class\u003d\"members_title\" ng-bind\u003d\"stepMembersListTitle\"\u003e\u003c/span\u003e"},{"line_number":32,"context_line":"                    \u003cinput type\u003d\"text\" name\u003d\"{$ stepSlug $}_members_filter\" id\u003d\"{$ stepSlug $}_members\""},{"line_number":33,"context_line":"                           ng-model\u003d\"members_filter.name\" class\u003d\"filter\" ng-class\u003d\"{$ stepSlug $}_filter\""},{"line_number":34,"context_line":"                           placeholder\u003d\"Filter\"/\u003e"},{"line_number":35,"context_line":"                  \u003c/div\u003e"},{"line_number":36,"context_line":"                \u003c/div\u003e"},{"line_number":37,"context_line":"              \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":8,"id":"AAAAUH%2F9wM0%3D","line":34,"updated":"2014-02-04 16:40:57.000000000","message":"\"Filter\" too.","commit_id":"b4f6b9f47c5f799b4ecc410aba5c435c00fba089"}],"horizon/templates/horizon/qunit.html":[{"author":{"_account_id":10127,"name":"Kirill Izotov","email":"enykeev@stackstorm.com","username":"enykeev"},"change_message_id":"88fc562749e35a2ed4c145b1d38448ab6df2cd5d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    \u003cscript type\u003d\"text/javascript\" src\u003d\"{{ STATIC_URL }}horizon/tests/templates.js\"\u003e\u003c/script\u003e"},{"line_number":15,"context_line":"    \u003cscript type\u003d\"text/javascript\" src\u003d\"{{ STATIC_URL }}horizon/tests/tables.js\"\u003e\u003c/script\u003e"},{"line_number":16,"context_line":"    \u003cscript type\u003d\"text/javascript\" src\u003d\"{{ STATIC_URL }}horizon/tests/membership.js\"\u003e\u003c/script\u003e"},{"line_number":17,"context_line":"    \u003cscript type\u003d\"text/javascript\" src\u003d\"{{ STATIC_URL }}horizon/tests/jshint.js\"\u003e\u003c/script\u003e"},{"line_number":18,"context_line":"    {% comment %}End test modules.{% endcomment %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    {% include \"horizon/_scripts.html\" %}"}],"source_content_type":"text/html","patch_set":8,"id":"AAAAUH%2F9wRw%3D","line":17,"updated":"2014-02-04 16:40:57.000000000","message":"Why do we need jshint here? Seems like one more merging mistake. Looks like it was added in another commit during this review and then removed because of the licensing issues (https://review.openstack.org/#/c/68268/).","commit_id":"b4f6b9f47c5f799b4ecc410aba5c435c00fba089"}]}
