)]}'
{"horizon/test/tests/utils.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"60867fea0c4eeefc277ca4d653ff00984d95bfdb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from horizon.test import helpers as test"},{"line_number":23,"context_line":"from horizon.utils import fields"},{"line_number":24,"context_line":"from horizon.utils import secret_key"},{"line_number":25,"context_line":"from django.template import Context, Template"},{"line_number":26,"context_line":"# we have to import the filter in order to register it"},{"line_number":27,"context_line":"from horizon.utils.filters import parse_isotime  # noqa"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BoHo%3D","line":25,"updated":"2013-11-22 09:31:04.000000000","message":"Please use module level import and move it around L.20 if there is no import ordering problem.","commit_id":"2ca12a72facd2528eb8f9e2ffbdde57d3a24a106"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d60d80ddcac3b2fd81cf976ed71ed8b9549d22e0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from horizon.test import helpers as test"},{"line_number":23,"context_line":"from horizon.utils import fields"},{"line_number":24,"context_line":"from horizon.utils import secret_key"},{"line_number":25,"context_line":"from django.template import Context, Template"},{"line_number":26,"context_line":"# we have to import the filter in order to register it"},{"line_number":27,"context_line":"from horizon.utils.filters import parse_isotime  # noqa"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2Blp4%3D","line":25,"in_reply_to":"AAAATn%2F%2BoDg%3D","updated":"2013-11-22 19:08:03.000000000","message":"Akihiro, good catch! Thank you! I totally missed this one (facepalm)","commit_id":"2ca12a72facd2528eb8f9e2ffbdde57d3a24a106"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"c3770e842d8bd77e0204aeb02e865639ad6200aa","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from horizon.test import helpers as test"},{"line_number":23,"context_line":"from horizon.utils import fields"},{"line_number":24,"context_line":"from horizon.utils import secret_key"},{"line_number":25,"context_line":"from django.template import Context, Template"},{"line_number":26,"context_line":"# we have to import the filter in order to register it"},{"line_number":27,"context_line":"from horizon.utils.filters import parse_isotime  # noqa"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BoDg%3D","line":25,"in_reply_to":"AAAATn%2F%2BoHo%3D","updated":"2013-11-22 09:50:07.000000000","message":"how could this pass flake8 checks etc?\nIn my alphabetical ordering, \u0027d\u0027 comes before \u0027h\u0027... (just curious, and Akihiros comment applies nevertheless)","commit_id":"2ca12a72facd2528eb8f9e2ffbdde57d3a24a106"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"b6a13ba88fd1763734dc5437357d39b1b126971c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from horizon.utils import filters"},{"line_number":27,"context_line":"from horizon.utils import memoized"},{"line_number":28,"context_line":"# we have to import the filter in order to register it"},{"line_number":29,"context_line":"from horizon.utils.filters import parse_isotime  # noqa"},{"line_number":30,"context_line":"from horizon.utils import secret_key"},{"line_number":31,"context_line":"from horizon.utils import validators"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F88cA%3D","line":29,"updated":"2013-12-18 14:38:06.000000000","message":"Please move up to L#27","commit_id":"1fd8dc43d51791eca84fe1cc4cdb4d00063d8e3e"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"b6a13ba88fd1763734dc5437357d39b1b126971c","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        values_list \u003d []"},{"line_number":309,"context_line":"        for x in range(0, 5):"},{"line_number":310,"context_line":"            cache_calls(1)"},{"line_number":311,"context_line":"        self.assertEqual(len(values_list), 1)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F88bA%3D","line":311,"updated":"2013-12-18 14:38:06.000000000","message":"Blank line here.","commit_id":"1fd8dc43d51791eca84fe1cc4cdb4d00063d8e3e"}],"horizon/utils/filters.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"78398ec7f1141603f849e2da082827a0259bbd78","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@register.filter"},{"line_number":31,"context_line":"def parse_isotime(timestr, default\u003d\"Unknown\"):"},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":"    This duplicates oslo timeutils parse_isotime but with a"},{"line_number":34,"context_line":"    @register.filter annotation and a silent fallback on error."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Bp1I%3D","line":31,"updated":"2013-11-21 23:40:44.000000000","message":"Unknown should be localized.","commit_id":"a3e15cd23dd29fd75bbf83660aca66c536d6619e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0190d88cf19111020434895d6fe478ec5b0f43b1","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@register.filter"},{"line_number":32,"context_line":"def parse_isotime(timestr, default\u003d_(\"Unknown\")):"},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":"    This duplicates oslo timeutils parse_isotime but with a"},{"line_number":35,"context_line":"    @register.filter annotation and a silent fallback on error."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BiWw%3D","line":32,"updated":"2013-11-24 22:46:35.000000000","message":"django defaultfilters (time, date, timesince_filter, timeuntil_filter) return an empty string \u0027\u0027 for invalid input. IMO it is better to follow it if there is no problem. What do you think?\n\nWhat in my mind is:\n\n   def parse_isotime(timestr, default\u003dNone):\n\nand to change L.45 to:\n\n  return default or \u0027\u0027","commit_id":"f644daf130f1f1e41e4703429163d8a3cc71b12e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0190d88cf19111020434895d6fe478ec5b0f43b1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    @register.filter annotation and a silent fallback on error."},{"line_number":36,"context_line":"    \"\"\""},{"line_number":37,"context_line":"    try:"},{"line_number":38,"context_line":"        default \u003d iso8601.parse_date(timestr)"},{"line_number":39,"context_line":"    except iso8601.ParseError:"},{"line_number":40,"context_line":"        pass"},{"line_number":41,"context_line":"    except TypeError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BiXQ%3D","line":38,"updated":"2013-11-24 22:46:35.000000000","message":"I prefer to:\n\n    return iso8601.parse_data(timerstr)","commit_id":"f644daf130f1f1e41e4703429163d8a3cc71b12e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0190d88cf19111020434895d6fe478ec5b0f43b1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \"\"\""},{"line_number":37,"context_line":"    try:"},{"line_number":38,"context_line":"        default \u003d iso8601.parse_date(timestr)"},{"line_number":39,"context_line":"    except iso8601.ParseError:"},{"line_number":40,"context_line":"        pass"},{"line_number":41,"context_line":"    except TypeError:"},{"line_number":42,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BiXM%3D","line":39,"updated":"2013-11-24 22:46:35.000000000","message":"Please consider:\n\n    except (iso8601.ParseError, TypeError):\n        return default","commit_id":"f644daf130f1f1e41e4703429163d8a3cc71b12e"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"e58992ae02ed29efe876448b09651e539a90c57e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    try:"},{"line_number":38,"context_line":"        default \u003d iso8601.parse_date(timestr)"},{"line_number":39,"context_line":"    except iso8601.ParseError:"},{"line_number":40,"context_line":"        pass"},{"line_number":41,"context_line":"    except TypeError:"},{"line_number":42,"context_line":"        pass"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BlhA%3D","line":40,"updated":"2013-11-22 19:32:58.000000000","message":"Won\u0027t it be better to issue LOG.debug message? In case someone decides to tackle this problem it will be easier to track it.","commit_id":"f644daf130f1f1e41e4703429163d8a3cc71b12e"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"e58992ae02ed29efe876448b09651e539a90c57e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    except iso8601.ParseError:"},{"line_number":40,"context_line":"        pass"},{"line_number":41,"context_line":"    except TypeError:"},{"line_number":42,"context_line":"        pass"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    finally:"},{"line_number":45,"context_line":"        return default"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Blg0%3D","line":42,"updated":"2013-11-22 19:32:58.000000000","message":"ditto","commit_id":"f644daf130f1f1e41e4703429163d8a3cc71b12e"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"ac6b7bfe1d6070e4c8e4db0148a94d88ded71977","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from django.template.defaultfilters import timesince  # noqa"},{"line_number":21,"context_line":"from django.utils.safestring import mark_safe  # noqa"},{"line_number":22,"context_line":"from django.utils import timezone"},{"line_number":23,"context_line":"from django.utils.translation import ugettext_lazy as _  # noqa"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@register.filter"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F89tg%3D","line":23,"updated":"2013-12-18 10:48:47.000000000","message":"This import is not needed anymore.","commit_id":"9a894e61d9fc07ee71ad6aa747be0f2402b1122f"}]}
