)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"62a050e6ebd3b83555e49a762175b3519b042f21","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to delete the profiling object that holds the base_id UUID so a new"},{"line_number":12,"context_line":"base_id will be created for the next profile. Otherwise the same"},{"line_number":13,"context_line":"base_id is used for subsequent queries and they become merged togther"},{"line_number":14,"context_line":"in the database."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I379cebfa2ed5282c96df0e255a8ba04c65a8523c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_c41bf119","line":14,"updated":"2018-06-18 14:48:47.000000000","message":"I would like to see a bug report on this.","commit_id":"749503416f2f27135c2135c46e00c4c8a45d3f0f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"927311c14352a112f410a175798ffd2f69501d3a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to delete the profiling object that holds the base_id UUID so a new"},{"line_number":12,"context_line":"base_id will be created for the next profile. Otherwise the same"},{"line_number":13,"context_line":"base_id is used for subsequent queries and they become merged togther"},{"line_number":14,"context_line":"in the database."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I379cebfa2ed5282c96df0e255a8ba04c65a8523c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_f3d0e355","line":14,"in_reply_to":"5f7c97a3_c41bf119","updated":"2018-06-21 13:17:52.000000000","message":"\u003e Bug report: https://bugs.launchpad.net/horizon/+bug/1777486\n\nAdd \"Closes-Bug: #nnnnnnn\" to the commit message as suggested in the OpenStack developers guide.\n\nBTW, Could you reply using inline comment rather than using a cover comment?","commit_id":"749503416f2f27135c2135c46e00c4c8a45d3f0f"}],"openstack_dashboard/contrib/developer/profiler/middleware.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"62a050e6ebd3b83555e49a762175b3519b042f21","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def process_response(self, request, response):"},{"line_number":144,"context_line":"        if profiler.get() is not None:"},{"line_number":145,"context_line":"            profiler._clean()"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        self.clear_profiling_cookies(request, response)"},{"line_number":148,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_84fc19b6","line":145,"updated":"2018-06-18 14:48:47.000000000","message":"You calls a private method of osprofiler instance. Is there no way to do this? If there is nothing, I believe we should change the method name to public in osprofiler code first. Thought?","commit_id":"749503416f2f27135c2135c46e00c4c8a45d3f0f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"927311c14352a112f410a175798ffd2f69501d3a","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def process_response(self, request, response):"},{"line_number":144,"context_line":"        if profiler.get() is not None:"},{"line_number":145,"context_line":"            profiler._clean()"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        self.clear_profiling_cookies(request, response)"},{"line_number":148,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b354abc7","line":145,"in_reply_to":"5f7c97a3_84fc19b6","updated":"2018-06-21 13:17:52.000000000","message":"\u003e Profiler instance is created and base_id is generated here:\n\u003e  https://github.com/openstack/osprofiler/blob/master/osprofiler/profiler.py#L60\n\u003e \n\u003e The only way to delete that is here:\n\u003e  https://github.com/openstack/osprofiler/blob/master/osprofiler/profiler.py#L35\n\u003e \n\u003e which is currently a private method. If not deleted, the old base_id will be re-used.\n\nI suggested to fix the method in osprofiler first. Is there any reason not to do that? This is the master branch so it is better to avoid an adhoc way.","commit_id":"749503416f2f27135c2135c46e00c4c8a45d3f0f"},{"author":{"_account_id":25666,"name":"Stuart Grace","email":"stuart.grace@bbc.co.uk","username":"stuartgrace"},"change_message_id":"f227918554ba759844c65e6c3ba1d92208d63ba4","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def process_response(self, request, response):"},{"line_number":144,"context_line":"        if profiler.get() is not None:"},{"line_number":145,"context_line":"            profiler.clean()"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        self.clear_profiling_cookies(request, response)"},{"line_number":148,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_891d0464","line":145,"updated":"2018-07-13 10:14:38.000000000","message":"Change https://review.openstack.org/578362 makes the clean() method public. This has been merged now.","commit_id":"7f83726da0e3da544aae39ad00498b814d3374c2"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"ff226938fc0b14420c7668ec502d9f2e71aee96a","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def process_response(self, request, response):"},{"line_number":144,"context_line":"        if profiler.get() is not None:"},{"line_number":145,"context_line":"            profiler.clean()"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        self.clear_profiling_cookies(request, response)"},{"line_number":148,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_62f7e45b","line":145,"in_reply_to":"5f7c97a3_605d0e7b","updated":"2018-07-19 08:11:24.000000000","message":"This looks to be included in the osprofiler 2.3.0 tag https://github.com/openstack/osprofiler/commits/2.3.0\n\nThere is a 2.3.0 package on pypi https://pypi.org/project/osprofiler/\n\nUpper-constraints is updated here https://github.com/openstack/requirements/commit/90f1580b686a2b5c82e377d74aa57bec386ac74d","commit_id":"7f83726da0e3da544aae39ad00498b814d3374c2"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3d621fb98a5927093ae59a573beeade14f531d59","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def process_response(self, request, response):"},{"line_number":144,"context_line":"        if profiler.get() is not None:"},{"line_number":145,"context_line":"            profiler.clean()"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        self.clear_profiling_cookies(request, response)"},{"line_number":148,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_8098a51a","line":145,"in_reply_to":"5f7c97a3_62f7e45b","updated":"2018-07-23 18:50:59.000000000","message":"Please, update osprofiler version in lower-constraints.txt","commit_id":"7f83726da0e3da544aae39ad00498b814d3374c2"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"91c455f35cc6ce3d463df47072a87e7b708251eb","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def process_response(self, request, response):"},{"line_number":144,"context_line":"        if profiler.get() is not None:"},{"line_number":145,"context_line":"            profiler.clean()"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        self.clear_profiling_cookies(request, response)"},{"line_number":148,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_605d0e7b","line":145,"in_reply_to":"5f7c97a3_891d0464","updated":"2018-07-13 22:27:23.000000000","message":"Do we need to wait for new osprofiler release?","commit_id":"7f83726da0e3da544aae39ad00498b814d3374c2"}]}
