)]}'
{"horizon/static/horizon/js/horizon.loadbalancers.js":[{"author":{"_account_id":9692,"name":"Gabriel Pettier","email":"gabriel.pettier@cloudwatt.com","username":"Gabriel-Pettier"},"change_message_id":"471ad6f881c42cce6ddf579a58c69c1af46e32d3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    /* Generate html string of a list of options"},{"line_number":5,"context_line":"     **/"},{"line_number":6,"context_line":"    generate_options: function(data) {"},{"line_number":7,"context_line":"\tvar html \u003d [];"},{"line_number":8,"context_line":"\tfor (var key\u003d0; key \u003c data.length; key++) {"},{"line_number":9,"context_line":"\t    console.log(data[key].id);"},{"line_number":10,"context_line":"\t    var option \u003d horizon.loadbalancer.optionTemplate({id: data[key].id,"}],"source_content_type":"text/javascript","patch_set":15,"id":"AAAAT3%2F%2F14U%3D","line":7,"updated":"2013-12-30 12:23:23.000000000","message":"indentation in this file seems to mix tabs and spaces, i think the rule is 2 spaces indentation in js, anyway, anything but mixed style, please.","commit_id":"37240813104796fb08a2dbd258f1298dd996a9d1"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"8960a1ec78c17d47618b7f38c5f9b592d4753dcb","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"$(\"#id_pool_id\").on(\u0027change\u0027, function(evt) {"},{"line_number":32,"context_line":"  horizon.loadbalancer.init_add_members_form(evt.currentTarget);"},{"line_number":33,"context_line":"});"}],"source_content_type":"text/javascript","patch_set":16,"id":"AAAAT3%2F%2Fssg%3D","line":33,"updated":"2014-01-03 09:06:54.000000000","message":"Can you add this file to the list of files checked by jshint?","commit_id":"660a2534aa2334e163dfc4eb7c95018beefd3109"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"566f50b562611b927308a157c6b01505833038b4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    var ajaxUrl \u003d selectElement.getAttribute(\u0027ajax_url\u0027),"},{"line_number":20,"context_line":"\tselected \u003d selectElement.selectIndex,"},{"line_number":21,"context_line":"\toption \u003d selectElement.options[selectElement.selectedIndex],"},{"line_number":22,"context_line":"\tdata \u003d {\u0027pool_id\u0027: option.value};"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    $.getJSON(ajaxUrl, data).done(function(response) {"},{"line_number":25,"context_line":"      var options \u003d horizon.loadbalancer.generate_options(response);"}],"source_content_type":"text/javascript","patch_set":18,"id":"AAAAT3%2F%2Frd0%3D","line":22,"updated":"2014-01-03 16:23:43.000000000","message":"There are still some tabs here.","commit_id":"1caa46f5e7386df8f90890bc69ee20778c27f7be"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"1445ef79ab707010f686c77a146e24c79bddeada","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* Namespace for functionality related to Loadbalancer Tab */"},{"line_number":2,"context_line":"horizon.loadbalancer \u003d {"},{"line_number":3,"context_line":"  optionTemplate: _.template(\"\u003coption value\u003d\\\"\u003c%\u003d id %\u003e\\\"\u003e\u003c%\u003d name %\u003e\u003c/option\u003e\"),"},{"line_number":4,"context_line":"  /* Generate html string of a list of options"},{"line_number":5,"context_line":"   **/"},{"line_number":6,"context_line":"  generate_options: function(data) {"}],"source_content_type":"text/javascript","patch_set":19,"id":"AAAAUH%2F%2F4p8%3D","line":3,"updated":"2014-01-07 08:35:20.000000000","message":"Didn\u0027t we just get rid of the underscore library?","commit_id":"a6183da6bfc535d54c61217cef79b8186df3d93b"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"6f6c4f59c5e15406c4d243489192451ef2b902f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* Namespace for functionality related to Loadbalancer Tab */"},{"line_number":2,"context_line":"horizon.loadbalancer \u003d {"},{"line_number":3,"context_line":"  optionTemplate: _.template(\"\u003coption value\u003d\\\"\u003c%\u003d id %\u003e\\\"\u003e\u003c%\u003d name %\u003e\u003c/option\u003e\"),"},{"line_number":4,"context_line":"  /* Generate html string of a list of options"},{"line_number":5,"context_line":"   **/"},{"line_number":6,"context_line":"  generate_options: function(data) {"}],"source_content_type":"text/javascript","patch_set":19,"id":"AAAAUH%2F%2FymE%3D","line":3,"in_reply_to":"AAAAUH%2F%2F3TE%3D","updated":"2014-01-08 12:53:57.000000000","message":"Yes, I saw the deleting patch.\n\nhttps://github.com/openstack/horizon/commit/36a141ee5edb785d5000ce3e67d87b3ac936d2a5","commit_id":"a6183da6bfc535d54c61217cef79b8186df3d93b"},{"author":{"_account_id":8984,"name":"George Peristerakis","email":"gperiste@redhat.com","username":"peristeri"},"change_message_id":"1de1b4fc1c2c69a43394588dfa52773d09b66132","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/* Namespace for functionality related to Loadbalancer Tab */"},{"line_number":2,"context_line":"horizon.loadbalancer \u003d {"},{"line_number":3,"context_line":"  optionTemplate: _.template(\"\u003coption value\u003d\\\"\u003c%\u003d id %\u003e\\\"\u003e\u003c%\u003d name %\u003e\u003c/option\u003e\"),"},{"line_number":4,"context_line":"  /* Generate html string of a list of options"},{"line_number":5,"context_line":"   **/"},{"line_number":6,"context_line":"  generate_options: function(data) {"}],"source_content_type":"text/javascript","patch_set":19,"id":"AAAAUH%2F%2F3TE%3D","line":3,"in_reply_to":"AAAAUH%2F%2F4p8%3D","updated":"2014-01-07 14:36:36.000000000","message":"I\u0027m not aware of that. If that is the case, I will change that.","commit_id":"a6183da6bfc535d54c61217cef79b8186df3d93b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"59773a7de67b97fc7c7dca77aed1c4dd0ab8d3a6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        key \u003d 0,"},{"line_number":10,"context_line":"        option;"},{"line_number":11,"context_line":"    for (key\u003d0; key \u003c data.length; key++) {"},{"line_number":12,"context_line":"      console.log(data[key]);"},{"line_number":13,"context_line":"      option \u003d template.replace(\u0027{id}\u0027, data[key].id).replace(\u0027{name}\u0027,"},{"line_number":14,"context_line":"                                                              data[key].name);"},{"line_number":15,"context_line":"      html.push(option);"}],"source_content_type":"text/javascript","patch_set":22,"id":"AAAAUH%2F%2Bvd8%3D","line":12,"updated":"2014-01-22 16:04:06.000000000","message":"Is it necessary?","commit_id":"cb6914628de739cc30d3f261ef41fcf968b3f284"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"59773a7de67b97fc7c7dca77aed1c4dd0ab8d3a6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    for (key\u003d0; key \u003c data.length; key++) {"},{"line_number":12,"context_line":"      console.log(data[key]);"},{"line_number":13,"context_line":"      option \u003d template.replace(\u0027{id}\u0027, data[key].id).replace(\u0027{name}\u0027,"},{"line_number":14,"context_line":"                                                              data[key].name);"},{"line_number":15,"context_line":"      html.push(option);"},{"line_number":16,"context_line":"    }"},{"line_number":17,"context_line":"    return(html.join(\u0027\u0027));"}],"source_content_type":"text/javascript","patch_set":22,"id":"AAAAUH%2F%2BvdM%3D","line":14,"updated":"2014-01-22 16:04:06.000000000","message":"Is it a standard way to format a string? (I am not so familiar with javascript, so i might be wrong)","commit_id":"cb6914628de739cc30d3f261ef41fcf968b3f284"},{"author":{"_account_id":8984,"name":"George Peristerakis","email":"gperiste@redhat.com","username":"peristeri"},"change_message_id":"76bc94873da3ef2f7e2a13289347a06d45354e72","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    for (key\u003d0; key \u003c data.length; key++) {"},{"line_number":12,"context_line":"      console.log(data[key]);"},{"line_number":13,"context_line":"      option \u003d template.replace(\u0027{id}\u0027, data[key].id).replace(\u0027{name}\u0027,"},{"line_number":14,"context_line":"                                                              data[key].name);"},{"line_number":15,"context_line":"      html.push(option);"},{"line_number":16,"context_line":"    }"},{"line_number":17,"context_line":"    return(html.join(\u0027\u0027));"}],"source_content_type":"text/javascript","patch_set":22,"id":"AAAAUH%2F%2BvIs%3D","line":14,"in_reply_to":"AAAAUH%2F%2BvdM%3D","updated":"2014-01-22 17:05:21.000000000","message":"I could create a string format function if the need is there.","commit_id":"cb6914628de739cc30d3f261ef41fcf968b3f284"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"d03531eb575f22cf9208180ee3096520cba8944f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        option;"},{"line_number":11,"context_line":"    for (key\u003d0; key \u003c data.length; key++) {"},{"line_number":12,"context_line":"      option \u003d template.replace(\u0027{id}\u0027, data[key].id).replace(\u0027{name}\u0027,"},{"line_number":13,"context_line":"                                                              data[key].name);"},{"line_number":14,"context_line":"      html.push(option);"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"    return(html.join(\u0027\u0027));"}],"source_content_type":"text/javascript","patch_set":29,"id":"3ae8d1ca_46d0c353","line":13,"updated":"2014-05-27 08:20:21.000000000","message":"Why not use here the Hogan templates that we are already using in Horizon?","commit_id":"d44daa4a837d8c151f9495ca7ec6612052412c7e"},{"author":{"_account_id":8984,"name":"George Peristerakis","email":"gperiste@redhat.com","username":"peristeri"},"change_message_id":"3c78644eb997f9e98d398a167a20446d25ff7d70","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        option;"},{"line_number":11,"context_line":"    for (key\u003d0; key \u003c data.length; key++) {"},{"line_number":12,"context_line":"      option \u003d template.replace(\u0027{id}\u0027, data[key].id).replace(\u0027{name}\u0027,"},{"line_number":13,"context_line":"                                                              data[key].name);"},{"line_number":14,"context_line":"      html.push(option);"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"    return(html.join(\u0027\u0027));"}],"source_content_type":"text/javascript","patch_set":29,"id":"3ae8d1ca_d5ab8987","line":13,"in_reply_to":"3ae8d1ca_46d0c353","updated":"2014-05-27 15:36:37.000000000","message":"I was not aware of hogan templates. I will do the adjustments.","commit_id":"d44daa4a837d8c151f9495ca7ec6612052412c7e"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"bd86c3635cdae8a2008344aacdea085fed6f6bae","unresolved":false,"context_lines":[{"line_number":5,"context_line":"   **/"},{"line_number":6,"context_line":"  generate_options: function(data) {"},{"line_number":7,"context_line":"    var html \u003d [],"},{"line_number":8,"context_line":"        template \u003d Hogan.compile(horizon.loadbalancer.optionTemplate),"},{"line_number":9,"context_line":"        key \u003d 0;"},{"line_number":10,"context_line":"    for (key\u003d0; key \u003c data.length; key++) {"},{"line_number":11,"context_line":"      html.push(template.replace({id: data[key].id, name: data[key].name});"}],"source_content_type":"text/javascript","patch_set":31,"id":"3ae8d1ca_75829c50","line":8,"updated":"2014-05-28 06:48:07.000000000","message":"You should probably compile the template only once, at the beginning, when defining it, not at every call to this function.","commit_id":"fe7cd5181244b9b6b2e652a78a280bbdd05314d6"},{"author":{"_account_id":8984,"name":"George Peristerakis","email":"gperiste@redhat.com","username":"peristeri"},"change_message_id":"99d355f040d3b63c73d64fe7ea96b0e989b86b6e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"   **/"},{"line_number":6,"context_line":"  generate_options: function(data) {"},{"line_number":7,"context_line":"    var html \u003d [],"},{"line_number":8,"context_line":"        template \u003d Hogan.compile(horizon.loadbalancer.optionTemplate),"},{"line_number":9,"context_line":"        key \u003d 0;"},{"line_number":10,"context_line":"    for (key\u003d0; key \u003c data.length; key++) {"},{"line_number":11,"context_line":"      html.push(template.replace({id: data[key].id, name: data[key].name});"}],"source_content_type":"text/javascript","patch_set":31,"id":"3ae8d1ca_14914152","line":8,"in_reply_to":"3ae8d1ca_75829c50","updated":"2014-05-29 15:04:29.000000000","message":"Done","commit_id":"fe7cd5181244b9b6b2e652a78a280bbdd05314d6"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"bd86c3635cdae8a2008344aacdea085fed6f6bae","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        template \u003d Hogan.compile(horizon.loadbalancer.optionTemplate),"},{"line_number":9,"context_line":"        key \u003d 0;"},{"line_number":10,"context_line":"    for (key\u003d0; key \u003c data.length; key++) {"},{"line_number":11,"context_line":"      html.push(template.replace({id: data[key].id, name: data[key].name});"},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"    return(html.join(\u0027\u0027));"},{"line_number":14,"context_line":"  },"}],"source_content_type":"text/javascript","patch_set":31,"id":"3ae8d1ca_d5e7f03e","line":11,"updated":"2014-05-28 06:48:07.000000000","message":"Just use template.render(data[key]) here.","commit_id":"fe7cd5181244b9b6b2e652a78a280bbdd05314d6"},{"author":{"_account_id":8984,"name":"George Peristerakis","email":"gperiste@redhat.com","username":"peristeri"},"change_message_id":"99d355f040d3b63c73d64fe7ea96b0e989b86b6e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        template \u003d Hogan.compile(horizon.loadbalancer.optionTemplate),"},{"line_number":9,"context_line":"        key \u003d 0;"},{"line_number":10,"context_line":"    for (key\u003d0; key \u003c data.length; key++) {"},{"line_number":11,"context_line":"      html.push(template.replace({id: data[key].id, name: data[key].name});"},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"    return(html.join(\u0027\u0027));"},{"line_number":14,"context_line":"  },"}],"source_content_type":"text/javascript","patch_set":31,"id":"3ae8d1ca_f495b540","line":11,"in_reply_to":"3ae8d1ca_d5e7f03e","updated":"2014-05-29 15:04:29.000000000","message":"my mistake. I did not save my changes correctly here.","commit_id":"fe7cd5181244b9b6b2e652a78a280bbdd05314d6"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"bd86c3635cdae8a2008344aacdea085fed6f6bae","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    for (key\u003d0; key \u003c data.length; key++) {"},{"line_number":11,"context_line":"      html.push(template.replace({id: data[key].id, name: data[key].name});"},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"    return(html.join(\u0027\u0027));"},{"line_number":14,"context_line":"  },"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  /* Setup the callbacks on the \"add members\" forms"}],"source_content_type":"text/javascript","patch_set":31,"id":"3ae8d1ca_f59cec6b","line":13,"updated":"2014-05-28 06:48:07.000000000","message":"You could just do something like:\n\nreturn Hogan.compile(\n\u0027{{#data}}\u003coption value\u003d\"{{id}}\"\u003e{{name}}\u003c/option\u003e{{/data}}\u0027\n).render({data:data});\n\n(of course, compile the template earlier).","commit_id":"fe7cd5181244b9b6b2e652a78a280bbdd05314d6"},{"author":{"_account_id":8984,"name":"George Peristerakis","email":"gperiste@redhat.com","username":"peristeri"},"change_message_id":"99d355f040d3b63c73d64fe7ea96b0e989b86b6e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    for (key\u003d0; key \u003c data.length; key++) {"},{"line_number":11,"context_line":"      html.push(template.replace({id: data[key].id, name: data[key].name});"},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"    return(html.join(\u0027\u0027));"},{"line_number":14,"context_line":"  },"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  /* Setup the callbacks on the \"add members\" forms"}],"source_content_type":"text/javascript","patch_set":31,"id":"3ae8d1ca_738a7bc0","line":13,"in_reply_to":"3ae8d1ca_f59cec6b","updated":"2014-05-29 15:04:29.000000000","message":"Done","commit_id":"fe7cd5181244b9b6b2e652a78a280bbdd05314d6"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"5c20eed6869ad4850ae60548eb9096a733e5d0c8","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    var ajaxUrl \u003d selectElement.getAttribute(\u0027ajax_url\u0027),"},{"line_number":9,"context_line":"        option \u003d selectElement.options[selectElement.selectedIndex],"},{"line_number":10,"context_line":"        data \u003d {\u0027pool_id\u0027: option.value},"},{"line_number":11,"context_line":"        template \u003d Hogan.compile(horizon.loadbalancer.optionTemplate);"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    $.getJSON(ajaxUrl, data).done(function(response) {"},{"line_number":14,"context_line":"      var options \u003d template.render({data: response});"}],"source_content_type":"text/javascript","patch_set":32,"id":"1ae5cdf2_bd61293b","line":11,"updated":"2014-06-03 06:58:43.000000000","message":"nitpick: you are still compiling it on every call of this function","commit_id":"525863f7acd740a4647cf41111a1b3bf84828692"}],"openstack_dashboard/api/lbaas.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"59773a7de67b97fc7c7dca77aed1c4dd0ab8d3a6","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    body \u003d {\u0027member\u0027: {\u0027pool_id\u0027: kwargs[\u0027pool_id\u0027],"},{"line_number":280,"context_line":"                       \u0027address\u0027: kwargs[\u0027address\u0027],"},{"line_number":281,"context_line":"                       \u0027protocol_port\u0027: kwargs[\u0027protocol_port\u0027],"},{"line_number":282,"context_line":"                       \u0027admin_state_up\u0027: bool(kwargs[\u0027admin_state_up\u0027])"},{"line_number":283,"context_line":"                       }}"},{"line_number":284,"context_line":"    if kwargs.get(\u0027weight\u0027):"},{"line_number":285,"context_line":"        body[\u0027member\u0027][\u0027weight\u0027] \u003d kwargs[\u0027weight\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F%2Bvsc%3D","line":282,"updated":"2014-01-22 16:04:06.000000000","message":"I wonder why this change is required. admin_state_up field in the form is defined as BooleanField and I think the value specified is converted to True/False. Am I missing something?","commit_id":"cb6914628de739cc30d3f261ef41fcf968b3f284"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d998adb1f5d2602eeea9f611f9cc898ba6f61cc3","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    body \u003d {\u0027member\u0027: {\u0027pool_id\u0027: kwargs[\u0027pool_id\u0027],"},{"line_number":280,"context_line":"                       \u0027address\u0027: kwargs[\u0027address\u0027],"},{"line_number":281,"context_line":"                       \u0027protocol_port\u0027: kwargs[\u0027protocol_port\u0027],"},{"line_number":282,"context_line":"                       \u0027admin_state_up\u0027: bool(kwargs[\u0027admin_state_up\u0027])"},{"line_number":283,"context_line":"                       }}"},{"line_number":284,"context_line":"    if kwargs.get(\u0027weight\u0027):"},{"line_number":285,"context_line":"        body[\u0027member\u0027][\u0027weight\u0027] \u003d kwargs[\u0027weight\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F%2Bbrc%3D","line":282,"in_reply_to":"AAAAUH%2F%2BvSQ%3D","updated":"2014-01-26 19:20:07.000000000","message":"I think \"admin_state_up \u003d\u003d None\" is a wrong parameter and it should not be passed here. If admin_state_up is not neither of True or False, the caller should check it.","commit_id":"cb6914628de739cc30d3f261ef41fcf968b3f284"},{"author":{"_account_id":8984,"name":"George Peristerakis","email":"gperiste@redhat.com","username":"peristeri"},"change_message_id":"315323f58f219c2d523360b0b37bbfda048a53a3","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    body \u003d {\u0027member\u0027: {\u0027pool_id\u0027: kwargs[\u0027pool_id\u0027],"},{"line_number":280,"context_line":"                       \u0027address\u0027: kwargs[\u0027address\u0027],"},{"line_number":281,"context_line":"                       \u0027protocol_port\u0027: kwargs[\u0027protocol_port\u0027],"},{"line_number":282,"context_line":"                       \u0027admin_state_up\u0027: bool(kwargs[\u0027admin_state_up\u0027])"},{"line_number":283,"context_line":"                       }}"},{"line_number":284,"context_line":"    if kwargs.get(\u0027weight\u0027):"},{"line_number":285,"context_line":"        body[\u0027member\u0027][\u0027weight\u0027] \u003d kwargs[\u0027weight\u0027]"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F%2BvSQ%3D","line":282,"in_reply_to":"AAAAUH%2F%2Bvsc%3D","updated":"2014-01-22 16:43:21.000000000","message":"I added this because kwargs[\u0027admin_state_up\u0027] \u003d\u003d None in some cases. I don\u0027t remember the use case.","commit_id":"cb6914628de739cc30d3f261ef41fcf968b3f284"}],"openstack_dashboard/dashboards/project/loadbalancers/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"21992b898f1f9c94e92f14aad961d36930ac3b71","unresolved":false,"context_lines":[{"line_number":568,"context_line":"                              HTTP_X_REQUESTED_WITH\u003d\u0027XMLHttpRequest\u0027)"},{"line_number":569,"context_line":"        content \u003d jsonutils.loads(res.content)"},{"line_number":570,"context_line":"        self.assertIn(content[0][\u0027id\u0027], server_ids)"},{"line_number":571,"context_line":"        self.assertTrue(len(content) \u003d\u003d 1)"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    @test.create_stubs({api.lbaas: (\u0027pool_get\u0027,)})"},{"line_number":574,"context_line":"    def test_ajax_get_members_with_invalid_pool_id(self):"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAU3%2F%2F8IQ%3D","line":571,"updated":"2014-02-23 22:04:06.000000000","message":"self.assertEqual(1, len(content))","commit_id":"a7e0987dd18c4a6f64aeedd0a9e2f6a48d4cddc7"}],"openstack_dashboard/dashboards/project/loadbalancers/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4d4c3656063d95365419ffd5d91a28c4ff7a7981","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                pool \u003d api.lbaas.pool_get(request, request.GET[\u0027pool_id\u0027])"},{"line_number":151,"context_line":"                subnet \u003d api.neutron.subnet_get(request, pool.subnet_id)"},{"line_number":152,"context_line":"                network \u003d api.neutron.network_get(request, subnet.network_id)"},{"line_number":153,"context_line":"                network_name \u003d network.name_or_id"},{"line_number":154,"context_line":"            except (neutron_exceptions.NeutronClientException, KeyError):"},{"line_number":155,"context_line":"                return self.render_to_json_response(choices)"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F8trk%3D","line":153,"updated":"2013-12-21 15:42:57.000000000","message":"name_or_id returns a name if the name exists and returns a short version of network UUID if no name exists. The length of the short version of UUID is defined in Horizon and I believe it cannot be used to retrieve UUID for this purpose.","commit_id":"e16c0f27f1619c8219a2a93bca82c37f2d6e32e1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4d4c3656063d95365419ffd5d91a28c4ff7a7981","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"            for server in servers:"},{"line_number":164,"context_line":"                try:"},{"line_number":165,"context_line":"                    if server.addresses[network_name]:"},{"line_number":166,"context_line":"                        choices.append({\u0027id\u0027: server.id,"},{"line_number":167,"context_line":"                                        \u0027name\u0027: server.name})"},{"line_number":168,"context_line":"                except KeyError:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F8trc%3D","line":165,"updated":"2013-12-21 15:42:57.000000000","message":"If network name is empty, server.addresses has the following value, so this does not work for empty network name.\n\n  {u\u0027\u0027: [{u\u0027OS-EXT-IPS-MAC:mac_addr\u0027: u\u0027fa:16:3e:26:7a:45\u0027,\n     u\u0027OS-EXT-IPS:type\u0027: u\u0027fixed\u0027,\n     u\u0027addr\u0027: u\u002710.2.2.4\u0027,\n     u\u0027version\u0027: 4}],\n   u\u0027net1\u0027: [{u\u0027OS-EXT-IPS-MAC:mac_addr\u0027: u\u0027fa:16:3e:0c:23:47\u0027,\n     u\u0027OS-EXT-IPS:type\u0027: u\u0027fixed\u0027,\n     u\u0027addr\u0027: u\u002710.0.0.4\u0027,\n     u\u0027version\u0027: 4}]}\n\nI think more robust way is to retrieve a instance list from neutron port-list.\n\n  ports \u003d neutronclient.list_ports(network_id\u003dnetwork.id)[\u0027ports\u0027]\n  server_ids \u003d set([p[\u0027device_id\u0027] for p in ports if p[\u0027device_owner\u0027].startswith(\u0027compute:\u0027)])\n\nIn addition, name can be duplicated in neutron. Does it work for this case?","commit_id":"e16c0f27f1619c8219a2a93bca82c37f2d6e32e1"},{"author":{"_account_id":8984,"name":"George Peristerakis","email":"gperiste@redhat.com","username":"peristeri"},"change_message_id":"4ed00fdc93dbb349155148ebb87e9cc34b3cdadf","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"            for server in servers:"},{"line_number":164,"context_line":"                try:"},{"line_number":165,"context_line":"                    if server.addresses[network_name]:"},{"line_number":166,"context_line":"                        choices.append({\u0027id\u0027: server.id,"},{"line_number":167,"context_line":"                                        \u0027name\u0027: server.name})"},{"line_number":168,"context_line":"                except KeyError:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F8oEo%3D","line":165,"in_reply_to":"AAAATn%2F8trc%3D","updated":"2013-12-24 05:43:50.000000000","message":"In this case, I\u0027m relying on the name of the network name because it is the key used in the instance\u0027s addesses. So if the name can be duplicated, does that mean that the address dictionary might misrepresent which network the instance is on. In other words, can a instance be on 2 different \"net1\" networks?","commit_id":"e16c0f27f1619c8219a2a93bca82c37f2d6e32e1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4d4c3656063d95365419ffd5d91a28c4ff7a7981","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                try:"},{"line_number":165,"context_line":"                    if server.addresses[network_name]:"},{"line_number":166,"context_line":"                        choices.append({\u0027id\u0027: server.id,"},{"line_number":167,"context_line":"                                        \u0027name\u0027: server.name})"},{"line_number":168,"context_line":"                except KeyError:"},{"line_number":169,"context_line":"                    pass"},{"line_number":170,"context_line":"            return self.render_to_json_response(choices)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F8trM%3D","line":167,"updated":"2013-12-21 15:42:57.000000000","message":"I think IP address is useful information too.","commit_id":"e16c0f27f1619c8219a2a93bca82c37f2d6e32e1"},{"author":{"_account_id":9692,"name":"Gabriel Pettier","email":"gabriel.pettier@cloudwatt.com","username":"Gabriel-Pettier"},"change_message_id":"471ad6f881c42cce6ddf579a58c69c1af46e32d3","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        initial \u003d super(AddPoolView, self).get_initial()"},{"line_number":99,"context_line":"        return initial"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def get(self, request, *args, **kwargs):"},{"line_number":102,"context_line":"        response \u003d super(AddPoolView, self).get(request, *args, **kwargs)"},{"line_number":103,"context_line":"        return response"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAT3%2F%2F13s%3D","line":101,"updated":"2013-12-30 12:23:23.000000000","message":"why override the method just to return super call with the same arguments?","commit_id":"37240813104796fb08a2dbd258f1298dd996a9d1"},{"author":{"_account_id":9692,"name":"Gabriel Pettier","email":"gabriel.pettier@cloudwatt.com","username":"Gabriel-Pettier"},"change_message_id":"471ad6f881c42cce6ddf579a58c69c1af46e32d3","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def get_context_data(self, **kwargs):"},{"line_number":132,"context_line":"        context \u003d super(AddMemberView, self).get_context_data(**kwargs)"},{"line_number":133,"context_line":"        return context"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def get_initial(self):"},{"line_number":136,"context_line":"        initial \u003d super(AddMemberView, self).get_initial()"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAT3%2F%2F13w%3D","line":133,"updated":"2013-12-30 12:23:23.000000000","message":"same, why override the method just to return super call with the same arguments?","commit_id":"37240813104796fb08a2dbd258f1298dd996a9d1"},{"author":{"_account_id":9692,"name":"Gabriel Pettier","email":"gabriel.pettier@cloudwatt.com","username":"Gabriel-Pettier"},"change_message_id":"471ad6f881c42cce6ddf579a58c69c1af46e32d3","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"class GetMemberByPool(generic.TemplateView):"},{"line_number":142,"context_line":"    def render_to_json_response(self, context, **response_kwargs):"},{"line_number":143,"context_line":"        data \u003d jsonutils.dumps(context)"},{"line_number":144,"context_line":"        response_kwargs[\u0027content_type\u0027] \u003d \u0027application/json\u0027"},{"line_number":145,"context_line":"        return http.HttpResponse(data, **response_kwargs)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAT3%2F%2F12I%3D","line":142,"updated":"2013-12-30 12:23:23.000000000","message":"why not the usual `kwargs` ?","commit_id":"37240813104796fb08a2dbd258f1298dd996a9d1"},{"author":{"_account_id":9692,"name":"Gabriel Pettier","email":"gabriel.pettier@cloudwatt.com","username":"Gabriel-Pettier"},"change_message_id":"471ad6f881c42cce6ddf579a58c69c1af46e32d3","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                                    \u0027name\u0027: server.name,"},{"line_number":173,"context_line":"                                    \u0027ip_address\u0027: ip_addr})"},{"line_number":174,"context_line":"            return self.render_to_json_response(choices)"},{"line_number":175,"context_line":"        raise http.Http404"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class AddMonitorView(workflows.WorkflowView):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAT3%2F%2F11M%3D","line":175,"updated":"2013-12-30 12:23:23.000000000","message":"So the method can only be called from ajax? can you document why? It may also make testing it a little harder, i also think there may be a better signal than 404 if it\u0027s a forbidden use case to call it directly.","commit_id":"37240813104796fb08a2dbd258f1298dd996a9d1"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"1118fb78acf5425fc36d94cb4801fe9def138554","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                                    \u0027name\u0027: server.name,"},{"line_number":173,"context_line":"                                    \u0027ip_address\u0027: ip_addr})"},{"line_number":174,"context_line":"            return self.render_to_json_response(choices)"},{"line_number":175,"context_line":"        raise http.Http404"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class AddMonitorView(workflows.WorkflowView):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAT3%2F%2Fvuk%3D","line":175,"in_reply_to":"AAAAT3%2F%2F11M%3D","updated":"2014-01-02 14:10:39.000000000","message":"You should raise an instance of the exception, not the class.","commit_id":"37240813104796fb08a2dbd258f1298dd996a9d1"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"6f6c4f59c5e15406c4d243489192451ef2b902f4","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        initial \u003d super(AddPoolView, self).get_initial()"},{"line_number":99,"context_line":"        return initial"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def get(self, request, *args, **kwargs):"},{"line_number":102,"context_line":"        response \u003d super(AddPoolView, self).get(request, *args, **kwargs)"},{"line_number":103,"context_line":"        return response"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAUH%2F%2FykA%3D","line":101,"updated":"2014-01-08 12:53:57.000000000","message":"seems like redundant method, right?","commit_id":"a6183da6bfc535d54c61217cef79b8186df3d93b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"59773a7de67b97fc7c7dca77aed1c4dd0ab8d3a6","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                if p[\u0027device_owner\u0027].startswith(\u0027compute:\u0027) and free_port:"},{"line_number":148,"context_line":"                    server_ids[p[\u0027device_id\u0027]] \u003d p"},{"line_number":149,"context_line":"        except (neutron_exceptions.NeutronClientException, KeyError):"},{"line_number":150,"context_line":"            return choices"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        try:"},{"line_number":153,"context_line":"            servers, has_more \u003d api.nova.server_list(request)"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F%2BvrI%3D","line":150,"updated":"2014-01-22 16:04:06.000000000","message":"Nit: It is better to change this line to \"return []\" and move L.136 to L.157 (just before for-loop). It is easier to read.","commit_id":"cb6914628de739cc30d3f261ef41fcf968b3f284"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"21992b898f1f9c94e92f14aad961d36930ac3b71","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from horizon.utils import memoized"},{"line_number":27,"context_line":"from horizon import workflows"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from neutronclient.common import exceptions as neutron_exceptions"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from openstack_dashboard import api"},{"line_number":32,"context_line":"from openstack_dashboard.dashboards.project.loadbalancers \\"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAU3%2F%2F8IA%3D","line":29,"updated":"2014-02-23 22:04:06.000000000","message":"Please move it before django import section. It is a thirdparty module.","commit_id":"a7e0987dd18c4a6f64aeedd0a9e2f6a48d4cddc7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"21992b898f1f9c94e92f14aad961d36930ac3b71","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    import workflows as project_workflows"},{"line_number":38,"context_line":"from openstack_dashboard.openstack.common import jsonutils"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"import re"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class IndexView(tabs.TabView):"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAU3%2F%2F8H8%3D","line":40,"updated":"2014-02-23 22:04:06.000000000","message":"Though it is not related to this patch, could you move it before django. \"re\" is a standard module.","commit_id":"a7e0987dd18c4a6f64aeedd0a9e2f6a48d4cddc7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"21992b898f1f9c94e92f14aad961d36930ac3b71","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            servers, has_more \u003d api.nova.server_list(request)"},{"line_number":153,"context_line":"        except Exception:"},{"line_number":154,"context_line":"            exceptions.handle(request,"},{"line_number":155,"context_line":"                              _(\u0027Unable to retrieve a list of instances.\u0027))"},{"line_number":156,"context_line":"        choices \u003d []"},{"line_number":157,"context_line":"        for server in servers:"},{"line_number":158,"context_line":"            if server.id in server_ids:"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAU3%2F%2F8Hw%3D","line":155,"updated":"2014-02-23 22:04:06.000000000","message":"The processing continues after this, but \"servers\" is undefine when an error occurs. Please here or specify redirect to exceptions.handle() set \"servers\" .","commit_id":"a7e0987dd18c4a6f64aeedd0a9e2f6a48d4cddc7"}],"openstack_dashboard/dashboards/project/loadbalancers/workflows.py":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"809f8f510b3dacfc64d6c73cc0dce2f6f70fd5f5","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            pool_id_choices.append((p.id, p.name))"},{"line_number":325,"context_line":"        self.fields[\u0027pool_id\u0027].choices \u003d pool_id_choices"},{"line_number":326,"context_line":"        self.fields[\u0027pool_id\u0027].widget.attrs.update({\u0027ajax_url\u0027:"},{"line_number":327,"context_line":"                reverse(\u0027horizon:project:loadbalancers:getmemberbypool\u0027)})"},{"line_number":328,"context_line":"        self.fields[\u0027pool_id\u0027].initial \u003d self.initial[\u0027pool_id\u0027]"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    class Meta:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F8tm8%3D","line":327,"updated":"2013-12-21 17:31:15.000000000","message":"Bad indentation. Please correct.","commit_id":"e16c0f27f1619c8219a2a93bca82c37f2d6e32e1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"809f8f510b3dacfc64d6c73cc0dce2f6f70fd5f5","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        name \u003d _(\"Select a load balancing pool\")"},{"line_number":332,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":333,"context_line":"        help_text \u003d _(\"Select a load balancing pool.\\n\\n\""},{"line_number":334,"context_line":"                      \"Select a pool to add members to.\""},{"line_number":335,"context_line":"                      \"Assign a numeric weight for this member and\""},{"line_number":336,"context_line":"                      \"specify the port number the member(s) \""},{"line_number":337,"context_line":"                      \"operate on; e.g., 80.\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F8tm0%3D","line":334,"updated":"2013-12-21 17:31:15.000000000","message":"Please add whitespaces to the end of line here and below.","commit_id":"e16c0f27f1619c8219a2a93bca82c37f2d6e32e1"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"65f56173289273bd7ed0d636159073cbb9a27c27","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        name \u003d _(\"Select a load balancing pool\")"},{"line_number":332,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":333,"context_line":"        help_text \u003d _(\"Select a load balancing pool.\\n\\n\""},{"line_number":334,"context_line":"                      \"Select a pool to add members to.\""},{"line_number":335,"context_line":"                      \"Assign a numeric weight for this member and\""},{"line_number":336,"context_line":"                      \"specify the port number the member(s) \""},{"line_number":337,"context_line":"                      \"operate on; e.g., 80.\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F8n0w%3D","line":334,"in_reply_to":"AAAATn%2F8oEc%3D","updated":"2013-12-24 07:03:50.000000000","message":"Actually it does. Badly formatted code makes it harder to read it and badly formatted messages tend to irritate end users. On the other hand -1 does not mean that I don\u0027t appreciate what you have done, but rather that there are things (may be minor) to improve.","commit_id":"e16c0f27f1619c8219a2a93bca82c37f2d6e32e1"},{"author":{"_account_id":8984,"name":"George Peristerakis","email":"gperiste@redhat.com","username":"peristeri"},"change_message_id":"a556bfc4c61a8ed9c9d6fafd3d92e34225566f96","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        name \u003d _(\"Select a load balancing pool\")"},{"line_number":332,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":333,"context_line":"        help_text \u003d _(\"Select a load balancing pool.\\n\\n\""},{"line_number":334,"context_line":"                      \"Select a pool to add members to.\""},{"line_number":335,"context_line":"                      \"Assign a numeric weight for this member and\""},{"line_number":336,"context_line":"                      \"specify the port number the member(s) \""},{"line_number":337,"context_line":"                      \"operate on; e.g., 80.\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F8oEc%3D","line":334,"in_reply_to":"AAAATn%2F8tm0%3D","updated":"2013-12-24 05:47:27.000000000","message":"I appreciate the comments on spacing and style. But this does not merit a -1.","commit_id":"e16c0f27f1619c8219a2a93bca82c37f2d6e32e1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"59773a7de67b97fc7c7dca77aed1c4dd0ab8d3a6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"from django.core.urlresolvers import reverse  # noqa"},{"line_number":17,"context_line":"from django.utils.translation import ugettext_lazy as _"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from horizon import exceptions"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUH%2F%2Bvus%3D","line":16,"updated":"2014-01-22 16:04:06.000000000","message":"#noqa is no longer needed. \"reverse\" is declared as an exception of import check.","commit_id":"cb6914628de739cc30d3f261ef41fcf968b3f284"}]}
