)]}'
{"doc/source/configuration/settings.rst":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"53e4bb32bf2afb5db85556b5bfd93a4df63078a8","unresolved":false,"context_lines":[{"line_number":1525,"context_line":"WEBSSO_DEFAULT_REDIRECT"},{"line_number":1526,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":1527,"context_line":""},{"line_number":1528,"context_line":".. versionadded:: 14.0.0(Rocky)"},{"line_number":1529,"context_line":""},{"line_number":1530,"context_line":"Default: ``False``"},{"line_number":1531,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_e501dd39","line":1528,"range":{"start_line":1528,"start_character":18,"end_line":1528,"end_character":31},"updated":"2018-08-13 08:23:29.000000000","message":"Perhaps it needs to be 15.0.0(Stein). We are in the feature freeze period and this looks like a mini feature. This needs to be discussed with PTL on whether we accept this in Rocky RC2.","commit_id":"739c611e006525ea1b8e1874c65c2788958d8f8d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"53e4bb32bf2afb5db85556b5bfd93a4df63078a8","unresolved":false,"context_lines":[{"line_number":1529,"context_line":""},{"line_number":1530,"context_line":"Default: ``False``"},{"line_number":1531,"context_line":""},{"line_number":1532,"context_line":"Allows to redirect on login to the IdP provider defined on PROTOCOL and REGION"},{"line_number":1533,"context_line":""},{"line_number":1534,"context_line":"WEBSSO_DEFAULT_REDIRECT_PROTOCOL"},{"line_number":1535,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_85a9097d","line":1532,"updated":"2018-08-13 08:23:29.000000000","message":"It is better to explain what \u0027default\u0027 means. According to the current description, it is not easy for operators to understand what is the purpose of this settings without reading the commit message (or the bug report).","commit_id":"739c611e006525ea1b8e1874c65c2788958d8f8d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2e4b4525ea791a615520978a97f2c19ea400279f","unresolved":false,"context_lines":[{"line_number":1540,"context_line":""},{"line_number":1541,"context_line":".. versionadded:: 15.0.0(Stein)"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"Default: ``False``"},{"line_number":1544,"context_line":""},{"line_number":1545,"context_line":"Allows to specify the protocol for the IdP to contact if the"},{"line_number":1546,"context_line":"WEBSSO_DEFAULT_REDIRECT is set to True"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_23e4addf","line":1543,"range":{"start_line":1543,"start_character":11,"end_line":1543,"end_character":16},"updated":"2018-08-13 10:05:40.000000000","message":"None?","commit_id":"792aca8c51e536e88520020693130ae47aa05af9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2e4b4525ea791a615520978a97f2c19ea400279f","unresolved":false,"context_lines":[{"line_number":1549,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":1550,"context_line":""},{"line_number":1551,"context_line":".. versionadded:: 15.0.0(Stein)"},{"line_number":1552,"context_line":""},{"line_number":1553,"context_line":"Allows to specify thee region of the IdP to contact if the"},{"line_number":1554,"context_line":"WEBSSO_DEFAULT_REDIRECT is set to True"},{"line_number":1555,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_a3d75dee","line":1552,"updated":"2018-08-13 10:05:40.000000000","message":"Could you add the default value?","commit_id":"792aca8c51e536e88520020693130ae47aa05af9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2e4b4525ea791a615520978a97f2c19ea400279f","unresolved":false,"context_lines":[{"line_number":1557,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":1558,"context_line":""},{"line_number":1559,"context_line":".. versionadded:: 15.0.0(Stein)"},{"line_number":1560,"context_line":""},{"line_number":1561,"context_line":"Allows to specify a callback to the IdP to cleanup the SSO resources."},{"line_number":1562,"context_line":"Once the user logs out it will redirect to the IdP log out method."},{"line_number":1563,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_c3d4d9eb","line":1560,"updated":"2018-08-13 10:05:40.000000000","message":"Could you add the default value?","commit_id":"792aca8c51e536e88520020693130ae47aa05af9"}],"openstack_auth/utils.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"53e4bb32bf2afb5db85556b5bfd93a4df63078a8","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"def is_websso_default_redirect():"},{"line_number":150,"context_line":"    \"\"\"Websso is supported in Keystone version 3.\"\"\""},{"line_number":151,"context_line":"    websso_default_redirect \u003d getattr(settings,"},{"line_number":152,"context_line":"                                      \u0027WEBSSO_DEFAULT_REDIRECT\u0027, False)"},{"line_number":153,"context_line":"    keystonev3_plus \u003d (get_keystone_version() \u003e\u003d 3)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_45bd31d6","line":150,"range":{"start_line":150,"start_character":4,"end_line":150,"end_character":52},"updated":"2018-08-13 08:23:29.000000000","message":"This docstring does not seem correct. Could you update it?","commit_id":"739c611e006525ea1b8e1874c65c2788958d8f8d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"53e4bb32bf2afb5db85556b5bfd93a4df63078a8","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def get_websso_default_redirect_protocol():"},{"line_number":158,"context_line":"    \"\"\"Websso is supported in Keystone version 3.\"\"\""},{"line_number":159,"context_line":"    return getattr(settings, \u0027WEBSSO_DEFAULT_REDIRECT_PROTOCOL\u0027, False)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_65c2ad5b","line":158,"range":{"start_line":158,"start_character":4,"end_line":158,"end_character":52},"updated":"2018-08-13 08:23:29.000000000","message":"This docstring does not seem correct. Could you update it?","commit_id":"739c611e006525ea1b8e1874c65c2788958d8f8d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"53e4bb32bf2afb5db85556b5bfd93a4df63078a8","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def get_websso_default_redirect_protocol():"},{"line_number":158,"context_line":"    \"\"\"Websso is supported in Keystone version 3.\"\"\""},{"line_number":159,"context_line":"    return getattr(settings, \u0027WEBSSO_DEFAULT_REDIRECT_PROTOCOL\u0027, False)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"def get_websso_default_redirect_region():"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_f2af6127","line":159,"range":{"start_line":159,"start_character":65,"end_line":159,"end_character":70},"updated":"2018-08-13 08:23:29.000000000","message":"False is used for a boolean setting. This settings is not a boolean value, so \u0027None\u0027 looks appropriate.","commit_id":"739c611e006525ea1b8e1874c65c2788958d8f8d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"53e4bb32bf2afb5db85556b5bfd93a4df63078a8","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"def get_websso_default_redirect_logout():"},{"line_number":168,"context_line":"    return getattr(settings, \u0027WEBSSO_DEFAULT_REDIRECT_LOGOUT\u0027, False)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"def build_absolute_uri(request, relative_url):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_b27a49b7","line":168,"range":{"start_line":168,"start_character":63,"end_line":168,"end_character":68},"updated":"2018-08-13 08:23:29.000000000","message":"same comment as for WEBSSO_DEFAULT_REDIRECT_PROTOCOL","commit_id":"739c611e006525ea1b8e1874c65c2788958d8f8d"}],"openstack_dashboard/local/local_settings.py.example":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2e4b4525ea791a615520978a97f2c19ea400279f","unresolved":false,"context_lines":[{"line_number":237,"context_line":"#WEBSSO_DEFAULT_REDIRECT \u003d False"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"# Specifies the protocol to use for default redirection on login"},{"line_number":240,"context_line":"#WEBSSO_DEFAULT_REDIRECT_PROTOCOL \u003d False"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"# Specifies the region to which the connection will be established on login"},{"line_number":243,"context_line":"#WEBSSO_DEFAULT_REDIRECT_REGION \u003d OPENSTACK_KEYSTONE_URL"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"3f79a3b5_e3e79511","line":240,"range":{"start_line":240,"start_character":36,"end_line":240,"end_character":41},"updated":"2018-08-13 10:05:40.000000000","message":"None?","commit_id":"792aca8c51e536e88520020693130ae47aa05af9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2e4b4525ea791a615520978a97f2c19ea400279f","unresolved":false,"context_lines":[{"line_number":245,"context_line":"# Enables redirection on logout to the method specified on the identity provider."},{"line_number":246,"context_line":"# Once logout the client will be redirected to the address specified in this"},{"line_number":247,"context_line":"# variable."},{"line_number":248,"context_line":"#WEBSSO_DEFAULT_REDIRECT_LOGOUT \u003d False"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"# The Keystone Provider drop down uses Keystone to Keystone federation"},{"line_number":251,"context_line":"# to switch between Keystone service providers."}],"source_content_type":"application/octet-stream","patch_set":6,"id":"3f79a3b5_a3ed1df1","line":248,"range":{"start_line":248,"start_character":34,"end_line":248,"end_character":39},"updated":"2018-08-13 10:05:40.000000000","message":"None?","commit_id":"792aca8c51e536e88520020693130ae47aa05af9"}]}